From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2977CC433E0 for ; Fri, 22 May 2020 15:42:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D5FD0206F6 for ; Fri, 22 May 2020 15:42:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xc5YNUMi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D5FD0206F6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 66BC480008; Fri, 22 May 2020 11:42:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 61BC480007; Fri, 22 May 2020 11:42:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 50AC180008; Fri, 22 May 2020 11:42:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0086.hostedemail.com [216.40.44.86]) by kanga.kvack.org (Postfix) with ESMTP id 34DC580007 for ; Fri, 22 May 2020 11:42:07 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id D6071824805A for ; Fri, 22 May 2020 15:42:06 +0000 (UTC) X-FDA: 76844771052.21.push89_126982cabcc20 X-HE-Tag: push89_126982cabcc20 X-Filterd-Recvd-Size: 4161 Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Fri, 22 May 2020 15:42:06 +0000 (UTC) Received: by mail-lj1-f195.google.com with SMTP id o14so13218798ljp.4 for ; Fri, 22 May 2020 08:42:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oOYVOHpaIS+oIho1dCUDLjlIT96AiPQqcbd2UVpV+2w=; b=xc5YNUMinAG4CGXABpBRi7fN1jT3RAq5g34Fsehb7FeGfXYItR+jv9zdzFUbWBZgED LmniBIdug9ZVwtsM86rfNB4Ym0c53ixm9EKzBW+98lrn+8iymUA1pl2rPFTIORF5gQ62 S7DQ9GAYdIyD0+h/PDFxltIl+vny9nvjNZwtDFWooA9AaFqDP1f1M3b8WEMP5ciTcCjp W9NaNLJ0XScz6f3UhpDiAU5ZGmdgvxMde4+OxowuByFtU+aSTB2XW+29FZ21ruR/AtlZ X2z7XizfkhRaPFBSCM5YrIriiEQ/BuEbJkBwj+XeDUcSN1pBzeruIIxoHJrH2wvAAVgG WYVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oOYVOHpaIS+oIho1dCUDLjlIT96AiPQqcbd2UVpV+2w=; b=G2kQ+y5ynVe0htvNzV++iah4MAV3tK22uajYXLdTVjq69Rfws8Q/Y57OLyPO/H0HDp bcJznorCI0m4KdXALLrhe429ATZFv3sFNECzjbAeLpF9NOKx6Mwkf9BPeP6GOwJ+ygpb R73ZTYboOUobetSs3ipcqpPumBmbewYS4s195F/s1MD/PKmXCxuUTYMAsMPWFMZxSI1E btmHy2cViovyovhZgGs15uVrMPEho1cEsxi6mZh7+F818slKdHkKYb8RyQ+id5Ks4zlY 7yACj+vsTpHkJFz+Kq5HJfv3GgtkBCEh7iG8A9keamJbtsq6KMBtgJGqxl9P3+qSd5NL B0Jg== X-Gm-Message-State: AOAM5302h+LX8cStw6l2HJu4ctoL6J4TPNzpDemwoX9s0Gp74HjGTmYw 8vDT9bcEKc8cjP2WvLRzVdZ72x8wjJoioSxDN+WFmw== X-Google-Smtp-Source: ABdhPJxRJSZJBv5r7tYd2u0AUqK3zkVLdXL1DZDbhQE8M+i8GAUoeEfr4zqO0vZ1A56dhmdh581qQsP3Tbtb1mlvNY0= X-Received: by 2002:a2e:150f:: with SMTP id s15mr7582617ljd.102.1590162124742; Fri, 22 May 2020 08:42:04 -0700 (PDT) MIME-Version: 1.0 References: <20200505084127.12923-1-laoar.shao@gmail.com> <20200505084127.12923-3-laoar.shao@gmail.com> <20200522114544.GA1112005@chrisdown.name> In-Reply-To: <20200522114544.GA1112005@chrisdown.name> From: Naresh Kamboju Date: Fri, 22 May 2020 21:11:53 +0530 Message-ID: Subject: Re: [PATCH v3 2/2] mm, memcg: Decouple e{low,min} state mutations from protection checks To: Chris Down Cc: Yafang Shao , Michal Hocko , Andrew Morton , Johannes Weiner , Roman Gushchin , linux-mm , Cgroups , open list , lkft-triage@lists.linaro.org Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 22 May 2020 at 17:15, Chris Down wrote: > > Naresh Kamboju writes: > >This patch is causing oom-killer while running mkfs -t ext4 on i386 kernel > >running on x86_64 machine version linux-next 5.7.0-rc6-next-20200521. > > I think I see what's wrong here -- if we bail out early, memory.e{min,low} > might be uninitialised. > > Does this patch fix it, by any chance? > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index d3b23c57bed4..aa902b9cbb79 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -5046,6 +5046,9 @@ mem_cgroup_css_alloc(struct cgroup_subsys_state *parent_css) > memory_cgrp_subsys.broken_hierarchy = true; > } > > + memcg->memory.emin = 0; > + memcg->memory.elow = 0; > + > /* The following stuff does not apply to the root */ > if (!parent) { > #ifdef CONFIG_MEMCG_KMEM This patch did not fix the problem. The test log showing oom-killer link, https://lkft.validation.linaro.org/scheduler/job/1445128#L1194 Build images: https://builds.tuxbuild.com/YqW37GVsCHf8ndxOT2z1iQ/ - Naresh