From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6565FC001DF for ; Tue, 25 Jul 2023 09:13:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EC83E6B0075; Tue, 25 Jul 2023 05:13:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E51906B0078; Tue, 25 Jul 2023 05:13:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CF3726B007B; Tue, 25 Jul 2023 05:13:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id BF62C6B0075 for ; Tue, 25 Jul 2023 05:13:54 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8B973C0D05 for ; Tue, 25 Jul 2023 09:13:54 +0000 (UTC) X-FDA: 81049571988.14.C28CB39 Received: from mail-vk1-f181.google.com (mail-vk1-f181.google.com [209.85.221.181]) by imf08.hostedemail.com (Postfix) with ESMTP id 330E6160008 for ; Tue, 25 Jul 2023 09:13:50 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=wVdoQoLB; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf08.hostedemail.com: domain of naresh.kamboju@linaro.org designates 209.85.221.181 as permitted sender) smtp.mailfrom=naresh.kamboju@linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690276431; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GRFuY+FZ1tURNJQm9tQxMWQj7iYDcIJ2HPAtsd5d2kY=; b=L+gRS69MpsB4PlGZ7k1nuvPGkmIHu4fdpmTHFfOq9mIKZOvZdteSOeEObJeBHJIteeH/Fl ecc7OCc7JKdzLOTeN9rZKuPyxzWVUV/F+DS/4xfuLodz/d+D4Ab3t7y3PVTqrQojUspz+e 6F908EfjCyJMlG88vBl1X0mU2KckLXE= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=wVdoQoLB; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf08.hostedemail.com: domain of naresh.kamboju@linaro.org designates 209.85.221.181 as permitted sender) smtp.mailfrom=naresh.kamboju@linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690276431; a=rsa-sha256; cv=none; b=23HPOLyjcRfQqfVR8UujPgaDjtk4DLLKBWByVko4Zpmys+iVu4KggxGk+q0A4tAIkxFIVQ ZrS7CVlOPGS4HxZk5fpoluo3B1IUXvkQjpbGeuDelhMgAfGzNgHdVD87BwuI5+G1MFPnG6 +pW5pC9sbqGqx8uC9IS2xLMzovNLWo4= Received: by mail-vk1-f181.google.com with SMTP id 71dfb90a1353d-4863c756812so121584e0c.1 for ; Tue, 25 Jul 2023 02:13:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690276430; x=1690881230; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=GRFuY+FZ1tURNJQm9tQxMWQj7iYDcIJ2HPAtsd5d2kY=; b=wVdoQoLBVh3vgs1zHXG7ZfrMP5dzW7BJtePPbF/5fMoxY2U17HODWvBNsyznKzTni5 41pYbbOFifDyrJkQhTWthsdoIdF1pNWVWrG0fMxerYP458q4UAcYd8CMarSSyUEC+RRN dUzd4zSOg5jfc5gJkvLWg2Hpke9kbujHAbZnl5uWc223qoytOqm5eQ3avipz2OKQ4gXE OJ/41PUiu2SDc+6ly7PEkl9X02PhPdcg8yDms7Njavf+FbEo8pAaUA1TKAIDFXb2dt9W CnKhngFUkZaK1daXEGEbwEsVK36HH0YHHlNh7xplgKf2m8RmjG2YiyZTUQWnO+cNUs8x VirA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690276430; x=1690881230; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GRFuY+FZ1tURNJQm9tQxMWQj7iYDcIJ2HPAtsd5d2kY=; b=HxafxEhU2Rn0y56/5viPBTgTWXdH0tnkjbOGCknnwvyydU5RPHWOQ0+ULmUk0XBLoM ep1GtPLsS+8bVUU/wqb/jjSw94xIqPsNenX9ibDuO4AZ/jQIh+leO5eA/2mcoWzU+AqR d1M6bK+hU8yzcJYtaVORxMGThExHAaam9hhDpS4sw+jSa/y+sEK6ij+M+LSdUrOdwKRp C6FEzUQECzY21t+OU8YXFwVWR6566CA/kouuc3obfdatJFIFA+sLA44O0R2lri3bApv9 zvyt2dWsMRoeHigdbsh1iyj4t7c9EKGVgeUdvG9ln2Jlg1Mb9JzQ5t2Jrw5cRXb1y03i 7wig== X-Gm-Message-State: ABy/qLYMwE7MHfFT+Sr9CCQTmOkVQR43oWzI5ym1JFcXxHUdVxbpkifV NWnfnWjNlYHO3qz78Ra1fPM4HDols0Jj10K0qHglgg== X-Google-Smtp-Source: APBJJlHmTBjG7KVaLIKq22U7zF9JKTeYXLUTZQRx/695Vxv0XvxUqX9R1dVmXdeYK3l8HFEg2b7Ed5xsdeThM63Rc6U= X-Received: by 2002:a1f:e683:0:b0:485:e984:771c with SMTP id d125-20020a1fe683000000b00485e984771cmr3805772vkh.3.1690276430148; Tue, 25 Jul 2023 02:13:50 -0700 (PDT) MIME-Version: 1.0 References: <20230721160528.800311148@linuxfoundation.org> In-Reply-To: From: Naresh Kamboju Date: Tue, 25 Jul 2023 14:43:38 +0530 Message-ID: Subject: Re: [PATCH 6.4 000/292] 6.4.5-rc1 review To: Alexander Potapenko Cc: Linus Torvalds , Muchun Song , Marco Elver , Roman Gushchin , Andrew Morton , Linux-MM Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 330E6160008 X-Stat-Signature: q7jwzimg18s4dwjmdpygkyebwqpniuu4 X-HE-Tag: 1690276430-641180 X-HE-Meta: U2FsdGVkX1+wbjnyH0Y9wW/XRjwu7wNwramQZGbQRceBC6yKOb9qvXoJxih3h80sJ1AXuR0Ja46aCZguD4hf4HVWO20feHyD5Ru0yXI086Nmr7oSg4hniGQRokycbU8oixqYYzeUob+mYg8DJh1mVcAEYlOelw14e6MLEQgfBKqAQxLGBJ98YquRh/0tLPfK6KsUV2UScpw/2N21xEAmoNtkSy8x3UmHVFRJu18Qqgabc77RFppe+g15LDZQz+b6yjHISb2Spsy7O/GRaVyJXmgwJ9zMSIfbJACDaLekm4B7a43jN5FGunD/IeEQ7tY6KO1RrqRXDUnDWV7k4w/FQYI3RCRhXxcE4CCn8225A808e4NhIB51PZ9VpOiKKMkHFi6ipKVMIKpxAyxquNeJRxqOx4fCqEeMbtHEs0sbxx7mo1Falfy20b4Jvk0OzWDUhTYDgAu7slgzWTJ6NmQ0FE2Dx2a2gJHjLivEPjaF+HK+oGWeMAgL1jT6KVrlv+73GpLn6yjF2PMGZHh7ts0nfLGgBuRdpsZtjFAztbdNs30s7BBot6U+MhrYEiiTe5WSyqUT+OP6mBpeQvz9FtPVeNBFvvp58jN3bs32qQ8KXOFbs6SLx9EXQju6I3NRlICPivgRbetkJfvxT9VFceXSi5a0O3tLCJkJFZK4SY7srlyyKZ53YkNHJt1ENylOEoHp8JOnzGLrFU62R1fEWhUV9Izohoa2vUep88y9SJ3KjeA/3TXYdl+u0TqoI0PZ9YhzHXnE6Oa+/6sjODac5RkXDhYOvD/bmyoCG/8+oGHNwXO3FIyyy7EDpIA9FL+nigd8IOZ9QTugs1QJjUQVWXnfHfsmuwltlQ00lDYrLJQeOPCaVcQq5V7OHFUmmgeOh8Gc5oyhxUJ857NATPixi+17glhBDHWcp7T1Rpnj2IDkY/+7lIen7co2p6iER3cFKl/awrR/Ki3ukGenQ7FavkG J0pbVewA UsfmOmI2HaBxunW8YGNTo1+dwFnWMOblxNveFn5E7FrvzX57XHdwmq4YLHNHig44fdOR6DyYPvGno7Bf+gvFCuDo9CewjcLXXmnFdztNiLbZpsNbjDN44LDbs6T3nDt3UfXSMghvL6N3DepWaA5DXoqRJLznxygZOqmXtYI+o4rlmW9ZNPyltEEjRGd4rvXnRKJrKxOQ7FVPCPBJcR1aesYSViNfEh9NwqNBVU046LfhC7rpgxOr2x60R5La9xvALR12mTCiddnQj5O/ggaNeA+IrS22m1cZ6M7TsvTCcHrZv/OFfNjhUs663vflDnprURB5X5OBUslb6INT3J6PJoAXc7SI8b+CsE9CLJBBxsvKT7C5+zTfBbCGnK6kSPGnhBpob0wqGa8xUnn9X9ZmXKKHkhYGHDo/gB037xxXIFIkXZOMGyvQ968zfGvaluwKnFNL672H9mxYspe4X/KxKlxtWpJYRKipqhlcAf3x3mE3zmbZjLdhwN4QsJQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Alexander, On Mon, 24 Jul 2023 at 17:40, Naresh Kamboju wr= ote: > > On Mon, 24 Jul 2023 at 15:50, Alexander Potapenko wro= te: > > > > On Sat, Jul 22, 2023 at 6:37=E2=80=AFPM Linus Torvalds > > wrote: > > > > > > [ Removed the stable reviewers, bringing in the kfence people ] > > > > > > See > > > > > > https://lore.kernel.org/lkml/CA+G9fYvgy22wiY=3Dc3wLOrCM6o33636abhtE= ynXhJkqxJh4ca0A@mail.gmail.com/ > > > > > > for the original report. The warning was introduced in 8f0b36497303 > > > ("mm: kfence: fix objcgs vector allocation"), and Google doesn't find > > > any other cases of this. > > > > > > Anybody? > > > > > > Linus > > > > > > > > > > > NOTE: > > > > The following kernel warning was noticed while booting qemu-arm64 > > > > with these configs enabled on stable rc 6.4.5-rc1. > > > > > > > > CONFIG_ARM64_64K_PAGES=3Dy > > > > CONFIG_KFENCE=3Dy > > > > Is there a full config somewhere? > > Please find build details > - https://storage.tuxsuite.com/public/linaro/lkft/builds/2StEPFnEfoD076P= Ru8fIxjexhnM/ > - https://storage.tuxsuite.com/public/linaro/lkft/builds/2StEPFnEfoD076P= Ru8fIxjexhnM/config > - https://storage.tuxsuite.com/public/linaro/lkft/builds/2StEPFnEfoD076P= Ru8fIxjexhnM/vmlinux.xz > - https://storage.tuxsuite.com/public/linaro/lkft/builds/2StEPFnEfoD076P= Ru8fIxjexhnM/System.map > - https://storage.tuxsuite.com/public/linaro/lkft/builds/2StEPFnEfoD076P= Ru8fIxjexhnM/Image.gz > > > > > > > This crash is not easily reproducible. > > > > CONFIG_KFENCE_SAMPLE_INTERVAL=3D10 > > CONFIG_KFENCE_NUM_OBJECTS=3D2048 > > > > might improve reproducibility. > > The above test have following Kconfigs enabled. > > CONFIG_HAVE_ARCH_KASAN=3Dy > CONFIG_HAVE_ARCH_KASAN_SW_TAGS=3Dy > CONFIG_HAVE_ARCH_KASAN_HW_TAGS=3Dy > CONFIG_HAVE_ARCH_KASAN_VMALLOC=3Dy > CONFIG_CC_HAS_KASAN_GENERIC=3Dy > CONFIG_CC_HAS_KASAN_SW_TAGS=3Dy > CONFIG_CC_HAS_WORKING_NOSANITIZE_ADDRESS=3Dy > # CONFIG_KASAN is not set > CONFIG_HAVE_ARCH_KFENCE=3Dy > CONFIG_KFENCE=3Dy > CONFIG_KFENCE_SAMPLE_INTERVAL=3D100 > CONFIG_KFENCE_NUM_OBJECTS=3D255 > # CONFIG_KFENCE_DEFERRABLE is not set > CONFIG_KFENCE_STRESS_TEST_FAULTS=3D0 > > > > > > > > > > > boot logs: > > > > -------- > > > > [ 0.000000] Booting Linux on physical CPU 0x0000000000 [0x000f05= 10] > > > > [ 0.000000] Linux version 6.4.5-rc1 (tuxmake@tuxmake) > > > > (aarch64-linux-gnu-gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binut= ils > > > > for Debian) 2.40) #1 SMP PREEMPT @1689957802 > > > > [ 0.000000] random: crng init done > > > > [ 0.000000] Machine model: linux,dummy-virt > > > > ... > > > > [ 0.006821] kfence: initialized - using 33554432 bytes for 255 > > > > objects at 0x(____ptrval____)-0x(____ptrval____) > > > > ... > > > > [ 7.726994] ------------[ cut here ]------------ > > > > [ 7.727704] WARNING: CPU: 1 PID: 1 at mm/kfence/core.c:1097 > > > > __kfence_free+0x84/0xc8 > > > ... > > > > [ 7.746478] Call trace: > > > > [ 7.746776] __kfence_free+0x84/0xc8 > > > > [ 7.747134] __slab_free+0x490/0x508 > > > > [ 7.748063] __kmem_cache_free+0x2b4/0x2d0 > > > > [ 7.748377] kfree+0x78/0x140 > > > > [ 7.748638] single_release+0x40/0x60 > > > > [ 7.750664] __fput+0x78/0x260 > > > > [ 7.751065] ____fput+0x18/0x30 > > > > [ 7.752086] task_work_run+0x80/0xe0 > > > > [ 7.753122] do_notify_resume+0x200/0x1398 > > > > [ 7.754292] el0_svc+0xec/0x100 > > > > [ 7.754573] el0t_64_sync_handler+0xf4/0x120 > > > > [ 7.755559] el0t_64_sync+0x190/0x198 > > > > It would be interesting to see the contents of > > /sys/kernel/debug/kfence/objects together with the object address. > > Would it be possible to boot the kernel with no_hash_pointers and add > > a line printing the object address: > > > > diff --git a/mm/kfence/core.c b/mm/kfence/core.c > > index dad3c0eb70a01..23f27f6cb18cf 100644 > > --- a/mm/kfence/core.c > > +++ b/mm/kfence/core.c > > @@ -1094,7 +1094,10 @@ void __kfence_free(void *addr) > > struct kfence_metadata *meta =3D addr_to_metadata((unsigned lon= g)addr); > > > > #ifdef CONFIG_MEMCG > > - KFENCE_WARN_ON(meta->objcg); > > + if (meta->objcg) { > > + pr_err("ADDR: %px\n", addr); > > + KFENCE_WARN_ON(1); > > + } > > #endif > > /* > > * If the objects of the cache are SLAB_TYPESAFE_BY_RCU, defer = freeing > > > > , and then dump /sys/kernel/debug/kfence/objects? > > > > This testing is running on CI loops and however, I will try to reproduce > this locally. I have applied the above debug patch and tested in a loop but the issues did not reproduce yet. - Naresh