From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AA73CF31BF for ; Thu, 3 Oct 2024 05:38:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 723B36B04B9; Thu, 3 Oct 2024 01:38:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6D37A6B04BA; Thu, 3 Oct 2024 01:38:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 59AC46B04BB; Thu, 3 Oct 2024 01:38:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2CECB6B04B9 for ; Thu, 3 Oct 2024 01:38:55 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 859F2161086 for ; Thu, 3 Oct 2024 05:38:54 +0000 (UTC) X-FDA: 82631186988.15.D39C0B4 Received: from mail-vs1-f52.google.com (mail-vs1-f52.google.com [209.85.217.52]) by imf07.hostedemail.com (Postfix) with ESMTP id D47A140002 for ; Thu, 3 Oct 2024 05:38:51 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=Kdv3Fb77; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf07.hostedemail.com: domain of naresh.kamboju@linaro.org designates 209.85.217.52 as permitted sender) smtp.mailfrom=naresh.kamboju@linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727933827; a=rsa-sha256; cv=none; b=CrwOHDyCJQeheDca0RFYobkkDj2qyzvbR19gP8VQybf1Wo7iwtwHZTFpijcTfd7+2CMqnR QqHdNY4hZVGvz8x7XYDxQJWgQVa0bV0Hea4sqQl8pzTFAxbc+i07wnGrNbi9BhUjEt14Dn 5SlGUMmhhad5pcLlex4KQjyofJFzkbE= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=Kdv3Fb77; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf07.hostedemail.com: domain of naresh.kamboju@linaro.org designates 209.85.217.52 as permitted sender) smtp.mailfrom=naresh.kamboju@linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727933827; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f5vUbpgAuf4ukV4d+K3A2JqlzY0GqMqBxJh0u41jQac=; b=m3pT9idX7YVMvY1+qJtTPCCupUgerxVD25e9U7k1mJLEwtXJUkROnd2y3Y3kEVEUN1qsSq +gO260+QlryYbbK5X9Sj9D15tEsgG1sa8p5P/GPNSZGsTdMaJMmpgAiMnAwNBDG50nU5QZ bGvg3Dm+sKvRhG8oM/zP1g6a4BgFMpw= Received: by mail-vs1-f52.google.com with SMTP id ada2fe7eead31-4a3a34b3a5aso169609137.1 for ; Wed, 02 Oct 2024 22:38:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1727933931; x=1728538731; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=f5vUbpgAuf4ukV4d+K3A2JqlzY0GqMqBxJh0u41jQac=; b=Kdv3Fb77ZsAdsnCngTnT5n0ajbn+Eaopj41u0hNMMIy4lW2ROG1MNEMNnHcFp0W2NQ aZSLlp/LqGl9lYxVw3rK+WS1CtucxdzH0WTjsB+qsW+pkhsyBUIvt0+Y8NqXgRFNHGmk 3dDh9K4h0TKVgGnitwzU2HvbIbQ+r0hdTpCkuzH34i3nppaBZ6PJFAYCRbPAw95H8/O1 hDvMAHRqwZMvYP/yO0osQU/eS31TdjgkCrS43ttJXhFji0bwEKqXY5JNgWlKtdg7WoPq GXeW/oep42PsydFutF5qnrdgg3NNmYtgYNjrlhHbKtoFvmOhfkYpHu25QrsSvG9S/JrL Qcpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727933931; x=1728538731; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=f5vUbpgAuf4ukV4d+K3A2JqlzY0GqMqBxJh0u41jQac=; b=dT3VCZp5fHfYmXGHnia5TQKXMq9HyraPp4uvWrRj9njS5u7coTvAkyJsqSS6RVfcV4 aupr8YvaPl/WBV5Z9d7bctuAFte9vH3IR+j9FYfNbIvKuyAMICQn6yT5XZ3xmTEJBzrd j1b0RM+DTBAIaHwUPo6sNMlCGFlFYb74UJgyN9kOXwMNNhndXj5VMpUKqnzn31+cbVCR mmvUmD7x57TjrDrfvLigkafNLB/4Rpe01rAztR/tgCutXzikEBpfXX+UADBqPTocgU+S BqiZfqGGIhrHo8kjeeMcqmVrymt76jcuHkDTDowW4bUWwQ3ykX62ynKBkAetaou0HHWV nT8Q== X-Forwarded-Encrypted: i=1; AJvYcCX7ksCLefGAPO+gN6mIKMoNhBi6clxnTCsPoA6nUhvLuYbk6W7jYAfuHWHgtnpf7whfYtr76zbqXA==@kvack.org X-Gm-Message-State: AOJu0Yx/sW0CXViA6UwTStdzlk7HKt+bTxyTpetROPeqbE3cnga3vXPw MycImWRDlGPu6wFDTGpeZTgL3t2t1yPEUS+jcst4mkCY0J0qaFPylyeMJSJIlQpOV4PVYVJpdtB 3NP4zzpGpZnhqsOIrNPHRcYWzKg4vR15ZaD4oBA== X-Google-Smtp-Source: AGHT+IE/udGm3ds/9p2RO6rOSEFkpb2M7UEn+Fb2vf0HPMu89AA8Y6YrRw6hQK0Vrjj2Jj6Mauzen3zuBjj6b49BXG0= X-Received: by 2002:a05:6102:c46:b0:4a3:cfa9:6c84 with SMTP id ada2fe7eead31-4a3e680c40dmr4484322137.3.1727933930644; Wed, 02 Oct 2024 22:38:50 -0700 (PDT) MIME-Version: 1.0 References: <62a65418-2393-40ec-b462-151605a5efcf@stanley.mountain> In-Reply-To: <62a65418-2393-40ec-b462-151605a5efcf@stanley.mountain> From: Naresh Kamboju Date: Thu, 3 Oct 2024 11:08:39 +0530 Message-ID: Subject: Re: next-20241001: WARNING: at mm/list_lru.c:77 list_lru_del (mm/list_lru.c:212 mm/list_lru.c:200) To: Dan Carpenter Cc: Kairui Song , open list , lkft-triage@lists.linaro.org, Linux Regressions , linux-mm , Andrew Morton , Arnd Bergmann , Anders Roxell Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: D47A140002 X-Stat-Signature: yk89rimw8gostyhqmqzomqh35ga68t8n X-Rspam-User: X-HE-Tag: 1727933931-245583 X-HE-Meta: U2FsdGVkX19vgQJ/U4cYcrt92ocmy0q8HSJlDZSBIqRCFba8bBYKXM5oB0naTvj3Vz6faEEKv26NJt+VYqR4/r4kqcgALyolItd0ZT73s6I6XgTrtjmpEdYmaT1M6ztczNNEh7ihgECdFniyZ6o4Vb+gEpaH+DWw4+yqwp3D6MWVyAcZzSqBB3UnVeeA7EmrlcHl/SCfp8tuBomc7MtpoKmF7zDrQ4YyqdSdn0usVjRBa/QALiIbJSbFddFiKBNWptbvSC9RJnrLeEwN7Kr6azXnFlQu+1uqnBApOyz6gSsEhoRsR3XmPIG/7IKBKy4VWIZsqVHufhB82gsYeJOeiyuBIvyK0IeIMK1MqHqN+5hh5h01TgwJyLLv7OgCVRB/bv0aayuFGr669Eoh7E4LsZaUEFoN5ggNFl1AITu8yWuwTC/1Jhy7kruGP3wVw3ccg15L0O0VI8XpR33OVW1YLIdTi223IUErqy4SoL6OhU+e/AiVv4VBVKI+l9Og67gdrwVGb38kME1xyNgyEUedSSz7l2MIRREH7BqWTP+8UhdCUPV2QvylobNNCWWsU7G8B/RHLD96C9mS6CQ1pgcXzQJB2bKCbxTkIZGkz1n+IJiGACXifZxqqwIaQxM5pL5r2RZW/aqT/BOX6mu6QLEhELeAYmaSARvQjxPeeLef8TUzxVWIE5k4yn5i782IQCjmKRpmF05o7YR9yG5OPdbcsBxFw1968dgjQBQM4wI1jADSDQu6B0VZQ1DOJfiJ/jidlh8UjLvv2zTAgid3Zuzt8aCqiLx1Ep4YSx7GEj+ntWdfKwGWfhuwITbxKX/6Rm4hdbfURnID6t9MJDhzdMYma6U78r8QHvi3led7qKuXrBpSdNkLNvCbcVKlDS4nDjAR9URlO3kNyJb+Rm3BETC8Q4q6PKkF/CWcntd7hvYNCI67BUgJ0lbqUE+RIgAFxltJ1ZwC4szfzi++aYGHWHl rNt/u4Om QY+qypUk5Bj4RCAjsAnvyekTTEjVNo7IWQscgK5BV252ewteBXsI+l27igYaOfCsS9m5wh13eFxR9+qfy3Y33St20BFq3e4WsBCdnpLSwCOa5AG0z3V7bMG7VRzntIco0QKr02NEVFGujDNbTXDLAGakKo8PhJ5Yl6SiinN0s0613La2YvpsXw98ocEfd1DzDXgJnbvZogSyheSbECNZD5tVri0q3WyoZIEPQDprSzkIfrUWTHBAMd7M2WZ7T/gMhDQLzMCcsaLL3GMHV5tYkXB9Kgre0zvOA7KOgZcwgsAqCU34= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 2 Oct 2024 at 16:58, Dan Carpenter wrote: > > On Wed, Oct 02, 2024 at 02:25:34PM +0300, Dan Carpenter wrote: > > On Wed, Oct 02, 2024 at 02:24:20PM +0300, Dan Carpenter wrote: > > > Let's add Kairui Song to the CC list. > > > > > > One simple thing is that we should add a READ_ONCE() to the comparison. Naresh, > > > could you test the attached diff? I don't know that it will fix it but it's > > > worth checking the easy stuff first. > > > > > > > Actually that's not right. Let me write a different patch. > > Try this one. > Thanks for the patch, I have applied this patch and testing is in progress. >From last night the tests running in a loop did not find the reported warning. > regards, > dan carpenter > > diff --git a/mm/list_lru.c b/mm/list_lru.c > index 79c2d21504a2..2c429578ed31 100644 > --- a/mm/list_lru.c > +++ b/mm/list_lru.c > @@ -65,6 +65,7 @@ lock_list_lru_of_memcg(struct list_lru *lru, int nid, struct mem_cgroup *memcg, > bool irq, bool skip_empty) > { > struct list_lru_one *l; > + long nr_items; > rcu_read_lock(); > again: > l = list_lru_from_memcg_idx(lru, nid, memcg_kmem_id(memcg)); > @@ -73,8 +74,9 @@ lock_list_lru_of_memcg(struct list_lru *lru, int nid, struct mem_cgroup *memcg, > spin_lock_irq(&l->lock); > else > spin_lock(&l->lock); > - if (likely(READ_ONCE(l->nr_items) != LONG_MIN)) { > - WARN_ON(l->nr_items < 0); > + nr_items = READ_ONCE(l->nr_items); > + if (likely(nr_items != LONG_MIN)) { > + WARN_ON(nr_items < 0); > rcu_read_unlock(); > return l; > } - Naresh