From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B0C3C433E1 for ; Fri, 10 Jul 2020 17:48:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 31AAB2078B for ; Fri, 10 Jul 2020 17:48:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="c7JFXD/A" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 31AAB2078B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AE8AD6B0002; Fri, 10 Jul 2020 13:48:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A73038D0001; Fri, 10 Jul 2020 13:48:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 93A796B0005; Fri, 10 Jul 2020 13:48:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0104.hostedemail.com [216.40.44.104]) by kanga.kvack.org (Postfix) with ESMTP id 7B49D6B0002 for ; Fri, 10 Jul 2020 13:48:18 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 0965F40FE for ; Fri, 10 Jul 2020 17:48:18 +0000 (UTC) X-FDA: 77022900276.12.birth53_36057ce26ed0 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin12.hostedemail.com (Postfix) with ESMTP id CE91F1801119E for ; Fri, 10 Jul 2020 17:48:17 +0000 (UTC) X-HE-Tag: birth53_36057ce26ed0 X-Filterd-Recvd-Size: 6883 Received: from mail-lf1-f67.google.com (mail-lf1-f67.google.com [209.85.167.67]) by imf37.hostedemail.com (Postfix) with ESMTP for ; Fri, 10 Jul 2020 17:48:17 +0000 (UTC) Received: by mail-lf1-f67.google.com with SMTP id y13so3681704lfe.9 for ; Fri, 10 Jul 2020 10:48:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QGH/1ehoZFwfhkJOgaIaTubnPetz+f4biA6QGk/2Uyo=; b=c7JFXD/A4EOhJwcLKu31TlBZ9abJajqaRKQlVWu/avrgpYDKmq8FSwvFK0J5HLnvNj Qp7Uz4blgJRqRqgOUAc3ruSqMZJRakazZjRrjHpru1thFep0tt+PjNMVb0JiBOzDfdjQ SuqVlOh3YkcyPvVxX1f0dOPQTLXNyaVDx5KQopfd2MKsDPz40FavPXF/hmuRMZO3jAGB vGbPXs71UGM5Kmg+G/NYtoVmh6Bu8+1CDVAlE/XIEnXprO6B2cVS4F/Ym2a9WvYAQELb 0EYa1Xo7BZCpJDCcnQgtSMyut2weoOJrX99Q1Xm2rhAz9w0bQeFMaPeCc4CaPDFP0wOc N9EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QGH/1ehoZFwfhkJOgaIaTubnPetz+f4biA6QGk/2Uyo=; b=SVjv9OcqEJup5mHeLJEBDNeNzLQ8Jm+3PvzUl25P/yjit16BYn9ewdW3TYE2GrYOGE SHrDbdt4NojJUvOALZaLBt/MxbrHlEdlBB9uzR+jn/oQfHigy63RQSmUpKM+c3pP/RFe cwDSuTaDcdef4l+5yzGzo+j+2PyG74uG3HZ/uePFJyvthXZ5+N81ZSPtDMQghxpHSVzo TW9Z/0mR0mFg0ABP7puN52/YzAsqeul8WjEwIiPUE1LIzdKwL8TNGt9qPLxGm13p8bm+ bGgnAPHdJ6IQYdOFmkBUZtoK8GNgGo+EQgD9wurVyOVnt0xp+VjeP6CZ3AZIWmCO5zfu +KQQ== X-Gm-Message-State: AOAM5311Oc6nO9/IN0vVoDLsoJqnZ+0lGtNgzLy7v5HhSFw3dejVWOh5 YZrgXXt3V0ID1e7i9lsbtRf6DwdZnSZTwaQZXWHwiA== X-Google-Smtp-Source: ABdhPJyCpqQFIy3eX/eFjtB9ld/zDOw4OnCM+wpMSQlR21gzdFLeVumVkGcJ/4fP4kY2YEfNFw8cH/ItJI+rohXmENc= X-Received: by 2002:a19:4285:: with SMTP id p127mr42097847lfa.74.1594403295614; Fri, 10 Jul 2020 10:48:15 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Naresh Kamboju Date: Fri, 10 Jul 2020 23:18:03 +0530 Message-ID: Subject: Re: WARNING: at mm/mremap.c:211 move_page_tables in i386 To: Linus Torvalds Cc: linux- stable , open list , linux-mm , Arnd Bergmann , Andrew Morton , Roman Gushchin , Michal Hocko , lkft-triage@lists.linaro.org, Chris Down , Michel Lespinasse , Fan Yang , Brian Geffon , Anshuman Khandual , Will Deacon , Catalin Marinas , pugaowei@gmail.com, Jerome Glisse , Joel Fernandes , Greg Kroah-Hartman , Mel Gorman , Hugh Dickins , Al Viro , Tejun Heo , Sasha Levin Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: CE91F1801119E X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 10 Jul 2020 at 10:55, Linus Torvalds wrote: > > On Thu, Jul 9, 2020 at 9:29 PM Naresh Kamboju wrote: > > > > Your patch applied and re-tested. > > warning triggered 10 times. > > > > old: bfe00000-c0000000 new: bfa00000 (val: 7d530067) > > Hmm.. It's not even the overlapping case, it's literally just "move > exactly 2MB of page tables exactly one pmd down". Which should be the > nice efficient case where we can do it without modifying the lower > page tables at all, we just move the PMD entry. > > There shouldn't be anything in the new address space from bfa00000-bfdfffff. > > That PMD value obviously says differently, but it looks like a nice > normal PMD value, nothing bad there. > > I'm starting to think that the issue might be that this is because the > stack segment is special. Not only does it have the growsdown flag, > but that whole thing has the magic guard page logic. > > So I wonder if we have installed a guard page _just_ below the old > stack, so that we have populated that pmd because of that. > > We used to have an _actual_ guard page and then play nasty games with > vm_start logic. We've gotten rid of that, though, and now we have that > "stack_guard_gap" logic that _should_ mean that vm_start is always > exact and proper (and that pgtbales_free() should have emptied it, but > maybe we have some case we forgot about. > > > [ 741.511684] WARNING: CPU: 1 PID: 15173 at mm/mremap.c:211 move_page_tables.cold+0x0/0x2b > > [ 741.598159] Call Trace: > > [ 741.600694] setup_arg_pages+0x22b/0x310 > > [ 741.621687] load_elf_binary+0x31e/0x10f0 > > [ 741.633839] __do_execve_file+0x5a8/0xbf0 > > [ 741.637893] __ia32_sys_execve+0x2a/0x40 > > [ 741.641875] do_syscall_32_irqs_on+0x3d/0x2c0 > > [ 741.657660] do_fast_syscall_32+0x60/0xf0 > > [ 741.661691] do_SYSENTER_32+0x15/0x20 > > [ 741.665373] entry_SYSENTER_32+0x9f/0xf2 > > [ 741.734151] old: bfe00000-c0000000 new: bfa00000 (val: 7d530067) > > Nothing looks bad, and the ELF loading phase memory map should be > really quite simple. > > The only half-way unusual thing is that you have basically exactly 2MB > of stack at execve time (easy enough to tune by just setting argv/env > right), and it's moved down by exactly 2MB. > > And that latter thing is just due to randomization, see > arch_align_stack() in arch/x86/kernel/process.c. > > So that would explain why it doesn't happen every time. > > What happens if you apply the attached patch to *always* force the 2MB > shift (rather than moving the stack by a random amount), and then run > the other program (t.c -> compiled to "a.out"). I have applied your patch and test started in a loop for a million times but the test ran for 35 times. Seems like the test got a timeout after 1 hour. kernel messages printed while testing a.out a.out (480) used greatest stack depth: 4872 bytes left On other device kworker/dying (172) used greatest stack depth: 5044 bytes left Re-running test with long timeouts 4 hours and will share findings. ref: https://lkft.validation.linaro.org/scheduler/job/1555132#L1515 - Naresh