From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F4EFC433E0 for ; Thu, 16 Jul 2020 08:32:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 36A372064C for ; Thu, 16 Jul 2020 08:32:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="eTIG4nqj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 36A372064C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D436E8D0009; Thu, 16 Jul 2020 04:32:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CF27C8D0005; Thu, 16 Jul 2020 04:32:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BBB8E8D0009; Thu, 16 Jul 2020 04:32:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0109.hostedemail.com [216.40.44.109]) by kanga.kvack.org (Postfix) with ESMTP id 9BBEF8D0005 for ; Thu, 16 Jul 2020 04:32:41 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 69D632DFA for ; Thu, 16 Jul 2020 08:32:41 +0000 (UTC) X-FDA: 77043272922.07.water99_2f0cdf026f00 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin07.hostedemail.com (Postfix) with ESMTP id E6B9D1803F9AC for ; Thu, 16 Jul 2020 08:32:40 +0000 (UTC) X-HE-Tag: water99_2f0cdf026f00 X-Filterd-Recvd-Size: 4135 Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) by imf35.hostedemail.com (Postfix) with ESMTP for ; Thu, 16 Jul 2020 08:32:40 +0000 (UTC) Received: by mail-lj1-f194.google.com with SMTP id q7so6234916ljm.1 for ; Thu, 16 Jul 2020 01:32:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=m13HjL6iO3fK1NRmtO6Jr3kBjditGEqJt09JegOvvrY=; b=eTIG4nqjVsO98qZmSOJ+yhdJ/V1wFHISz7DLn80VfOS8MexHv+PCzNha9wKPfA7XOu ePGZslMvvoXZMP1dwsQE8w0hhlpslJvAr3QNzp9NfK98aQ8m88Jpct2O0JcUgBoMKq7o 7pvTQeBYcGGJxc5COhhLO2VycQDmEs5dOoo+WSkKkd7UBs2zKfvkAFt8dindvYQYk102 p1W1pgjR193Pv1CDR4UTrxZgsEsfacQOReBPKlICptYiIE5wOosr0GkMNSNpdZnFMlsp o9mlfS7lOJAtChtXV6umK3LdRMAyxK+eoikfGTEgJbpU3u1B+W7UuNAZZX2C8FFIAIBI tPfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=m13HjL6iO3fK1NRmtO6Jr3kBjditGEqJt09JegOvvrY=; b=cs8tjnc1/w+Lv2YKq0ZeLJoZnJt8EAu5/rkeRMgkFb2rBmXto2aECSOOT+x9C0TSfr mIkluQRIR87O5Pwu+ViaLdQpX0F4adiUAALx9reeibjw5nRnB10lJllqkxCeMrVqqK/D jl4/4orZtbZXJ5DWu2GRhxnfltOdQfjUK0lt5Q52/MWOitcBLSNCPyPplplnxWBC4rWO 5/et8nset3XG/pSjXAmPeAofNEWpmcuv4gcbkGBZhVNQUR/FGLK21vXOtBaF0GkMSwCa kYkCgifAJMGlml+gV86jMxuJJsMn9E4qanM6rzK/WJR5gyheN0nIv8yPUSK+x4xNpPYe NRKA== X-Gm-Message-State: AOAM530OyYe5rI0mpwlT8oMqqwg8toKOe9ZkpC+Ii+tgVS8W7OCNOzLU nngdja2AR78H1fI8C4HyE4AnTX47OGUqXA6741RzaQ== X-Google-Smtp-Source: ABdhPJzTpySGYJra+BXvTq6iSyad4XDiq+DupsOPlgYKnrXUooOYd6+ozHss6nzbKgV0pRvRbwKXGlxdocZbciGAZg0= X-Received: by 2002:a2e:9b42:: with SMTP id o2mr1408833ljj.102.1594888358789; Thu, 16 Jul 2020 01:32:38 -0700 (PDT) MIME-Version: 1.0 References: <20200715135011.42743-1-kirill.shutemov@linux.intel.com> <20200715205428.GA201569@google.com> <20200715222228.jf2pv5u2wyhtc5o5@box> In-Reply-To: From: Naresh Kamboju Date: Thu, 16 Jul 2020 14:02:27 +0530 Message-ID: Subject: Re: [PATCHv2] mm: Fix warning in move_normal_pmd() To: Linus Torvalds Cc: "Kirill A. Shutemov" , Joel Fernandes , "Kirill A. Shutemov" , Andrew Morton , Linux-MM , Linux Kernel Mailing List , William Kucharski Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: E6B9D1803F9AC X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 16 Jul 2020 at 04:49, Linus Torvalds wrote: > > On Wed, Jul 15, 2020 at 4:04 PM Linus Torvalds > wrote: > > > > It *might* be as simple as this incremental thing on top > > No, it needs to be > > + if (*old_addr + *len < old->vm_end) > + return; > > in try_to_align_end(), of course. I have modified the patch with the above change. Sorry the proposed patch [1] did not solve the reported problem. Link to warning on i386, https://lkft.validation.linaro.org/scheduler/job/1574295#L2055 Link to the patch which applied on top of Linus master and tested. [1] https://pastebin.com/2gTxi3pj I am happy to test the next version patch. - Naresh