From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B008C2BA18 for ; Mon, 6 Apr 2020 08:23:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 197A4206F8 for ; Mon, 6 Apr 2020 08:23:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="a7tYuu3T" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 197A4206F8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 192C58E000E; Mon, 6 Apr 2020 04:23:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 145498E000D; Mon, 6 Apr 2020 04:23:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 032C58E000E; Mon, 6 Apr 2020 04:23:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0236.hostedemail.com [216.40.44.236]) by kanga.kvack.org (Postfix) with ESMTP id D99288E000D for ; Mon, 6 Apr 2020 04:23:22 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id A03EE2479 for ; Mon, 6 Apr 2020 08:23:22 +0000 (UTC) X-FDA: 76676740644.06.glass60_3a8ce33a30711 X-HE-Tag: glass60_3a8ce33a30711 X-Filterd-Recvd-Size: 5144 Received: from mail-lf1-f68.google.com (mail-lf1-f68.google.com [209.85.167.68]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Mon, 6 Apr 2020 08:23:22 +0000 (UTC) Received: by mail-lf1-f68.google.com with SMTP id z23so11065847lfh.8 for ; Mon, 06 Apr 2020 01:23:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1c07BEC07UZVPJHnU0F7x86Le0JR3iWdmr6B9bHz+yQ=; b=a7tYuu3Tabrb7D/49u9jm9lL6eXqgnC87ZMNcPFC7Nhjk8WnjExZ5NeAav2TmLOtTW HVNKnRwOQthkpWpKCu2IqTs9B9uLUy+qD+ZXrkoZOQa4SdgWML5ql6jNVz6rjlMO86EM vko/niF41g++EhmL5P89Gaw9j9naop8nVPhfPvv8MtqRlJWkb00n0vhf1E8dnZUcusZm W0XWYQ8/D5jON++s/0YlrLFub6gpZD2KF1qEuyJMLJsVONTssqP7rGo/2tnCoRIGTPsr GLui6R61RHcd9Xb2J+Wnm2rOU8Yv+FJkmZScKBanNWvbolq/1/jbnRCD7nqBKn52Ovdp WDRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1c07BEC07UZVPJHnU0F7x86Le0JR3iWdmr6B9bHz+yQ=; b=IkqdlHD7MMcNszV/XOQ+2/+HY7GG9ZElM+6MSMP0eZhYleY+iABdN2LoAC+AeDnU2d /llNYCc3teG+dUIR3VtZYntAjvFb3zHzdXUAUT/szvXVPQHI9L8l+BURbsVaGPetlaQb daE2WxrVdC9h0KCKzkupc2dHmXmIl1eTtXaUBKlqpGCmnvS7tuJiPLYUb6CqZ5s94f8o nhPR16ucIselsWYLGML1dYmKjoMgpS6a9T/cXQpg5IWnIlAJ+2wEqNpzO4QMA22uaHrj I7vOQSqC/S4s78Ioo/5nz1IRIz48M2QrmqX1X84NIGDw1+pYboFUHkJbq0d+yj0n6JEk OXLw== X-Gm-Message-State: AGi0PuaKSGCX3GPc5suNze7BAQ0R3o4mA+ja6qjNSttMlCfzSTrGroWT 5Wgn6JX/99CxiYNBo9JtpynifTiop8+d0mICaCpiNw== X-Google-Smtp-Source: APiQypJnyOYlwjP10HGdWQRrOOqzpBCTzDkFCOrs1js1rgvxGv5ZQLRUnz8Sei/ZMVu9arbIsNBG6fLhNsXR4+STv6U= X-Received: by 2002:a19:5e46:: with SMTP id z6mr11789742lfi.74.1586161400666; Mon, 06 Apr 2020 01:23:20 -0700 (PDT) MIME-Version: 1.0 References: <20200402133849.mmkvekzx37kw4nsj@box> <20200403133252.ivdqoppxhc6w5b47@box> <20200404160631.7eny3swsqn665m2p@box> In-Reply-To: <20200404160631.7eny3swsqn665m2p@box> From: Naresh Kamboju Date: Mon, 6 Apr 2020 13:53:09 +0530 Message-ID: Subject: Re: mm/mremap.c : WARNING: at mm/mremap.c:211 move_page_tables+0x5b0/0x5d0 To: "Kirill A. Shutemov" Cc: Andrew Morton , linux- stable , linux-mm , "Joel Fernandes (Google)" , William Kucharski , Julia Lawall , Michal Hocko , Will Deacon , Greg Kroah-Hartman , lkft-triage@lists.linaro.org, Mike Kravetz , LTP List Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 4 Apr 2020 at 21:36, Kirill A. Shutemov wrote: > > On Sat, Apr 04, 2020 at 08:10:42PM +0530, Naresh Kamboju wrote: > > On Fri, 3 Apr 2020 at 19:02, Kirill A. Shutemov wrote: > > > > > > On Fri, Apr 03, 2020 at 12:56:57AM +0530, Naresh Kamboju wrote: > > > > [ 734.876355] old_addr: 0xbfe00000, new_addr: 0xbfc00000, old_end: 0xc0000000 > > > > > > The ranges are overlapping. We don't expect it. mremap(2) never does this. > > > > > > shift_arg_pages() only moves range downwards. It should be safe. > > > > > > Could you try this: > > > > Applied the patch and tested and still getting kernel warning. > > CONFIG_HIGHMEM64G=y is still enabled. > > > > [ 790.041040] ------------[ cut here ]------------ > > [ 790.045664] WARNING: CPU: 3 PID: 3195 at mm/mremap.c:212 > > move_page_tables+0x7a7/0x840 > > Are you sure the patch is applied? The line number in the warning supposed > to change. Yes. The patch was applied and tested. The reason for line number change is due to linux/mmdebug.h included because an earlier patch "dump_vma(vma);" needed this. diff --git a/mm/mremap.c b/mm/mremap.c index af363063ea23..cf02d4244e83 100644 --- a/mm/mremap.c +++ b/mm/mremap.c @@ -24,6 +24,7 @@ #include #include #include +#include #include #include @@ -208,7 +209,7 @@ static bool move_normal_pmd(struct vm_area_struct *vma, unsigned long old_addr, * The destination pmd shouldn't be established, free_pgtables() * should have release it. */ - if (WARN_ON(!pmd_none(*new_pmd))) + if (WARN_ON(!pmd_none(*new_pmd) && old_addr > new_addr)) return false; /* - Naresh