From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97B37C3F2D1 for ; Tue, 3 Mar 2020 18:41:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 50DEF20716 for ; Tue, 3 Mar 2020 18:41:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="kvElP/GN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 50DEF20716 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D58166B0005; Tue, 3 Mar 2020 13:41:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D09246B0006; Tue, 3 Mar 2020 13:41:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF8B16B0007; Tue, 3 Mar 2020 13:41:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0078.hostedemail.com [216.40.44.78]) by kanga.kvack.org (Postfix) with ESMTP id A59286B0005 for ; Tue, 3 Mar 2020 13:41:00 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 366575008 for ; Tue, 3 Mar 2020 18:41:00 +0000 (UTC) X-FDA: 76554917880.26.spy62_7d20107423e3f X-HE-Tag: spy62_7d20107423e3f X-Filterd-Recvd-Size: 4115 Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) by imf46.hostedemail.com (Postfix) with ESMTP for ; Tue, 3 Mar 2020 18:40:59 +0000 (UTC) Received: by mail-lj1-f194.google.com with SMTP id q19so3755813ljp.9 for ; Tue, 03 Mar 2020 10:40:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=K9L8LpeVMtnzZ8FmaaVZ7NUiIySlaxwUj+GAhb2yvpg=; b=kvElP/GNRjricekrnBnTwMWm1NGHWE1mYYa6ncy9xTGBJuw41jJj81446Umt2+q0MC in6YY7aDXGyKX5w0ot7dmbCgKT/GKvWkyQaQrj08cTqPSz5Zg2d9hCE2bNTT2sWYEG1K m42AyTUFIhhinghhUC//FkRkrPCs5F4sZ40iDGnLoerHOCGTiUvF48uNKuo1m6TG8sjp AlheRsSsQ9gpoGw1qFh2QUTDt+zfMlLcFTk6zObeWYexEp33z804P/OZ1iijmFolqank IBPBCfg65QssXvD3PyHcOF33d6z0zVbmCVg6DdnW07ajv+0smTXkP3u8qQR1TaNLqo0T UgZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=K9L8LpeVMtnzZ8FmaaVZ7NUiIySlaxwUj+GAhb2yvpg=; b=sLlxQKIHte0nu2+BfcIgcTET1LCkRla0Ebv0vyWw7aWNGxs31sc9zDG9c3f2d4He4y pTZf58tZtUt5VKSdPanohGXANla4qMA3Tt3bCTAuvIdD9zbhDIwvRJel1bCjlzfmVv6f XDF/gF65H7L0yQgb4CN8VEIOyXA3v/yJQiGAocF7NO227tut3FJ6I7WEetoJsCCiEP5n HcxRfHPN69OJbuYhtMs+DZUfK5EYZ7naafbEzMvoLXD3f3XOhjovDeb5IbLupUlePAQP a6yECCIIci7epkRv2FvQFKdy0nZUIGaTcyHiqHTmySpfKnZmFQstiMsirWWRJSytbNF3 fi2w== X-Gm-Message-State: ANhLgQ23lqcE8RaxVySYvrU1MhFQkUcYaEzynGFyXg8sDLGYz2bdcfMJ mtLrx+dx/Ny/DDw6SnYTZLtkXBEZQtzHuv6rQjcU9A== X-Google-Smtp-Source: ADFU+vveWWrvF39sdtRWSPvGCy5k47/WOCsYaSY9indjbjp+WgB9JR7Zjea5rnIm33d2gEkkY++13V2jS7qUeCgGywE= X-Received: by 2002:a2e:9dc8:: with SMTP id x8mr3227246ljj.38.1583260857753; Tue, 03 Mar 2020 10:40:57 -0800 (PST) MIME-Version: 1.0 References: <0a37bb7d-18a7-c43c-52a5-f13a34decf69@i-love.sakura.ne.jp> In-Reply-To: From: Naresh Kamboju Date: Wed, 4 Mar 2020 00:10:46 +0530 Message-ID: Subject: Re: fs/buffer.c: WARNING: alloc_page_buffers while mke2fs To: Yang Shi Cc: Tetsuo Handa , linux-mm , Andrew Morton , Mel Gorman , Michal Hocko , Shakeel Butt , schatzberg.dan@gmail.com Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 3 Mar 2020 at 23:17, Yang Shi wrote: > > On Tue, Mar 3, 2020 at 2:53 AM Tetsuo Handa > wrote: > > > > Hello, Naresh. > > > > > [ 98.003346] WARNING: CPU: 2 PID: 340 at > > > include/linux/sched/mm.h:323 alloc_page_buffers+0x210/0x288 > > > Could you please try the below debug patch? This is not the proper > fix, but it may help us narrow down the problem. > > diff --git a/include/linux/sched/mm.h b/include/linux/sched/mm.h > index c49257a..1cc1cdc 100644 > --- a/include/linux/sched/mm.h > +++ b/include/linux/sched/mm.h > @@ -320,6 +320,10 @@ static inline void > memalloc_nocma_restore(unsigned int flags) > */ > static inline void memalloc_use_memcg(struct mem_cgroup *memcg) > { > + if ((current->flags & PF_KTHREAD) && > + current->active_memcg) > + return; > + > WARN_ON_ONCE(current->active_memcg); > current->active_memcg = memcg; > } After applying this patch the reported "warning" did not happen. Here is the full test log. https://lkft.validation.linaro.org/scheduler/job/1265325#L1287 - Naresh