Re: WARNING: CPU: 1 PID: 23 at kernel/workqueue.c:4317 enable_work (kernel/workqueue.c:4317 (discriminator 1) kernel/workqueue.c:4488 (discriminator 1))

[Naresh Kamboju <naresh.kamboju@linaro.org>]

On Mon, 6 Jan 2025 at 23:45, Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
>
> The following warnings have been noticed on today's Linux next kernel
> on the arm64, x86 and arm devices.
>
> This is first seen on next-20250106.
> GOOD: next-20241220
> BAD: next-20250106
>
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
>
> Boot warnings logs:
> ===============
> [    0.132875] workqueue: work disable count underflowed
> [    0.137989] WARNING: CPU: 1 PID: 23 at kernel/workqueue.c:4317
> enable_work (kernel/workqueue.c:4317 (discriminator 1)
> kernel/workqueue.c:4488 (discriminator 1))
> [    0.146001] Modules linked in:
> [    0.149098] CPU: 1 UID: 0 PID: 23 Comm: cpuhp/1 Not tainted
> 6.13.0-rc5-next-20250106 #1
> [    0.157180] Hardware name: Thundercomm Dragonboard 845c (DT)
> [    0.162892] pstate: 600000c5 (nZCv daIF -PAN -UAO -TCO -DIT -SSBS BTYPE=--)
> [    0.169918] pc : enable_work (kernel/workqueue.c:4317
> (discriminator 1) kernel/workqueue.c:4488 (discriminator 1))
> [    0.173886] lr : enable_work (kernel/workqueue.c:4317
> (discriminator 1) kernel/workqueue.c:4488 (discriminator 1))
>

Anders bisected this regression and found the bad commit,

# first bad commit:
    [adcfb264c3ed51fbbf5068ddf10d309a63683868]
     vmstat: disable vmstat_work on vmstat_cpu_down_prep()

Git bisect log,
-----------
# bad: [9d89551994a430b50c4fffcb1e617a057fa76e20] Linux 6.13-rc6
# good: [fc033cf25e612e840e545f8d5ad2edd6ba613ed5] Linux 6.13-rc5
git bisect start 'v6.13-rc6' 'v6.13-rc5'
# good: [ee063c23e48212a6af163f8d45560a92fcaec125] Merge tag
'nios2_update_for_v6.14' of
git://git.kernel.org/pub/scm/linux/kernel/git/dinguyen/linux
git bisect good ee063c23e48212a6af163f8d45560a92fcaec125
# good: [a984e234fcdce25a276be882c799e5fda1b32812] Merge tag
'io_uring-6.13-20250103' of git://git.kernel.dk/linux
git bisect good a984e234fcdce25a276be882c799e5fda1b32812
# good: [7a5b6fc8bd70cbb22b1e9eacd7edaf5626e9fc74] Merge tag
'clk-fixes-for-linus' of
git://git.kernel.org/pub/scm/linux/kernel/git/clk/linux
git bisect good 7a5b6fc8bd70cbb22b1e9eacd7edaf5626e9fc74
# good: [d0e6983a6d1719738cf8d13982a68094f0a1872a] mm: shmem: fix
incorrect index alignment for within_size policy
git bisect good d0e6983a6d1719738cf8d13982a68094f0a1872a
# bad: [0210d251162f4033350a94a43f95b1c39ec84a90] scripts/sorttable:
fix orc_sort_cmp() to maintain symmetry and transitivity
git bisect bad 0210d251162f4033350a94a43f95b1c39ec84a90
# bad: [8debfc5b1aa569d3d2ac836af2553da037611c61] mm/damon/core: fix
new damon_target objects leaks on damon_commit_targets()
git bisect bad 8debfc5b1aa569d3d2ac836af2553da037611c61
# bad: [adcfb264c3ed51fbbf5068ddf10d309a63683868] vmstat: disable
vmstat_work on vmstat_cpu_down_prep()
git bisect bad adcfb264c3ed51fbbf5068ddf10d309a63683868
# good: [d77b90d2b2642655b5f60953c36ad887257e1802] mm: shmem: fix the
update of 'shmem_falloc->nr_unswapped'
git bisect good d77b90d2b2642655b5f60953c36ad887257e1802
# first bad commit: [adcfb264c3ed51fbbf5068ddf10d309a63683868] vmstat:
disable vmstat_work on vmstat_cpu_down_prep()

- Naresh