From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC6C1C433E0 for ; Thu, 21 May 2020 09:22:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 86CFA20759 for ; Thu, 21 May 2020 09:22:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Cr+vYd5d" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 86CFA20759 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EE31580021; Thu, 21 May 2020 05:22:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E6BA580007; Thu, 21 May 2020 05:22:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D33C580021; Thu, 21 May 2020 05:22:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0090.hostedemail.com [216.40.44.90]) by kanga.kvack.org (Postfix) with ESMTP id B7AFB80007 for ; Thu, 21 May 2020 05:22:24 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 746078248047 for ; Thu, 21 May 2020 09:22:24 +0000 (UTC) X-FDA: 76840185408.03.rock80_89618f24ff348 X-HE-Tag: rock80_89618f24ff348 X-Filterd-Recvd-Size: 5613 Received: from mail-lf1-f67.google.com (mail-lf1-f67.google.com [209.85.167.67]) by imf47.hostedemail.com (Postfix) with ESMTP for ; Thu, 21 May 2020 09:22:23 +0000 (UTC) Received: by mail-lf1-f67.google.com with SMTP id c21so4071656lfb.3 for ; Thu, 21 May 2020 02:22:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FIbEyFSF9lKlh/sPieDWc1oRqrvi4vGBjOrvNTlDQgI=; b=Cr+vYd5dIpgIP1m+dtPF8wLQuyM7qoaALMgtSirDDMRRIgqxpytD0hrSF2zko/x5mk l/G2FXraKn8PMsmRDq4Un6jQXt2HJ4hL78VRPU+qdLES1+ToQVDFdGiGtpaOGLK7F2zM 6MKEL1a7yiV4ickufkf1ggX7LbmfPLokTuBN2TG1x20EISryRLnvWvNBgcl/y8m7/sVI MO9cnUWS6iHrtzbq50+WiROYQCTdiEG/ExnjIv1i160UasocMEWgmgikQ3pbvdWCeIhi xdBAwAYfUkhH3wWYCwg1eVm4WzkttSXEgcgDwM0Fh/LeRJSCjz+QgsRbYOOK7ojMzFLX xICg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FIbEyFSF9lKlh/sPieDWc1oRqrvi4vGBjOrvNTlDQgI=; b=R5F5ygm9nKfVov6Bzmkw8AsKgz3PTqJhit1hNbEiby/JCozoDPl0rO2TbHCIGOJQ13 oEGCM/JVVM57mM6dcst2xE+5VWOBUZRF4wFZyTz+IZPSx55AIkP9uBEQqVx7oHtRhkjk aLSlf9nBYVVUeVgoQyoURFlssBQlditcOKhB8eYZuUJ6VUeU4s6LKQrDqwpqPmCYpdic PYMGLXuzAWBGtLGDqU7yevo09ZuMxnWWXTKhHaDVUm2s+Sl7/6qYrnnn5hYB+7uZTvQF WxQbO5HYOTxk6mT1JeRITrqOLJWIXeflmkqDgcdzUxkCPmM0j+bqjey51A6VMRIjQNkU sUpw== X-Gm-Message-State: AOAM531207YG4WVpfRwBeCufimhR6IhdbrDudckegRDWtCOhxarysggq S5XNEQIEnqlCITrtwWqqheRxX4DAfaQJRRSRVe2J0A== X-Google-Smtp-Source: ABdhPJxo0iMvxRymbhbSSmZbSlzo/jmqeHEAf6W0prqay+f+/zEUegDczxDDUgR2FE8lvoDDugzyWov/NH6f84fYzgY= X-Received: by 2002:a19:641b:: with SMTP id y27mr372964lfb.74.1590052942272; Thu, 21 May 2020 02:22:22 -0700 (PDT) MIME-Version: 1.0 References: <20200501135806.4eebf0b92f84ab60bba3e1e7@linux-foundation.org> <20200519075213.GF32497@dhcp22.suse.cz> <20200519084535.GG32497@dhcp22.suse.cz> <20200520190906.GA558281@chrisdown.name> In-Reply-To: <20200520190906.GA558281@chrisdown.name> From: Naresh Kamboju Date: Thu, 21 May 2020 14:52:08 +0530 Message-ID: Subject: Re: mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page To: Chris Down Cc: Yafang Shao , Michal Hocko , Anders Roxell , "Linux F2FS DEV, Mailing List" , linux-ext4 , linux-block , Andrew Morton , open list , Linux-Next Mailing List , linux-mm , Arnd Bergmann , Andreas Dilger , Jaegeuk Kim , "Theodore Ts'o" , Chao Yu , Hugh Dickins , Andrea Arcangeli , Matthew Wilcox , Chao Yu , lkft-triage@lists.linaro.org, Johannes Weiner , Roman Gushchin , Cgroups Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 21 May 2020 at 00:39, Chris Down wrote: > > Hi Naresh, > > Naresh Kamboju writes: > >As a part of investigation on this issue LKFT teammate Anders Roxell > >git bisected the problem and found bad commit(s) which caused this problem. > > > >The following two patches have been reverted on next-20200519 and retested the > >reproducible steps and confirmed the test case mkfs -t ext4 got PASS. > >( invoked oom-killer is gone now) > > > >Revert "mm, memcg: avoid stale protection values when cgroup is above > >protection" > > This reverts commit 23a53e1c02006120f89383270d46cbd040a70bc6. > > > >Revert "mm, memcg: decouple e{low,min} state mutations from protection > >checks" > > This reverts commit 7b88906ab7399b58bb088c28befe50bcce076d82. > > Thanks Anders and Naresh for tracking this down and reverting. > > I'll take a look tomorrow. I don't see anything immediately obviously wrong in > either of those commits from a (very) cursory glance, but they should only be > taking effect if protections are set. > > Since you have i386 hardware available, and I don't, could you please apply > only "avoid stale protection" again and check if it only happens with that > commit, or requires both? That would help narrow down the suspects. Not both. The bad commit is "mm, memcg: decouple e{low,min} state mutations from protection checks" > > Do you use any memcg protections in these tests? I see three MEMCG configs and please find the kernel config link for more details. CONFIG_MEMCG=y CONFIG_MEMCG_SWAP=y CONFIG_MEMCG_KMEM=y kernel config link, https://builds.tuxbuild.com/8lg6WQibcwtQRRtIa0bcFA/kernel.config - Naresh