From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E880C433DF for ; Wed, 20 May 2020 18:00:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 40B47204EF for ; Wed, 20 May 2020 18:00:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="RwL7kSM3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 40B47204EF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C6C2980007; Wed, 20 May 2020 14:00:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BF5A4900002; Wed, 20 May 2020 14:00:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AE3CF80007; Wed, 20 May 2020 14:00:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0101.hostedemail.com [216.40.44.101]) by kanga.kvack.org (Postfix) with ESMTP id 93C93900002 for ; Wed, 20 May 2020 14:00:03 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 3A0DB181AEF21 for ; Wed, 20 May 2020 18:00:03 +0000 (UTC) X-FDA: 76837861086.18.chalk58_57ae8854ca428 X-HE-Tag: chalk58_57ae8854ca428 X-Filterd-Recvd-Size: 5395 Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com [209.85.208.196]) by imf14.hostedemail.com (Postfix) with ESMTP for ; Wed, 20 May 2020 18:00:02 +0000 (UTC) Received: by mail-lj1-f196.google.com with SMTP id l15so4510451lje.9 for ; Wed, 20 May 2020 11:00:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mtpCTLjeaytdekB4adxVz/e/JZwQHur4soi/tkekgkg=; b=RwL7kSM3fz9MR6t5Ar2hYTR0dC+a68qyUw6+z9033WeXCAUoxY8PEL7x2rcKx9bIWT l6A08Wjxs5sPfZMw5X09MFSUjE1qHLWgyYHW8VFFkTznN60/pkdMAWpnger7o85A8dVP qTXxWNl+c9c6DyvNDvC0ebMsh3xbuJUKuQ8Rz44tF4eOqCus/XLjH8vxAcgNxnvE6ECD vDEUVjfrmmgeklu12ukdEkM3ps7/O48UUdbhbzh08v+evhakhTrUIyOdzD4cM7odKyc2 jWOem0ysPrATgUJg9nMtB+WUY+Ngyots1DIicBIYLP8IlhqZc/3YjYx7aeu0g0fnDMxE 4bOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mtpCTLjeaytdekB4adxVz/e/JZwQHur4soi/tkekgkg=; b=c0mVFl4edImsITBYh5UYm+fJBA6C+j4D2fAvUfgCpRlIBes21bABbJhAv29YMbf2Zx KlW8qQBlq7xmyiLztPLsnLZQPo8tgNs1L2fbNUosLTy7j0N4tgDo0v2BQX1Zaj4z0ltZ mxiRRFaMVe/c6Ibox4DxVv+we+gJSRISVCUVfhLjqC1uPazoEIJwjKpBfuSYzmhSZJ9W sx3xLr2vfXq3ePXCLj5jNZyfujmnsgzyHHvJSTMf0tzqnGc3d5mcvV7LQ3bg3ThYCcNN 4fqj7LLBSmt14Qt+eOo2qB0c4FW6/A0W9Qeu6M4oPxGx+4A17Fb34a/jMDIjnxtK3BJR qREQ== X-Gm-Message-State: AOAM533kTB9xRmKxyoPJkn+eg7oRRqt27US7aipBh+ys/cI00JMGXfdW ojUJwEy4FODz+Bc3h7Wg6oZymublKHcT+/RsYAILiA== X-Google-Smtp-Source: ABdhPJxMVT2aazzajf86PZFdGt2E7whHDnP+nICKDm4NC6feIw0z4SprtT2do+git6kUcT4Xo3qaJQi4N/SBczqLtpU= X-Received: by 2002:a2e:3012:: with SMTP id w18mr3286415ljw.55.1589997600706; Wed, 20 May 2020 11:00:00 -0700 (PDT) MIME-Version: 1.0 References: <20200501135806.4eebf0b92f84ab60bba3e1e7@linux-foundation.org> <20200519075213.GF32497@dhcp22.suse.cz> <20200519084535.GG32497@dhcp22.suse.cz> In-Reply-To: From: Naresh Kamboju Date: Wed, 20 May 2020 23:29:49 +0530 Message-ID: Subject: Re: mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page To: Chris Down , Yafang Shao , Michal Hocko , Anders Roxell Cc: "Linux F2FS DEV, Mailing List" , linux-ext4 , linux-block , Andrew Morton , open list , Linux-Next Mailing List , linux-mm , Arnd Bergmann , Andreas Dilger , Jaegeuk Kim , "Theodore Ts'o" , Chao Yu , Hugh Dickins , Andrea Arcangeli , Matthew Wilcox , Chao Yu , lkft-triage@lists.linaro.org, Johannes Weiner , Roman Gushchin , cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 20 May 2020 at 17:26, Naresh Kamboju wrote: > > > This issue is specific on 32-bit architectures i386 and arm on linux-next tree. > As per the test results history this problem started happening from > Bad : next-20200430 > Good : next-20200429 > > steps to reproduce: > dd if=/dev/disk/by-id/ata-SanDisk_SSD_PLUS_120GB_190504A00573 > of=/dev/null bs=1M count=2048 > or > mkfs -t ext4 /dev/disk/by-id/ata-SanDisk_SSD_PLUS_120GB_190804A00BE5 > > > Problem: > [ 38.802375] dd invoked oom-killer: gfp_mask=0x100cc0(GFP_USER), > order=0, oom_score_adj=0 As a part of investigation on this issue LKFT teammate Anders Roxell git bisected the problem and found bad commit(s) which caused this problem. The following two patches have been reverted on next-20200519 and retested the reproducible steps and confirmed the test case mkfs -t ext4 got PASS. ( invoked oom-killer is gone now) Revert "mm, memcg: avoid stale protection values when cgroup is above protection" This reverts commit 23a53e1c02006120f89383270d46cbd040a70bc6. Revert "mm, memcg: decouple e{low,min} state mutations from protection checks" This reverts commit 7b88906ab7399b58bb088c28befe50bcce076d82. i386 test log shows mkfs -t ext4 pass https://lkft.validation.linaro.org/scheduler/job/1443405#L1200 ref: https://lore.kernel.org/linux-mm/cover.1588092152.git.chris@chrisdown.name/ https://lore.kernel.org/linux-mm/CA+G9fYvzLm7n1BE7AJXd8_49fOgPgWWTiQ7sXkVre_zoERjQKg@mail.gmail.com/T/#t -- Linaro LKFT https://lkft.linaro.org