From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.6 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 888ACC433DB for ; Thu, 7 Jan 2021 21:08:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0FDC423441 for ; Thu, 7 Jan 2021 21:08:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0FDC423441 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 828DB8D014E; Thu, 7 Jan 2021 16:08:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7B3498D013A; Thu, 7 Jan 2021 16:08:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 67C078D014E; Thu, 7 Jan 2021 16:08:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0025.hostedemail.com [216.40.44.25]) by kanga.kvack.org (Postfix) with ESMTP id 52C8A8D013A for ; Thu, 7 Jan 2021 16:08:32 -0500 (EST) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 11854181AEF10 for ; Thu, 7 Jan 2021 21:08:32 +0000 (UTC) X-FDA: 77680217664.04.coal92_500a111274ed Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin04.hostedemail.com (Postfix) with ESMTP id E21058013B8E for ; Thu, 7 Jan 2021 21:08:31 +0000 (UTC) X-HE-Tag: coal92_500a111274ed X-Filterd-Recvd-Size: 5701 Received: from mail-ua1-f49.google.com (mail-ua1-f49.google.com [209.85.222.49]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Thu, 7 Jan 2021 21:08:31 +0000 (UTC) Received: by mail-ua1-f49.google.com with SMTP id p2so2739093uac.3 for ; Thu, 07 Jan 2021 13:08:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9fYan1yzqxVguL0ZQY0BTwdyUMx5dFzjZBmr/vD5tRY=; b=k7t5Q/9M+TUvwdmswWS/rvtjs9qDhmvTiyszvvNXDsiTTlK7iB6M75IDdY0nIKnm6o GYgVSYkz+jKHpbNAvuoI2PnlSbdVKN9N8tYY9oDVdPAJLz3Qh0r961/AZyx9ijfzjpgJ ukj0XTlvL+oBbgW9V7gFwDCroxhJAPHYplQxxdUck0GFKbevY5xd6LlUDYmLfrh2CZFG t9e7IoqPMQ1m2bAiehuDjT3IJJ/WVoT2VKCRUFvLh2ff4ikDY85hN1+fFyduNyKX2Lwq 1IADMWi+19HunLHNAHcaQpdX6aEEOEuWryDSKQhxLwPtwfBTH2uENWi3N2YKSrHla3YG w4Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9fYan1yzqxVguL0ZQY0BTwdyUMx5dFzjZBmr/vD5tRY=; b=IeN7I5WGA0vMCP/qrcewXiBXHBZU0wQK7pfyG6SfPtROUtH8P0bnXyvvXO5cJAB8o1 qvlrt+/q11YrU20/tP6F/X1Bq9p0MFUGqnWLN0qwyk9opKkcdxcOb5RwI5hvNTr2xPF+ sLmVwSX+EEVXO14BN7TzEDPLDeQSnNGiuTGArGlf6ZxeFX49UKb2G2jQZdQ5N4NcNzMv uzhZ3pG7RsHgV8uEd/5yMYjoy2jDpn5Dgy8OC6lWTkll5yWHXoJ1+1FQSFQJzWMR5EkE psQ4RxPfSt097uo13apUyrAdiCu1Kcg+pSpISfPKeIotxbQaKygKvya8WT5XO13W3Y5z 9GWQ== X-Gm-Message-State: AOAM532uiSJhD4boUxs7uj5lXsJ6PBnYCK2C3kYtxKAaWaQNUjEAf9Q8 iB0ChxbbWrSaw2FWp43ksjb04uXDsBXRIwWZTg3XEA== X-Google-Smtp-Source: ABdhPJxHnJvsbDwyF4bx6K6BhV313BR8eONthkFk/er2XbRI7zrOtNCXhB8Pf0IMiO7/77tD+fvpJVhr9OCB4d8PTk0= X-Received: by 2002:ab0:7386:: with SMTP id l6mr642880uap.141.1610053710484; Thu, 07 Jan 2021 13:08:30 -0800 (PST) MIME-Version: 1.0 References: <20201118194838.753436396@linutronix.de> <20201118204007.169209557@linutronix.de> <20210106180132.41dc249d@gandalf.local.home> <20210106174917.3f8ad0d8@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20210107155256.7af2505e@gandalf.local.home> In-Reply-To: <20210107155256.7af2505e@gandalf.local.home> From: Willem de Bruijn Date: Thu, 7 Jan 2021 16:07:54 -0500 Message-ID: Subject: Re: [BUG] from x86: Support kmap_local() forced debugging To: Steven Rostedt Cc: Linus Torvalds , Jakub Kicinski , David Miller , Jonathan Lemon , Thomas Gleixner , LKML , "the arch/x86 maintainers" , Christoph Hellwig , Matthew Wilcox , Daniel Vetter , Andrew Morton , Linux-MM , Peter Zijlstra , Ingo Molnar , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Netdev Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 7, 2021 at 3:53 PM Steven Rostedt wrote: > > On Thu, 7 Jan 2021 11:47:02 -0800 > Linus Torvalds wrote: > > > On Wed, Jan 6, 2021 at 8:45 PM Willem de Bruijn wrote: > > > > > > But there are three other kmap_atomic callers under net/ that do not > > > loop at all, so assume non-compound pages. In esp_output_head, > > > esp6_output_head and skb_seq_read. The first two directly use > > > skb_page_frag_refill, which can allocate compound (but not > > > __GFP_HIGHMEM) pages, and the third can be inserted with > > > netfilter xt_string in the path of tcp transmit skbs, which can also > > > have compound pages. I think that these could similarly access > > > data beyond the end of the kmap_atomic mapped page. I'll take > > > a closer look. > > > > Thanks. > > > > Note that I have flushed my random one-liner patch from my system, and > > expect to get a proper fix through the normal networking pulls. > > > > And _if_ the networking people feel that my one-liner was the proper > > fix, you can use it and add my sign-off if you want to, but it really > > was more of a "this is the quick ugly fix for testing" rather than > > anything else. I do think it is the proper fix as is. If no one else has comments, I can submit it through the net tree. It won't address the other issues that became apparent only as a result of this. I'm preparing separate patches for those. > Please add: > > Link: https://lore.kernel.org/linux-mm/20210106180132.41dc249d@gandalf.local.home/ > Reported-by: Steven Rostedt (VMware) > > And if you take Linus's patch, please add my: > > Tested-by: Steven Rostedt (VMware) > > and if you come up with another patch, please send it to me for testing. > > Thanks! Will do, thanks.