From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D600DC3DA7F for ; Thu, 15 Aug 2024 07:27:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 603406B0092; Thu, 15 Aug 2024 03:27:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5B36B6B0093; Thu, 15 Aug 2024 03:27:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 47BB16B0095; Thu, 15 Aug 2024 03:27:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 2B5F96B0092 for ; Thu, 15 Aug 2024 03:27:26 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B2104414CC for ; Thu, 15 Aug 2024 07:27:25 +0000 (UTC) X-FDA: 82453649250.29.F39B257 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by imf02.hostedemail.com (Postfix) with ESMTP id EBB5D80025 for ; Thu, 15 Aug 2024 07:27:23 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ZKWVckCY; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf02.hostedemail.com: domain of tabba@google.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=tabba@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723706762; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pXJzm0D10WfLU9z0++7Jp9e2VIC6jCXOZwkG9G3TV6A=; b=giNiTq2DBQcUDZWYPk/1mBBWeI522+p6Gx3O4QNy9QBR7wojnZYGXPuWLtZTfHkjLmmCbE AeA1uViis+mKwJWCyAqKDwgy4BMmlN/5qTEhzWE1/o50YQ5qvtfIzCoiLlhO2dQPwJVnhW H5keo/PXfEGBUVifLnSRGBARlBPSyZQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723706762; a=rsa-sha256; cv=none; b=Ji752rCSyasiCkQ3flAfs6fRmpH+sAs/Azt/aFXld2vIpHxWYGjIRnoTmpBfox6LdaT1zb 9lH2PHhMe+L4DtTeCxpt6kEvTYX3NeBpqbySLdylo7I3IK7NV79JMJXU82v/R4EIxpyo/U Awgu634x3FiGUt7IVmCVvRO3OOIy4EU= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ZKWVckCY; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf02.hostedemail.com: domain of tabba@google.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=tabba@google.com Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-367963ea053so418169f8f.2 for ; Thu, 15 Aug 2024 00:27:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1723706842; x=1724311642; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=pXJzm0D10WfLU9z0++7Jp9e2VIC6jCXOZwkG9G3TV6A=; b=ZKWVckCYHQah4xKOoxhzA7EDCUExBeew2rV8a6MyltOpJq4QqcmK7uZ0dSET1l1F3U JIgb/2IwbD8SHj1nmv5kRAKYp2bws5dP99lvkOKJikf+295dIE+temLe4wOR6JXvGid4 kYSQToitZGkOPk690enVKUjIbftk3PgwZIaZzd9uOAZxTxz0dmWmTv9qA3g1KOIfF4KP QPLj9FDui/pkduPHACZ34EF0rl/3L5VawSOD7Z2UYRP1cv+8bURTJbPfLTiPJDvqUpap YM24sOgPnf2Iip1fzB2SCmbObmABz6a2IpJKqQ4TLijdrjYF7x9Z1Wsq173VChbxRgW8 BH7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723706842; x=1724311642; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pXJzm0D10WfLU9z0++7Jp9e2VIC6jCXOZwkG9G3TV6A=; b=dzl1WtjK7FPH281wUK88JtaQPgCkEIsR77pW6u80qTJvvpp4pg5gbXg9h7NBdVcd4U m2uIAO9fWmouVaV75noF5YQPrBfpW2umvLbO2yT4JUKmRfiBIMITx3qJ7+cVzZ+4lozv vP5+I+Cr7ZRuqRLXrAz38U/6G+Fl9hucaiuGTaqzVtVa6zoxp8VL4jDMfc3rhUDH6Z0X BsdBmcUg6H7B7XrIRZEp7+yplfwfSsYbC4LQu1Av3qKcHftMESwzPlwqjO+sU0g1+4+g p5//Lh2nrGkjMxsAgOQFtEYNOaknzUzF9nGPwjImQyfF1bMgeLNzeDjhdmZDqR4qxKFj Zw3g== X-Forwarded-Encrypted: i=1; AJvYcCVONA234UfAY5W0+3WCJMVonJqwp0kjJLzhVdV3espKyYzzXtgBRqSw7PL9RGhLgyiGHJNmBHTWVcUhDlyfFNNCeFo= X-Gm-Message-State: AOJu0YzdlXMZQ0Jy2jM8/LnShYn/ZBsYzcaoTes7SsjpzDOThwaPkGZu r9vSCHc5IwEd+SyRED7KInWb8/x9i0tIrsb+IAI7GLSe6mDCRFyjMMTV36xqij6iRTtMmbzmC5t 0j9pVwDVGLM3SmqSiU87rT1hRQJVYTtxN32zv X-Google-Smtp-Source: AGHT+IH6naSRz220SzN8RarZSndGjV+CeULQ4qqyqInU1++JS55z0LhTf5shflkfmNPy3v60d0PC6kZ+l6KMyILMVYE= X-Received: by 2002:adf:f283:0:b0:368:3b5c:7a5d with SMTP id ffacd0b85a97d-3717775c4c3mr4945906f8f.20.1723706842239; Thu, 15 Aug 2024 00:27:22 -0700 (PDT) MIME-Version: 1.0 References: <20240801090117.3841080-1-tabba@google.com> <20240801090117.3841080-10-tabba@google.com> <910085c1-c29c-4828-853c-70760b458086@amazon.co.uk> In-Reply-To: <910085c1-c29c-4828-853c-70760b458086@amazon.co.uk> From: Fuad Tabba Date: Thu, 15 Aug 2024 08:26:45 +0100 Message-ID: Subject: Re: [RFC PATCH v2 09/10] KVM: arm64: arm64 has private memory support when config is enabled To: Patrick Roy Cc: kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, yu.c.zhang@linux.intel.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, david@redhat.com, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: EBB5D80025 X-Stat-Signature: mh1jx853etaydahrc535jrbai4imrtrk X-Rspam-User: X-HE-Tag: 1723706843-446763 X-HE-Meta: U2FsdGVkX1/RoEtko1HVW4Lu9pbjt/VK9nbQ5agBK8nCjuJt1Ud6i1EINKYW6tzJ+GOqlrwquPtEw9WZcB8EHUcfRzr0lAY8qDl/b6Rl1dlD6eOFd5DQfFRC38uYFub4K8iYEBUzCmRKw8Dye/xOSu1NMPv4DLJ66Yiyb8+plqyHVX7Yz+HMq4KnQEywSWRLiTxM3MEfQ4aqRCq0d931CsLlcW25HaEHMz4pUV8UEW4Y8xys24G+e5AMDEoYP/yrKJgC2SOa1KgSwwexnUxVq15RMnAeb5O3+IVhV72V3oL35PP6rn+62BHERw+Ynqgrq6hlakmOPUHa1KfSjfEBEcqf5mymVsFGTXlOJAMeOpCD7xgfF2gfIvIQnoWxNmRrYtUdOI0JlzDh7jIb58EYI37O5R18qz+xtiME28OFdh3Dimz2ItF288A5e5qo1TPM+EVMz8K4BAWfVf8kBKlR5hixmuqyBrsKe9xSo3s6/B/Eq1eI7LQ1A6MPE1GeN7iVnaW8a1gNFgNN6vRSg6z4DqJluJjnFQXXaQiMzoLchkcwx/YPgrA/gO7ClfIl+rpZxLbRB+qC6bKN0z1TjyoXdOIMfmHEPadaDGIiZLJ3mX4w2z7r1yatq+KCoN2fiJPD5t/l4wugpuHHv2zLKtM0CDdMhkeRNhXsZ7JUCiqsJ6b76uHTibZbtfTzU1ULm37YeByTPThCgGV15u24+N48TFkmHy2PzIZv5PFFvo3FoKoPAazmAY+6HNmnuyO6omgvfl/pV2CzrTFYMT6bRuU8eIhX12rI/31xsq80STlfg6izyUX/n9i2x0wK6kD9YtN1vBgFtb/crBYdyVzhGsJNfgrUwx7XDE3PJWoYnqqd7cdH5MlsY5gu3q1x65JpDpuR3jGPk1SD3RuAOtSsEOfKwWugPT2zxEesHUkFs1XKrQLbcrCzZHzVl7fMQDjlFEh+BX9kuFZvJWSQrQfrIPR hNxmHhsp QAWMnmx3VwpneP3V8bg4PKLtM0Rjkafceog8g/YiR11ZAQKaDpCujwKX+Cf4TyHurCI4cZ16tQ+FsS6LVKQqDg1EWj9ZoYYs1mnsyO9uaXjKts35cJ/WjXsvVf4V+CrSseQe9O7NWGGE8MIsDd+SdlV93DgmdNZEwAYqYzUn0Wf8RuZ3eBOCbl+HO9p8TysFD9tKDv2lsLe06SwSv1Dy9jijpbxnn9HWdhIHhXEiL0MbokmTE91Wedg+jhaBHP4vAEYI/xXZtBEI/LGL78/B+ijIFr6ZijM7S1M5f X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Patrick, On Thu, 15 Aug 2024 at 07:27, Patrick Roy wrote: > > Hi Fuad, > > On Thu, 2024-08-01 at 10:01 +0100, Fuad Tabba wrote: > > Implement kvm_arch_has_private_mem() in arm64, making it > > dependent on the configuration option. > > > > Signed-off-by: Fuad Tabba > > --- > > arch/arm64/include/asm/kvm_host.h | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h > > index 36b8e97bf49e..8f7d78ee9557 100644 > > --- a/arch/arm64/include/asm/kvm_host.h > > +++ b/arch/arm64/include/asm/kvm_host.h > > @@ -1414,4 +1414,7 @@ bool kvm_arm_vcpu_stopped(struct kvm_vcpu *vcpu); > > (pa + pi + pa3) == 1; \ > > }) > > > > +#define kvm_arch_has_private_mem(kvm) \ > > + (IS_ENABLED(CONFIG_KVM_PRIVATE_MEM) && is_protected_kvm_enabled()) > > + > > Would it make sense to have some ARM equivalent of > KVM_X86_SW_PROTECTED_VM here? Both for easier testing of guest_memfd on > ARM, as well as for future non-coco usecases. I don't really have a strong opinion about this. I thought that if/when that were to happen, it would be trivial to modify this macro. Cheers, /fuad > > #endif /* __ARM64_KVM_HOST_H__ */ > > -- > > 2.46.0.rc1.232.g9752f9e123-goog > > > > Best, > Patrick