From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC71DC4332F for ; Thu, 2 Nov 2023 14:36:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8EFC38D008C; Thu, 2 Nov 2023 10:36:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 878968D000F; Thu, 2 Nov 2023 10:36:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 719B68D008C; Thu, 2 Nov 2023 10:36:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5FDBF8D000F for ; Thu, 2 Nov 2023 10:36:16 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 23C15120166 for ; Thu, 2 Nov 2023 14:36:16 +0000 (UTC) X-FDA: 81413264352.14.D80310F Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) by imf05.hostedemail.com (Postfix) with ESMTP id 4C7CE10001B for ; Thu, 2 Nov 2023 14:36:14 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=CTqi70NI; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf05.hostedemail.com: domain of tabba@google.com designates 209.85.222.175 as permitted sender) smtp.mailfrom=tabba@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698935774; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xGQNRc9zE40ysVevY/WGU/Lu6W4371YJar5QqeiLOSY=; b=0Ew/sj6/uva+yH32blSj97djDj/XqLQy56FrQ23cOWjrdRIdQ4YedNCVCkVZVFAFWttpam UCsms6ePDHv6sBF6F2W7rMA3yGvaj4m775NJo5V3Q6kQuhIxC9sPCoEyAur6cQ/6dfRneJ MyJnRzbWEn0Ks/DY3UOD4hv+3sIuJAo= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=CTqi70NI; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf05.hostedemail.com: domain of tabba@google.com designates 209.85.222.175 as permitted sender) smtp.mailfrom=tabba@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698935774; a=rsa-sha256; cv=none; b=6tONvmFVwL81h5ibX4z5fx9ilRSH5dWCQpHtOwBx0BZNti6djzu6eO5PWvqGECzkm7A9zc 3Q53GTYWesDKRBvGXfkR0I7TxHdWlJ/cAbQxj76i/F1+EDl/nXRoiIvN5k0chPnezqqgOx s963Mesw06DnaME6nkyUOct4B4bVHko= Received: by mail-qk1-f175.google.com with SMTP id af79cd13be357-777719639adso57853885a.3 for ; Thu, 02 Nov 2023 07:36:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1698935773; x=1699540573; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=xGQNRc9zE40ysVevY/WGU/Lu6W4371YJar5QqeiLOSY=; b=CTqi70NIpWv0d4pzajAhe1CamJwS8qw5SRZLXm/OBRg+NILdip40D1d4eIATh5M9yn kP6JAosFwx1PcXF0p4RWR5BC/NSWFIwads0rjg4JW0w9jTcSRcZ3601QJvBoyowe3YK7 iCnMwfgKqXvqeECwB7283lJTOiVwrhiMwCez0o0m652VUWDz7/WOkWMrtll8QOBibG3v 30QwZqWjrOd1BskAAgsP7IyROy3rdDf1KxRIpOatxPh6QBmWIJGBH2pHoAHRt8lfAOkO SQge9Vo6ujzs0LA9NbtmgvZx+g2tMuNswAjm5MmRwWecQlNS9mxbDqlz3oykPiuh4yBI lJgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698935773; x=1699540573; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xGQNRc9zE40ysVevY/WGU/Lu6W4371YJar5QqeiLOSY=; b=LHY38AWIeulJTLOWE0coKLQKZw42dWc9ZTJH4GYo9WiV7dfGwQl34Y/Zk+ee2cBwez SojaLR9r01/xPJnkVRESVpWR8ver20A/ZtVUVt7FxvbNCc315H3qt7iqGIGF6C5XBDEa XbKMj7Bkr3oNq4cQ3q1U8hgTJ1JfdtyTMAn+5aAki6sHnIoF+FEruUb1hVIB9BDZ8RTC iVkcb7rvqxFRCOhNMEEuKmOJ/sLYWa22gyTlzYAzvdW9+D3GIBiXVffSai+cAinreZLs 7ZTPH+2tg1viJwpFZp/S+imEVqCno2gBS3AjVYxVrTUmHjQfWDE/vCFZY6WCVNBHsaXP ZmPg== X-Gm-Message-State: AOJu0YysLxVWZYTiAJE39KxqiFXTJFjDBbiOb1Bf+WA0Bh2TgitPLJVU T9q2RJK7egM+HighEmbFP1jW4UsEzvXc8AtI4b+Izw== X-Google-Smtp-Source: AGHT+IG3zQONLtNNLFCBisiqnyb2KBBdAZoBcVXn8ZKHSOcO4zLCu8vZ+2T5E0OEe4jyHp5mk0SJgyrOfTeARfH9hlY= X-Received: by 2002:a05:6214:242e:b0:66d:a90f:c06 with SMTP id gy14-20020a056214242e00b0066da90f0c06mr22425828qvb.14.1698935773112; Thu, 02 Nov 2023 07:36:13 -0700 (PDT) MIME-Version: 1.0 References: <20231027182217.3615211-1-seanjc@google.com> <20231027182217.3615211-22-seanjc@google.com> In-Reply-To: <20231027182217.3615211-22-seanjc@google.com> From: Fuad Tabba Date: Thu, 2 Nov 2023 14:35:36 +0000 Message-ID: Subject: Re: [PATCH v13 21/35] KVM: Drop superfluous __KVM_VCPU_MULTIPLE_ADDRESS_SPACE macro To: Sean Christopherson Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Viro , Christian Brauner , "Matthew Wilcox (Oracle)" , Andrew Morton , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiaoyao Li , Xu Yilun , Chao Peng , Jarkko Sakkinen , Anish Moorthy , David Matlack , Yu Zhang , Isaku Yamahata , =?UTF-8?B?TWlja2HDq2wgU2FsYcO8bg==?= , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4C7CE10001B X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: u9p3iu88ugym38ys4atw9mkyomremo7n X-HE-Tag: 1698935774-668617 X-HE-Meta: U2FsdGVkX1+gX3y97mP0h4azkvPH07C6CmpzAEhFM1dIfMHtH3Z454bGXN5MiKPRDkBieL8f2skWTqyzTGLIgb/VKpEZPxQFM275fQJeb43mDjtKe6nNuUKIB4O0bZjsPa3B1muncJjQgwLHGFaG268Y662Xq/n/SaQshSn5M1GUo1gbI9EBx5fp80a3ElRJouI9yf0YjhipklFgoaKCXJbSp45i7pb7b4OBp4AJys0izepzS1UyWi9/MEbC4ISinRURkqF4w/Tr2VKvK18Nj69r/hv13U6//oLf7+3fJKqQrFBF0Q7VJSBhkrZvX47IRcLeudwzC8RN0VIBsTYvjH5Qvk+28CmPoNmSlgkgZ1nS11qtkDOLsp0Dq38R/0PHkO/ozp9fP5evJBOeVR96yM/hmb/ljf2+zbTivMVKiELDfHv6ApbspZ2qoHxvB+MLp2cE8rRF9Gevf9W0PMAKEt2T7x3zXrHroj2yVsj/uFQ97QiihuiY/RRtmDf1+cXBxLBHM5JdjoEFdxkCxlQKuKCFTGWctFjkUF8KMibCPmWEZboYszICyLyo0nkKjNvwAr7LwwM4vS2UDkMJyy71bwKFbRyLMmfsdrTf7yIqVPe+f6H10OXgQaXr3FUaq4lYisUtZWdhrcQQH2qTaEjqls+rkIOWJUNDizBh7dyieiQF35DqKN+50Z5arnDYAJgtUSIM2yiWG1Krm4TCJ8smgcOU2oE5e7PhM+X6gSQLRaiO1HtjjHpRlUDtk4Thxe4zrLVw64c322QTNPApbOr4MSL1ujWbPUgnRAGXiqVwCuAIGpIf8AKUs9ZHBFmgOswf8qs4OMfsL4b84FcbEnO4l30FBRko0MDs0K4RPgnGs6O/jSC2541c2kk1/8JIO5UhRIBFG7Gytl8DxJfMupYPytJRazgzL5HnumW9krAwwIXl6OI+qu0jdzJAW01YD7YupMEnioC/wVLrVMKx1r9 TX4VAb3E ub87yCz1Th4f9yad5jv/EGZBMnIkUUAw8ixD5ngIoDnfmb9JVqh9EaliIo+YqkxEgQSHowjSbmvXOKDaEw5r2PkH0KYYl93B5uPGAfLC8eCLf1kcaEYKmGcC8zyuN8UWE9ruxdOzraj8Mx3JdUlrXvG3gFsJSEIAH+u/k5C5GYCNRZAL6sAABUXGcUbARQ8Pozq1bg1kNFWYsi35OqFaXctRFZYrzrj8spHj2TbkJaIxcb3Bqfb90quu06x85Li6jy3EXAEnS59vZPIvmjsroWXffNWx0l92nqzuXK3C6il4CKWzmYiA6ismxhyiI9gd7NxidmnEZ5Z7iYow8lukf6eCHZzX08BMQfu5Iiw9TGhJKCAOZjDoQ3DUjWfwdp1563AWS9Qk29tVJEaY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Oct 27, 2023 at 7:23=E2=80=AFPM Sean Christopherson wrote: > > Drop __KVM_VCPU_MULTIPLE_ADDRESS_SPACE and instead check the value of > KVM_ADDRESS_SPACE_NUM. > > No functional change intended. > > Reviewed-by: Paolo Bonzini > Signed-off-by: Sean Christopherson > --- Reviewed-by: Fuad Tabba Tested-by: Fuad Tabba Cheers, /fuad > arch/x86/include/asm/kvm_host.h | 1 - > include/linux/kvm_host.h | 2 +- > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_h= ost.h > index 8d60e4745e8b..6702f795c862 100644 > --- a/arch/x86/include/asm/kvm_host.h > +++ b/arch/x86/include/asm/kvm_host.h > @@ -2124,7 +2124,6 @@ enum { > #define HF_SMM_MASK (1 << 1) > #define HF_SMM_INSIDE_NMI_MASK (1 << 2) > > -# define __KVM_VCPU_MULTIPLE_ADDRESS_SPACE > # define KVM_ADDRESS_SPACE_NUM 2 > # define kvm_arch_vcpu_memslots_id(vcpu) ((vcpu)->arch.hflags & HF_SMM_M= ASK ? 1 : 0) > # define kvm_memslots_for_spte_role(kvm, role) __kvm_memslots(kvm, (role= ).smm) > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h > index e3223cafd7db..c3cfe08b1300 100644 > --- a/include/linux/kvm_host.h > +++ b/include/linux/kvm_host.h > @@ -692,7 +692,7 @@ bool kvm_arch_irqchip_in_kernel(struct kvm *kvm); > #define KVM_MEM_SLOTS_NUM SHRT_MAX > #define KVM_USER_MEM_SLOTS (KVM_MEM_SLOTS_NUM - KVM_INTERNAL_MEM_SLOTS) > > -#ifndef __KVM_VCPU_MULTIPLE_ADDRESS_SPACE > +#if KVM_ADDRESS_SPACE_NUM =3D=3D 1 > static inline int kvm_arch_vcpu_memslots_id(struct kvm_vcpu *vcpu) > { > return 0; > -- > 2.42.0.820.g83a721a137-goog >