From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F237C83F27 for ; Wed, 16 Jul 2025 12:54:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D4BF48D0005; Wed, 16 Jul 2025 08:54:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D23838D0001; Wed, 16 Jul 2025 08:54:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C398C8D0005; Wed, 16 Jul 2025 08:54:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B4CCD8D0001 for ; Wed, 16 Jul 2025 08:54:55 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 6DD90B924A for ; Wed, 16 Jul 2025 12:54:55 +0000 (UTC) X-FDA: 83670122550.24.5A8E2E4 Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) by imf24.hostedemail.com (Postfix) with ESMTP id 98124180006 for ; Wed, 16 Jul 2025 12:54:53 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=lP4Aa7nu; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf24.hostedemail.com: domain of tabba@google.com designates 209.85.160.170 as permitted sender) smtp.mailfrom=tabba@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752670493; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=j8ldmZ55jy5ZaXuomv0Qov+zBm2r6aMGVRc2HGPVpC4=; b=MUaavMwRUIllNBJMSSEz5YNL9McHkK4M0ollOBN32PcHhNxSBxpzBNYPa0Vk/yNZqFWDsa gLZhOpnaj8MXlfhPUM5CBX7XuzDCn/ovgk7IP2mc6IHuV/kmsYIZWeThtRjjfDIppXD1zg 7inqdGY3jfGWLF/Yn+03jOp9JQyqxkQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752670493; a=rsa-sha256; cv=none; b=DQd0GcLW89YCES14vHZ7BoPgxnLRygigFrG1vZzi2dQjSzfwaH66Ek6QOPGucrP5OyzNfs NRv8JgcR1+4uUdF6jd/yW6U4m9wDBlyHgZIJN8V8bxPh+4DJbGyXfH13JZlzCW/JjFfuZ/ xEUNAwRJu3vulUA5T7e+cX+KJTh1vt4= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=lP4Aa7nu; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf24.hostedemail.com: domain of tabba@google.com designates 209.85.160.170 as permitted sender) smtp.mailfrom=tabba@google.com Received: by mail-qt1-f170.google.com with SMTP id d75a77b69052e-4ab3855fca3so192231cf.1 for ; Wed, 16 Jul 2025 05:54:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1752670493; x=1753275293; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=j8ldmZ55jy5ZaXuomv0Qov+zBm2r6aMGVRc2HGPVpC4=; b=lP4Aa7nujFSCmeqBA8FNFV+5IhjOvmZ4JTkAoneBPOStNZ38Ynbe7cUwZer8mqG3hr 3Z1adGDxFxI9gIztlxrAo9/wjVLY0rN+fvrnuhRGKt1Tz8mFXMBloIFGrneks51Ihqv4 GaOt1rpj/T69ileO14Xys8tTTv25gAOlMlYmAFZOjAvLPG7VKkd6eidw4ePylUONfrvS ZsixI/JIBw4feMAcvUR0I2iLc6ZDULKFvrqzMXljtpVPT7MgvkXDQdJqq+9Yo01d72Gn rKqFL9j6H+AOte0jXZSSwIcI4NkzhTnZPnSRvV6tC7N8g/PbWkwSxIxcAm/cd7avLLo1 YciA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752670493; x=1753275293; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=j8ldmZ55jy5ZaXuomv0Qov+zBm2r6aMGVRc2HGPVpC4=; b=QEPM+z95mujTTXfSWfVybwakjoUG3a//M9J7NNzKajG8zpBvXIaY49GDYUBCXCfvDa 18a/qLJWrvcZG05EMi94jQSO9/PRk9eNXTOjwshckFrmsGhjUYxjQUGFh7EzR8U19eUf RjJrF8Ofrfcl9MacWQpwMQd70H11M/zVadNufeyyOYi9112QTp2Zb2srklcgynZEV7Nh xQrcc9yBx/eRLWCilVUZJYU69ihGMXOeDTZzfQjziNxuwH8U9RJuCeqmtst4sZCLe/dZ IQGcPyBf3AId7rxzeooaXYQ3SZBkZkC09Zcp/2LjQKmRA28ZqDRB1iKCFpOvFJock/J6 lhZA== X-Forwarded-Encrypted: i=1; AJvYcCV+/UFtmOz8OsltwN7CNXmBezJs2FGbIFcERP4jmS2J1cr75odQfh8s7DU9ubYd2P2FdwzZk0tEHg==@kvack.org X-Gm-Message-State: AOJu0Ywt0Xdteim7Bxr2bFRBSImgY46GfrWPruaPuL+btGPj/psBc4LC d7KYP1iy6wEWYPP/HzI6NSAv+UmtrD0ckxEQophmK4jkyDDqhvJ+hexqFPpjcfZzxocQnjqMGiZ h4JyFPoTop+VvZfu3ps+E8/9zfYqa/+TpKyl32sDX X-Gm-Gg: ASbGnctLSwZFQ4dz4zcx11QMV5yNZ6tCZYeZM5jHhNIPmuBDwqZWto3gnBiQxJr6DsQ 1NA0QvX18OzV9bRwFVd9gwVjm8lXfKMlleRt3BaSnGrEyUwS94j0WwM9PIsQdrlQa67zXjn3eFl SDDySWKpGm877l17IwZOKtDIvuUE3jmyuVZswLuI0Qusm4MiIojeLCUbNIIKyr/3+bMOa3y5hOT Vdij7SEN5/yV7TXnOZ5CO+h6LCdQ4ZENGw= X-Google-Smtp-Source: AGHT+IG5QZXwMh/pWZ7YvuTyEUvPla3aSmPB5N9IHixBAAJw9oVvqZOIDmKNLn+4MKe74P7oCrt5WimSbibRGo5z6oU= X-Received: by 2002:a05:622a:1aa0:b0:4a9:b6e1:15a with SMTP id d75a77b69052e-4ab954d8746mr2689661cf.24.1752670492218; Wed, 16 Jul 2025 05:54:52 -0700 (PDT) MIME-Version: 1.0 References: <20250715093350.2584932-1-tabba@google.com> <20250715093350.2584932-3-tabba@google.com> <418ddbbd-c25e-4047-9317-c05735e02807@intel.com> <778ca011-1b2f-4818-80c6-ac597809ec77@redhat.com> <6927a67b-cd2e-45f1-8e6b-019df7a7417e@intel.com> <47395660-79ad-4d22-87b0-c5bf891f708c@redhat.com> In-Reply-To: From: Fuad Tabba Date: Wed, 16 Jul 2025 13:54:15 +0100 X-Gm-Features: Ac12FXyFhk5Ea2iRIAOGi8JPKWZm4iBDcstyagLqnmugwx2wsA5Hot8K1UY8_ZA Message-ID: Subject: Re: [PATCH v14 02/21] KVM: Rename CONFIG_KVM_GENERIC_PRIVATE_MEM to CONFIG_KVM_GENERIC_GMEM_POPULATE To: Xiaoyao Li Cc: David Hildenbrand , kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, kvmarm@lists.linux.dev, pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com, ira.weiny@intel.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 98124180006 X-Stat-Signature: az58xi4ixiipqqq5ox93wubbj4t3974o X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1752670493-315179 X-HE-Meta: U2FsdGVkX1+pjsJ4TDzDR2GnpbWOOpQW+S4qGCxseZvP89XMQRWRvyP+4QwNQKoJSR125Ut7BpolGBd7hv2PgOKFzkukdEgBHj4Y4cPmQ1ITMvXw2bQLt/MGrWhmAxYcnG3KcUciw6vNcHxEfrP3wBfyCUqhCQsxc6Emnpf8I7CUD+T+Dmmlp90MrXYD+cGjQskjutf2E2DuPyA4SstVwKDDQlkT0kS0xd0+MDLid+dko64FQnO12ojsMLNwaFaC6FnwXYmf0GlMK2/S6cIED3H0gmr0t2dbBS00x97rmCH0F1hjKRl4DUqBb8X+SbIcsBmc7XRfvkAt/QzbOFNQ99JNfYdu5zxjH9fkzQYt/9CeGhvUVHM4TSkmWvnY49yG2nf0N99YLQts/sAZkfrOJW1O1sOJXORogW9sizCnt9Oe2Q+KPPRGAs65adiIIWRu2qw4COn1XwWeqXdSInIO6+gsdzMzdCSUIiJ2/oBMAi63TfmOKg/3Pibsqxg8g4+cHuX8DD7kwDyDzEMoho7WR1aty8/lZImJv33ACTaQQilrNVlfHlJTL/IS0YS1IVbAhpGlcS3bRNGxUa5i0Ko8yYL/BQzxgXJjb6VpqpNpeGVR6JXFMzUOjlDfxko36C5UAyhAvPnI1PbdBcGRXpLP6KpIuay/VHumojpzQjhrDg+Oi+EwSGNT9WbqWJZRun1PJjxN8wz2fMdY+eHkkcAyw6F9gdF2x4FJubZPDwax0SNl5PTIQ/PFMS1SogiSF8LQWdo/s3NE+v8SNbwI0J+ZOXsYOc8XcYipWQltsumT7gQfq6BXeIO8NtZq3aSegSLKL3pGctVvHqC8Vs/GMC5l/oevn1K5dyF+Mb4orKPf4PmJ0NN5aqK06XCrCV6vad+RJwjCf7l7YzkpudaxAhHcpUiEuUH2Yf7szTcD31GNFpguWkmaCQnpx4CZ5XSB85gbseuPjlx7VIaEtJjbip1 gfmxN3nm BkWwKEI1SJx2OWB/kC8TSj5LMWry3gcrgjmAIAEzWmEikucr/jr62pqVxdwKtJwUTBnrawXlUvLnslW7AtFsl3JprRRg5ARTNo8GZI2Sk/db14RwK8acsSIeZPnzSBDabyJ2+TTsdMrrMJgV8VBdius6q3LC3KuIC1i3TXBXSkJVd44zEaSdTmqTrbkeXsZHmu5r02hIUFDnLcJEKKOD5KxyMyvemKX1yjYBzeYlgQt4h1Z33t+ezkphfKDZLHO0Ssa3n72gSgAyocz8fHLutA61aQzONSiGYHJTSqrkfeSXWSyUB8WDkaJvskg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Xiaoyao, > Not really the same result. > > The two-step patches I proposed doesn't produce the below thing of this > original patch. It doesn't make sense to select > KVM_GENERIC_GMEM_POPULATE for KVM_SW_PROTECTED_VM from the name. I think I see where you're going. That said, other than in the configuration files, in all the actual code, the purpose of KVM_GENERIC_PRIVATE_MEMis to guard kvm_gmem_populate(). So I disagree with you, and I think that this should be one patch that fixes the name. That said, I agree with you regarding: - select KVM_GENERIC_PRIVATE_MEM if KVM_SW_PROTECTED_VM + select KVM_GENERIC_MEMORY_ATTRIBUTES if KVM_SW_PROTECTED_VM + select KVM_GMEM if KVM_SW_PROTECTED_VM Cheers, /fuad