From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17AB5E75457 for ; Tue, 3 Oct 2023 12:48:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7F29C8D006A; Tue, 3 Oct 2023 08:48:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 77BEE8D0003; Tue, 3 Oct 2023 08:48:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F55B8D006A; Tue, 3 Oct 2023 08:48:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4DBF68D0003 for ; Tue, 3 Oct 2023 08:48:03 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 279FB1A0307 for ; Tue, 3 Oct 2023 12:48:03 +0000 (UTC) X-FDA: 81304127646.23.CBE0CB5 Received: from mail-qv1-f49.google.com (mail-qv1-f49.google.com [209.85.219.49]) by imf07.hostedemail.com (Postfix) with ESMTP id 6E99B40022 for ; Tue, 3 Oct 2023 12:48:01 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=z8oB63eI; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf07.hostedemail.com: domain of tabba@google.com designates 209.85.219.49 as permitted sender) smtp.mailfrom=tabba@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696337281; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YZe9z/CDJkweGhxZy3F+7e7AP42NZQg1sBDsRc6xWLw=; b=o7Dx1dJ8XK9OSn6G4rd71tRr+fmcScKJOH82yUpPjrqgZ2zRJVre2FVsxpsGCiNf42tA3I Zl4wqVvzzLnrLqiFXztLMIOqRyEb9GxsoPUhK2ty+PLlAwt+ksJHt5vLp3i4B9MMZ5vUku uAfU3/8XUXD8jEJpYx0n2CGb4zaGYng= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=z8oB63eI; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf07.hostedemail.com: domain of tabba@google.com designates 209.85.219.49 as permitted sender) smtp.mailfrom=tabba@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696337281; a=rsa-sha256; cv=none; b=uK3TMEC+v2bm19iISPqJOaPEfbEMuLreRVzYlUlUwMey88kPWwAIFlvKD/40mnqbSxERVw 9PppfpzQP8xX4Eahf46Sc7BhNw2M70vjOpAAJ1lVL6QLbS/E/5APxMW/0Ga7aojhGCF1E+ gIu55ZYTKSG0WhK0j8WtkArGhafO4Dk= Received: by mail-qv1-f49.google.com with SMTP id 6a1803df08f44-65af7d102b3so5868946d6.1 for ; Tue, 03 Oct 2023 05:48:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1696337280; x=1696942080; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=YZe9z/CDJkweGhxZy3F+7e7AP42NZQg1sBDsRc6xWLw=; b=z8oB63eIya4KkcoSnEsMPH2fZjKPPRt8ufLxIuCcjOjbDSVkIRljMCCVUQ1wmLMOlD Hav4A5dk/t3RQsFe+3ozoRyZR/jcTpCg8jIA6eb/JoAyhXnOzagJr2MmjxMaTFR4Q5v5 HHhETO6tpTe45yC5DQof4qMjAWZBV8r3fnhKdMg76yVADw4BpjvjA1gh5fH9RCFxoEY3 ztmAMSxeG8+3C4yhJNRZpL6l4f5GlX2cz8V/p7AcxLOVD8E3ubjBJIIWnfaDVEtSQqje J/KvoyYQ1AOGPVBx8dwAzCZr0ltMOp5UcW+5Q4ptndvQxNrGBIyroHjlpxemA3HILmTf CKPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696337280; x=1696942080; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YZe9z/CDJkweGhxZy3F+7e7AP42NZQg1sBDsRc6xWLw=; b=dd9B+tNoGu3+DMIEJvLFvXztbOsY07e324OK5Jrko8XC66bfjtEWP6LUf5tGcHea83 91P7J4ZB/36rPNV/2s7+ycB8uN8sngjC1cE+PcSs0K6k+KIp7GBFnl+vVtx4/PHFJqUK 6TkQcbbqCc4iD6lQodqJQAtTHVA5am8Xocxsiuf0ah+5ZzlI9gAUNtc3VGrP0oGH/b96 mk+Xde2yL6Vh+VtzNETk3z5K8btos7ivolUJQ0t8NDjDLudW/AfuJYQ+gJHClY6CmggL TIHTage4G/AUYXTqB6Kg2IWDRpKilcXOmxv/QgPtarP8YOrXDlz/IdxL9Z7NW9cGeP6J tOwA== X-Gm-Message-State: AOJu0YxLcMJh1oZfyPDp3GxFOjcnbX/hpn5MgC892MAnj0X2lM6FMGWl Y2FaFOs3u6j7vN2xVZ9du0DHFpQd5O04Dc6D2YOjfQ== X-Google-Smtp-Source: AGHT+IGdg5KfMiaxwpI9vdrZwCI62gGbA1qcJqHvAfDGqDxEQ2JSHryTMBO/72MMo9L0zK8WyPrlSIxRkNMNwCJdjzY= X-Received: by 2002:a0c:e493:0:b0:656:347b:ea75 with SMTP id n19-20020a0ce493000000b00656347bea75mr13564335qvl.24.1696337280208; Tue, 03 Oct 2023 05:48:00 -0700 (PDT) MIME-Version: 1.0 References: <20230914015531.1419405-1-seanjc@google.com> <20230914015531.1419405-12-seanjc@google.com> In-Reply-To: <20230914015531.1419405-12-seanjc@google.com> From: Fuad Tabba Date: Tue, 3 Oct 2023 13:47:23 +0100 Message-ID: Subject: Re: [RFC PATCH v12 11/33] KVM: Introduce per-page memory attributes To: Sean Christopherson Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , "Matthew Wilcox (Oracle)" , Andrew Morton , Paul Moore , James Morris , "Serge E. Hallyn" , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Chao Peng , Jarkko Sakkinen , Anish Moorthy , Yu Zhang , Isaku Yamahata , Xu Yilun , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 6E99B40022 X-Stat-Signature: om69cpmx1gz171xspn3kysgbfqftbgww X-HE-Tag: 1696337281-743845 X-HE-Meta: U2FsdGVkX192n950B2GiMOHGFPwQ8DVhEwzkxMLzIvlbUgrSJRLmm0AYi3XRWInZHcKYadH0y3TM4pWMW38et/4NwzBjP5PqGYd/INYIXBS/ahsLZbcOoXvmpq7wDJwS4JwauHn0Yr4hpMWXoUz75djwcbd3ni3nlTr5LDCFKR5OSIFnqVuIvks5FjXnmb95j70zcJG5yTZQfKwMIxPP5zw3g92+HOxKNXWOK00dRdzQj1TTpazFjPYjEZOGXD6Qtr95Y3zVhNFrY2owjWa+8K+WpMCkFWMR4oK37pE66QrjvPL9V0BJQ6VeJ5BRWxVCcI5nkzyZhJP98p+FPaPtk/Ua3hryTIALgzmzhiJyU6oBWKee2i7ReSh6yGupvbPjQfss59M6sKhqHX2cYCA8cw0zHsUIZBkqvs41Lshi77Q5wa7nS7b0YNv2otjzKsswr8PEKUNTJi/u65RKlzcUvbwjcPGeBsIyY5268zdxqYqtl0mz51PbQGe/wnU7NJ20Xz2sPoXEnj66Jh3RJXDVmZ3rLfBzYEQn4EM8rijEou916l0SU1AN78nx33JVj/BX4hKSKTSoeWlyO0ai7Sbu1V2CZcWetiR6Obgna9PaEH7uGQe+1kbJRlEkTEIhHNDB5E3qmOYjDtJlblF6j1EHTXETmEGRemY0BDEknP3V4G52F1VJDkrduCiCpgt63dDWdHnmT0NrJybwotZKM+cBQOKdMiT+onho23PU2+j6Ezxou5qdXkg93K3z08tezV+b3m+pPZiJkjqzYB8dHeeLmdwJTbZCma0zfJ/jp4Sk48jsfpEYLt79cWb4cEZ3toKYoOooaAKYuqmXEF0ggfvCfXNaWdEEyIletHzqXQNSM40RoJioEXew4aFREdRhszdgq6bzpJAeewB0LE0mBASN4EkRkcniXhQW07mze7SMmpBsLN7s8Fyq130MYqtVhyvz67ayQEoXze2fi9jK0/e HoKw3jQp V7xqzsqq9rdvGHTQup+1kpP0tYbdjfTsxP0HtZMaSoHrImb4fcfq5SnfzjuIbWz5CjDKxIKUv+cBFrJ6kBysic/ISJNoyNP1diGvsVcGy3o46OCwsCVOKobubi07JNY7PfyqDZ6dcfTSnN5ri0TRfghnVV1WFWh1ZaaNN45VnrlB/OfUXlkcxkJDALvif38sP3NO7u5kTY3eCn0G1EnQdNERAcLjl4PcW5ib8ml9qIDTJBLpy3nFhS19d+hOuFqtQjl17FEU7KswIi8rjOKnl7LKJ8AeS0sVJs2VgltWGxV8SXN/ULfFSvo7+oermsN7hxwkaoxGD6qQyaRYYMR46ogn6eIkd27UHGU6j X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, > diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h > index d2d913acf0df..f8642ff2eb9d 100644 > --- a/include/uapi/linux/kvm.h > +++ b/include/uapi/linux/kvm.h > @@ -1227,6 +1227,7 @@ struct kvm_ppc_resize_hpt { > #define KVM_CAP_ARM_EAGER_SPLIT_CHUNK_SIZE 228 > #define KVM_CAP_ARM_SUPPORTED_BLOCK_SIZES 229 > #define KVM_CAP_USER_MEMORY2 230 > +#define KVM_CAP_MEMORY_ATTRIBUTES 231 > > #ifdef KVM_CAP_IRQ_ROUTING > > @@ -2293,4 +2294,17 @@ struct kvm_s390_zpci_op { > /* flags for kvm_s390_zpci_op->u.reg_aen.flags */ > #define KVM_S390_ZPCIOP_REGAEN_HOST (1 << 0) > > +/* Available with KVM_CAP_MEMORY_ATTRIBUTES */ > +#define KVM_GET_SUPPORTED_MEMORY_ATTRIBUTES _IOR(KVMIO, 0xd2, __u64) > +#define KVM_SET_MEMORY_ATTRIBUTES _IOW(KVMIO, 0xd3, struct kvm_memory_attributes) > + > +struct kvm_memory_attributes { > + __u64 address; > + __u64 size; > + __u64 attributes; > + __u64 flags; > +}; > + > +#define KVM_MEMORY_ATTRIBUTE_PRIVATE (1ULL << 3) > + In pKVM, we don't want to allow setting (or clearing) of PRIVATE/SHARED attributes from userspace. However, we'd like to use the attributes xarray to track the sharing state of guest pages at the host kernel. Moreover, we'd rather the default guest page state be PRIVATE, and only specify which pages are shared. All pKVM guest pages start off as private, and the majority will remain so. I'm not sure if this is the best way to do this: One idea would be to move the definition of KVM_MEMORY_ATTRIBUTE_PRIVATE to arch/*/include/asm/kvm_host.h, which is where kvm_arch_supported_attributes() lives as well. This would allow different architectures to specify their own attributes (i.e., instead we'd have a KVM_MEMORY_ATTRIBUTE_SHARED for pKVM). This wouldn't help in terms of preventing userspace from clearing attributes (i.e., setting a 0 attribute) though. The other thing, which we need for pKVM anyway, is to make kvm_vm_set_mem_attributes() global, so that it can be called from outside of kvm_main.c (already have a local patch for this that declares it in kvm_host.h), and not gate this function by KVM_GENERIC_MEMORY_ATTRIBUTES. This would let pKVM select only KVM_PRIVATE_MEM (as opposed to KVM_GENERIC_PRIVATE_MEM, which selects KVM_GENERIC_MEMORY_ATTRIBUTES), preventing userspace from setting these attributes, while allowing pKVM to call kvm_vm_set_mem_attributes(). What do you think? Thanks, /fuad