From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D597C04FE0 for ; Thu, 27 Jul 2023 10:40:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 105628D0001; Thu, 27 Jul 2023 06:40:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 08EBB6B0074; Thu, 27 Jul 2023 06:40:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E70A68D0001; Thu, 27 Jul 2023 06:40:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D574E6B0072 for ; Thu, 27 Jul 2023 06:40:17 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 893DCA0B62 for ; Thu, 27 Jul 2023 10:40:17 +0000 (UTC) X-FDA: 81057047274.21.DCB24BC Received: from mail-qv1-f49.google.com (mail-qv1-f49.google.com [209.85.219.49]) by imf03.hostedemail.com (Postfix) with ESMTP id BF6972001A for ; Thu, 27 Jul 2023 10:40:15 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=BRo0MX+z; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf03.hostedemail.com: domain of tabba@google.com designates 209.85.219.49 as permitted sender) smtp.mailfrom=tabba@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690454415; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sndfUp5VQwyYdDkfd9c4UQTPXsXPqaVmv/x1Ijy8DrI=; b=qETRfZ2jcpFGt5d7dZomxLM5Sp/8H4xMUnR68eaZEi/p5VsysiYWrFjtgHFgL57pBVRgc3 6OPN8ke75zvxwvOCkckcqAxEcXUTq9041LUrzWI5lJLYrZAufhkBx0hB+y/hpn6UtIB6KF iQntsPiSAB7MgpJIn8gB328mGjUOvrM= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=BRo0MX+z; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf03.hostedemail.com: domain of tabba@google.com designates 209.85.219.49 as permitted sender) smtp.mailfrom=tabba@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690454415; a=rsa-sha256; cv=none; b=6y/qfzIY4qLGrrh1Hz0NC1ojjoU9FZryEbqxNB9FjqX30hyfcDjx7/u1aRwpqO6laW+UHA OtOdMCQb2E/c28hXI+gooQr2DtjXX0It9PCqDe7W2orX5Q3/ihu0U1Cc7PQ6wB3ZGdacdB TmklU05aZ1jt8UNi+wUndTLahPcab34= Received: by mail-qv1-f49.google.com with SMTP id 6a1803df08f44-63cfe6e0c32so5789726d6.1 for ; Thu, 27 Jul 2023 03:40:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1690454415; x=1691059215; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=sndfUp5VQwyYdDkfd9c4UQTPXsXPqaVmv/x1Ijy8DrI=; b=BRo0MX+z2r1SS6yWvALim/6/nbcuIraz/dvlfYWOZ9asJfVrKNdNm2FzRqaxLf+dSr gd8iH6tStNBkd23/w31KCfLL9pbPEeNVyPTR03aUqTDZY6wZTMoqJSnBUDPOFUCLZI8l DGkcMHGLOMeyEEgRm2q9vaf0Y5Q5Azvv1tkZ/xFOCXwAaoOvebuUDqbcoCdnlpWZyTyX q38zkUOHeP0Tt+nEWAcZ8JszB60VlCahpErQX1nO7BawFSz3QtUcVh1o5Am/iWB313H6 H0uJV9FuYrV0GCIZde+45ERDs3S4qD78OMMR7S/b1svm4zQQyj/BCkUn3DI2PJoOlxx+ Zjrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690454415; x=1691059215; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sndfUp5VQwyYdDkfd9c4UQTPXsXPqaVmv/x1Ijy8DrI=; b=XDIcE+9kTCkL0lVlNhlXV355ZPkKR7iUCkgQP0bOoR5j10+LF8T5MmQ4vtlbQoWTVh lp3E/ys27mhSaqz55WO8iB40yFP+zQRiGEF4umcnD2dyZ5cE2bH4w37mB69vgBKImrVo mQbDI+moxXRcmNmup94NlWTBO1Nhdq7IF8ckIScfjOPrCB2EMwgAIgDItRvmku5ksy8S Z+2trOa15FjtClIvDVJiyilvT8im7Unu3kazcK6+BYH2w50Zynj/WVBhwGJQa6qSY1zv SKkE3B2Q5dGkJwQFB3NnM1azwPiVHb3Cq3QJBujUlTpF5bPQZNOgU3DGfRJ5JK89nSMN 288w== X-Gm-Message-State: ABy/qLYJs2TH78di8zY5AhXpxSfzmT+tInsYM3zoH694cCOHyUyTeAqN RYRz0iagaFLeVWBmfvIhR0uKGsGD6YJwbCvFBHGrtg== X-Google-Smtp-Source: APBJJlE+0dXFxcWiQX8kiDXJfKau+LxjypHc8uOGBYfuDsHhoPcJDBpq4NHTu2yqyvhkPVt07nS69cNqQCueoayyUeg= X-Received: by 2002:a05:6214:12b:b0:63d:218:c83f with SMTP id w11-20020a056214012b00b0063d0218c83fmr4306083qvs.36.1690454414736; Thu, 27 Jul 2023 03:40:14 -0700 (PDT) MIME-Version: 1.0 References: <20230718234512.1690985-1-seanjc@google.com> <20230718234512.1690985-13-seanjc@google.com> In-Reply-To: <20230718234512.1690985-13-seanjc@google.com> From: Fuad Tabba Date: Thu, 27 Jul 2023 11:39:38 +0100 Message-ID: Subject: Re: [RFC PATCH v11 12/29] KVM: Add KVM_CREATE_GUEST_MEMFD ioctl() for guest-specific backing memory To: Sean Christopherson Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , "Matthew Wilcox (Oracle)" , Andrew Morton , Paul Moore , James Morris , "Serge E. Hallyn" , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Chao Peng , Jarkko Sakkinen , Yu Zhang , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , Vlastimil Babka , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: BF6972001A X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 56u79pii34ncu3qy83o6tj73w6wu8fc6 X-HE-Tag: 1690454415-326085 X-HE-Meta: U2FsdGVkX19c9+C24ZuJx+6uG/6J48ZACLa5SsKF37Lh4F9hhAEUYILB86zkt1FvW5JCMHIfLfeF65F2l1tAIVNn+3BtirwG+pWApHvkc289QdQwE2WMATctW6ZxtaUbTrM+KI3YpsqAI+pdL9FwbS1dCW3oGQNolssOJReO8oAAJ+QTK0Ejj83/s2ueOzauSWI5vMgbveborA4wWoy8XRovivTqdh4+aEIsuCfII4DDkLtGotJkGHq7mzV835MiGMIzTH/q2zCSBt4A8DqHsVMAJnaLdOTpVy0EmDX7HF7qRDfV/A+nnd4T1hMJdeGvQ55hDpRr221pxCiQ0SNseVM416Z4GdWpoHz8c2zo7VPrky1qqNWxu2FAftCgESTWH96X/QUUPJJ5iLosPyFrKzUSbH3+pawX/8pBUUY3m38Nrk+OL4Deuolkm/Nkj4Q+dcVLKGNmXy6EbVwWN2SYRZSpgFAKi+yR6neqOJlLuJQ5kqrLwU2KgRzpoemMmMnCnmW2tGWjgOERwatHN4q9Vwm32LDhh9pjHJVccGh5OXTCtJXXJ+RFJCIOqcNCX/9dWSuPPsdYyXzj7MdSCrJpk5z0yjeDEtlAU+NxIB5CJc/avqcUGbEm8lscK8Pba/YH8cTl6Hjys7Kvbjs4i+nhOlynSFTXo3e5PHbwNeAqpJM3PXwS4tJQakInfZ8GxMvlGqsjL/GJu6bZtOSEKFHZ6FjdnhUssgNSjmxYRLTAzq1Vc//bOYsSCtKOd/xHQhs3+788RVwnGTjO03fRaOVyDRljh8UXxj+VKh2VVR4LjHUEh+ePpXJNfx2jLH97DLU6J4SCaQwOg1jBcOlThd/rVW4r8/TiqjRZa0F1+clr6r38lUtVl2TEVrZKmHo5ZWKUar73QMZA/9Icsq+zk4zlulz6bRr+00UllLK/UlHTiKtoPVhiGQmxCXbfCW4qkfAmXyxc0ONJ63m0StHWz44 lyNIJC7C EVxIAeJSZ6Su3RJtqjAu+j/c+c6YSAtSK/wfM/TwMua8HLb33TfLUxd5sPTYEq1/R1u1jao7Hm1OPJR4kaDBByLM/LhdgWdI7co+TdEGDzPmocabbYlolHL61HD5ZL7ruzLfUds8g3KYlx/RHz3ShFXeej/jb3sjoDzOLKKWicH8qlP5bt/JmyUU2sqmMe2t+YxHCfpUvldxxhUth9xooWjePX790iZzdXKRPhKWeCeLKoRavxOtpyAQONjfT3TggFKUhgkJ2OOXa5/ITj46GGSD/3s0FPxJQCbZz83qcIKbUp7o98B5GHTIZijlxNSUUkHDN96rCOnL2o8Julzbwx/zAFQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Sean, ... > @@ -5134,6 +5167,16 @@ static long kvm_vm_ioctl(struct file *filp, > case KVM_GET_STATS_FD: > r = kvm_vm_ioctl_get_stats_fd(kvm); > break; > + case KVM_CREATE_GUEST_MEMFD: { > + struct kvm_create_guest_memfd guest_memfd; > + > + r = -EFAULT; > + if (copy_from_user(&guest_memfd, argp, sizeof(guest_memfd))) > + goto out; > + > + r = kvm_gmem_create(kvm, &guest_memfd); > + break; > + } I'm thinking line of sight here, by having this as a vm ioctl (rather than a system iocl), would it complicate making it possible in the future to share/donate memory between VMs? Cheers, /fuad