From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8568AC021A4 for ; Fri, 14 Feb 2025 11:34:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DF5F2280002; Fri, 14 Feb 2025 06:34:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DA5A0280001; Fri, 14 Feb 2025 06:34:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C4705280002; Fri, 14 Feb 2025 06:34:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A0C50280001 for ; Fri, 14 Feb 2025 06:34:20 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 4DA00B4830 for ; Fri, 14 Feb 2025 11:34:20 +0000 (UTC) X-FDA: 83118341880.04.4F8B86A Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) by imf28.hostedemail.com (Postfix) with ESMTP id 6FAE6C000E for ; Fri, 14 Feb 2025 11:34:18 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=tjkRTU9l; spf=pass (imf28.hostedemail.com: domain of tabba@google.com designates 209.85.160.175 as permitted sender) smtp.mailfrom=tabba@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739532858; a=rsa-sha256; cv=none; b=frnKiPqcQA8poyMt8s2zeZ59VCfrAt+2l8Cl4LZlqacf/BAg/pm/WmiFSGhDszISDkeSKa +wZKBGanTqJPwwM3Qfv/FW1XbR+0KY2vHtkHlsldWRuPGMBNWkiK64BiaRPu6F2b1b8sAr kM9s0TsWu8SMFxe19Efkn25zNs9dN+g= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=tjkRTU9l; spf=pass (imf28.hostedemail.com: domain of tabba@google.com designates 209.85.160.175 as permitted sender) smtp.mailfrom=tabba@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739532858; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oIIxZXp55qHUezW1KXD6M19h0CDt+B15X3kzsrT1cbg=; b=uGusdEeXUgyYA+/8DUY2b1fwd3N4eRvYMXFpIGG6O6AMgj8MMT2LTN0LZt68CBCxRsAZ4B RIxefOM9z4b+O9v0oK4EAChj8oNvGHm2BUklmk8G9WZgq08qFgwVYYPOn2sYwlaiIVwNE+ SbRwwPZtTUil7X2VpNqQC4ceOx3o+GU= Received: by mail-qt1-f175.google.com with SMTP id d75a77b69052e-471c9947bb5so192501cf.1 for ; Fri, 14 Feb 2025 03:34:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1739532857; x=1740137657; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=oIIxZXp55qHUezW1KXD6M19h0CDt+B15X3kzsrT1cbg=; b=tjkRTU9lhp5Cpc4o6iplsNmeOJIZVqwHsOtCh2q9wnOQiwkC7CIZISfeWYTxHk0z7U 3gw+1pUEKS9f3C/Lf+czv5+QhQVpDE0jyYJWz9n/wY5EkF/OYmNq/++MWoix8Po4jtMk rvJY3YX7HgMUWc95Rizrp7ZBiaIZEshYtWRB5+jpY+0QonMmyHWU/WBvK3lN2NkHo6B1 l+1jrhgFDrmcXWjh4M/evGOzsmMxzJ4ETqKE1Y8bErPUnSLaM0LTTUD2MAjKA+g9rADn CO1sOPqCGOUrzJ25BMZYHZ/aeUNLj3mlOHBMbdSDAHdumZzDWlLEGzo6/kfMLTOm2Y4i ydNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739532857; x=1740137657; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oIIxZXp55qHUezW1KXD6M19h0CDt+B15X3kzsrT1cbg=; b=w4/Y4LOhwzJuRu7Zlj/7bItjojv5lKaRuTqj1s8Y5+4aLKPst7/n+ZGQ25nSch4KiP dv//iJjPiSsXNVVN92BAkwA6dmBT7vBgWKoUQkFg4z+vrhgG724yaqSNGVZx7e/X5KsP mtxjMDVDepDIdS9rg1H7a1Tp2R7CYoZWYtZY5R+cg9sq0bDgyASDk5DDwwMuoI3p1X2S QOPcMOTb6Pb6Ht4er54j3fYNyJ2zQZ23PAIBOVFJFCYfBmUxwnG5wxgaaDCheqgdj06h 2JiBX4gv0UnxaHk2x5OlmYdKt/Zel6U1heZxrSPbjcKpXbtBTVZOM5IrBdRQ0suzOkLR ExFg== X-Forwarded-Encrypted: i=1; AJvYcCU8yg4tqw5Da80+45ajjmGoYOgF0AF+Kddh5JTASAsz+j6ilJdawJTwJaWwNiW2xNTR6YcSDjUwNg==@kvack.org X-Gm-Message-State: AOJu0Yxs2VRvpI+Gq4Y8wHvms4pHkZowDxw2nujxObUWDzjfbBuF7lYy IVcbCcdX3gRfBgAFGjGax0UUK180xd2dwJKmxyxGcrdjvAia38UgyR7k9yloQpyb76wEFO+cx09 DqWFKuCJ63B0KP2Txoa1vrIrqcGOY3qoABVRp X-Gm-Gg: ASbGncvqn6R+ZePmonH8cPUS+PELzOdaA6WR+zEio2L4CHCo3U/I/erzFP7b5p31jP+ 7oaVvRd+wNF5rZmZQwvcif4m0hfUK+dKN7XnylSqKYqHNZaxukOwAmItEXi0NngyTVexqmH0= X-Google-Smtp-Source: AGHT+IHtlxcMR3vxqJWY40h6ajM6F3iajxeDdssyRx/Y0YsmLzdFANWrYFIiKj2QO/E2Jl5nbjtDGwGC4XIUy4DvM7w= X-Received: by 2002:a05:622a:d0:b0:467:7c30:3446 with SMTP id d75a77b69052e-471cf9817a6mr2328871cf.25.1739532857266; Fri, 14 Feb 2025 03:34:17 -0800 (PST) MIME-Version: 1.0 References: <20250211121128.703390-1-tabba@google.com> <20250211121128.703390-10-tabba@google.com> In-Reply-To: From: Fuad Tabba Date: Fri, 14 Feb 2025 11:33:40 +0000 X-Gm-Features: AWEUYZkg9ciLMmzUzGdibdWHAPxNuB7L-_G6HGADGpvsMSO9kriMESSOnmZ50-k Message-ID: Subject: Re: [PATCH v3 09/11] KVM: arm64: Introduce KVM_VM_TYPE_ARM_SW_PROTECTED machine type To: Quentin Perret Cc: Patrick Roy , kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, yu.c.zhang@linux.intel.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, david@redhat.com, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, keirf@google.com, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 6FAE6C000E X-Stat-Signature: 93u51h1mewxd9ytsrfmwz5h4spxuw9ud X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1739532858-939572 X-HE-Meta: U2FsdGVkX18RiRYV6VqzSwGswc3EwAnEV3P5WkpcC9/zQ2VexFgK5e4+LjO6UUQjVKahGdVj/KMCDTIGbGRmFJZdXrmg43NjXV9WIkyx+44tQf4ZIZiipzhNimF1/ty5JRWD7gYti9XT75LpTPS13EHaoH1YwWB591LT/8RuOwNNxOmi/yZNa1k8V2/ty2mdl2ylaujS8YPJ8exvevF62L0gqZS468J43o93+cUkCjWmd1mjw+8D47+cHGjNazVcHpm0+pGIi2OCSdqABBM+b/T+b3J8JwOOgx3HxxmPl8pPhhKGQQ7HWODLAqTZAx1msZDB+FO2bjF+VODdzBS3gK10P8RZ3bVoQk+qdHuKBinQuBBRota6HqIrZAs3Xqx6JFS6xB//oFp+zY9fvaKSFPGexe3YpyVxvWwrGqBRhPNiFN0MeKxO9mXX6zLEAFgD2f1MyxkiN5c4FPXRtXTGvt8xAtaDfEVCDltJbmG80rrOAf/lQJUDoEtuTMTZlSUplCgkbnBZs+S3nCTPhtaGC/EqHWGR4LY8hInaQ61e8w5I/AwvSRzEI/KXkVVcG0eo1c1OBnHw9qfdxxe+efgKb/tMDVE2B2IsxV/ex4DuLdUkRmrUpyMEZr/w1qYwbwPdEsHCdZtx8fKjA+Gf9BBjmqZ0PDaphfVQzsvZvpmA1LzYJLKRVPFVgIgDiFBmqpg95yRpI/vz43W9I6aQjI+1nTIVgxkNepG70FHoQzfcGvwu4XqclOS17H9ZqO3aWKuigkGO070oJwvFg5WTcWmUtGRqgNBWvZi73R2S4CePcM81bs3kH2UcTRUHZsnah7gHc9AYNnTwJCEjLBbQ/32tjHUEVkJ5tRlikjdzIAU6r632H8fDqDFCAs8rFSo9ynBB3CRbh6rcRKUYU3KbUOOV7frJ882uJEpFWks8dw+CPmNvRIqlz455YRFheGEhZrs/MFEZ6EzlESKxP8jZ2Zd U75kNKfr gDhgSBwiLrgW4Jm+rp3pITpl55uEDipAaOYqcXKYrNWvyQL1hy9nCHZjegdCD5XBBapniSUGpYvTABElcfIY4guJpGeM2MXp0+gjb/v0A6x7xu1Ne8ognmn+kRFcJ+dWz7exAyEcTtsDXNY09ZInunBmHOXPqcWvMJjyswR6FVQR7olLhCqR6xarXsHYP77qRfiMW3FzNFqMCpSJqbw4IXYcFAF4Tc7xxGJBR7+NwEKAYA4Ch4VQzXE7+uFLsLfVXykTYF9FIKRknWSspxT4orpenrJbVd+8JmS7mVzTd1lm1BSp3EYRYeMebSVGmqstIISK90PiT4Zd6ipCvwgpD2WwwUA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.250048, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Quentin, On Fri, 14 Feb 2025 at 11:13, Quentin Perret wrote: > > On Tuesday 11 Feb 2025 at 17:09:20 (+0000), Quentin Perret wrote: > > Hi Patrick, > > > > On Tuesday 11 Feb 2025 at 16:32:31 (+0000), Patrick Roy wrote: > > > I was hoping that SW_PROTECTED_VM will be the VM type that something > > > like Firecracker could use, e.g. an interface to guest_memfd specifically > > > _without_ pKVM, as Fuad was saying. > > > > I had, probably incorrectly, assumed that we'd eventually want to allow > > gmem for all VMs, including traditional KVM VMs that don't have anything > > special. Perhaps the gmem support could be exposed via a KVM_CAP in this > > case? > > > > Anyway, no objection to the proposed approach in this patch assuming we > > will eventually have HW_PROTECTED_VM for pKVM VMs, and that _that_ can be > > bit 31 :). > > Thinking about this a bit deeper, I am still wondering what this new > SW_PROTECTED VM type is buying us? Given that SW_PROTECTED VMs accept > both guest-memfd backed memslots and traditional HVA-backed memslots, we > could just make normal KVM guests accept guest-memfd memslots and get > the same thing? Is there any reason not to do that instead? Even though > SW_PROTECTED VMs are documented as 'unstable', the reality is this is > UAPI and you can bet it will end up being relied upon, so I would prefer > to have a solid reason for introducing this new VM type. The more I think about it, I agree with you. I think that reasonable behavior (for kvm/arm64) would be to allow using guest_memfd with all VM types. If the VM type is a non-protected type, then its memory is considered shared by default and is mappable --- as long as the kconfig option is enabled. If VM is protected then the memory is not shared by default. What do you think Patrick? Do you need an explicit VM type? Cheers, /fuad > Cheers, > Quentin