From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BA09C4332F for ; Wed, 19 Oct 2022 15:03:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D8DAC6B0071; Wed, 19 Oct 2022 11:03:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D3E8A6B0073; Wed, 19 Oct 2022 11:03:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C05CE6B0074; Wed, 19 Oct 2022 11:03:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id AF0736B0071 for ; Wed, 19 Oct 2022 11:03:10 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 68E0A1A0158 for ; Wed, 19 Oct 2022 15:03:10 +0000 (UTC) X-FDA: 80038016940.27.DBB8796 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by imf28.hostedemail.com (Postfix) with ESMTP id F0EFAC0074 for ; Wed, 19 Oct 2022 15:03:00 +0000 (UTC) Received: by mail-lf1-f45.google.com with SMTP id b1so28582575lfs.7 for ; Wed, 19 Oct 2022 08:03:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=8uws4B5WgtxEQQPonRBN7dDm57mj+TMYZwg9NWMF6uE=; b=GNoRQIq9JKVsi3NBMOHtxRxaA+HyiSRxEbQwKROCIdQN7YeQVvkeCL/tBfTJ0rFShS wLv+OMed6GKtlzQERAvDIH0fS9RwWNLH1iDzg8iIFUBsQUCTCUR56HEIdBHp5w6KeZ+i ed0p1SeRI6LjurmDyBxbuv8clbnocReb3YyBgtI/ebogw01dMtsK7A/KD1lbcyPsqtH5 TaWyyc8eNama/1dRhNwUMQO8P85tBb+QCcPLfYt81cuF60S21NuSTt9ENjFqtPiqHbYW QbAZcIWW265YqQ7fQmjB0etPPuYGAVxyYuBBwAInvDjayuW/S/xhDX/aqG8lWy7/HjYu bNlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8uws4B5WgtxEQQPonRBN7dDm57mj+TMYZwg9NWMF6uE=; b=KgbpYRmGsGO9i04sj7tLuPAWGv1RudvWzZpgQIXuB6CyWpuqahKZ6S7dRsx4D5Ddxi 0A1Om+WqOtVQo0PblUcASVf5Nolg7CLkX9CbkPI1aMvggtcgZmdkO2GRftjYA+75IYer 0psdE63Utskmm2lm04kf13oMAdQDl3oM6+ywo4sr8orBk0bKfkDoXtCpgBquDmQIifJm CF8jBkZj5aLlSkwmiDGDd/guJW0w4Z0oFxRRox8VKFO2JzFMqlcMnPob8/Q3a7V8gI4X r3bivyEBCpomwUDqoqOrs1ifp/G8igEaplrpJKRwbZlj8+MlTnz3tpg3PG64j7z59T6B 8/Gw== X-Gm-Message-State: ACrzQf3MH1QuSUPZQG2bMeTmQ2sYzLlR0BbkDrCxtN27/uKzcW9IUC0z M7PTKffHi8d+owUbQfaXIP6GYPIFiHnkwo28TwCu/A== X-Google-Smtp-Source: AMsMyM73/Iz2UA6hD6VnKREmVWKox8T+CDDwCUSlKn0rjft7dc92r9M4EXDXMPFumhxI7Ld+a4+gjwQViVOGvFn4W+A= X-Received: by 2002:a05:6512:4cb:b0:4a2:25b6:9e73 with SMTP id w11-20020a05651204cb00b004a225b69e73mr3205357lfq.30.1666191778897; Wed, 19 Oct 2022 08:02:58 -0700 (PDT) MIME-Version: 1.0 References: <20220915142913.2213336-1-chao.p.peng@linux.intel.com> <20220915142913.2213336-6-chao.p.peng@linux.intel.com> <20221012023516.GA3218049@chaop.bj.intel.com> <20221019132308.GA3496045@chaop.bj.intel.com> In-Reply-To: <20221019132308.GA3496045@chaop.bj.intel.com> From: Fuad Tabba Date: Wed, 19 Oct 2022 16:02:22 +0100 Message-ID: Subject: Re: [PATCH v8 5/8] KVM: Register/unregister the guest private memory regions To: Chao Peng Cc: Sean Christopherson , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-doc@vger.kernel.org, qemu-devel@nongnu.org, Paolo Bonzini , Jonathan Corbet , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H . Peter Anvin" , Hugh Dickins , Jeff Layton , "J . Bruce Fields" , Andrew Morton , Shuah Khan , Mike Rapoport , Steven Price , "Maciej S . Szmigiero" , Vlastimil Babka , Vishal Annapurve , Yu Zhang , "Kirill A . Shutemov" , luto@kernel.org, jun.nakajima@intel.com, dave.hansen@intel.com, ak@linux.intel.com, david@redhat.com, aarcange@redhat.com, ddutile@redhat.com, dhildenb@redhat.com, Quentin Perret , Michael Roth , mhocko@suse.com, Muchun Song , wei.w.wang@intel.com Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666191781; a=rsa-sha256; cv=none; b=hPCdlczoAvZSloOQaMWd4uPVZuhC/CB/03M8NsxVZtajJOk6r6cepJppezUU+4OM4hkz4f AIexrHSVCHtqyY/8IkN6txYzyHxAi8aXoYJ/7FQ3dQv059gr+JAsLuupnzS+9QP2J1r5+v Jcv/H40J8Z1Un8p+FEtfgX1IMeyy6fs= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=GNoRQIq9; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf28.hostedemail.com: domain of tabba@google.com designates 209.85.167.45 as permitted sender) smtp.mailfrom=tabba@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666191781; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8uws4B5WgtxEQQPonRBN7dDm57mj+TMYZwg9NWMF6uE=; b=JJrJYPiQ1U6jq1yyejZWoEC8rLXRayl2iLoznVdZkN75aD4En+7EQigISaEGYAzuiMiba7 6dowT3hI+oK4ibvpkgnVEJbWvT0zZriVhJBK6V36XXXd4RDKBE9czPs2MyoYgk74EB6ocf +V8GymH0lzxFzjspLhfkdAG/EyOJMUM= X-Rspamd-Queue-Id: F0EFAC0074 Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=GNoRQIq9; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf28.hostedemail.com: domain of tabba@google.com designates 209.85.167.45 as permitted sender) smtp.mailfrom=tabba@google.com X-Rspam-User: X-Rspamd-Server: rspam08 X-Stat-Signature: ocyzscoupcc9ick3o611d5s8zpctaymo X-HE-Tag: 1666191780-18207 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > > > This sounds good. Thank you. > > > > I like the idea of a separate Kconfig, e.g. CONFIG_KVM_GENERIC_PRIVATE_MEM or > > something. I highly doubt there will be any non-x86 users for multiple years, > > if ever, but it would allow testing the private memory stuff on ARM (and any other > > non-x86 arch) without needing full pKVM support and with only minor KVM > > modifications, e.g. the x86 support[*] to test UPM without TDX is shaping up to be > > trivial. > > CONFIG_KVM_GENERIC_PRIVATE_MEM looks good to me. That sounds good to me, and just keeping the xarray isn't really an issue for pKVM. We could end up using it instead of some of the other structures we use for tracking. Cheers, /fuad > Thanks, > Chao > > > > [*] https://lore.kernel.org/all/Y0mu1FKugNQG5T8K@google.com