From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C47FC369B2 for ; Mon, 14 Apr 2025 10:16:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D2146280049; Mon, 14 Apr 2025 06:16:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CF813280036; Mon, 14 Apr 2025 06:16:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE5D9280049; Mon, 14 Apr 2025 06:16:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9A9D5280036 for ; Mon, 14 Apr 2025 06:16:01 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 8838E1A1CAE for ; Mon, 14 Apr 2025 10:16:02 +0000 (UTC) X-FDA: 83332243764.26.3244A98 Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) by imf19.hostedemail.com (Postfix) with ESMTP id A7AF41A0011 for ; Mon, 14 Apr 2025 10:16:00 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=wDxUvboc; spf=pass (imf19.hostedemail.com: domain of tabba@google.com designates 209.85.160.177 as permitted sender) smtp.mailfrom=tabba@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744625760; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OcLJDnrFkO8e8oXnJcW6VAoR6xwGl1kDtwgUjWBGRiI=; b=n6Ebx+wgL85r/esVfHKYOAEBzMrMkfNMH54XNlC2NWHHjlpRvgOWxZbOrxRtDLYgl6ljKy Q02kT0yyqyUC6GJmGDfcemipN3Hi6dT2ZBjoew5gR3Z1xFV22v4w4wzC10Y1B7S6Tyn95j FWs2Za9U0OjyV08CaRmv8xULH/C6HwY= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=wDxUvboc; spf=pass (imf19.hostedemail.com: domain of tabba@google.com designates 209.85.160.177 as permitted sender) smtp.mailfrom=tabba@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744625760; a=rsa-sha256; cv=none; b=rVTn1LTZ70NJ1r1HojaI6D2ky1IPx7f/T+G/LEyxF9HX5H2Xx56gUArhig4L0udRpv2gb2 X3V2BDGTb4e1bkD7npifZpXWZYpd86mf3gYGVdv/EJkgchW7USuHaQCj4JANNv2dLJLSjA M1nVDnNoGUZfa+G55WFV2bCvopkSXKk= Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-4769e30af66so600061cf.1 for ; Mon, 14 Apr 2025 03:16:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1744625760; x=1745230560; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=OcLJDnrFkO8e8oXnJcW6VAoR6xwGl1kDtwgUjWBGRiI=; b=wDxUvbocTokhPUIRHbcM615VRFqzOqcQcgT3WFHm7QfvRdkb3WLqkFmvsAMOBXhcIb OgEjiKuj+513XP6h7aN+w+z9ojZ9naSgqOHlmQFhz/bjA3Z7UUNqGZIRsr/cvlwC19D0 1q0/m7Mb9ACOEU3KsrJ4fTKKY/7UdohdV6mu8vysl3ezdO9j4E9VSrA5v6iQ6z6pyOhx DoU687blSjRnkdXg9uFy0A8R3kJrX9rYR0S4NaTI+zgxO2eSGL9VoxXtVmqdw2YpVBnK mnuKuFwatPK2Gehip0dNGsLhXZXVhiT+7kaifCevS+mrocGdZ7p3liU/HLEueSchgxim 3aeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744625760; x=1745230560; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OcLJDnrFkO8e8oXnJcW6VAoR6xwGl1kDtwgUjWBGRiI=; b=CH+vSJjNKZfEBlS9QbpfUvkSdNLy0/IqfqHyuQJ8AyZWu2UjtTIlZLpUGD6557X3Yb KqxarQwxZMNOQJamdjNXLZFh8RQ+LyFBUW4RM1erl0m1AquXf28wfp67pLuq7dUqlybp 5MtnpTfEhnjSGJfGcZN5OaaxZInKJTFySgys00Qb80T0EfdCswNh6cPLucKOuY4aFMxK gmAYti6kb0sWAjBHWVjcgQrlb9LPlybVAaom5e7q1lC3SfsfOZJy43A1/pSTJvQqbiu/ Zn+63P7o8bMdV7hJqfdt9prF46M5lXcw0ZxxMzXba1+3/IR5t46W585PrkMOmyzdQowY gXog== X-Forwarded-Encrypted: i=1; AJvYcCXrygr8jFsxRGfVWGNshH+t9LJK80/MA+rE06gpac0l3DUwae8oxsA4Lt/l3ge/eqJI10sfzDEGbg==@kvack.org X-Gm-Message-State: AOJu0YzW/rc5Wn0A+bSfIMfFxHObOGIYZPiV4ExL9rwpEQuwS8HCZXuu QZmZHn8dpXAj4FyKwH1DS8vOp33yIfX2hnxS0yKgtoRvqCo/ZxyandQ/AfFdQVOslteBr0vHEdi cGhsPwIcMxZV6JPu1J7rJnnA44wwjtoYN3i8v X-Gm-Gg: ASbGncvsN2dKZiyR3xsyOWXhqwsL7WDQUkN3agsJhBMzg4DEeIy6KVh+PLrh78MPSCY hT/7O9Q+46OR3uIZvPnBtwldYTcdnvtr4lBxElgGPmS7Wlr5wnUxkGdST2k1G/2uRbGqBO7+C5v e9M1y37O59jFD68V88tDoDPA== X-Google-Smtp-Source: AGHT+IGCz8tRzMWzZ7k1b4BNH1NUIjgUIZI2IRy23Z5IEMrMl0Yq7yQbo8Xe1bpouJ0DZWpGxsoWemisIh3ijjXh1mA= X-Received: by 2002:a05:622a:11:b0:479:973:46f1 with SMTP id d75a77b69052e-479815f5c0emr7965841cf.22.1744625759359; Mon, 14 Apr 2025 03:15:59 -0700 (PDT) MIME-Version: 1.0 References: <20250318161823.4005529-1-tabba@google.com> <20250318161823.4005529-2-tabba@google.com> <96ed1b7e-a4ec-417f-a766-237229231017@redhat.com> In-Reply-To: <96ed1b7e-a4ec-417f-a766-237229231017@redhat.com> From: Fuad Tabba Date: Mon, 14 Apr 2025 11:15:22 +0100 X-Gm-Features: ATxdqUGYDtD0-17Blas24LtFzrv5L-nhb2QSHzRNpC2CiejHvLicJITFfxnMcJ0 Message-ID: Subject: Re: [PATCH v7 1/9] mm: Consolidate freeing of typed folios on final folio_put() To: David Hildenbrand Cc: kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: A7AF41A0011 X-Rspamd-Server: rspam05 X-Rspam-User: X-Stat-Signature: i3ii71skxbgnkczptym1txnb6patn43a X-HE-Tag: 1744625760-316980 X-HE-Meta: U2FsdGVkX1/h34MK4nUS+JB81L8SQlmxZVxbeO4ApSZeHapALzRqo0i83yWdBqzIWqGbJsEiEDJ0tDaEX9D3ujvzl4jn+7qCz8OpBH+8BtaZgjWdCRCmpYycN/c4fSn5hPCk6Jw6+dLqqb6MWnWJB/iPN+cjFFtROpm+eYxrlr1zTnVh8s+SGkwdbXt1HebVbEvLF7vLOr/1lYpikv3izuAWSezOpgJZHSQa1bGtv0TZ6qEPyPMGF68i+cCrZQkMZaPFzyp2ADRWPmuCapyEMlyzCrPZFdrG+0y7sYnkEHQ+rsSE9gbkcT783JynycOk4Lz9DO5EWSUs9rQ1MBJ/pf8G1Vz2WNCx7baA16zxM7aDLXKkuD8eGrfgWU5exQb75egyZeqLVlQCzspjgfK8jU2B2hZ0ruh8ohHM7WXKpEzvrspey7jM64OrZq3yDAmjfErmh6B7ljf7DnQChmEIikQlcip9R4NSpcMKIzIU7bFfd/s7s3Jb5zfIObk7VGGr3hGNRdnLhDWZp0yNMY3u656atJEY/ux02jIi6xCIeKHVVBsqmtvnPgX/4tzWqj2Kx+WitdNSiYgH76hpX8jx7uxcCADOchteeBNIHwnT+B3mQQnh8sPoA7Tg5DQN2x8NhBFzXp+KW6sEO25YHrmZJFN93OB3zv/gZvIjgj5HLMpMDyn+46i4Jmvw8EDUuF9CIb3MfXetbk5ColLv95K2aWMGSWyz3KQdd+1jDO6chlqTBQXBiaUPb6gZ62wYWDupsFppE4FScujszAjUO6Ie7JXX1h/YVTwLNcjNjVSOtUG1idnqNx24OyNeCCtt6CqpbU7o5e/7LyM2Y97/gy1cHPVupZb16fcfM1GCyA/34WVS903xaktnd6f5wyjCjSrLi6mvXIC2suDF/vJrFSa4OqUfwHA6oD5t72PCy/3L4RnVSXplA/iEVVfjSS0AnJdBQI95lVj6Zax4i2PdabR i59Ptnt1 DTPzGih0M1yNJThVAdif+MRrYkT5kz/Kjgj7vAditHpd/iGeYSEoB4oJNeGcMZyRF2xT5LUgGyRymyorjDgU9Msr+CxLnDiuGiPCScJwmTxzFHUwwnv+uqkjGxInIF2IauJ/jSPPEZinSknKiQIepWCLvmC+scC6SBkwmpI2kCsrxHDq97ZgHxrDxLC75HChxuKYFi5/QgKHVyYSJ0tLd/EJbpHoPtx8m42EYk+qF48v/pui8HI6KUuT8igiiyxEPGNG/Q0x+tds0c0HDo8Lvs6tZtCwup9ANCV0f7a1byNiSE9MoEjQEC/nRqcmkeuTjMk63gCOgGJrW0rFws67TfmZAgrzB1pNtbkMpi2BO4fmxk98= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi David, On Mon, 14 Apr 2025 at 11:00, David Hildenbrand wrote: > > On 18.03.25 17:18, Fuad Tabba wrote: > > Some folio types, such as hugetlb, handle freeing their own > > folios. Moreover, guest_memfd will require being notified once a > > folio's reference count reaches 0 to facilitate shared to private > > folio conversion, without the folio actually being freed at that > > point. > > > > As a first step towards that, this patch consolidates freeing > > folios that have a type. The first user is hugetlb folios. Later > > in this patch series, guest_memfd will become the second user of > > this. > > > > Suggested-by: David Hildenbrand > > Acked-by: Vlastimil Babka > > Acked-by: David Hildenbrand > > Signed-off-by: Fuad Tabba > > --- > > As discussed in the last upstream meeting, we should focus on using the > folio_put() hook only for the post-truncate case where required (e.g., > re-assemble hugetlb). > > For shared->private conversion doing it synchronously (unmap, try > freezing refcount) and failing if impossible to signal user space to > retry is a better first approach. > > So this patch will be dropped from your series for now, correct? Yes it will. Thanks, /fuad > -- > Cheers, > > David / dhildenb >