From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCDAAC28B20 for ; Wed, 2 Apr 2025 08:57:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9ADD5280007; Wed, 2 Apr 2025 04:57:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 982B9280001; Wed, 2 Apr 2025 04:57:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 849DD280007; Wed, 2 Apr 2025 04:57:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 677E9280001 for ; Wed, 2 Apr 2025 04:57:05 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 844C914145F for ; Wed, 2 Apr 2025 08:57:05 +0000 (UTC) X-FDA: 83288499210.13.169DEBF Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) by imf26.hostedemail.com (Postfix) with ESMTP id B5982140005 for ; Wed, 2 Apr 2025 08:57:03 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=phvAOHdf; spf=pass (imf26.hostedemail.com: domain of tabba@google.com designates 209.85.160.174 as permitted sender) smtp.mailfrom=tabba@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743584223; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=m5iA78/yZurmEltRRdW/uf+siD/f5GN0SyOgheLp9+Y=; b=4B6I669r26zsR02t1k/+8QxZJ49lWzyJtCG0+g3BW7Zw48ENZhjuD3UZlZcJpDnyVass26 qRb8lukw/Z7cq/Wr+gxGF3gm6hK9/elf3Ulxispho4pLq9oHC8uyJXpUVHgI/Rds99RSC7 sn4srQ/ZLQxlRd4fOwdcB27FCTrdgJE= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=phvAOHdf; spf=pass (imf26.hostedemail.com: domain of tabba@google.com designates 209.85.160.174 as permitted sender) smtp.mailfrom=tabba@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743584223; a=rsa-sha256; cv=none; b=tsc+rvAGJf6cQi+e6tDSCeJJ5bhwsNHvpmRNJxny2f27INJMtNthkZDXbeEDwostjua2Al LUAdC/d4usvmI9TwkPZYG2dpBjIEATfxSTNqeQK9GFvjR94dtBXIiYLY99+h0za/uC3uAs cN7op41IZXN5wAWSNoDhEh0jCi8ABnU= Received: by mail-qt1-f174.google.com with SMTP id d75a77b69052e-4774611d40bso202371cf.0 for ; Wed, 02 Apr 2025 01:57:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1743584223; x=1744189023; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=m5iA78/yZurmEltRRdW/uf+siD/f5GN0SyOgheLp9+Y=; b=phvAOHdfkJN+AFW1bFQSyrUB5CBMFIf2kxgGiUFhTxxdI1edrFhb8JLT6E28x49BIB YrS83fN5ZBWDwu2+Iv2ykJWsuBd9Y9TNNYDSAQgCLLUoTUkmaIatmyQXgTijjotOlP5W 2enc4+74+2DIUhfg/8CL0QOPh+3aDEKbaR9wpNuSU/UV7me2s4+Dh0IwCC1eSO72CiEF kdB0WmfxsKQvQUIGFzKJ6AdjvvS0V5aGeYvAPxO4UjwUtj+h+S0IT7Nd/1enUksupgkF dG/aeVRA89J556hQUx2zHggwou61x6E6y7ZVM0hSALkn/5nxkDz6PCoJXCNqhh8BFHZn ZJ9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743584223; x=1744189023; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=m5iA78/yZurmEltRRdW/uf+siD/f5GN0SyOgheLp9+Y=; b=rFIRxVbluicXEXDk3+5aZQhFlnNIb2M0W2WmIexU0K19h11iFx2+6Jtvw6RXJwFA2B DspoB8/F9pEow7A0O9UDiKIBTWQvBZaBvVniYaQ/1MVbLFVvUNPCWjblO6kFusRxvbgO jOcF6Kqb4C1CPq+48in/6ZCss9AC8m31leitiKpdAv2CsCWl8uBAjJlMQT04vnD503sX Q4Z6Teo74I0enhPMpjJxZ4vKm2TAnrvrFuE4SgZiuu7DRITZaFV30bnUKMHaednMEGHP AGjo2bfrLjOj9snAGI+W40Prjos5wYY8qlVB1TjDsyWisraXhbJHf1UAl5BgG1U6O03L pc9g== X-Forwarded-Encrypted: i=1; AJvYcCWjzp/cCWRG5JmL8SANyebN7FuBscidCca02T7G3uoBOBDK7rFy3CggzgGzohBh+JKHm332zQfhNg==@kvack.org X-Gm-Message-State: AOJu0Yz2ebPqOs9ZBK7ycilkRjqmABRzW623SmFdLAm1OWlvDSe6shb8 VEpjXrx45WRjs9dSnllsHH1LV7iLeO99m89aY0V7OiBPi9Oguvd5GSgzC4Pp5gRkrxpFmI0s/8f XVoISjwsIgqu565g8gGPiau7fNacpjgWXSPr/FicFpsBzE3j18Q== X-Gm-Gg: ASbGncvp0g7A8C8mM0tnGrONrbhR1hO3cWbcI0zLm41ntXnrk1SFyb8X0UuH1z6k97A tBiMF/vNrHjYYAQOLbgUVcUBluDA5fi1iVXjGHykvBfIp991mDTxbykoTaf1cKYrJJZXuwnBv65 a7aGRSLefeaaAs4aTT7lhU9N5C5ZqGjKwLPy4USzZCgCqGzyX0YM+LZA== X-Google-Smtp-Source: AGHT+IFMTKEuvL6e2xcrh8KaPfFrhCp5Vu61ZzX0pTYvrTSHuSwEWdkkapnTZnUw//F3Ru98j861ZY4zhkBOorh2/Jw= X-Received: by 2002:ac8:5847:0:b0:476:f4e9:314e with SMTP id d75a77b69052e-4790970660cmr2555471cf.25.1743584222699; Wed, 02 Apr 2025 01:57:02 -0700 (PDT) MIME-Version: 1.0 References: <20250318161823.4005529-10-tabba@google.com> In-Reply-To: From: Fuad Tabba Date: Wed, 2 Apr 2025 09:56:26 +0100 X-Gm-Features: AQ5f1Jr4jnEVAOjFid1RNVBv-AxFH88c8b48xrmOJ-wbYii36QQdgSCZv00f5kw Message-ID: Subject: Re: [PATCH v7 9/9] KVM: guest_memfd: selftests: guest_memfd mmap() test when mapping is allowed To: Ackerley Tng Cc: kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, mail@maciej.szmigiero.name, david@redhat.com, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: B5982140005 X-Stat-Signature: 3mchmc8jk5wjr8w8yuom7ruh4oyo3bs6 X-HE-Tag: 1743584223-659072 X-HE-Meta: U2FsdGVkX1+egybiW5p2PQCm2wEiVaVW9wlZ+w0g/rwFP4Th6WHCHthM6ZnF7S8BzgAfbzJmNmbPjmAETpsHLLIocHV7dG7+gNGuvyOa07Nlf0O4wfBhtx3P3XPTOEUiRi2t7KXb/BtHlEdnDAtkhmKGmeGI001LnPlJkZZ4jB59ywNA6ye6zvGIngkGByY0/6Exr9B+/E69DMRQV++Rai/tbuddJv0H2ERzmMtvr2KYbWhwK9zCtv7dOf+25l+RQMN/nsbsPbwrz3VOzqX6gLMhNROc1hjsGkZLe74/NTqaVvrYFtxGhDuIRIKTxHDUikGt0/pHd/RuaZIa8RVeBjWe9aT5/PJTX99+bHlX+5r/TrwGw13zRYBBQ/WDznPyNNf3lI+BZLGbEvgLM0snl5OP4vKOWsTorWluwW42I+lFE4Csy39RisshuBexbg7+X4lVijnJuuU2OFaiSslNKF+lvbLkAMMJksyQWu0v7yVI0xZCCGRSHVuNpOsjdmqnZqqJmL0het2QWPaABgUzxA/Kjwt9kUCrQ5IAYLpgoWIEuOB2/HfHCe3Vqxp1xwj96ZRbQnBIUt3iUx8Z+sbsVm7rWHh+b+Y6iFmoL07RqKtWBsELZvLSuAPBG6U9x5zRitXe3fnad+oAubeCttpSiVOFz3H03MdyH91DB8HnJ/U2IJO8IfX4berFrmM/74l7IkcCuQq/AJM+qc97qwEu3dNzojhuKibpE3lscWMuBfZHuVKI5JTfX1kKZ5OhvNwnSa2d6D7Vg0fxLH6l7PmtWA4lgRbv+ZyZcC8YmKpR74FejenM+7rogqL58HXBQO0YUsrW459aGBZN7YBXSEY6+IRFRiMq7/Rq7x0KrZQ6jqcwMV8aemjNZ6M77DQ9xX70mRppTXU8WFIWYSqILzS9oJqPOOpZwXP2/fL30HlBwrfDvVUtZa2h7uz5fbAlDXnwOOKJk2qQjY91kkH/g3w nodfDQkj mJQvxXpu8/7wHuXYkQX02ohs6ycvpYD3JNgoj/l+9SO6UwhKTkLIFIIkLO09sJLf3i3+e5L3xTCMfiqWmvDFKU+GLMDscOPAoGvHWXNKWJIaVZRT/nRo6JCYWUbRCbx7w6RqF92AuZywZW+I7RPSlNjXf/pibRe04C5q9oFfT/HlTbDEh0WeqGLGX75iu0/wLwLxkVGuRC8o4ba4A6kJSca2vDHEpPqkJZXs8zR9N2M3XdDo3OhcIB3kFOFvTloXkxbmiMapVPp7LAGYcFSk4kcPdUMYwicnDICayTtAt0/qzEQNK8A729hg0d7mCY2G5kZouFJnlpcC1CyKh6DsOj2iuz98+1DYGbpBJyBWI580WJ6knK8ctp1HvCQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Ackerley, On Tue, 1 Apr 2025 at 18:25, Ackerley Tng wrote: > > Fuad Tabba writes: > > > Expand the guest_memfd selftests to include testing mapping guest > > memory for VM types that support it. > > > > Also, build the guest_memfd selftest for arm64. > > > > Signed-off-by: Fuad Tabba > > --- > > tools/testing/selftests/kvm/Makefile.kvm | 1 + > > .../testing/selftests/kvm/guest_memfd_test.c | 75 +++++++++++++++++-- > > 2 files changed, 70 insertions(+), 6 deletions(-) > > > > diff --git a/tools/testing/selftests/kvm/Makefile.kvm b/tools/testing/selftests/kvm/Makefile.kvm > > index 4277b983cace..c9a3f30e28dd 100644 > > --- a/tools/testing/selftests/kvm/Makefile.kvm > > +++ b/tools/testing/selftests/kvm/Makefile.kvm > > @@ -160,6 +160,7 @@ TEST_GEN_PROGS_arm64 += coalesced_io_test > > TEST_GEN_PROGS_arm64 += demand_paging_test > > TEST_GEN_PROGS_arm64 += dirty_log_test > > TEST_GEN_PROGS_arm64 += dirty_log_perf_test > > +TEST_GEN_PROGS_arm64 += guest_memfd_test > > TEST_GEN_PROGS_arm64 += guest_print_test > > TEST_GEN_PROGS_arm64 += get-reg-list > > TEST_GEN_PROGS_arm64 += kvm_create_max_vcpus > > diff --git a/tools/testing/selftests/kvm/guest_memfd_test.c b/tools/testing/selftests/kvm/guest_memfd_test.c > > index ce687f8d248f..38c501e49e0e 100644 > > --- a/tools/testing/selftests/kvm/guest_memfd_test.c > > +++ b/tools/testing/selftests/kvm/guest_memfd_test.c > > @@ -34,12 +34,48 @@ static void test_file_read_write(int fd) > > "pwrite on a guest_mem fd should fail"); > > } > > > > -static void test_mmap(int fd, size_t page_size) > > +static void test_mmap_allowed(int fd, size_t total_size) > > { > > + size_t page_size = getpagesize(); > > + const char val = 0xaa; > > + char *mem; > > + int ret; > > + int i; > > Was using this test with hugetlb patches - int i was overflowing and > causing test failures. Perhaps use size_t i for this instead? I need to think big, or rather, huge (sorry :)) . Will fix this. Cheers, /fuad > > + > > + mem = mmap(NULL, total_size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); > > + TEST_ASSERT(mem != MAP_FAILED, "mmaping() guest memory should pass."); > > + > > + memset(mem, val, total_size); > > + for (i = 0; i < total_size; i++) > > + TEST_ASSERT_EQ(mem[i], val); > > + > > + ret = fallocate(fd, FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE, 0, > > + page_size); > > + TEST_ASSERT(!ret, "fallocate the first page should succeed"); > > + > > + for (i = 0; i < page_size; i++) > > + TEST_ASSERT_EQ(mem[i], 0x00); > > + for (; i < total_size; i++) > > + TEST_ASSERT_EQ(mem[i], val); > > + > > + memset(mem, val, total_size); > > + for (i = 0; i < total_size; i++) > > + TEST_ASSERT_EQ(mem[i], val); > > + > > + ret = munmap(mem, total_size); > > + TEST_ASSERT(!ret, "munmap should succeed"); > > +} > > + > > +static void test_mmap_denied(int fd, size_t total_size) > > +{ > > + size_t page_size = getpagesize(); > > char *mem; > > > > mem = mmap(NULL, page_size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); > > TEST_ASSERT_EQ(mem, MAP_FAILED); > > + > > + mem = mmap(NULL, total_size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); > > + TEST_ASSERT_EQ(mem, MAP_FAILED); > > } > > > > static void test_file_size(int fd, size_t page_size, size_t total_size) > > @@ -170,19 +206,27 @@ static void test_create_guest_memfd_multiple(struct kvm_vm *vm) > > close(fd1); > > } > > > > -int main(int argc, char *argv[]) > > +unsigned long get_shared_type(void) > > { > > - size_t page_size; > > +#ifdef __x86_64__ > > + return KVM_X86_SW_PROTECTED_VM; > > +#endif > > + return 0; > > +} > > + > > +void test_vm_type(unsigned long type, bool is_shared) > > +{ > > + struct kvm_vm *vm; > > size_t total_size; > > + size_t page_size; > > int fd; > > - struct kvm_vm *vm; > > > > TEST_REQUIRE(kvm_has_cap(KVM_CAP_GUEST_MEMFD)); > > > > page_size = getpagesize(); > > total_size = page_size * 4; > > > > - vm = vm_create_barebones(); > > + vm = vm_create_barebones_type(type); > > > > test_create_guest_memfd_invalid(vm); > > test_create_guest_memfd_multiple(vm); > > @@ -190,10 +234,29 @@ int main(int argc, char *argv[]) > > fd = vm_create_guest_memfd(vm, total_size, 0); > > > > test_file_read_write(fd); > > - test_mmap(fd, page_size); > > + > > + if (is_shared) > > + test_mmap_allowed(fd, total_size); > > + else > > + test_mmap_denied(fd, total_size); > > + > > test_file_size(fd, page_size, total_size); > > test_fallocate(fd, page_size, total_size); > > test_invalid_punch_hole(fd, page_size, total_size); > > > > close(fd); > > + kvm_vm_release(vm); > > +} > > + > > +int main(int argc, char *argv[]) > > +{ > > +#ifndef __aarch64__ > > + /* For now, arm64 only supports shared guest memory. */ > > + test_vm_type(VM_TYPE_DEFAULT, false); > > +#endif > > + > > + if (kvm_has_cap(KVM_CAP_GMEM_SHARED_MEM)) > > + test_vm_type(get_shared_type(), true); > > + > > + return 0; > > }