From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B21B0C41535 for ; Thu, 9 Nov 2023 08:55:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 17D778002D; Thu, 9 Nov 2023 03:55:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 12FAB8D0073; Thu, 9 Nov 2023 03:55:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F37488002D; Thu, 9 Nov 2023 03:55:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E228E8D0073 for ; Thu, 9 Nov 2023 03:55:35 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0F541A0DE7 for ; Thu, 9 Nov 2023 08:55:35 +0000 (UTC) X-FDA: 81437807430.22.7E82BB5 Received: from mail-vs1-f49.google.com (mail-vs1-f49.google.com [209.85.217.49]) by imf21.hostedemail.com (Postfix) with ESMTP id 3A2331C000B for ; Thu, 9 Nov 2023 08:55:33 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=JMMcohCe; spf=pass (imf21.hostedemail.com: domain of tabba@google.com designates 209.85.217.49 as permitted sender) smtp.mailfrom=tabba@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699520133; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LW/Fx883nWIRZKyM7HAb/UStNZnvbG60FpXDwf7xK7Y=; b=mvOrZE+hViIsbVZY7rxbGZZz91e1Z8Nv1cCEYbn+acJ251dVU6JmtUABzCP1eh2bkiPy+E ClMplQ9xoZVovaAI0KRqdAWW/TVAlHL6loxsKJWmM0gcCM1i7W14gCOk+FvRrdaHCGLA+3 fy2CX6XI1KTmwdYWlN5EKOrAGMBSAdc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699520133; a=rsa-sha256; cv=none; b=CgzwFyPRLdAAW55Mnf6Jb7iijXYb9ej2HV2blI0VKyhOk1FavonJsnMBuW8NOU7zmfYuh4 Iel+NpxvamsWReJzFxu6mHw1lDBnuBdcW615ypNMbfUyLM+uT/0d5B29yrgsF6yT/PuppR cDJJpTqnaTWK9WUP5yhNezV45wNmYSM= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=JMMcohCe; spf=pass (imf21.hostedemail.com: domain of tabba@google.com designates 209.85.217.49 as permitted sender) smtp.mailfrom=tabba@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-vs1-f49.google.com with SMTP id ada2fe7eead31-45d9689b65dso285430137.0 for ; Thu, 09 Nov 2023 00:55:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1699520132; x=1700124932; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=LW/Fx883nWIRZKyM7HAb/UStNZnvbG60FpXDwf7xK7Y=; b=JMMcohCe6xhfpwhVDu/WN+McMmg8Wb/iMLT9qI0MfBN4T+feOrosyBP6X9oSTWJbrs 845ja16FXBGUQVnjN1wKbGUa9vjh5I9sED7nPWJ13vY7BPsKnIYv9euUuvH8xxNUauVu +Pp5MOghin0seB70N8wQxy6kC43FbgHfkcckDVZXJSNbJ0Xp6dT1lHx3TrCwjhT2lddH XwwvzcY8HxdnyorFRoMgVqjJUG7RItbF/OdezA6TTVF8kIaLwdnTEbRyhR1qWZFmOFxL NKTD4uHtuTnHBlTacsFrA/AFkbWAp8qVa/xADlJjz1IC5rXUdmfEcGSC4YVjC8OF3kmj kU+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699520132; x=1700124932; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LW/Fx883nWIRZKyM7HAb/UStNZnvbG60FpXDwf7xK7Y=; b=Nz9xr+O9OpCoqiOP11S7sFSOgyJaX6POtWZtvNdF1jTjNIAiSjVKH2ucuHJnUA7agX AlqNRDSnvrRF5GTbqzLE98GXe9tzvvDRHRgRnhHFBRg+bmJ0e2vKP21jg/xmH691Glkl mWHOps1g/Z/1wR5AsUNhFd1WqsbGplpGg2/FsmJscv7xqPt2QhzGeBX7JMzJ+8EKNsso LEklCNdqJW9clmZW3pgDXYwOlSZbve66RnxP+rER6C5l+QXcCVDOnvzokpW2BXOIXvT6 afN9P+HhmT9758E+tKz2n3TC1+iv7bYf6AEJHkIqxlmqDOqglRGflpYt2Ip7Z9BNzat3 h7wQ== X-Gm-Message-State: AOJu0Yxu68OQ/5Q4H824BVHSEszD3U0F5D2RKSXotR5rbzCGsU7LemPY Vq9wDMpypeHEkfXSpJnQfQGX7A7gP62KRuMAQGcALg== X-Google-Smtp-Source: AGHT+IFw1OMfZ7dogx5GHZ5PY3FJDFYi1Xj9fX4uGT6v90sIMw1YGf7XiATC8vKEmYII9um0nqZKnx8f2F+kXqvVgVE= X-Received: by 2002:a67:c282:0:b0:45f:65e9:f070 with SMTP id k2-20020a67c282000000b0045f65e9f070mr3952209vsj.12.1699520132149; Thu, 09 Nov 2023 00:55:32 -0800 (PST) MIME-Version: 1.0 References: <20231105163040.14904-1-pbonzini@redhat.com> <20231105163040.14904-35-pbonzini@redhat.com> In-Reply-To: From: Fuad Tabba Date: Thu, 9 Nov 2023 08:54:55 +0000 Message-ID: Subject: Re: [PATCH 34/34] KVM: selftests: Add a memory region subtest to validate invalid flags To: Anish Moorthy Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Sean Christopherson , Alexander Viro , Christian Brauner , "Matthew Wilcox (Oracle)" , Andrew Morton , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiaoyao Li , Xu Yilun , Chao Peng , Jarkko Sakkinen , David Matlack , Yu Zhang , Isaku Yamahata , =?UTF-8?B?TWlja2HDq2wgU2FsYcO8bg==?= , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A. Shutemov" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 3A2331C000B X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 167f19fximemdqm4mfh81mzwtymadben X-HE-Tag: 1699520133-410230 X-HE-Meta: U2FsdGVkX19DgqNQzL+H1cjvpl3ihoX3ViZ8F7N8QuGXzd1JOHTOSXNRlhTWHQREXj1Vu/ByaD3R0m8wdaQ65TuHjtenBooxxyASFIZcX0TrsTs5jmLYOjR+gc3kUVCT6N4UxoN+2BAQFpp7ZlWyMfNdyTJ+LUU8yL0FsEpr1BKxlLFLyFKBmM74LzrsWpEb0OQsGMpiSg4Kd7XYRC+90dPXYPFAWo0olM/B+UbVtH59e4R+BQi+3gnRutLnrwajNOzIPFgTvQZjV4ebtddeY/K7IHxZ6IvDfSUqvHswPSOqHJPT8IEXsjx+XrRHKyn95kmO9WKsrSzKycG9CF0Q94AEalQo3DQc7/v47RngZ617vhnMa3Imx26ntQFws61ERl6lnyDScKPCku1berdjEx7KvfrUZ+6yXaw2kDhJvV6zc5Lqkf0c9im2XYPqZlS4hOcx5oOXm2vY8A/MloDA2dUVaUQtPqtFGQK4of8deFwA+uLCewXw6KK1qtJPjBZuWSgcyqaScArcaN00xhcWjNuMeGEayh0GSxoVl5Vev5n7JDYmNK3nZmQVnhaljXhPANrKaRxdiKJnKZzsOc1pM8d1+sodYIQgz/OhepMFre5dy2Now0VoWLxkPJKNJ4KZk0yM6wAFRpdkerzi/mu4JwEMYKs6E4sh5IXbzd1ksho4t9sXKDDyWiWRjumBU2Q+wkw3xf2UDAJcpF0xB8vgx/YeDzCg8Y8HSLsm8A8XHs83w0+f/cKcFodlTldMGH5Tw90BuzebsBdxO2SLb0JH3i8+YBmoLygFsZ543X8nG4gM8UelByLIkN+tXlWHhf1gvqWF9n4WNACzGldE7Rl8ihPEusD/wHXF+UuUViShKfb455y1yjoGb592gzsI1S6wXGs1jc7VGoYJ7+kF6ho26MVcylDZ2D5ZfFOwSh3jOYxJ+SMoDDG0EjLrsrJgEYwmhlhb2M8sbS5lvOP5cdo 7UDgyTWf z+U/EDgeD9sV2Rj51jZuDgz9sd2QvCe6dCr9K/v1op1BeenxvlZYUmVuzEUrdaVy56NuUimWg7QbJSMiyKCH+kxn0p0R8bve5n23PFwsM+MmMOcMjh9EwEIZFMJPKf3oUxJA3fCohH2cZBPd4AkFRYhjw0WBDHWHl9CcndZVx+gR6sR8ra4Udg2j8vrDxmrSxBB/1sEhF6mtnr8vWAMbUyCO/+1npWIjIdmzl7j55aS8EYhO4gest7MOuQm2GlU4G3BsvPixx1HuprSJJ069tqXKhJ/Gow/lLpRLzw4Hha0jMCq5gqqOl72Vh5azP8eVtnJZSfFLZFlb/0seTR1tQaeCjiqDvBOejc5dcB4HxnJMKMdMzIttDgVYJM1DysFWbar3UCbAm/1DS02xU1y8TyFcMyZqF1C30IAU0bvIF2KtFKFo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Anish, On Thu, Nov 9, 2023 at 1:08=E2=80=AFAM Anish Moorthy = wrote: > > Applying [1] and [2] reveals that this also breaks non-x86 builds- the > MEM_REGION_GPA/SLOT definitions are guarded behind an #ifdef > __x86_64__, while the usages introduced here aren't. > > Should > > On Sun, Nov 5, 2023 at 8:35=E2=80=AFAM Paolo Bonzini wrote: > > > > + test_invalid_memory_region_flags(); > > be #ifdef'd, perhaps? I'm not quite sure what the intent is. > > Side note: I wasn't able to get [2] to apply by copy-pasting the diff > and trying "git apply", and that was after checking out the relevant > commit. Eventually I just did it manually. If anyone can successfully > apply it, please let me know what you did so I can see what I was > doing wrong :) For me I applied the whole series as follows: Checkout kvm-x86-next-2023.11.01 (45b890f7689e) from https://github.com/kvm-x86/linux.git . Then use b4: b4 am -o - 20231105163040.14904-1-pbonzini@redhat.com | git am -3 Cheers, /fuad > > [1] https://lore.kernel.org/kvm/20231108233723.3380042-1-amoorthy@google.= com/ > [2] https://lore.kernel.org/kvm/affca7a8-116e-4b0f-9edf-6cdc05ba65ca@redh= at.com/