From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9CE9C4332F for ; Wed, 1 Nov 2023 12:51:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7503E8E000D; Wed, 1 Nov 2023 08:51:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 700198D0040; Wed, 1 Nov 2023 08:51:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A1A88E000D; Wed, 1 Nov 2023 08:51:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4805D8D0040 for ; Wed, 1 Nov 2023 08:51:58 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 12F551407FB for ; Wed, 1 Nov 2023 12:51:58 +0000 (UTC) X-FDA: 81409372716.10.C3A3BB1 Received: from mail-vk1-f181.google.com (mail-vk1-f181.google.com [209.85.221.181]) by imf09.hostedemail.com (Postfix) with ESMTP id 3DD5E140006 for ; Wed, 1 Nov 2023 12:51:56 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="lf5U7/AR"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf09.hostedemail.com: domain of tabba@google.com designates 209.85.221.181 as permitted sender) smtp.mailfrom=tabba@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698843116; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=d3o84LhG/JDs4XT09LqOqAL557WR+kTbV5Toac0tgZE=; b=uM4rHwbFSuSHC0KNrYHziG0EwWhcWdOQ0IsLpvcJN8sxtG9kLZXfT4KmBXUVyL68NSbqct XDetR4BjMtxT/eSerHfBpoFpaK8+2rqbO4d0ZjAXBYKvC6fRvx+6Q/Ag8agZ4QGLvSoazH u2qx4BEHRbhUK+OoG/rWqsNYy9phvng= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="lf5U7/AR"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf09.hostedemail.com: domain of tabba@google.com designates 209.85.221.181 as permitted sender) smtp.mailfrom=tabba@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698843116; a=rsa-sha256; cv=none; b=FstG46tQPA5g6ADX96lKkdFXP3ikyuACiIOxCHtOO/N/QkzOGNKPApsona+KJAFI7zChRe 0owHkXuK2eXR81rxgOYOcRq4BU/HMaeTjdias+XwWPfgu58p8vOgsY9F4c/MzlJN6gNK+R ZhEXFMZjwBWiJ6zQumtcnIf5ImzHx0c= Received: by mail-vk1-f181.google.com with SMTP id 71dfb90a1353d-4a13374a1e8so2754537e0c.1 for ; Wed, 01 Nov 2023 05:51:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1698843115; x=1699447915; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=d3o84LhG/JDs4XT09LqOqAL557WR+kTbV5Toac0tgZE=; b=lf5U7/ARommx+SDnKtgPgX+i3RDavOzJ7VFP2AICiGy0KlBU/3+/bjtHXlwQPRxO8N M9M+odQgEpbBQvNQqifhFWSapVhiehstksteYeD1KSaPaDgsTFF3TdwsU/prai0r3hwH bdxn7cP37dT9MNewqYOGnDf2HJSBqVXz6rqdEs5Lwy4o7ni4sl7ot4Xab/BvTeE2lste MnBFWVmkKBhV7R/ZQOVzbkMZsvjWLK9qYUFdA2ObS6mgUIGe7Wa5jJ619+NjwJzsZw0h SXJso5e6TknhQyTUC7y18r1Kpg4gzPD2cfm8pPWBp5eeDbtYC5klkKueKFQxq7+/LIlY LpQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698843115; x=1699447915; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=d3o84LhG/JDs4XT09LqOqAL557WR+kTbV5Toac0tgZE=; b=HcH8iWlZ3N9c93CmOcQ3vG025WDSOGIPpAifUdBU4eitxhrVfoQZUFZGriOIAPbK1n RDn0OKyzcC6QlxYHWWBIV1Mn4dYbjd4BTHRc3QpxZp0wZuA1NtfNxW3NYQ/92uEhFcVo EeKfUpMldYRZgD56xyLT70KUfRRxffF5H3Q8mLdMz9OAj3aftXfgebMKIbcT5DftTF/a CKKNRZCt4JmbJ245RCsxkY9t0Ss0P5h72TypumxkkA2jwQNsC4UcQ1CFxFZAz+8kJVJ1 GaF5rrKKWo84FbNJnrcwQDzkAnvBzTQeKN9h9we2MR7x3+lqET2S2qNG3P3qQTAGxz3X g7ng== X-Gm-Message-State: AOJu0Yys/pTcdvEk+Iug5U279kKmszz0dJOl7kS1Ot7GBmP1x86tkbBq pOPm3WXCLCeyp5P80xgG9bO7buclcewbpEtiLqYzdA== X-Google-Smtp-Source: AGHT+IF0GS509bXC109Q/KsllvKKbuNv6izlI+nfo857C1iROxiLKrI4wNuuGIZxmkDtH9Saf2Z2BbskHZJDaldFC6s= X-Received: by 2002:a1f:9b13:0:b0:4a1:7278:3bf5 with SMTP id d19-20020a1f9b13000000b004a172783bf5mr13903007vke.4.1698843115068; Wed, 01 Nov 2023 05:51:55 -0700 (PDT) MIME-Version: 1.0 References: <20231027182217.3615211-1-seanjc@google.com> <20231027182217.3615211-6-seanjc@google.com> In-Reply-To: <20231027182217.3615211-6-seanjc@google.com> From: Fuad Tabba Date: Wed, 1 Nov 2023 12:51:19 +0000 Message-ID: Subject: Re: [PATCH v13 05/35] KVM: PPC: Drop dead code related to KVM_ARCH_WANT_MMU_NOTIFIER To: Sean Christopherson Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Viro , Christian Brauner , "Matthew Wilcox (Oracle)" , Andrew Morton , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiaoyao Li , Xu Yilun , Chao Peng , Jarkko Sakkinen , Anish Moorthy , David Matlack , Yu Zhang , Isaku Yamahata , =?UTF-8?B?TWlja2HDq2wgU2FsYcO8bg==?= , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: 7y1y9kjc37jya7gqxumuf73aj5nhumfi X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 3DD5E140006 X-HE-Tag: 1698843116-474787 X-HE-Meta: U2FsdGVkX19NJe+pFcbyX+llQsqSqI+wDWiOrnCfWyKaZqxG4oj7v1yxSyNq42xw/4bfLkOjCESrF1SeXCKyn/7s3L51HXVJptytOQ35EInsGJfyIc+W+ztgdYZzBWiuZOBd6Rl7JKUMkRSFkg15BZhHhz5F7BxN5k9I6nUOpr+VT5DqOpNPvrrcl3G9UBg5WyjqNeaAZ4p/TbbT5Ya2UfZIO+Avts4CM6YT7HJ4Gw6T4mElYZrVwXu5/PuLhJUsZUZVJbEKmTcX1RVO7GijC0lRFk84M0YZCvLEJej3tOUE2CmcBZ2ZOKbMShyDEne3RPRlW2BabFykEfTkeNz8Dcza/uXuoXbzOpoyCCaOqpW2oz3VB/wbT9L8ahvoy3h4mq0kHKt8+BNFrBSGnjZAMASWwKUA7jJzHVjUQu+Te4XX3pqMvYk0FGGRg8OPbxaJl2J9wBVLlkTgiEnBq8ndLwF46UU4OrLyTORbheBYpZPNV3hj8CIQ5Z1I5B24DZR9m/oyBm2VB1JJ8Jtydjx9gbjk70b7UJJts0nvC8AQsZeiiZLjnpeATXvWF6im1PHh8lt8OVuRY3XGaTEcEsF97B3vD1s6w+9DPvJIZoK9V/tNh4Jl4pjCEFkd3/BgGUkVfm7BOzRoBt4sk2K1jZbND/7/H5vUAyFybwou1uVDvX9Md4EzdE71v46Gui4kquJxPLGLUA7YpnPJTpeJa0YgJIPNDuXeJdeBqNg87Y+vX7SE/jrRq1PJbvxHhHWttWmGUNrtBXuRFUcpfhByi7YyWvMrxI8/W0NkFt7OfaaiHgPOFp2BXSsR9UQl2gT+97f0Z8YzCSY6TmHDARnlu6TP8kbhfFPcQXU+TVoqZDcei20Ytp/z4ktl4YQFH+0t6f3FR9ymrJNT2bmPVytuExJHi56VFb3DOCzr9PLbl5qODfs0TIhSr/NuZkPUJDf+edai1Wh5VrfLd06HDErWmD8 bVHKGcjj oBMQI4UOWm6UnuOTCwRr806FSqe94vyvdzMiCfEeXx2UViAizqaxSfid4WQrI4UuHXz2KVLKX12LTp2MWIJEeMi8FTsLSapVK0BYUb0/kOfTghDSXG6rzwbclqzJJUBqfNI7HEzFk/VQ0KV1A/ZU14o2Bc54LRUtTKz1MY2a7S2RyskJ74D/i6fR9M0VmedBLxqNfVpM00z4RNo6eekognKBPfud7R5I3UaWLL7tCkgdaO2BuavwQ0c0vTuU2QZYCVbI8EkFZRvduZ6TTChwuC0e+j6daleNL4mpbNVkukAO8hRgTVb3fA3bKJkYQ7N2t8vo90nf4TW/WRrBX+4dT+YHv/5geaocP0Z9Bq1mzQw8+Rmj9audZXJU5/w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Oct 27, 2023 at 7:22=E2=80=AFPM Sean Christopherson wrote: > > Assert that both KVM_ARCH_WANT_MMU_NOTIFIER and CONFIG_MMU_NOTIFIER are > defined when KVM is enabled, and return '1' unconditionally for the > CONFIG_KVM_BOOK3S_HV_POSSIBLE=3Dn path. All flavors of PPC support for K= VM > select MMU_NOTIFIER, and KVM_ARCH_WANT_MMU_NOTIFIER is unconditionally > defined by arch/powerpc/include/asm/kvm_host.h. > > Effectively dropping use of KVM_ARCH_WANT_MMU_NOTIFIER will simplify a > future cleanup to turn KVM_ARCH_WANT_MMU_NOTIFIER into a Kconfig, i.e. > will allow combining all of the > > #if defined(CONFIG_MMU_NOTIFIER) && defined(KVM_ARCH_WANT_MMU_NOTIFIER) > > checks into a single > > #ifdef CONFIG_KVM_GENERIC_MMU_NOTIFIER > > without having to worry about PPC's "bare" usage of > KVM_ARCH_WANT_MMU_NOTIFIER. > > Signed-off-by: Sean Christopherson > --- Reviewed-by: Fuad Tabba Cheers, /fuad > arch/powerpc/kvm/powerpc.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/arch/powerpc/kvm/powerpc.c b/arch/powerpc/kvm/powerpc.c > index 7197c8256668..b0a512ede764 100644 > --- a/arch/powerpc/kvm/powerpc.c > +++ b/arch/powerpc/kvm/powerpc.c > @@ -632,12 +632,13 @@ int kvm_vm_ioctl_check_extension(struct kvm *kvm, l= ong ext) > break; > #endif > case KVM_CAP_SYNC_MMU: > +#if !defined(CONFIG_MMU_NOTIFIER) || !defined(KVM_ARCH_WANT_MMU_NOTIFIER= ) > + BUILD_BUG(); > +#endif > #ifdef CONFIG_KVM_BOOK3S_HV_POSSIBLE > r =3D hv_enabled; > -#elif defined(KVM_ARCH_WANT_MMU_NOTIFIER) > - r =3D 1; > #else > - r =3D 0; > + r =3D 1; > #endif > break; > #ifdef CONFIG_KVM_BOOK3S_HV_POSSIBLE > -- > 2.42.0.820.g83a721a137-goog >