From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB3FFC83F25 for ; Mon, 21 Jul 2025 12:42:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 645CC6B0095; Mon, 21 Jul 2025 08:42:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5F6B96B0096; Mon, 21 Jul 2025 08:42:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4E5546B0098; Mon, 21 Jul 2025 08:42:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3694F6B0095 for ; Mon, 21 Jul 2025 08:42:04 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 8D86614077A for ; Mon, 21 Jul 2025 12:42:03 +0000 (UTC) X-FDA: 83688234126.20.BED7C3D Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) by imf27.hostedemail.com (Postfix) with ESMTP id BF8B14000A for ; Mon, 21 Jul 2025 12:42:01 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=cv3vsr+y; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of tabba@google.com designates 209.85.160.174 as permitted sender) smtp.mailfrom=tabba@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1753101721; a=rsa-sha256; cv=none; b=UPdcsgY4IyPEDPpIcrnqgCt6rTb+HGxFC4WZPMrOTSPdxSWPeZKigGfQjOZBh74Jid15Xh W5YShM37CYmOgQ8OU78Bozj73xArd5tpur45PaLvjM/zTAfRLdcN2Y7P/Vf80N9LKf3MLI j3E5hmIICH5xPtzAGXCBFG52QCAEVJU= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=cv3vsr+y; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of tabba@google.com designates 209.85.160.174 as permitted sender) smtp.mailfrom=tabba@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1753101721; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rIS8RtGx3BM3yP3QF7bgfk7fFz/ztOEu+IhwOpSASZw=; b=OxOCGimwA6X96YV3JGEvk0+GsF3sqT+dEqY82qMO3JzFT3XfIqjkUtnAU36YySyGl5x+rE v7XlecrwrfRWWAQVIqKs03bp5gwn1Z+QPZp3hgoxsTiPEbyj7ETOGAvUu6csMEoDhBSmU5 svXWsjt0KZvToOcOLAf1K2oN0gS0Bkk= Received: by mail-qt1-f174.google.com with SMTP id d75a77b69052e-4ab3ad4c61fso713491cf.0 for ; Mon, 21 Jul 2025 05:42:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1753101721; x=1753706521; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=rIS8RtGx3BM3yP3QF7bgfk7fFz/ztOEu+IhwOpSASZw=; b=cv3vsr+yAbYVvgo6Q9RjjKg0DIQMgUxMxTZLiPHOb6PaqgfJayHi1pUmvZpJrVvgCM oMvS2tqjyoxlERRESBOpNJNFtNrT+nSSBw0Ab1dF1Pj0eozLvUFSYfQ8AalnCwFtWTEY /FTeqTFrzdDKudhS8kBdfocJjvWZZx3RxSvh5Vx9I3t43CqgpRITD2alC/xZfG++logK zQgIp8lhz9/yx9RMJUTUcsQJa81a5Zc7wlc3+sRQHtlsJ8nOqG3TjvmclJGdULlgqBz/ +AhLeQ566MIRdfzwZcCYfhwsbbMt1dpADz8td0bylOVmtlV7cFdigxvZKANujieqJaoL /jSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753101721; x=1753706521; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rIS8RtGx3BM3yP3QF7bgfk7fFz/ztOEu+IhwOpSASZw=; b=GGO59zpeVd011EGrI7a7V8eG5MsWP6yYYqVZzmhanxwjNmUCU3BLbFBTOA4UMiKBkM N37tDJom2Ylqv3My0cMN2mq2u/pnjSt4rA0xWOXj2XsPNPuxb8fFrRoTbwHVcBEWd1ol Ishe2ffkN8H841XV6ATNomurtMypp2f//bVW8W1IvAw2uV7AcGdTgR2nI/km/vkuNeJX TtphkMYrn0dFrxThlQrQssT2ZuUCoG/tfHuDLB6gG/z/Mop/WaTjjgWh9o9aNJgJv/gR Ky8CiUnUhsSPIsBuTVwyX3SSGQ9Ca6kctajfceXJPoRcKfBn9+Zd164wiwx0wfubFl+c CD1g== X-Forwarded-Encrypted: i=1; AJvYcCVHrAhN20ziFLBvW2gSdl8QqY13tHCGoLzvXeH4JnzC1v3gVvfFqVSlfTMDJx3SOD0I8MPnLTHdBQ==@kvack.org X-Gm-Message-State: AOJu0Yzp1DRUFM56XqXD+VRknn8Kaa4d6JB/EYSz+TcFaNSxSNpj4Me0 YvASVhcN8L7uVWgX9FgHwKXKGDlETKRxX/1AeiGO1jwCxzxssUF+won9SVU9v02MOqOdB3quKuY ibWBNMAAxnbjLV8FsYV2v7xYqLlEf0NBBHVyEav6L X-Gm-Gg: ASbGnctpLzmqM7T7DKE41GMg/2IvOZjj6plrZHX7vP+5SwNZ6lDV7wk+7qzeOs3DzNZ 9AdBHpLsAePIat8YShrx5qihiCB3s48MYfMJHVmG3SlNNF8jgFzEDw3rrBYnSp+a3JqTv4BRaUR 06NcnVzWg4OxkrQ4hIzuW9d3EC9FO5W6TBlDGzAnThc6yV94sHhNm6p14lfhsixQC88Rw8WiUrd n51EMQ= X-Google-Smtp-Source: AGHT+IHICvOHUdMlgc+MwG4TRplOdK0+NsvYnQSN7a8Q94vN9K19Iv4njTMi3Vqu6DpIpL1LZ7OPxQ3JKDjs7jxoPb4= X-Received: by 2002:a05:622a:8c19:b0:4ab:54d2:3666 with SMTP id d75a77b69052e-4abc2b37a63mr6227901cf.25.1753101720495; Mon, 21 Jul 2025 05:42:00 -0700 (PDT) MIME-Version: 1.0 References: <20250717162731.446579-1-tabba@google.com> <20250717162731.446579-15-tabba@google.com> <505a30a3-4c55-434c-86a5-f86d2e9dc78a@intel.com> In-Reply-To: <505a30a3-4c55-434c-86a5-f86d2e9dc78a@intel.com> From: Fuad Tabba Date: Mon, 21 Jul 2025 13:41:23 +0100 X-Gm-Features: Ac12FXwLO_dne2w1dGUUYLFktGe9s64wr0cEuXbxIsFFA8S3s8yrvlEfzoVjAQI Message-ID: Subject: Re: [PATCH v15 14/21] KVM: x86: Enable guest_memfd mmap for default VM type To: Xiaoyao Li Cc: kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, kvmarm@lists.linux.dev, pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, david@redhat.com, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com, ira.weiny@intel.com Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: m4y7rgpyjcqdktosw79ai7mb15emg37c X-Rspam-User: X-Rspamd-Queue-Id: BF8B14000A X-Rspamd-Server: rspam02 X-HE-Tag: 1753101721-413825 X-HE-Meta: U2FsdGVkX1+jEfbZ5/B5yzvP9wPF6FlQPu0xRID5SGOA0BfOAkBu222xXZCdAitA6xOOX6rTSN3725a5FEvseS3Tu+75az0biua691+R0hQoCM5Tuq+sTk32/52uPE+rQkQARESYMQ8rLU97dS2wK8rZ+lTOtppZ8WIeFnbOAFniC6tFf7uWoSMg5eoKppfX6g6nh3lghwNxToX9xcqQhYT73rOdS6I9vttO+/GNoPcHLTkodYFUPyVTl9kTVgFTqmgVJZQO8xp0zsMLKia+6sF0kFKJEsvssQBBu+fVF2wRHtVP4O9CVuMD0B6ebaUkwDWo632zuLSpclPA/OJf7HWLtj9yrZuq9mMo30M+Y9K8RcmzgdGVtzdeMzJS6zHWwojubaooLZyARTdTgMDd0JfR9Ks1gE8TbESg6Ca0xMO6HYSMF+swSpc73d3pMSMSr0M7jXF8lC6fWoSiDj0Rgg/O3UUr/X2exGftW1DFL73hUru6ZZ3CdKLz5ECBZQ+fIHdMkuiQVLO0ZcvMX9FqpUiMfCtngbbnBgJzDdAUU9Komiyft3IRZdbUY8q1nNs5v0puSgyXomNrQZCPe301R37Q6QcNSMmwJzRV02LBy14QxdlZi2aAdIiG3oKtxlBVF2VDmFtfixHw+OJgBG9aNJOABAX94fFPpeBa9OYT/A9Jt1rMEnid0dUJEufGIHjQOPxcM4QrmDBpBkmJaL29QwOMd5cOX6/oXnrlcGD/qjyn347KqxUO1hka27rskyfIYrlwA03EGTzMp9gyBngKxXsyAcJBGuC0fAfEQRtk9szNMpd6w7aIfvUqDNhF6BGDmsZnmdnQVcDpdAfERVUjzqPIQfWnH+wnyaGZ/dW1Ii0W3sJ+gacFPAvLk7ohNjzRwebyQDDI1GfetfgALHNE7cDCD7fa7tqpxxBUYOdSe/6Whim3f3+6BeIrv2VmbJ7q+vT65bZ15QunFCZ71U6 wy49EyLl SYNrzxfLwpDmrjuHhHdKtk+z5qA7t4L5zXr21pne1Bvl2H5SorvWwAtWgjCmL/9RTJcl0DzVRs4Ul0e0v1WEwgIApoQ/STWr1+/34uvj0c9X5/egUdfEzCkss/iQWAThgYEpmv52ea1FMZk8s+4ahpMYn1evNWYBTFKBr+nkQYmQ39wruz73raizGqYwadvNy1Mu4XzxEfqAZdIjQZTjhtwjzxJ7ApqwXVl0x6x1Wr++1A13TpFKXrJ4u0ovjQpJ2j+EsDV3k+ck+phtsdeiVkjHvm8kMxNX1zztlKfqMBY9Vr44= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Xiaoyao, On Mon, 21 Jul 2025 at 13:22, Xiaoyao Li wrote: > > On 7/18/2025 12:27 AM, Fuad Tabba wrote: > > +/* > > + * CoCo VMs with hardware support that use guest_memfd only for backing private > > + * memory, e.g., TDX, cannot use guest_memfd with userspace mapping enabled. > > + */ > > +#define kvm_arch_supports_gmem_mmap(kvm) \ > > + (IS_ENABLED(CONFIG_KVM_GMEM_SUPPORTS_MMAP) && \ > > + (kvm)->arch.vm_type == KVM_X86_DEFAULT_VM) > > I want to share the findings when I do the POC to enable gmem mmap in QEMU. > > Actually, QEMU can use gmem with mmap support as the normal memory even > without passing the gmem fd to kvm_userspace_memory_region2.guest_memfd > on KVM_SET_USER_MEMORY_REGION2. > > Since the gmem is mmapable, QEMU can pass the userspace addr got from > mmap() on gmem fd to kvm_userspace_memory_region(2).userspace_addr. It > works well for non-coco VMs on x86. > > Then it seems feasible to use gmem with mmap for the shared memory of > TDX, and an additional gmem without mmap for the private memory. i.e., > For struct kvm_userspace_memory_region, the @userspace_addr is passed > with the uaddr returned from gmem0 with mmap, while @guest_memfd is > passed with another gmem1 fd without mmap. > > However, it fails actually, because the kvm_arch_suports_gmem_mmap() > returns false for TDX VMs, which means userspace cannot allocate gmem > with mmap just for shared memory for TDX. > > SO my question is do we want to support such case? Thanks for sharing this. To answer your question, no, we explicitly do not want to support this feature for TDX, since TDX uses a completely different paradigm. Cheers, /fuad