From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24F1DC4332F for ; Tue, 7 Nov 2023 13:07:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5F8078D0038; Tue, 7 Nov 2023 08:07:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 580EB8D0001; Tue, 7 Nov 2023 08:07:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D3AA8D0038; Tue, 7 Nov 2023 08:07:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2C0C58D0001 for ; Tue, 7 Nov 2023 08:07:58 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id F1BA91209CE for ; Tue, 7 Nov 2023 13:07:57 +0000 (UTC) X-FDA: 81431185794.06.BC3BFBC Received: from mail-oa1-f51.google.com (mail-oa1-f51.google.com [209.85.160.51]) by imf09.hostedemail.com (Postfix) with ESMTP id C4D0B14002B for ; Tue, 7 Nov 2023 13:07:55 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=X+bRsUbs; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf09.hostedemail.com: domain of tabba@google.com designates 209.85.160.51 as permitted sender) smtp.mailfrom=tabba@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699362475; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7VRoxoxM3bk/ddMYA7RkVxhIt7sN32CxDfhJasXbdTQ=; b=hQeiFwkcmUQGO1tw+oLC/lc6eV9TKYEc5RscYzr7OaFASoOVfpGblbyuGhB3MG9wplnGub q/oJ4bOo7lLc6aE9Z9B073l5mzWkAQkKFqBhUrM5EAcCpIKKLDyZcsfIfApi8s8uZsz0ko w40fSmqI08Qria84MInsSmglRuoM0O8= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=X+bRsUbs; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf09.hostedemail.com: domain of tabba@google.com designates 209.85.160.51 as permitted sender) smtp.mailfrom=tabba@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699362475; a=rsa-sha256; cv=none; b=lR4XeJWD7yRIgAVOamNulpeT5gN3q/fl7/UUNSeqi2uNaflz2Sp2bNsqJqeSpim0oxStoG oPhAZ6ZVfr3VMUZKOAzZWZD2+LS5oIZdbYIkZNHKn00K0Tz6j/57dU4AhTJexF6d1Q6kvd cb6LtNZ8ZJX37YqxT76hOxH79LLpKpU= Received: by mail-oa1-f51.google.com with SMTP id 586e51a60fabf-1f0f160e293so707431fac.0 for ; Tue, 07 Nov 2023 05:07:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1699362475; x=1699967275; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=7VRoxoxM3bk/ddMYA7RkVxhIt7sN32CxDfhJasXbdTQ=; b=X+bRsUbsmYpJ4AZABjUd0/cemkqpQ086/A24tVddVX54qwRWKAoNibIkM+DxnUxMNL 9nivT+2yd9Cvk6/+O/k3CEzHzuUTREwLE+Q+CoLENwNXH5UnYrS7hYH9uiurvIF5Bm2H +vfdYQlrtJqCbqY4MewtsnpaWJ1g49TNtNUBtfXnn+cXgjEPm0GpLXBCVVVrD292UojD WEIEGaYKIFQcbmnteWDMU6k7oDONK/e1WO9QZIRuHf9gue+L6YINJ7jocwvE1vY86MvS ED+mpee8/ftPkWs8A1iwaIqVnbVuDf4EJhImf7wFX1r+PhuDfaHuACTcVFUTm0zRfWfo iG2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699362475; x=1699967275; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7VRoxoxM3bk/ddMYA7RkVxhIt7sN32CxDfhJasXbdTQ=; b=ZfR4wnlWlUQ7yKOtybePJLEz+P2ugcjAhR2jzPPIU1lejdNtU56XBcH3p7okSA7B9D xC+6+G4312iq235QB+1iGRfcjpgjQLQlD/NdfOrO2ZqWE6qKBEt0/cVSbMPMQYeN9B0p NgMw3yzpYbFkDfahBYjyUXX6CCyA+QKbIe9xyc1nROFBpfVUOUSu7surYWynM32d7r7v SqAZRZeEZrBVmYRSZyEyhT8gD2fhoHC69gGCwnapPgljz1r8Br/He2Gnb5nXKP/OirBx cQK4uBQ/fPubyCRZyGPxJ1eGsDeQxOIVeZJzjjU300bWT+pQlXMFpPes72LPHuHs1dpo S4eQ== X-Gm-Message-State: AOJu0Yzn3XZe8TEsJuIxmorYmwlLtzpurYDfpcsZCgnrHmmqJXkXEwuO RH8qbvPNsVxmVVTLDSYHC/+1MPeNdbijpi+HhXvlEQ== X-Google-Smtp-Source: AGHT+IEc/OoLKiW5UzIza8k0AJcg/cvGrUiQc/SGatsr9amhK5Gck/VoGoIGcZKiRYhIoVxvQmPBVV/w9nNgSokWHaw= X-Received: by 2002:a05:6871:3227:b0:1ef:ace4:f360 with SMTP id mo39-20020a056871322700b001eface4f360mr2023903oac.17.1699362474620; Tue, 07 Nov 2023 05:07:54 -0800 (PST) MIME-Version: 1.0 References: <20231105163040.14904-1-pbonzini@redhat.com> <20231105163040.14904-33-pbonzini@redhat.com> In-Reply-To: <20231105163040.14904-33-pbonzini@redhat.com> From: Fuad Tabba Date: Tue, 7 Nov 2023 13:07:18 +0000 Message-ID: Subject: Re: [PATCH 32/34] KVM: selftests: Add basic selftest for guest_memfd() To: Paolo Bonzini Cc: Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Sean Christopherson , Alexander Viro , Christian Brauner , "Matthew Wilcox (Oracle)" , Andrew Morton , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiaoyao Li , Xu Yilun , Chao Peng , Jarkko Sakkinen , Anish Moorthy , David Matlack , Yu Zhang , Isaku Yamahata , =?UTF-8?B?TWlja2HDq2wgU2FsYcO8bg==?= , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A. Shutemov" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: e8tsr7ppsdxk5b36nnicwutbgikuk8j7 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: C4D0B14002B X-HE-Tag: 1699362475-754412 X-HE-Meta: U2FsdGVkX1/7BuEIiF+b8CfyHCdaFIi4bO9Heb8kQ6wAje4r5ANn0WezTZyWr32MMJJtP+x7Q7/NjDVwGZQESiS02cJSC77H/UEnb2l9FnPqv1hGqOFGT8Zi9WQrZTQq+XZ/TyIgIe+35GqfUEwL6yreo1qoSStPX7gg7TRy6m4aOM/Qvv5KX7dGB0gKfItgcDtEBnSHCtlH8/kmcCU4fkpQxy/cRFTr8nGM883U4mJsWi6XG+N4PR+n5lwuTiiQIp7/cAIqSlLFqbmhTrVZXl8n/DcyhCmB7JCOK7XpFtvIqkZdp5TS1cYF/N+mVqlqqAHSPS1tNUyvjHauN12AvtZx0WoO25eGksHAnupk0cirM3PxWLsMUeK/Z3qCxp7bcn9QF9hUZua50fJoxik4xQQtZa66+YzUM8On/AKVLs8FqApjB6aAnFFZMdO6G0wbOu+7hSXxrSENONJLCj/KhpfsOkaaU/qgBP+Z9HgYSJ/ziegm55bE8wVuAWMEciYtouQLLCzUuR85yDo0kLAgFljmabnAn1EgyitykB6oKS8OFMcErHQwN3Wfgm+QV3xTcFpQXjff09rS4B7ypVqAk+Zd+WW2cfTQmpkv2uPowN5kyZln7pwikJSr4U9GgQoR+lc9mrBuGcb+5nhBttx+afSnp9hNzNQgjhUEpCbDM0hCx/Ohmpj6M+HnLvMP2YwU0vy8SYk72//kzWE87i3g/2zhsjuX/3R0cnMGbDhEiKGeXEXES0OJs4VKaVmN94S2ouZL36pNcAObs9tpUCSU6QKBgLVucpVlHXKvvJpBsCGQ+zIklflCS2WnSj/k8kXIoeCDEoCoPQhJ1qPtkvSdqQsPlB4Susc6O2W/lKX6ZsIQ1/Ys4pKNXSTTv0gilTTLEXH6EO4Iq7HGHpDQjBAJL+OT60OKGUNH/lWd/kNMPjq7cac6CjhKVWysneDghUd4FZRsL3ucQShaKtvg0Tn ybY8L6kt Jfh4Atpqte0iWzqncuBawN888rbf0RObn0QgsXHu0KPpa9n9Fnb2V+er54GqTnSDbv6K61fcN687OUMJcoXZt0g0qUMF0qRnPI8ldyUkNmcAGndGs7zkqxG+irCwA+SUHvv835+afNahpjZ9hbYn5JwQo3r7gZl48yj6704RDTyQv0QDrYmhngnqWomR8ku2k5h4rwgPhc/AhAW9ULaPrsOWqGD1f+wgULc62g8eLcR8r8uPjAd0pu+vrg0e5hWRbWyk9/TjLl3kRQORmyBZAH1mwsApILY7/0BozXCwsuGXRVAPcOHI8phPgyEEl5o6wkcJmRi722gAKleRvNokXD9oOALgLdeqYrJkuuVNyNch+eepYe78Csm7SObeA9UzU7CjECdE5oLZtPfZGLnvmAIIxCb7gfoG+GZJL X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, On Sun, Nov 5, 2023 at 4:35=E2=80=AFPM Paolo Bonzini = wrote: > > From: Chao Peng > > Add a selftest to verify the basic functionality of guest_memfd(): > > + file descriptor created with the guest_memfd() ioctl does not allow > read/write/mmap operations > + file size and block size as returned from fstat are as expected > + fallocate on the fd checks that offset/length on > fallocate(FALLOC_FL_PUNCH_HOLE) should be page aligned > + invalid inputs (misaligned size, invalid flags) are rejected > + file size and inode are unique (the innocuous-sounding > anon_inode_getfile() backs all files with a single inode...) > > Signed-off-by: Chao Peng > Co-developed-by: Ackerley Tng > Signed-off-by: Ackerley Tng > Co-developed-by: Paolo Bonzini > Signed-off-by: Paolo Bonzini > Co-developed-by: Sean Christopherson > Signed-off-by: Sean Christopherson > Message-Id: <20231027182217.3615211-35-seanjc@google.com> > Signed-off-by: Paolo Bonzini > --- > tools/testing/selftests/kvm/Makefile | 1 + > .../testing/selftests/kvm/guest_memfd_test.c | 206 ++++++++++++++++++ > 2 files changed, 207 insertions(+) > create mode 100644 tools/testing/selftests/kvm/guest_memfd_test.c > > diff --git a/tools/testing/selftests/kvm/Makefile b/tools/testing/selftes= ts/kvm/Makefile > index ecdea5e7afa8..fd3b30a4ca7b 100644 > --- a/tools/testing/selftests/kvm/Makefile > +++ b/tools/testing/selftests/kvm/Makefile > @@ -134,6 +134,7 @@ TEST_GEN_PROGS_x86_64 +=3D access_tracking_perf_test > TEST_GEN_PROGS_x86_64 +=3D demand_paging_test > TEST_GEN_PROGS_x86_64 +=3D dirty_log_test > TEST_GEN_PROGS_x86_64 +=3D dirty_log_perf_test > +TEST_GEN_PROGS_x86_64 +=3D guest_memfd_test > TEST_GEN_PROGS_x86_64 +=3D guest_print_test > TEST_GEN_PROGS_x86_64 +=3D hardware_disable_test > TEST_GEN_PROGS_x86_64 +=3D kvm_create_max_vcpus > diff --git a/tools/testing/selftests/kvm/guest_memfd_test.c b/tools/testi= ng/selftests/kvm/guest_memfd_test.c > new file mode 100644 > index 000000000000..ea0ae7e25330 > --- /dev/null > +++ b/tools/testing/selftests/kvm/guest_memfd_test.c > @@ -0,0 +1,206 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright Intel Corporation, 2023 > + * > + * Author: Chao Peng > + */ > + > +#define _GNU_SOURCE > +#include "test_util.h" > +#include "kvm_util_base.h" > +#include > +#include > +#include > +#include > +#include > + > +#include > +#include > +#include > +#include > +#include > +#include The include ordering should be fixed. Otherwise, Reviewed-by: Fuad Tabba Tested-by: Fuad Tabba Cheers, /fuad > + > +static void test_file_read_write(int fd) > +{ > + char buf[64]; > + > + TEST_ASSERT(read(fd, buf, sizeof(buf)) < 0, > + "read on a guest_mem fd should fail"); > + TEST_ASSERT(write(fd, buf, sizeof(buf)) < 0, > + "write on a guest_mem fd should fail"); > + TEST_ASSERT(pread(fd, buf, sizeof(buf), 0) < 0, > + "pread on a guest_mem fd should fail"); > + TEST_ASSERT(pwrite(fd, buf, sizeof(buf), 0) < 0, > + "pwrite on a guest_mem fd should fail"); > +} > + > +static void test_mmap(int fd, size_t page_size) > +{ > + char *mem; > + > + mem =3D mmap(NULL, page_size, PROT_READ | PROT_WRITE, MAP_SHARED,= fd, 0); > + TEST_ASSERT_EQ(mem, MAP_FAILED); > +} > + > +static void test_file_size(int fd, size_t page_size, size_t total_size) > +{ > + struct stat sb; > + int ret; > + > + ret =3D fstat(fd, &sb); > + TEST_ASSERT(!ret, "fstat should succeed"); > + TEST_ASSERT_EQ(sb.st_size, total_size); > + TEST_ASSERT_EQ(sb.st_blksize, page_size); > +} > + > +static void test_fallocate(int fd, size_t page_size, size_t total_size) > +{ > + int ret; > + > + ret =3D fallocate(fd, FALLOC_FL_KEEP_SIZE, 0, total_size); > + TEST_ASSERT(!ret, "fallocate with aligned offset and size should = succeed"); > + > + ret =3D fallocate(fd, FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE, > + page_size - 1, page_size); > + TEST_ASSERT(ret, "fallocate with unaligned offset should fail"); > + > + ret =3D fallocate(fd, FALLOC_FL_KEEP_SIZE, total_size, page_size)= ; > + TEST_ASSERT(ret, "fallocate beginning at total_size should fail")= ; > + > + ret =3D fallocate(fd, FALLOC_FL_KEEP_SIZE, total_size + page_size= , page_size); > + TEST_ASSERT(ret, "fallocate beginning after total_size should fai= l"); > + > + ret =3D fallocate(fd, FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE, > + total_size, page_size); > + TEST_ASSERT(!ret, "fallocate(PUNCH_HOLE) at total_size should suc= ceed"); > + > + ret =3D fallocate(fd, FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE, > + total_size + page_size, page_size); > + TEST_ASSERT(!ret, "fallocate(PUNCH_HOLE) after total_size should = succeed"); > + > + ret =3D fallocate(fd, FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE, > + page_size, page_size - 1); > + TEST_ASSERT(ret, "fallocate with unaligned size should fail"); > + > + ret =3D fallocate(fd, FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE, > + page_size, page_size); > + TEST_ASSERT(!ret, "fallocate(PUNCH_HOLE) with aligned offset and = size should succeed"); > + > + ret =3D fallocate(fd, FALLOC_FL_KEEP_SIZE, page_size, page_size); > + TEST_ASSERT(!ret, "fallocate to restore punched hole should succe= ed"); > +} > + > +static void test_invalid_punch_hole(int fd, size_t page_size, size_t tot= al_size) > +{ > + struct { > + off_t offset; > + off_t len; > + } testcases[] =3D { > + {0, 1}, > + {0, page_size - 1}, > + {0, page_size + 1}, > + > + {1, 1}, > + {1, page_size - 1}, > + {1, page_size}, > + {1, page_size + 1}, > + > + {page_size, 1}, > + {page_size, page_size - 1}, > + {page_size, page_size + 1}, > + }; > + int ret, i; > + > + for (i =3D 0; i < ARRAY_SIZE(testcases); i++) { > + ret =3D fallocate(fd, FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUN= CH_HOLE, > + testcases[i].offset, testcases[i].len); > + TEST_ASSERT(ret =3D=3D -1 && errno =3D=3D EINVAL, > + "PUNCH_HOLE with !PAGE_SIZE offset (%lx) and/= or length (%lx) should fail", > + testcases[i].offset, testcases[i].len); > + } > +} > + > +static void test_create_guest_memfd_invalid(struct kvm_vm *vm) > +{ > + size_t page_size =3D getpagesize(); > + uint64_t flag; > + size_t size; > + int fd; > + > + for (size =3D 1; size < page_size; size++) { > + fd =3D __vm_create_guest_memfd(vm, size, 0); > + TEST_ASSERT(fd =3D=3D -1 && errno =3D=3D EINVAL, > + "guest_memfd() with non-page-aligned page siz= e '0x%lx' should fail with EINVAL", > + size); > + } > + > + for (flag =3D 1; flag; flag <<=3D 1) { > + uint64_t bit; > + > + fd =3D __vm_create_guest_memfd(vm, page_size, flag); > + TEST_ASSERT(fd =3D=3D -1 && errno =3D=3D EINVAL, > + "guest_memfd() with flag '0x%lx' should fail = with EINVAL", > + flag); > + > + for_each_set_bit(bit, &valid_flags, 64) { > + fd =3D __vm_create_guest_memfd(vm, page_size, fla= g | BIT_ULL(bit)); > + TEST_ASSERT(fd =3D=3D -1 && errno =3D=3D EINVAL, > + "guest_memfd() with flags '0x%llx' sh= ould fail with EINVAL", > + flag | BIT_ULL(bit)); > + } > + } > +} > + > +static void test_create_guest_memfd_multiple(struct kvm_vm *vm) > +{ > + int fd1, fd2, ret; > + struct stat st1, st2; > + > + fd1 =3D __vm_create_guest_memfd(vm, 4096, 0); > + TEST_ASSERT(fd1 !=3D -1, "memfd creation should succeed"); > + > + ret =3D fstat(fd1, &st1); > + TEST_ASSERT(ret !=3D -1, "memfd fstat should succeed"); > + TEST_ASSERT(st1.st_size =3D=3D 4096, "memfd st_size should match = requested size"); > + > + fd2 =3D __vm_create_guest_memfd(vm, 8192, 0); > + TEST_ASSERT(fd2 !=3D -1, "memfd creation should succeed"); > + > + ret =3D fstat(fd2, &st2); > + TEST_ASSERT(ret !=3D -1, "memfd fstat should succeed"); > + TEST_ASSERT(st2.st_size =3D=3D 8192, "second memfd st_size should= match requested size"); > + > + ret =3D fstat(fd1, &st1); > + TEST_ASSERT(ret !=3D -1, "memfd fstat should succeed"); > + TEST_ASSERT(st1.st_size =3D=3D 4096, "first memfd st_size should = still match requested size"); > + TEST_ASSERT(st1.st_ino !=3D st2.st_ino, "different memfd should h= ave different inode numbers"); > +} > + > +int main(int argc, char *argv[]) > +{ > + size_t page_size; > + size_t total_size; > + int fd; > + struct kvm_vm *vm; > + > + TEST_REQUIRE(kvm_has_cap(KVM_CAP_GUEST_MEMFD)); > + > + page_size =3D getpagesize(); > + total_size =3D page_size * 4; > + > + vm =3D vm_create_barebones(); > + > + test_create_guest_memfd_invalid(vm); > + test_create_guest_memfd_multiple(vm); > + > + fd =3D vm_create_guest_memfd(vm, total_size, 0); > + > + test_file_read_write(fd); > + test_mmap(fd, page_size); > + test_file_size(fd, page_size, total_size); > + test_fallocate(fd, page_size, total_size); > + test_invalid_punch_hole(fd, page_size, total_size); > + > + close(fd); > +} > -- > 2.39.1 > >