From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96F2DC3ABD8 for ; Fri, 16 May 2025 07:31:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6CB096B00CB; Fri, 16 May 2025 03:31:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 67AD76B00CC; Fri, 16 May 2025 03:31:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 568D36B00CD; Fri, 16 May 2025 03:31:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 39F4E6B00CB for ; Fri, 16 May 2025 03:31:56 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 479AF1217E5 for ; Fri, 16 May 2025 07:31:56 +0000 (UTC) X-FDA: 83447951832.19.F66D693 Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) by imf26.hostedemail.com (Postfix) with ESMTP id 6335B140007 for ; Fri, 16 May 2025 07:31:54 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="zYW7t/YT"; spf=pass (imf26.hostedemail.com: domain of tabba@google.com designates 209.85.160.181 as permitted sender) smtp.mailfrom=tabba@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747380714; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iA5Rlo6gvEycOSiSoroWMXnzZM7Pfdgqe3zhq/cG5C4=; b=n6rFtPk9QTXgN3eqI7s5DsMDsHnqSZqEUJpSTtHwGpD+EUPogafzzVA55XNAm73lW6bBE/ dPNxEaJ/QF1HjHupk6SrITdojKEMf2F2+BTYosGx0ZK+2RFDQPnd/bS0YLD9UaCqBEz3bB 4XjDvxuk1QjsmegN/QnYLDXCBOtTm2g= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="zYW7t/YT"; spf=pass (imf26.hostedemail.com: domain of tabba@google.com designates 209.85.160.181 as permitted sender) smtp.mailfrom=tabba@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747380714; a=rsa-sha256; cv=none; b=kzMxFw4a5LiqRUF6WPbHr/aRKzvg+GTfz2JJS97bffr2db8PX1ZkFaAiq/9QcXN5LUOrZR EQB1y/8//7S3SGUZLzm7Hnvef+89sBRKWFv9jyE+l8S22oMVxfQHkJqGe06KLAN0mU1CCo rkp/75hKphexhpT/ikD64npI0XSyFxY= Received: by mail-qt1-f181.google.com with SMTP id d75a77b69052e-47666573242so249371cf.0 for ; Fri, 16 May 2025 00:31:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1747380713; x=1747985513; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=iA5Rlo6gvEycOSiSoroWMXnzZM7Pfdgqe3zhq/cG5C4=; b=zYW7t/YTuOe6WqAdOrht1IJtWE9NNuZkuoMgJ33E2meKL4AMm4LWaVZEW0wzFXcqnp D9ZGl4UUdhVNVdNgKNZzDrTLAP+RUAhjrKwIusSbUm1bcGZpr7a8H+Fkf1Vnq2RmvSro /iTW9RJkfMV78vF7Eb3FnKMP97mxyw7oI2Vyw8UM26RarxWeadYHS79LDRuEzIaru3QA DWp7RSEVemBJPiI1Yvcy9/fxIAhLLYxKl/RguNPreVfzTUN21bIT3def1cchse43q8es ftxABruEQ0hsvD+1Z5gdjSXcxMwaZhZuXJGOXK8mlE54+K6bet+VESiX9PTtlRU0Shv8 Se2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747380713; x=1747985513; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=iA5Rlo6gvEycOSiSoroWMXnzZM7Pfdgqe3zhq/cG5C4=; b=ad5/gcrqi89yF3JNFJSSR4vgjRRxGuI+VJfv2D9fAV8Ji9uhQgBVaqXksrtB4dU1pu gLnJZbNdupkAZurhGV+ljAuS9KQxuNz341INo2kludoji4cO34qvHTr6nMbUw2DVJaXG yu9HIoMo5wwZIkeXfn+68LsTTiDM6r0jtw0ybCts6ErjlnbCy7+JhVVYDxPXKkTUMBmk XENNG+451n9tGoYPBO1vPwtjdgvhG3EwMNAyiSFxP3BR9NGWp3PxFodmb92det07Dw/U L+XuxKLt2aip1TbXNYUSqVBBm5uTGGROfZs1np6z9ehknYlQyWlWLiyHiWBGfrn3kuSL wlzw== X-Forwarded-Encrypted: i=1; AJvYcCUFrViLWNxnYguhr5ogcgwDqW2W5TK49TCMQoxj1Y6NQAi2eMuUdo7kXFV5QNkHnYX7pXvW5nQ0xQ==@kvack.org X-Gm-Message-State: AOJu0Yy+4Dw91bpcYHJUSY8pSLZtDbZApVy02vIwVy0JdE+sUDne+cA3 k5BJ1s9Mb7VIMVaJ6pNAH1I7cNZv3cP6fJI1Fxv1Olu7weFcAXegeWQvnrMc9/O9dAHSkFw6zM+ tQ05kJEB/p1Z7PtNet8fOpSqPtL4s69PqA52xdF7u X-Gm-Gg: ASbGnct2Ndv46wKRh3rqVXUf7KLRjR7rQxT8C1XV6wuy/MEypIBIVDwWD3cTWm8SHwn 5MONgxQQCljbn/tmokQSDV2n/LhS+aNVdrYmiPjWO9jnvs+0tbfexDCotwTL8HB9Tjm1ScJzAGi ksneFOdslEe83iwUIomG68nQTEVZ6r3g9IcfxfrubAOXrb4Dtn1tfMdEO7SudainDwRU6L3Q== X-Google-Smtp-Source: AGHT+IFxiV5iPu5dQEBJoe6TlPITSBOzNWDezJ/h5fJxvEvCNoIQw1B7R4bYKnaDO/kUBLpxtnmGTwV6DQlu2P800G8= X-Received: by 2002:a05:622a:13cb:b0:472:538:b795 with SMTP id d75a77b69052e-494a1dceb95mr7011001cf.22.1747380713230; Fri, 16 May 2025 00:31:53 -0700 (PDT) MIME-Version: 1.0 References: <20250513163438.3942405-1-tabba@google.com> <20250513163438.3942405-8-tabba@google.com> <9a2431e0-252d-41c9-a91d-9e02a8779e8c@redhat.com> In-Reply-To: <9a2431e0-252d-41c9-a91d-9e02a8779e8c@redhat.com> From: Fuad Tabba Date: Fri, 16 May 2025 09:31:16 +0200 X-Gm-Features: AX0GCFtTFrYptZZw3YHVysqXM1_O1MRDVTMCRaXQ18VXjYBBDwJ72qpImK1p7N0 Message-ID: Subject: Re: [PATCH v9 07/17] KVM: guest_memfd: Allow host to map guest_memfd() pages To: Gavin Shan Cc: kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, david@redhat.com, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com, ira.weiny@intel.com Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Queue-Id: 6335B140007 X-Rspamd-Server: rspam09 X-Stat-Signature: rdf4aum74sszxc4nmrxdkod7pwz5xfnk X-HE-Tag: 1747380714-431145 X-HE-Meta: U2FsdGVkX18wyj3g9MXzl9H8MJWVLSqbprDo+lCJ/F5sXS+inr+S06IvDbGu6tRtzQcVNu/c5+2/dzAaQ6xP9XnoIQY5wuYSgwwWJidaLUk2tZThWR3RV8Kn+4eyJHvPHqzuFUFb2TOtT6GIXyKwvfT8tV369AqmTAQJJj0tDBNfRbRa3JF5vplBfSLmR0QsXQaXeVzVt1bN1RCXhPlQQhI8G2Wk/pttDZdzWbnq47pJBc1SyZPR/M7RPqikafg4w34RlVFasZS6WOqyKQ/UCtF7BFz/BnfgycwCRWz/JWZGy3jTDHgyHDHDr6ypee+H47YUzyaXt3HzIKqmN6abUQxD+TzEmyLVDiDqAAVJbS9V49wzDsGMo1SDRthG5ds/XgmxB7vdTA8CxvBbj+inaIHngywrJ6Mbp3DScqre43ZKaNXSWMbqSKs2Se66pSjfOdZZab7/vlgJyDTSDNhVcg6XgKT0B+jzPWzGVPasdHHsApNgxLozseNqn4YrM3wkl0WSwDWo3bviVybPnGwZTTd+US/6gqpZgLwTaK6sTeRn9oXnqbHR9un1R384G7db2scc6Fc3RsAysbyHxrf9ZHyYnrdT8rnqs7s/toyV4j+ezhWvZ/UpoVq0VGX/rU8hL5OqRlro7qPX1S5WgZo+oLkzH1RpOhksdQKhXKcmQHiesAVNqDbs1Iq6bWZ8pX+Dgdx+wmRcL/JkBUcBNMwo3P1ZPtuoKZkV5Y9vp9Jxc6wUeEDq5sfUI8/NgpD1Gy+fzxQErf3s5uy0ZSjgxMswt4MHQo56yrfrD/bzKYV7tq0Vz7FoRa3TSScpP+W8WWRZVulslSRlaqWha/gbWddzt924Xuai+wOcHoQvYiFG5u9o4ZHjnM2/1vmF/8S2tXsQRsksVrSM3OnpwQlIKLh/7wOxDnRJmp6hWc4BNdeiIylMnyY7oeEewd7vCAgynRp11iciiPf85BmaFAVuLlZ bNTnMxF1 AOGfktCtX2cQgCBZOnZzjdS2EDXKWwu2EQH3MbZWr+ybg92mrRLj9GRwc5Jym1BdP8wIlPot8XU/QpNDldHm3tV5W8KmueCslvsfTNm/xxEDmClFAIPDfsvzLQZOsSO0RixbzoRaPe+qLXfTY3Ei125BUKnhLoT+JYH4+2ZV/4aFHKAqXGOQHq4LrV4Sxgvbi0wddFOU9rFk7Xqfc0KpNjAfNT6lxT5L1/OWR75bwyoXrGA1jleLDVSqed/MmbrbByI17vRWNHw6gtZQMKBfhPvbpIYaGUJWdc0VhRtVo+xu7dWw53E/+NhP3qZRdONjtELfqZMseJkCW4kQ+0Fl1LCEsdefsM29ci5L1z0D1KuXhrE8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Gavin, On Fri, 16 May 2025 at 01:42, Gavin Shan wrote: > > Hi Fuad, > > On 5/14/25 2:34 AM, Fuad Tabba wrote: > > This patch enables support for shared memory in guest_memfd, including > > mapping that memory at the host userspace. This support is gated by the > > configuration option KVM_GMEM_SHARED_MEM, and toggled by the guest_memfd > > flag GUEST_MEMFD_FLAG_SUPPORT_SHARED, which can be set when creating a > > guest_memfd instance. > > > > Co-developed-by: Ackerley Tng > > Signed-off-by: Ackerley Tng > > Signed-off-by: Fuad Tabba > > --- > > arch/x86/include/asm/kvm_host.h | 10 ++++ > > include/linux/kvm_host.h | 13 +++++ > > include/uapi/linux/kvm.h | 1 + > > virt/kvm/Kconfig | 5 ++ > > virt/kvm/guest_memfd.c | 88 +++++++++++++++++++++++++++++++++ > > 5 files changed, 117 insertions(+) > > > > [...] > > > diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h > > index b6ae8ad8934b..9857022a0f0c 100644 > > --- a/include/uapi/linux/kvm.h > > +++ b/include/uapi/linux/kvm.h > > @@ -1566,6 +1566,7 @@ struct kvm_memory_attributes { > > #define KVM_MEMORY_ATTRIBUTE_PRIVATE (1ULL << 3) > > > > #define KVM_CREATE_GUEST_MEMFD _IOWR(KVMIO, 0xd4, struct kvm_create_guest_memfd) > > +#define GUEST_MEMFD_FLAG_SUPPORT_SHARED (1UL << 0) > > > > This would be (1ULL << 0) to be consistent with '__u64 struct kvm_create_guest_memfd::flags' Ack. Thanks! /fuad > Thanks, > Gavin >