From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 068EDC02194 for ; Wed, 5 Feb 2025 10:08:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8B492280008; Wed, 5 Feb 2025 05:08:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 863D9280004; Wed, 5 Feb 2025 05:08:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6DD7A280008; Wed, 5 Feb 2025 05:08:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4E58B280004 for ; Wed, 5 Feb 2025 05:08:02 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 257D7C0A78 for ; Wed, 5 Feb 2025 10:07:57 +0000 (UTC) X-FDA: 83085464994.20.7DAB11B Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) by imf06.hostedemail.com (Postfix) with ESMTP id 4025718000D for ; Wed, 5 Feb 2025 10:07:55 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=q1nrxHMk; spf=pass (imf06.hostedemail.com: domain of tabba@google.com designates 209.85.160.169 as permitted sender) smtp.mailfrom=tabba@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738750075; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GgieNQDWbe6UJ/a3VoJuSb/hrlwJAKxq/2FZo7aK9C0=; b=eZ59qAqrzmQBgiGXEYLsl1ACT9jz9YH9qIYynKQRnFgs1ycQxbHmsco5PhpVljh6uy0uY4 N57/n3oG+Hw3YVIy7sqCUI8eSx5W6QgGZUbW2o6utbn9Tbh7aNzGCRu4TfNUeoppm6Sv9c 1lwcgJrK7aB93crm+fAzOmMintqnw0I= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738750075; a=rsa-sha256; cv=none; b=o722qjU5mmhAdOkDkSDORi4EBq8t8x1buuyL+/IQjPfHr3pqy+oA0pz4ZuFZN1NMthv54w dn+sg6bm14d1mbDx7IVatV9IGemZ+0dLgqwP1eUSINc/T6AzJ9bQ4X5CHZC157yf0K5EYf FAwjg+3Me3Ue68VfARhZQq0JEQKpIlE= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=q1nrxHMk; spf=pass (imf06.hostedemail.com: domain of tabba@google.com designates 209.85.160.169 as permitted sender) smtp.mailfrom=tabba@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-qt1-f169.google.com with SMTP id d75a77b69052e-467896541e1so560161cf.0 for ; Wed, 05 Feb 2025 02:07:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1738750074; x=1739354874; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=GgieNQDWbe6UJ/a3VoJuSb/hrlwJAKxq/2FZo7aK9C0=; b=q1nrxHMkKIZA4aT7b1+DvF+r7WQM8oRgZw7N1nJ4og/tRM+u8bqQo2V3RUcEX8mRZB XrVLHpinmYD9b7LoZjk7aIkBSxpr9iAHfnYSECLMmn1BwgfZ8Qm0VZ0KQIjueYEVdUiy KH1/trMalMfMGMUQLAWAW5hTa2OOH4DjvizngMAxTJm7ZSH1VG+Y+IcQkS2TPh+bPQ5t y0MFIi+o0xD9TnmDWdFzfjwqHEvZCqjvvXuSW2Y1qVkK8Fs+QQrtYExsxsT9Efb+6gMP Zlm1nk3BPtaLno6nOz5gOA7FpECxiRBC7+6tJcnMCojczwOGQOcH0sOnCc92sb1DCVy8 rggQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738750074; x=1739354874; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GgieNQDWbe6UJ/a3VoJuSb/hrlwJAKxq/2FZo7aK9C0=; b=LEMK5AC5rEmDEzEvhocA/7lm84OuwuiXdnlI8V9Au2d/6H0yCeDXrAuD8iia6hA08S UsZs0aUqfRGYAVUL+VRLCvTyN3vgjDP21Yf6rdMpuPhIn6sSdAkzE5u0g8Y6ebHA0+d1 NEFx87eCxJkSowPl9jUiH/trr/2v3gcTo5Bp1SPat/ItfxDttN9kU/NmuKYm/2wsgIHv O0cfkt2vMBgZLQEISKWOXqQ3EtpwvOVltAdTVFoK0fB91v/sCwVds47vLLMipv5V/HaK FMm+Sh4cwe+0j12ypBDd6g0WZYDOcEdLiUd2mpQbUkoluYPF9nN6xvSapZhH0//2VmNY SjiA== X-Forwarded-Encrypted: i=1; AJvYcCVsFPMsIsNgi3DJSf0Dh5l/RNJ1KgOiBDJgACbmVjwhdbGpAxL83KL/RKN0U2J1fk/3D4fnt3nFLA==@kvack.org X-Gm-Message-State: AOJu0Yx1j7uRm/6Iw9WjVdHM6MQUnjVdmBRY2JPfU7X9JMTCsN1AuZnm MFGLY0vLC4HqEKEgcsFpAsMNUbUKuiaFRM/MddhD9B8SublZ7LJwDZnp7pK3IZ1Tk2D9FyR6oay WU7C/wnVlsxXlczSfrAElvloi8PT+VeXa6v+e X-Gm-Gg: ASbGncsvGftP4cn9PO4YSCQ15I7JmPIxKTlLHQfeI/cGH3B/A1xk4TG693H61uSSlMu QhbpBOwacdYg8kpLvmUNiooGucLcU/Pn8MKHH5FSPA98CO2owIuBXXCJAzC3d727d0jPU9h6rkc 1ofbEzVuCdroRNWCdprAZWprT71Q== X-Google-Smtp-Source: AGHT+IG4G08H6SaXBG9SJQq4wOUQkHhFq5TVkaTFoYC9nSvxNxVx1eB6lZEAlM3Dy7awdhwgGaeQi6Fwr/JMOjowJPA= X-Received: by 2002:a05:622a:34f:b0:46c:9f17:12dd with SMTP id d75a77b69052e-4701ab77f50mr7422001cf.19.1738750073369; Wed, 05 Feb 2025 02:07:53 -0800 (PST) MIME-Version: 1.0 References: <20250117163001.2326672-1-tabba@google.com> <20250117163001.2326672-7-tabba@google.com> In-Reply-To: From: Fuad Tabba Date: Wed, 5 Feb 2025 10:07:16 +0000 X-Gm-Features: AWEUYZkIkkLRXyaTMrVhdDtLzD6dWJnmf8Pfc1flZ135xg6YsQDlRYh3poiT-4Q Message-ID: Subject: Re: [RFC PATCH v5 06/15] KVM: guest_memfd: Handle final folio_put() of guestmem pages To: Vishal Annapurve Cc: kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, yu.c.zhang@linux.intel.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, ackerleytng@google.com, mail@maciej.szmigiero.name, david@redhat.com, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4025718000D X-Stat-Signature: g6wh79p9io95jb8pbss1ocpf3bmkxdnm X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1738750075-950564 X-HE-Meta: U2FsdGVkX1+8vrjHrxYUFQ8bokBRWx3s0YKrfIQeyTJVCjbY9TQJu9PP39D0zZoTSMAcsVGPkqC/NkBpkWM894yxIawqiYxmYl2iQ4kahrIK1LLCg5ndD8Lxs0UOtPHZ/PtKxYCH1gETWeYck/qxDY2YkgtoXHnkt3iyFDzX/3dmABQnwSnTlBOMrmA3TdaRygZsMQe+vr4cbU6SzsN5JBGxbRcuOpXAKB5aEHyNzraTWcd0pdVVhs+jkpUVSlvjfLQFT1CrJJXyeir//WM7APo5eBTRtP/NP7OoF+zHd/rzdZYt37pbelS/gQj773vQ+55O+GkYH8yTWnIl/iVjz9YjtwyT6MC89EYM/2tqBTJuzrUcIR2KjrFCxJIpAYkvgdV3MjVFTPG+2lDoCOsV8Radg/a3faL5acJE7CIq/QEmOHWwImxwvBvoxbNGq/VyYSGJ+T9aRh/VhzXBQ4xf2RLeO5GwUjz/Los3Zif/cE05eNAEdFtUUCoLf52QL0W6EBuetFl6Ev9/MIx0kNTmdPofOj6GqYiaFRidoDIqo0kaImJy1KIcorZrihs/LzIumNQfmkJ1LLOKRzmK3UVr8IpY0YRZhhnBdVzGv0T/13sTwDtpNUHyR67TCcW8CFKidKNRvPz9joZIsSHYK3NQ4xdTsSLlE1j9HRxoctSZhAbwy7HbcU84xIytICqz4ZhVInas/OMQV6KE7Af0rrYcjdrsq1dkz0NvmxD1cFWnt/7S3useHArxWhiTM7Er7exXRz1mXCZi6MZQ5vBXisLrc8j+jNM2geAzDjzozY+9ZANn/h5RmhXuWgYWvLyUqkeYRn3mXyMx1/VzBsInoibdjF571v/D1Uso7wNZaMEuiu08UlSMkBdpWmoB42vjXpBLSYg9K90iKziIEazAwfSTlnaL7NB9ZUckdmM65QDFjjVccK9sWGaLG15LCsYlbZE1ak063sIaALZN92t/Z+o 4l8WVYSx FB6uR1PZ60L9Psth1XAk5zt6Ufn0I/lqLpf0X6Zt5a2rkxnDEypDafJiOopeX0eYz3Zc8vOQpSPH+COHBPwxNvF22tyvdeDAu1YxEPWX73YEI+vDSelLGcMFWJrngI/ZPsfIHLuWusV6ZqGKZPucYa9yMhSi4E5gtcEfz9MlKEwinsKSoVmShSZxQnJxXGTWuRHGBT+P9947Jy5UumJCuYLSJhu/0FnTNwBGP/m0p1Yh7u3a1AV9yDeJd+jMnWF0Vky6lsMTi6fheSmzxs8jgeO3C7HwyM7mE3C1E0NfoMBvKRwuOQiin02pzaq9CoABaDUhbwmm7If97JA30RDbZ5dsMYvrOUHYzIZysXBoPqBNhvAYC/h0lO7Ds9OCdgLqiQKWuCuk+h6ry8gctuCickGt2e0YqOKwLOYKBA9B5QM4p+jk+bV/lPRIYnhsjheAlLJVYwgOQmxJE2uk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.054150, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Vishal, On Wed, 5 Feb 2025 at 00:51, Vishal Annapurve wrote= : > > On Fri, Jan 17, 2025 at 8:30=E2=80=AFAM Fuad Tabba wro= te: > > > > > > > static const char *page_type_name(unsigned int page_type) > > diff --git a/mm/swap.c b/mm/swap.c > > index 6f01b56bce13..15220eaabc86 100644 > > --- a/mm/swap.c > > +++ b/mm/swap.c > > @@ -37,6 +37,7 @@ > > #include > > #include > > #include > > +#include > > > > #include "internal.h" > > > > @@ -103,6 +104,9 @@ static void free_typed_folio(struct folio *folio) > > case PGTY_offline: > > /* Nothing to do, it's offline. */ > > return; > > + case PGTY_guestmem: > > + kvm_gmem_handle_folio_put(folio); > > + return; > > Unless it's discussed before, kvm_gmem_handle_folio_put() needs to be > implemented outside KVM code which could be unloaded at runtime. > Eliott's plan [1] to implement a guest_memfd library can handle this > scenario in future. > > [1] https://patches.linaro.org/project/linux-arm-msm/patch/20240829-guest= -memfd-lib-v2-1-b9afc1ff3656@quicinc.com/ Yes, not just that, but there's a lot of KVM code in guest_memdf in general= . Cheers, /fuad