From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB4C1C02181 for ; Mon, 20 Jan 2025 10:43:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 67F1E6B0093; Mon, 20 Jan 2025 05:43:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 62F38280001; Mon, 20 Jan 2025 05:43:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D0AE6B0096; Mon, 20 Jan 2025 05:43:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 2CD196B0093 for ; Mon, 20 Jan 2025 05:43:47 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A4A2AAFF51 for ; Mon, 20 Jan 2025 10:43:46 +0000 (UTC) X-FDA: 83027494452.22.8606CED Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by imf30.hostedemail.com (Postfix) with ESMTP id BC43A8000E for ; Mon, 20 Jan 2025 10:43:44 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="Caj8B84/"; spf=pass (imf30.hostedemail.com: domain of tabba@google.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=tabba@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737369824; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gtyHizTgd9OfFYLkI8lyOfPyBAyYNnRj5gwYAtdvydI=; b=APL0uIeon0z3GOOqWM7NI2snduSfx9p8jFs1zzt9iYWyEQRMx+XRyJYK5fbk0jtG7vSxNL HHPIWU1CJAumIRp6is+9CJu6K7GWgVK8gaG7SmysZA+fOjFmW8l8DHjabuNObFPDWKHBqS L8ut9TpZDD36zqZ2gkltDdn5aV3wj2o= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737369824; a=rsa-sha256; cv=none; b=0y0bqrQgb+y9Nu/X7KO/d3jJH7oMR0Hn+hcJfXKrbPP7rjotjTc7Pz40K9Fmv1+S4SO4V9 rDlV+B2wUiGhvHaMdcjbNj3wFbk7xjbVmKKChmkG9ttILjlw+VhA5nkb+mDjGHRwgucvcn IpQo9ePgguC6W0beUhU7QQlU5HMrMyg= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="Caj8B84/"; spf=pass (imf30.hostedemail.com: domain of tabba@google.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=tabba@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-435b0df5dbdso73135e9.0 for ; Mon, 20 Jan 2025 02:43:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1737369823; x=1737974623; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=gtyHizTgd9OfFYLkI8lyOfPyBAyYNnRj5gwYAtdvydI=; b=Caj8B84/2/ZO1dkMwaTmCTNwUccxmubAQmqYEe5VgMr5GdFoYr6L/ITbyPVQMlJrkt LqIv5eg3dIrqTu0PDudW2vdtviZTiG1RFw74xv+bZZrWdDPiFE1CkaM2bHjFlYCePsX3 uHmKgM+uoGhB59QoX0ipf73WG52itosu0EM5LLcChTVn0dF6Nmz0nrMa2l8blbFYHv7D jYX4JrkxmNTGl78+cUaIMdqBCI8X6mnUdk5489in2tiGOaooCEhfR7YDp4631CTwAbAX 5tVcJNee4TVqGGW8unvZ9kch0dedBpwfRjGmp4rUfPbjuyOXZl/uUt2jaA5JLhu5akW0 729g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737369823; x=1737974623; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gtyHizTgd9OfFYLkI8lyOfPyBAyYNnRj5gwYAtdvydI=; b=mIcPzPAxMMbI7vIjnLye6st++aN42P59l+KxMWl1x0mvA8vKhS05lqWM7zAFmYVBmw h0xbrQMCe7FloLJ1VyzYld929dg0/wdCps6RC0yGvjwjYJJhHAM4ldADqtezPAXSqQPS bo76PjGGeUkFiZ4T9I31XSo+akWve+4E/IYZhSBj288TA6xyew+TcdPI6mP1HrD02wT0 rwdTkrJzOI4rqpM/tncRGo78cgDNa+/wNUsGPZSuz9yxilGuft22pNx8Cy8qHIV/GEPB KB/EgdQSzRH2/2WFyRXEQrBp4gqE+q/YEsaQe2eyA+WNbx1jQsWlaXaxQHdnscPKefSS jDVw== X-Forwarded-Encrypted: i=1; AJvYcCXJa1daiQgipXccMUioQNM2PiOdJVLz15XNZZwN7e0fjl05JudbSeSBt/MBI6qImrcYiXRq0S0MXA==@kvack.org X-Gm-Message-State: AOJu0Ywo337fKUpDODzB6NDC0cPX+n3veWHws4XbNPiW0PhIMqkONuSH TYsncl1NwkjUI8YWy1pNZoAY+Qk+Qyu9HVrbtS5mBsxlTcG43Ovr3kjcaHTDV2nbCC6JVz5dlKS FIMSkX0EAUsDIUSfmuOOqRXJklk0swjuH9Eaf X-Gm-Gg: ASbGnctiwWpjVo8RIZMF+9j/fYwxTHBz1tNcbWR9a2THomCZ6LwRdftmfrsmaPS5oVo P3zfgj/stuJ5V1knAhZd/JcbbVSq5q7WiGRRS6UfSM21Mr1GhCg== X-Google-Smtp-Source: AGHT+IEFtQ6XvmXZuX/8tACQygJkjqQww0pl9ZAAKVz9eTLzDlyCLWLq0l2L6OY8U+uEiBnaF1CwVJq7Ea7mRykWRo8= X-Received: by 2002:a05:600c:3b9c:b0:436:186e:13a6 with SMTP id 5b1f17b1804b1-438a0c4c155mr2424435e9.6.1737369823127; Mon, 20 Jan 2025 02:43:43 -0800 (PST) MIME-Version: 1.0 References: <20250117163001.2326672-1-tabba@google.com> <20250117163001.2326672-2-tabba@google.com> <0f588655-62c0-46c3-bd15-01016615953f@redhat.com> In-Reply-To: <0f588655-62c0-46c3-bd15-01016615953f@redhat.com> From: Fuad Tabba Date: Mon, 20 Jan 2025 10:43:06 +0000 X-Gm-Features: AbW1kvZLQbxvixcsMAGSfw-d4tIbwHt3wKcd2__DJ7I2f8BhUWRabX-EZuB6KlU Message-ID: Subject: Re: [RFC PATCH v5 01/15] mm: Consolidate freeing of typed folios on final folio_put() To: David Hildenbrand Cc: kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, yu.c.zhang@linux.intel.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: yn7wzkguqbsyqrpsmy1epkbds6uaxt7j X-Rspamd-Queue-Id: BC43A8000E X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1737369824-232616 X-HE-Meta: U2FsdGVkX19uiZc8lJQDxf2VWolBA6F4/jQ5hKG3835NJprLT2KmXfXXJFoFWnTZad9hJDDfWCEVR86gpPtpZ8s865i1l+MQDl9qJr9bWcRZQEKW9NqbFMx3WykXUmuQVO8SRTIz8nveCOCsqMZ9ERI5M1q1o/wcZ4qXGGveh5Sl/X/27xsTN6qt8ItFr1EeDPdA3cQLbj1628/myJk+TP/Ww8j+VY92/Kw5QBtq4tV7hzAWrp9xcjtw8rKzsVsRCmGPoyP1dQxHKODExgmvmcUPHOB9I0xk/PjxnR+bTYuakYoLf44BbcswsbXqk8aenI8PsmzfmATeCX+n+fQ76eKPF10ofGA/xiVFsSHra/TRfqZR9VAORrDhyUjeU4jZ1v9Cklsflp8+cjO0b7LlzHYy6toQeIS9a0u9b58Iq3yAfxU7SZFT+y7/DQPElVMhXKJA23PgM56ojoRldDs6uLVVqItQaOkQGrNwlan4GDT/vpucfnHHq4XtlY5tI5/WiPrQGY33FK9mMVyZ7aopubpi61kFuESNhMH4WcVIWmSUrnXFthDWeyL8Lt2tkQBoCAVHE4+3pVcjKfyB+VZnTGCqk1t0O4moCOyDQUMd/IJPafZbcyyXaGZqx52S4RYlbYNXNko8s3zFAMMtnvlfsZFu2zyDemDckPHatEGyUZuCx0rfoy3TuABApHKnpNtdizR4DzQNyYGo5jFPw5h5nk/6hXvwHVFxnMXq8VaFInPsh0Z1a8IwYbwJIWrlXd9L6x29K3pHKDhMZOR+ojDQdUosFfSpMHkuc+7eFMK2n8ByeG50qeXM+mneXndcGsv0yyXNr3XbaP9pyThDEwKxaMotra+nhu2ICuezIACvJDIJqWkpPMloJXMf7Gtdx0JtSNgSKtf2KbtGbXhv7szdC74xNvNannJxpInYgD3yMcJiIT87nRr9gJqpSzU+pkkeSq9yMRrw34DJy+UBrAi zRkEhqOj 5C6JXgRWanxolVun2M9LISLM5PX3CiCgIb7V0B3YKynWXoaWbGX/VJEdAUDl26B5X0zmpWdcewRzJzU3K8ZDxNquFY629yA2r5m2PatNeAIYcv430CsyzJ2Ersdx0clwq7xYd4p0V6AsLUBP2aPNZmDBMEoO4uXiHzVNjYoJx/xxwC4vw4F0+vA9629W/uTHV58VTtBmutp7SEACtd9LzgQzXKHMihCb2TXCIJO1JovuhThHtdpS0A47M/q9JrozTwrbWks0bgQuwLvmQFBRZIU1Ut/f+tNd0wHl9qLfyQp3WuRqSpl1wzEt1Y6NPvUyvx9F3IbZxM9XrhOL0pwk/TI4KJ7Kl+SjYTtVfJqEj9uQU5YE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000362, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 20 Jan 2025 at 10:39, David Hildenbrand wrote: > > On 17.01.25 17:29, Fuad Tabba wrote: > > Some folio types, such as hugetlb, handle freeing their own > > folios. Moreover, guest_memfd will require being notified once a > > folio's reference count reaches 0 to facilitate shared to private > > folio conversion, without the folio actually being freed at that > > point. > > > > As a first step towards that, this patch consolidates freeing > > folios that have a type. The first user is hugetlb folios. Later > > in this patch series, guest_memfd will become the second user of > > this. > > > > Suggested-by: David Hildenbrand > > Signed-off-by: Fuad Tabba > > --- > > include/linux/page-flags.h | 15 +++++++++++++++ > > mm/swap.c | 24 +++++++++++++++++++----- > > 2 files changed, 34 insertions(+), 5 deletions(-) > > > > diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h > > index 691506bdf2c5..6615f2f59144 100644 > > --- a/include/linux/page-flags.h > > +++ b/include/linux/page-flags.h > > @@ -962,6 +962,21 @@ static inline bool page_has_type(const struct page *page) > > return page_mapcount_is_type(data_race(page->page_type)); > > } > > > > +static inline int page_get_type(const struct page *page) > > +{ > > + return page->page_type >> 24; > > +} > > + > > +static inline bool folio_has_type(const struct folio *folio) > > +{ > > + return page_has_type(&folio->page); > > +} > > + > > +static inline int folio_get_type(const struct folio *folio) > > +{ > > + return page_get_type(&folio->page); > > +} > > + > > #define FOLIO_TYPE_OPS(lname, fname) \ > > static __always_inline bool folio_test_##fname(const struct folio *folio) \ > > { \ > > diff --git a/mm/swap.c b/mm/swap.c > > index 10decd9dffa1..6f01b56bce13 100644 > > --- a/mm/swap.c > > +++ b/mm/swap.c > > @@ -94,6 +94,20 @@ static void page_cache_release(struct folio *folio) > > unlock_page_lruvec_irqrestore(lruvec, flags); > > } > > > > +static void free_typed_folio(struct folio *folio) > > +{ > > + switch (folio_get_type(folio)) { > > + case PGTY_hugetlb: > > + free_huge_folio(folio); > > + return; > > + case PGTY_offline: > > + /* Nothing to do, it's offline. */ > > + return; > > Please drop the PGTY_offline part for now, it was rather to highlight > what could be done. Will do. Thanks, /fuad > > But the real goal will be to not make offline pages > use the refcount at all (frozen). > > If we really want the temporary PGTY_offline change, it should be > introduced separately. > > Apart from that LGTM! > > -- > Cheers, > > David / dhildenb >