From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E5C0C5AD49 for ; Fri, 6 Jun 2025 09:48:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BF4216B007B; Fri, 6 Jun 2025 05:48:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BCB786B0088; Fri, 6 Jun 2025 05:48:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AE1FD6B0089; Fri, 6 Jun 2025 05:48:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 8FAD16B007B for ; Fri, 6 Jun 2025 05:48:58 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 372A1BD3F0 for ; Fri, 6 Jun 2025 09:48:58 +0000 (UTC) X-FDA: 83524501956.22.8E7425D Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) by imf03.hostedemail.com (Postfix) with ESMTP id 5709E2000A for ; Fri, 6 Jun 2025 09:48:56 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=tXBoB7Zb; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf03.hostedemail.com: domain of tabba@google.com designates 209.85.160.179 as permitted sender) smtp.mailfrom=tabba@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749203336; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LCDKfsXlZzurcM1ezkFJ6H0HklmVMiMXd+AkoFUM1Qc=; b=HLBI2HIT0Mr0pvepnScyNJI7JO4JJ5POVNU4MBBgNENNs+Io+KMK2VqZ6nsy+DOYsmlpxM 0z0Aas8GfrmHPNTYKt1ExLcBB4BlJWMg1a4qz38xmApunszsPgozKVg4iNc+nQv7xKiTb1 F7VVyikSv1B49CO0rFegzcBWvuHn7sM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749203336; a=rsa-sha256; cv=none; b=xpVPoCmVgY3yX+VoehSLgaf0PKEY1XOrO6Cv+gPgPcYfpHRAbn3R8Zcvwcp5K/Kj5jABmO mzKkIAUzZogSB/B5Id5unlXmQKQKp8OweiBwCExtKSv7z/o5dLyRGJhTuwqQdC9bji7QUs S8ybyDNhIELhmWI7tLHKKmmNR2B01Nw= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=tXBoB7Zb; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf03.hostedemail.com: domain of tabba@google.com designates 209.85.160.179 as permitted sender) smtp.mailfrom=tabba@google.com Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-4a5ac8fae12so349661cf.0 for ; Fri, 06 Jun 2025 02:48:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1749203335; x=1749808135; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=LCDKfsXlZzurcM1ezkFJ6H0HklmVMiMXd+AkoFUM1Qc=; b=tXBoB7Zbtajoecalq1L3FSpTfUvt7ypieRE8jB3LpC855PU1kLiMi0nn+fEtAXwZEb 0RoVLJSqyun34sUQUf02vewUdrDQgmqbV6ghy8fUMDE+Ou47Q69rOu+7ZumOfqH0KNNQ YKXC6x1O1LkiWQ8o0Li/P00CeIagrCs5b2k3Gvv0EfJoHz0xQNichHTrjCBgxOLHbvDu 6XKvWjkVKmZl9ptSR3WEbaU0yCgxTEeu8lCsUqQD2N27SVh9d1p0xekhvJLz53V/o+vL yFoplptJWYiM9//NqXycRUWIcbJ2Tjs+MdIQK0WuKyMwIFKsqarHTfEdJOTa41NnEoUB jaYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749203335; x=1749808135; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LCDKfsXlZzurcM1ezkFJ6H0HklmVMiMXd+AkoFUM1Qc=; b=VJAQlgRQltWvzowIx48Hhbn9NHxwpl9Ee1FcPa8qEeAYfrcGFbZuyWdOHqGR7qvUFF Z0ydaqFVPK0WORWt6dDE7WvFi1bstzrRKLfwJcr1nf6T/vmTSIMlkThxFfCqVSuR3/U0 C+MzL4T81btZdkd7mG3pOgoqwUwGsNrUFyw71FJaBtkINUSWqbMSGO4SdFFneYklauH5 Xl4vxFe98iDCGo/r6sTm7SBbasBDotVuF7mgIO/oOtsbdqAzu8h+5dAM6nzMcONp3TYy pmr2JIJaadeC9/DFZaG1/l65smIIRO46r4l00UaaAapuA6ghoNe+nu+6ywOBW2WYNkfy VLag== X-Forwarded-Encrypted: i=1; AJvYcCXL1g51orWnkbUlNS+8k9YQPj9XUGvuf375eDXlKobgZfrFPMhtlV6kCaGoomjlXQcEcQJsTMhE8g==@kvack.org X-Gm-Message-State: AOJu0YxTeUtfMb3WXzK/qtyAsGvKGZxT0QgF8BV2xr+MUehJ6wannkPI MsYVSn+8ig/FcjsTACKPZx50Ble7ZFiZS6GoEI1FkoUznGTbKL13i41MLi8cN3rGxmE/Sxy4QNQ wlkoB/Fe40loHYD7ZWBbCae2s4L/UCkDYIFM/DBp6 X-Gm-Gg: ASbGncs+GHkA0wR44ffyupghwKnL4d2rZ08+55towNuDfDyJ3bWI5q+xw1XAvMRo//a GLjplgPdseMA0ComniZxlad6uBG2gs3REUarXE93pB01Hq1QJGhWo8MT0n+/ug02k8Dwi1EPzn7 +pg9qiF3g+Y5mJaWEQpFmwEwC5xaDXSpC/oGtxr27NrzQ= X-Google-Smtp-Source: AGHT+IG6E/J9MfX2i8oW0aNRitzNLiDBnW8BoUvZFi+PsgUTsFLCcluC/1qihGgfccxw0D/xPEa7YdyrZSgObmD9Gpk= X-Received: by 2002:a05:622a:3d2:b0:4a4:ead0:92c4 with SMTP id d75a77b69052e-4a643a2d4camr2437051cf.5.1749203334828; Fri, 06 Jun 2025 02:48:54 -0700 (PDT) MIME-Version: 1.0 References: <20250605153800.557144-1-tabba@google.com> <20250605153800.557144-12-tabba@google.com> In-Reply-To: From: Fuad Tabba Date: Fri, 6 Jun 2025 10:48:18 +0100 X-Gm-Features: AX0GCFsIRwALL9qxco1UxN6YH4tCXZf-K_YUSzqBvF-siNiwfomILhB3vusRSbI Message-ID: Subject: Re: [PATCH v11 11/18] KVM: x86: Consult guest_memfd when computing max_mapping_level To: David Hildenbrand Cc: kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, kvmarm@lists.linux.dev, pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com, ira.weiny@intel.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 5709E2000A X-Stat-Signature: 3nkt83x6q6s5urq366qphr4kc4j7ebb1 X-Rspam-User: X-HE-Tag: 1749203336-658701 X-HE-Meta: U2FsdGVkX19IdBg5peu3ZCwybHJd+5joDzminRE9H9xMBIOZvquvKYH1GKLMFiLbCl2OutEOIYwhI0wCj4nYD5MXYU9GpuLbP/vYrMPT2z81Q83feD1Bz/vRT9CD6lyFiJYnwdXlE9PaWYxaIOiRqy4tWMeIsdFiOzMwqOxV+gRolW3HSG3NA0uU1z7A4eNAFcJbspyLMVQkkoW1W9J5zL/Gki//lWFBRabAwezAsbIokSPv4OEgrQtR093KuY32RyXPNK5mp+wgEcCgkdCdz4kj0rXZBDLnot2j1Dj4L6E3q66045QOKCnoCHc2Kp89KwizeceOjtDAsKOd2poyKCAZ2XNdIjr/XHdQbIzFt8si3n2Ca8h+juvxazrKmhFOKuNpCm0bZYjKr78GFwWUOan02kG6upjuSeXHY0p38e8MDyg7pSa73WdKs2nbSXMmN4uy4L1eVNX0ZWrifw0yLD9KhX5Ro/KLMetMg1fHDUzHt2NE3N8ji5533Z5lifdBbLZNkC38dsV3BuhDenItm5sav3KgGkPXgd5lUYyE4MZlQNhC/JZihzGRbioRFuHVsbJA3MfMvsFWwtXnJ6xxK0ksfykPgCqxxmq8bxxQgq+jrhe0DvPm1emryZCu9UMVbkyE1R0Wz6m8nbDq6a4737aQCpO+4238zSg+ERIEKYI+tiWaTpDtenng9b2KIeymVUtXjOJ9W4PWAxPhthIjU5oFuoc3E/+EHvnyQMkr1XC59dbpzNJWd9beKXl0ekL0GJdWHGCQPMKGBx6BNbZkcdvAGWMu16prXZAl8PJS9djWmiXR899oo9t6pBHm3CJTJ/cfpEYFsmLRqHsBjGzPS9zlSymqTbGub1E/u6EO6tfFukHWwmSHXOMDvMZ7zgo0H47WN9szs4cXeB/Up2GFdpfmror9JXMfhiTBXvB2L7fbfFcqgVUuppaghIxqX2zX3QRTvAVPXxyxfJHm+OB SXUchAA2 wKrJ3db6oh9VG/o9yyDYtdDIwQIwUqX39LtVJ90SUXaFCxrTiUGXJCh3m/4CZeaN51T2NX8TxMmAsSFoRtYkWXzJQP/IaRnGE0L95GhcRxxsO12Z1lytpKTziC8yBsebmiGi/3okV/bPNYcNdQPrxNDS9ryVnLsqEhnOeI0rqWCsNbfyxPI/9tbajKpR+py9HIUQqY076eVqxofTXXH7wVtXrloApuz0qlkkE7g94oFGR2M7YvGudYQmLQviJkGfOtMh6uNyckIL6VKoIBsHCVrA62o0EV1NgFG2ZkGKT7moOODsX6jGlYTfnri8cfH3w9sOOYjO0ziSuFzCsACVDxqUCHESrYV6r+DZcFbycZ3AAaZ4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 6 Jun 2025 at 10:14, David Hildenbrand wrote: > > On 05.06.25 17:37, Fuad Tabba wrote: > > From: Ackerley Tng > > > > This patch adds kvm_gmem_max_mapping_level(), which always returns > > PG_LEVEL_4K since guest_memfd only supports 4K pages for now. > > > > When guest_memfd supports shared memory, max_mapping_level (especially > > when recovering huge pages - see call to __kvm_mmu_max_mapping_level() > > from recover_huge_pages_range()) should take input from > > guest_memfd. > > > > Input from guest_memfd should be taken in these cases: > > > > + if the memslot supports shared memory (guest_memfd is used for > > shared memory, or in future both shared and private memory) or > > + if the memslot is only used for private memory and that gfn is > > private. > > > > If the memslot doesn't use guest_memfd, figure out the > > max_mapping_level using the host page tables like before. > > > > This patch also refactors and inlines the other call to > > __kvm_mmu_max_mapping_level(). > > > > In kvm_mmu_hugepage_adjust(), guest_memfd's input is already > > provided (if applicable) in fault->max_level. Hence, there is no need > > to query guest_memfd. > > > > lpage_info is queried like before, and then if the fault is not from > > guest_memfd, adjust fault->req_level based on input from host page > > tables. > > > > Signed-off-by: Ackerley Tng > > Co-developed-by: Fuad Tabba > > Signed-off-by: Fuad Tabba > > --- > > [...] > > > static inline bool kvm_mem_is_private(struct kvm *kvm, gfn_t gfn) > > { > > return false; > > @@ -2561,6 +2565,7 @@ static inline bool kvm_mem_is_private(struct kvm *kvm, gfn_t gfn) > > int kvm_gmem_get_pfn(struct kvm *kvm, struct kvm_memory_slot *slot, > > gfn_t gfn, kvm_pfn_t *pfn, struct page **page, > > int *max_order); > > +int kvm_gmem_mapping_order(const struct kvm_memory_slot *slot, gfn_t gfn); > > #else > > static inline int kvm_gmem_get_pfn(struct kvm *kvm, > > struct kvm_memory_slot *slot, gfn_t gfn, > > @@ -2570,6 +2575,12 @@ static inline int kvm_gmem_get_pfn(struct kvm *kvm, > > KVM_BUG_ON(1, kvm); > > return -EIO; > > } > > +static inline int kvm_gmem_mapping_order(const struct kvm_memory_slot *slot, > > + gfn_t gfn) > > +{ > > + BUG(); > > + return 0; > > As raised, no BUG(). If this is unreachable for these configs, > > BUILD_BUG() might do. > Ack. > Apart from that > > Acked-by: David Hildenbrand Thanks! /fuad > -- > Cheers, > > David / dhildenb >