From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB6C2C0218A for ; Thu, 30 Jan 2025 16:58:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1EC43440154; Thu, 30 Jan 2025 11:58:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 12658440151; Thu, 30 Jan 2025 11:58:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EE270440154; Thu, 30 Jan 2025 11:58:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id CE773440151 for ; Thu, 30 Jan 2025 11:58:38 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 77D1C120206 for ; Thu, 30 Jan 2025 16:58:38 +0000 (UTC) X-FDA: 83064727116.24.78EA428 Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) by imf27.hostedemail.com (Postfix) with ESMTP id 999C340005 for ; Thu, 30 Jan 2025 16:58:36 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ZK87zZiQ; spf=pass (imf27.hostedemail.com: domain of tabba@google.com designates 209.85.160.180 as permitted sender) smtp.mailfrom=tabba@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738256316; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OjVSJeaXnqEO6kzNOY1Q8YRm02MOKH0yqrkAcstxsgU=; b=QR9pZDk1J3qX9n5ayiwyQ/E34ClxECP8Dx4cl0bM9ty2CPix/cjfAnsRngBeiXrfKQmBcn gAqeWVLVVril95utp8WKlMurtvAPxikKte+euEF0T1o2XkNkV2jk2Ms2ncshL46SoMU5cW ly+zY0jnHrIjoltdfZSKp8Nj2+PlUGc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738256316; a=rsa-sha256; cv=none; b=C+kvMUPGbnpp18dtzC6RQvlodRCKHHkBQSoRTpSibgHjDI4OD5QrtA2uxxDXgJOsagbLgB nFhKa/ihArFDqpAx5HMy8NlR/sVl3cDlqQs+/o+4LrZ5Q5ce99RBw/Cm5CCQSot25EHV1J g0YX+4ILqRQktK8XUXlUBVsZG0Rr0Xg= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ZK87zZiQ; spf=pass (imf27.hostedemail.com: domain of tabba@google.com designates 209.85.160.180 as permitted sender) smtp.mailfrom=tabba@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-qt1-f180.google.com with SMTP id d75a77b69052e-4679b5c66d0so252211cf.1 for ; Thu, 30 Jan 2025 08:58:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1738256316; x=1738861116; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=OjVSJeaXnqEO6kzNOY1Q8YRm02MOKH0yqrkAcstxsgU=; b=ZK87zZiQGeaRMx7cIoH3xfnjmZjVAkP9xxNUxV/eynr2XSUcUZ/T45ZA60tsTJaP0t lVlE6ZORv3z5MRgwKzUNzbDPZ7geradxRZKVer9f0zkn+jtq4GgVFc4Ui9Hm8+PxSlBO GKxqrN90y4GpTDmWy2wt80gyYnpGLtJTmkHWcQR3Quu90loYON4NT94CZc7/eanRPVYy MB57DA2a0D2+zbplj5Pf5dmK+7RlYbpO8RykvNDkWMmsiqqUcnrpedZgFtw0OjCaeBsl j1Vw9tA3B2RRiOKXEFE2Tv8NxhFPFnD0hlbDxCl5qbM81qpHgKcoqVqsvdaa1TySwx5G XWiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738256316; x=1738861116; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OjVSJeaXnqEO6kzNOY1Q8YRm02MOKH0yqrkAcstxsgU=; b=Kko332A7qTRieY78PftvSii1LPufgOE2jhReAua0DEjSLGk25ox3DovkSjeoYANMBF 9hdzanbdl5TdTWNWU2aCwZqWmqVSlt6jKGdr8/ot789TL1N8Cu7MtDVyu/Mr5Eopq4ek uJCpCZdYgWzhCssvVLUYyU0FeLn0O3Q02scVUyhd9z7iE6RaDxpRUevX1R/VT+nL7S+B fH2w2u9wZqzeGk4QyppQBOF6GluZX9s4BcbpvIY+RxhaHM2bjUfEv0Nx9Uo9rtAT7X+g bMCTdw2Hne00Mf+DilcG1OhMDB9TMWtb20JRjdQ2Qk9JygE8VY2NhtP7HkM3mlqBmju6 xSXw== X-Forwarded-Encrypted: i=1; AJvYcCXNVHNohzowIpKq3dQEOTLI3IJYQP8RkKljdC3qxrYwJx3sUdXhmEtp58L8N/VnUTiNRgGyql20OQ==@kvack.org X-Gm-Message-State: AOJu0YxTRQTiLu+AUP+v2dZdo9qTUnqaK/TEMCAC6QxDk903v0ETHTST siL7UbuV7HXwGjkcuxES+6tF0/NuoPV3TeRthUGbuWZkMgY0A5EQ3AF/fj86pRMQ0nvMjhfPy1f x9ftKmQ7U2CfThCFCksA5JwCm/L1/AqQSZdne X-Gm-Gg: ASbGncujI0TwRwLId7jX9BAS+EJBKwH2lpfbsS+aa860vc0+5wsf2teAbgLciCQ9ww5 7vgOL1vmsb2TQetzlsH8RhADgw3/Pvv0rXnjti/sqsygMQFaa74EtI6VTYLKINGrVwnoSq1U= X-Google-Smtp-Source: AGHT+IHCwX9tBUNJ4vUL+HRtX/pNUZGqGIBRJgFIeh7dwGLzBMH2QbmaQNU6B5i4kDVwxKn3b3C2BGkQe7GPOVyR6ew= X-Received: by 2002:a05:622a:1a9a:b0:466:97d6:b245 with SMTP id d75a77b69052e-46fde4b14e3mr4241201cf.22.1738256315469; Thu, 30 Jan 2025 08:58:35 -0800 (PST) MIME-Version: 1.0 References: <20250129172320.950523-1-tabba@google.com> <6810dbdb-1b44-4656-9f65-abca471523f9@redhat.com> In-Reply-To: <6810dbdb-1b44-4656-9f65-abca471523f9@redhat.com> From: Fuad Tabba Date: Thu, 30 Jan 2025 16:57:58 +0000 X-Gm-Features: AWEUYZkqjd_c8s8_NqAiNB2ua1_PSsCvwT_KNHeeEKbL3m2RKXKoGVCEenSF2OE Message-ID: Subject: Re: [RFC PATCH v2 00/11] KVM: Mapping guest_memfd backed memory at the host for software protected VMs To: David Hildenbrand Cc: kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, yu.c.zhang@linux.intel.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: w6ky3uzgaq8pue4j1eqmei39yjhpwozs X-Rspam-User: X-Rspamd-Queue-Id: 999C340005 X-Rspamd-Server: rspam03 X-HE-Tag: 1738256316-567865 X-HE-Meta: U2FsdGVkX1+A0xfGUUrQRmyXqE7AM5M94w88vqbBZEMo7qOqA0OYq/o1WgDXAy2IzWdi8P+OimnTCfew/p7REQoQqBdrpuuVLpCW4qGe0nE8oDFFqZwPHSDA0vECeZIXKan6nwW52NjJ7gVzNdRbQ1I+YI4ocIqFNp9ByDam5AZrI4u0zQU8ajVFsVH5+MHM9PSWEbOQDBfZ7i9dtrzMP8SEyiz3eoG6XmXlStSlJAi3e+OJWWP6orfUaB8b26YgN4dHHkz3YLAQiw5JivCyh3W4vaAzh2jeQdyjvtQb4OMYygRyZGLGOvHojNaB2Xn+A2cW/4m/U698vin9B/f3zo1Frvzqeye6IzVmL0Lk9nX5svQH1e0lMESWdfBAd9kvFNFFjPNkNofgVKoH8q3woBXAcVz5BNeTGSzDjb2OMsroR7vVOkrxqdptH5Zb69eiSOr0mdEQJT5+f2mZZbvlWDazlXWRK0skMEkC2SzL+JwpgivwfA/Sh+dGez0G86TflfxE3raANQAZEaTDilCkR6DcjkeL+nGV7wuGDSlRTblrfuhcXrdhLbrIOBLd6QUMK48a4Zh/pOo/502No+LlJftcwWF1Co8tl4mx1kYxbmOHgK6iXaNas20jmXkVGMcXHE8YJ53vmNrkpljmhu5KRYhgn68WwZ8ioV4P11ZhibsAW0hbPqwzwUkChBIHCwrk9pm7j8RByHq8x74aQsWuwD9JHNug86/4dp6xnFnmSE1qHHTbHxYRetzNouvrVUG27OzbKSCXAN2bwAx+i/3hVdmuU9sNmvXA972D74tXj9Y7PH/c/x0C9rsQ4cbanDrgkIfVDigm2ad9uJCy6+eOFG1buz0oGf2namwQ3FhYIHb7fvUXKe3oFvzZarHIj/ntl+uuJdbC5Z4+HfjsmQSNRtSzTTI8i2tSina+5ls7KAmvHMuNTNKbW1LFMDV6clYQZQE+gqfNivVJ1CfYpOh 7A2czC91 AwtRQSqTxazuuoRY9vzcIriey/fwTm7FakMeNkzmqu3p8CTSGmWXeVl+oS+ZXYIMvWxDJyrfu/v9pmHKqkKRxSLvHAFn3XlE1OGbQj6aPEuFuphic1AjxTWrJZOoVx8EmO+BYwtgKF69tFTRQHGR0zF+kanh5471JMSpVQyXwIOSHpCjxGffl9g2qzNlFKq3KKRBlvI7czSsdo9HW3oqpXf+mgdZQOS3H4CCLzejPqyOJruW3RAMXpbS7pYAcG2IP5nyKk/6SRKTnIQ3hfDj0h2McYV6u2daBtr4HwtEzuy+jIAE79lXaIsKCVEdl/SwwEgcHIUdQwhdbTXXpTi2Gv5Rgpg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.004195, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi David, On Thu, 30 Jan 2025 at 16:50, David Hildenbrand wrote: > > On 29.01.25 18:23, Fuad Tabba wrote: > > Thanks for the new version > > > Main changes since v1 [1]: > > - Added x86 support for mapping guest_memfd at the host, enabled > > only for the KVM_X86_SW_PROTECTED_VM type. > > Nice! > > > - Require setting memslot userspace_addr for guest_memfd slots > > even if shared, and remove patches that worked around that. > > - Brought in more of the infrastructure from the patch series > > that allows restricted mapping of guest_memfd backed memory. > > Ah, that explains why we see the page_type stuff in here now :) > > > - Renamed references to "mappable" -> "shared". > > - Expanded the selftests. > > - Added instructions to test on x86 and arm64 (below). > > Very nice! > > > I assume there is still no page conversion happening -- or is there now > that the page_stuff thing is in here? > > Would be good to spell out what's supported and what's still TBD > regarding mmap support. Thanks! No page conversion happening yet. I'm rebasing the other series, the one with the conversions, on top of this one, as well as fixing it based on the feedback that I got. What this is missing is the infrastructure that tracks the mappability/shareability at the host and the guest, as well as the implementation of the callbacks themselves. I thought I'd send this one out now, while I work on the larger one, since this one is easier to test, and serves as a base for the coming part. Cheers, /fuad > -- > Cheers, > > David / dhildenb >