From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9C28C4167B for ; Mon, 6 Nov 2023 11:03:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7CDF58D001A; Mon, 6 Nov 2023 06:03:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 77CBF8D0002; Mon, 6 Nov 2023 06:03:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F6728D001A; Mon, 6 Nov 2023 06:03:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4E34D8D0002 for ; Mon, 6 Nov 2023 06:03:19 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 161FDC076E for ; Mon, 6 Nov 2023 11:03:19 +0000 (UTC) X-FDA: 81427242918.18.14313BF Received: from mail-qv1-f41.google.com (mail-qv1-f41.google.com [209.85.219.41]) by imf06.hostedemail.com (Postfix) with ESMTP id 3B789180036 for ; Mon, 6 Nov 2023 11:03:17 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=cUZUQWCo; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf06.hostedemail.com: domain of tabba@google.com designates 209.85.219.41 as permitted sender) smtp.mailfrom=tabba@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699268597; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KU+b2mECXXvQ5slHB7/YEPM4eq1YPpk0J5Rl/yZ7AP8=; b=0zL1UQZflQnIetivvpAKFlywPnUcfhNbxqFDpVcozZ+fzZ/HbVLlhnXwq3yzXCZyeTN9BN NF9noNsITW+dBlTw+p/ZAfxuOZC6TZOmO/wjnO/hYhMScsbj1LhZEgGf5XB8BaWEcnsL+X ruxT8IW4yJiPccFxMlDLn5tfoANp77o= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=cUZUQWCo; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf06.hostedemail.com: domain of tabba@google.com designates 209.85.219.41 as permitted sender) smtp.mailfrom=tabba@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699268597; a=rsa-sha256; cv=none; b=gjduCpX97NaAY3gRBVE1Tz26XeQiriOhGvWYsw8MgAMtKEWPmvlI3HDxVQtMCv6d9KzTMY yINQoLg4Qg7ebla0HJW+BgQdyXCp5Ep+gdV50q6oKWiL35sWgtjJhBe1HaifAaZ/0brWYB bPpd4fs/72rCfF75XgXoNQAh19Lg9iE= Received: by mail-qv1-f41.google.com with SMTP id 6a1803df08f44-672096e0e89so28253736d6.1 for ; Mon, 06 Nov 2023 03:03:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1699268596; x=1699873396; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=KU+b2mECXXvQ5slHB7/YEPM4eq1YPpk0J5Rl/yZ7AP8=; b=cUZUQWCoI5isH0umueiYDDoTGgdt5Sdk4OGbn92y7MD+yvBzBVPCgqTTFLIjhOiVuU 7jCv7pcsALoYccIRc60KkMx6LUZQ4ZjFMeA0SUB4TRCHNgfQ7FnSL3jd989zFgQLOxnK KszL90iIv9OjzxUdJtrLFu6AiAIr43FR72ib46IsTmWFua96DC14J+bSD5Jkn/BX5J4Q /cVkfdG1l7NdUaGEpkg3ZSAamm81DAapQyu+Rn7nIBvrp5JCL1m8KLcaEEytYxEHdstj 1OqKbGb/c8Ua3PFoBpg4SREsWII9nvUDZHIsukhmJ2UjfqD+J/l+tYZBXjJ+bwPuKCDv lZag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699268596; x=1699873396; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KU+b2mECXXvQ5slHB7/YEPM4eq1YPpk0J5Rl/yZ7AP8=; b=Cx88zJ5t0MfUsZdhA9KFDOGA3jXj44SnYN8QLEcAHN2ixai5fUjuk1eFfGu6c5Oao2 VXhtuiAMBLfzQlcRl/Ondx9JA3le1WmyCY7SQGtC9Hdoo+rDYy9KqQoYc5wL5cG6KLwF H8yY88MrIyiP6Tv61qMIk3RdFZJKkDHhVln60LpI7FGL338i0Wci/hp+VU3nArxe+XJs IzotNIB8jq3c43t45b/ZX1P11I7+vFX59h2Z13pxrSXADkHnIgL826N2iATIzKoMWAtn zzfUEhtd5Q35b1yX5cF37C59BASwaL16UmNzyO4WQZV96wHhl27w6dVyRGA4b39VFFo6 CYiw== X-Gm-Message-State: AOJu0YxR5bHJxAQOq+m6GJjb3j8l2/twThAn50I5nDz6daoXZndzjfj1 y/bv6WAzIuF5YI6j2FeHluBHIUq78shvj06c4aeq1A== X-Google-Smtp-Source: AGHT+IH064K0ZtIRC0Ddcf2wpRdR9qcn5N+rpiGlH1rS/nMIj84KwquVAyvAa55WjBkBZ58J/DOu2Zh9h49soweI3jk= X-Received: by 2002:a05:6214:2582:b0:671:3493:61e8 with SMTP id fq2-20020a056214258200b00671349361e8mr28685929qvb.26.1699268596310; Mon, 06 Nov 2023 03:03:16 -0800 (PST) MIME-Version: 1.0 References: <20231105163040.14904-1-pbonzini@redhat.com> <20231105163040.14904-23-pbonzini@redhat.com> In-Reply-To: <20231105163040.14904-23-pbonzini@redhat.com> From: Fuad Tabba Date: Mon, 6 Nov 2023 11:02:40 +0000 Message-ID: Subject: Re: [PATCH 22/34] KVM: selftests: Drop unused kvm_userspace_memory_region_find() helper To: Paolo Bonzini Cc: Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Sean Christopherson , Alexander Viro , Christian Brauner , "Matthew Wilcox (Oracle)" , Andrew Morton , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiaoyao Li , Xu Yilun , Chao Peng , Jarkko Sakkinen , Anish Moorthy , David Matlack , Yu Zhang , Isaku Yamahata , =?UTF-8?B?TWlja2HDq2wgU2FsYcO8bg==?= , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A. Shutemov" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 3B789180036 X-Stat-Signature: hkutmjzmn3c7yp46h5d3i9kye4847rw7 X-Rspam-User: X-HE-Tag: 1699268597-621918 X-HE-Meta: U2FsdGVkX1/nh8yqVsAWTC31DEjMk2dKS9ocTY/GefWz7/uFC8TJzIt7zYUQBYAoFcOShrK3iF+0CW6MRRlKgXpkVOSMAFhUPdRwGQKk0Bw9Yu9j7s0EiDMsla9RbNLd7hyCc6M2Uf1Np6vH2Ygn6kfJVz/l9iUDlpwIJbOuA85zuBtpXtEltmfk4aXxCbwYuItfHYx3GLyfMHhi+TWNAkMz/Js62kJvcWtZR2mvaaxpW4JxuUL9ldBXI1HXfh0EHlYBTREOgHYtkHYkzyEj7iTbpbmR9B3x2M4hDI/XdnQguREjS8S2OIVFt40v6WXed1kq8yS7V+3Au4i8twSCQu+Xw9dzx5hYsvnrqUSNGwAVAe0qRmuwadABJYqj/0cwFOCa05hxLNSTb0bWGFBcwd7tc0qKebq1nOrE00/EOzp+mmogUNsKlheI25jF8dLo8Z8huLXn5L1Z1nNRudM/D8tsfmwqbYzy+CDYk0GFLHCQjpjkeaZtbMQgTj3ok7HEm2klXI3+FtnSroVzqteqKnFzeniFQ6B0JfBkRL25VDq4jZtn/t+I9NMIzZD5lsEbWa+UraJtALVl00VhD6/MbRvbb6X5i+tD+lPbbi+bOgjC2tLl1T5Z6Ep5gUiypToistLR/l1GdWb4H9RhTklnKeUiiMFr+qZ1QLHhjlzGwHJiNSdSBNTpz/N7730QJQshV337n+enrl+h3kLtQBdP0WXpHSWWyLY0BHip9ymzjSjP54wpscwhyGc7TR4PRbsjTFKeCTN1c7AVb09E5H8jNCv3b+WFvJT3X+B6Ol3nMfuF6S/Br/z/qL3ZkgEI3orxmKEIwpMbA/Xc8IkkQXTWkx+rC+CGBPXoO1weE3tFHJEiSD8GE43fXsS5CM1gLUQbP+l4EUiF72fm2y9pOQT07XCdxWV9QBBT57ZM6yt32S6hxCrLsTd58aP9jFiu56NbnMYe4CIpDOaDt+/i0VM JcyeV/JP 8RHxDg+CtI+hCRt0M8FTR1ckgIq/XzlBlfpLTkWWuv8xRaZmT8gbFXkMc47onyGOvnhKjj49k5k+mzEkWGZgCqK8BkOsTg0wCZZCJa2F/EGjsK+1mBEsoknsPezW1HnBOhEquucX7EZ8A/lxh4rQlQbitdbgp4zcclIbjwsz1LIACymUse+06fhLR84dKqOF8rgdbo6Bzcq6obRO+7I2bXoZUR5QZMO44VZqAvPa/uL/eMOvtnSTBKI29GdEA1ibokDfSdlPT2gvKUHmkxx9psGVLXbW8qpwmHBTrBrS8hTRAo0oa4IRyGlR8Uy5GbktCtl/gWIzlsrm1maZBp6IJotGTTcFsJ06wDcpC+oRC+LtNHNvYTlDPT8xJfuxVuMQei3YK6bUxvPpju9Y= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Nov 5, 2023 at 4:33=E2=80=AFPM Paolo Bonzini = wrote: > > From: Sean Christopherson > > Drop kvm_userspace_memory_region_find(), it's unused and a terrible API > (probably why it's unused). If anything outside of kvm_util.c needs to > get at the memslot, userspace_mem_region_find() can be exposed to give > others full access to all memory region/slot information. > > Signed-off-by: Sean Christopherson > Message-Id: <20231027182217.3615211-25-seanjc@google.com> > Signed-off-by: Paolo Bonzini > --- Reviewed-by: Fuad Tabba Tested-by: Fuad Tabba Cheers, /fuad > .../selftests/kvm/include/kvm_util_base.h | 4 --- > tools/testing/selftests/kvm/lib/kvm_util.c | 29 ------------------- > 2 files changed, 33 deletions(-) > > diff --git a/tools/testing/selftests/kvm/include/kvm_util_base.h b/tools/= testing/selftests/kvm/include/kvm_util_base.h > index a18db6a7b3cf..967eaaeacd75 100644 > --- a/tools/testing/selftests/kvm/include/kvm_util_base.h > +++ b/tools/testing/selftests/kvm/include/kvm_util_base.h > @@ -776,10 +776,6 @@ vm_adjust_num_guest_pages(enum vm_guest_mode mode, u= nsigned int num_guest_pages) > return n; > } > > -struct kvm_userspace_memory_region * > -kvm_userspace_memory_region_find(struct kvm_vm *vm, uint64_t start, > - uint64_t end); > - > #define sync_global_to_guest(vm, g) ({ \ > typeof(g) *_p =3D addr_gva2hva(vm, (vm_vaddr_t)&(g)); \ > memcpy(_p, &(g), sizeof(g)); \ > diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing/s= elftests/kvm/lib/kvm_util.c > index 7a8af1821f5d..f09295d56c23 100644 > --- a/tools/testing/selftests/kvm/lib/kvm_util.c > +++ b/tools/testing/selftests/kvm/lib/kvm_util.c > @@ -590,35 +590,6 @@ userspace_mem_region_find(struct kvm_vm *vm, uint64_= t start, uint64_t end) > return NULL; > } > > -/* > - * KVM Userspace Memory Region Find > - * > - * Input Args: > - * vm - Virtual Machine > - * start - Starting VM physical address > - * end - Ending VM physical address, inclusive. > - * > - * Output Args: None > - * > - * Return: > - * Pointer to overlapping region, NULL if no such region. > - * > - * Public interface to userspace_mem_region_find. Allows tests to look u= p > - * the memslot datastructure for a given range of guest physical memory. > - */ > -struct kvm_userspace_memory_region * > -kvm_userspace_memory_region_find(struct kvm_vm *vm, uint64_t start, > - uint64_t end) > -{ > - struct userspace_mem_region *region; > - > - region =3D userspace_mem_region_find(vm, start, end); > - if (!region) > - return NULL; > - > - return ®ion->region; > -} > - > __weak void vcpu_arch_free(struct kvm_vcpu *vcpu) > { > > -- > 2.39.1 > >