From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34D6FC4332F for ; Mon, 6 Nov 2023 16:25:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C91648D0025; Mon, 6 Nov 2023 11:25:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C423E8D0002; Mon, 6 Nov 2023 11:25:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B0A4D8D0025; Mon, 6 Nov 2023 11:25:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A1D9C8D0002 for ; Mon, 6 Nov 2023 11:25:21 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 6D8001CB304 for ; Mon, 6 Nov 2023 16:25:21 +0000 (UTC) X-FDA: 81428054442.22.1245481 Received: from mail-oi1-f176.google.com (mail-oi1-f176.google.com [209.85.167.176]) by imf15.hostedemail.com (Postfix) with ESMTP id 84868A0006 for ; Mon, 6 Nov 2023 16:25:19 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=lsNUp9lQ; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf15.hostedemail.com: domain of tabba@google.com designates 209.85.167.176 as permitted sender) smtp.mailfrom=tabba@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699287919; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5xnGb8Sp7Bw2ldCk3b7+mm/bKINtcTCgeZ/KDZ+GW64=; b=riL5vxbyj+QuvdmI9xW8h1yGkljaK01MX1M7SOqXrTYZQMK15H5htNfeYcom7doG0SKnNa 1CN6FPtlfh9wZdB/eysCHojXtsN0sXwzfe4bWQf9YZcA5Wgl3Oo7bsyfMZ2gJx8dgCH/SI 9dXegCWisMZDt4e/u9TygijYX3DXBm0= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=lsNUp9lQ; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf15.hostedemail.com: domain of tabba@google.com designates 209.85.167.176 as permitted sender) smtp.mailfrom=tabba@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699287919; a=rsa-sha256; cv=none; b=r9FqA5FMgNQJ9nRU6qQvcWEBg16mTUpHr6WZdQv8bqWVZbtgPkLM+5uQeaEKGatLiFTBuA vQ/fwYlNABYcA/wnObVm3OR2617kTUHTv91yCpURxDVxEi/by/tDO3ETMwzIlkzEoOgNLD avBPmsQ+LXybeWQyAOyGHqdhgZ6zst0= Received: by mail-oi1-f176.google.com with SMTP id 5614622812f47-3b2e72fe47fso3001283b6e.1 for ; Mon, 06 Nov 2023 08:25:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1699287918; x=1699892718; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5xnGb8Sp7Bw2ldCk3b7+mm/bKINtcTCgeZ/KDZ+GW64=; b=lsNUp9lQfrYrOJlWUr6mD443s1el2Rz/t30iiSVx7QanWgvtGDh9xbu+Wut9DBB1tj 5ka3G/gYoO2j4lGldX/keFAwAzlRSkbVtOIFBUGBXGREv89cRcu3M1Kt1CScPF4uwVlf LLsX0fOoWXe8BCL7Cc3px1rx/uUHBrAXNwov0YZLjjJnx8y04jEESkBoqXpQS7AEHs8F XrvNNAizy1WlFsrJzkhGxm34ckfZbLod+kQWUa2u/p1ypq/F5konH1W+RUkyjRXgjGUw 4tFtGc//XVGl18NF3PRXTvxkXc6CxfrSdJGCZ00uNY62TjIh9FG4TQtN5lFLpPGjFB7b XhdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699287918; x=1699892718; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5xnGb8Sp7Bw2ldCk3b7+mm/bKINtcTCgeZ/KDZ+GW64=; b=Y9HbTrvJodi+UNGZxfmhw+FdsIBAemwttsE6dB/OG7iP/NpNZQlbYv1c3iCpvtKFUk /iQo4HJDJUrvbnGnZsCYAT2LttAET+btpiRflHqq2vVWjGAPGMVNiW2bSGOcbm47UGY7 3XO6tQ7Qw/dviXkj8wvqimAjblZj0QyElX7wiz+Yj8yMJvLIAflKHsk7oDV5izC3+rX7 a0GPHAgSZ9NsYj+hFG+tHSEZ291zZus2GhbnoDEgxQryrexYuNz+5GrC6/p+ngDOEBS5 8+jij6c1q0f7hnhqAFqgjtULZMoT6w2AMSz/o6SEKnLb/+7clNUy3U2gQBq5A0n+oWWq Y48Q== X-Gm-Message-State: AOJu0Yy4vA+jN1heBHuSxR7n3h8qdvwhtlh5QKZ5rIM3q9aFssKU9iRV 9agx3d77SolT6IJBDtITMIqBXPaccM4fJ5mjgiC4tA== X-Google-Smtp-Source: AGHT+IEz2M905daE9adgBPAvjj9bLaNYp4EiTefEe+KnfTT86zKFKrzhkzHGJH5RS/f9fNDUudL2BwXAULrnwcO9LCk= X-Received: by 2002:a05:6808:28c:b0:3af:a107:cf68 with SMTP id z12-20020a056808028c00b003afa107cf68mr28980109oic.40.1699287918292; Mon, 06 Nov 2023 08:25:18 -0800 (PST) MIME-Version: 1.0 References: <20231105163040.14904-1-pbonzini@redhat.com> <20231105163040.14904-26-pbonzini@redhat.com> In-Reply-To: From: Fuad Tabba Date: Mon, 6 Nov 2023 16:24:42 +0000 Message-ID: Subject: Re: [PATCH 25/34] KVM: selftests: Add helpers to convert guest memory b/w private and shared To: Sean Christopherson Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Viro , Christian Brauner , "Matthew Wilcox (Oracle)" , Andrew Morton , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiaoyao Li , Xu Yilun , Chao Peng , Jarkko Sakkinen , Anish Moorthy , David Matlack , Yu Zhang , Isaku Yamahata , =?UTF-8?B?TWlja2HDq2wgU2FsYcO8bg==?= , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A. Shutemov" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 84868A0006 X-Stat-Signature: 5ymmtbdrodynqxo1hgwapcaya6oeu9it X-HE-Tag: 1699287919-772546 X-HE-Meta: U2FsdGVkX19oPDrwUMYswXsb3GX2tnpD0v7DVkCdY/QV3fPZX6gDb1ge79V5StmCVzCCyEhm0xpfuZQXeJe/AMsYr7Gd8+i5jvA4Sx5g6c8pjoz3rae/4DU4QmOQnPQZYisZCYCvASyCcNRx10hvgYOWr5uEiZ39QQIS54yMo0/VHby7Y+9Rnt1/sXT9j9ToqKN4u2ssEdlG26MVq3ahz7s1lPXRmxilwmcYTFnEcIkxgBRfjNnIO8JDrTelTE9UVjy+YerASFnGwjNbymlzgwxIqVGpViqSxDgJDE0Igno5G91dlK0KhsxTa18ukKolGqI+PH2wXYyIqINAzalpLE3YAMLKcKs8czxsjq9JqzpggUpTaH3R+TWqvDSpL7MPeVSWtbbqdF43AUHU0cT3te3t3fz8jVPU/yI9ta8gYZK4vx7SIjQPd2B3cZKEWmM+3LX/6QMer2mMePMfuhLlI0rN3ogK+doaWPhesQKIslH7GftnyqXYxLC/DPWbC4b+h9bbbEa8xQfDnQ/pMN6kL1MKHX4RwmkFHU0osSTVGYDUFnL4Ge4jXagiHNc4HvHrwPmy3twWQ3xZYrCianW6t7XoTBB28Dw79KUTmj3DSBCGy4KB7O4RKeFj+dMaxtI0FqYf7h+XqMmgv4cBw9C4lZFaul525rr1zq9iQiBQpIaHyRyYvG+XoRsz0usr+NB5MG6s6IrVbuj2n19yI6OnuqzHBHpCax2brfduw34NkB+kJYMtg6PWHYcZO3UhhXWcwFxTWH/N1Kbq3bp6Tl7TtpIPNa4bI1mYrps73uBK5BuZ4J/XzPlcCjNrYEmCc/vGBbNp/WO6faKplDio2cawQgVNhDsVntEJ8eixwXSdgdSpD6HxPVKfTbi8duvftwH+LHGBAQxbzr+ymvwMFtFmIJZOdn6tsuW5fgLMlegwkHzqZ65xzrZzlkh1BcwMD4Xfv0FXphT8bzMo8lkhxhE RuH+dW2r YP7C3PGKwL4jf8eWHkMJ5xa3mVdZ7Z7uWMdwojUg619Yp9q0PGTmZF7QskPSqxXvcRaKRn5Y3zMvTgJcVFwaHyNYCdtJye2BWCW4FeV/pBghNIuTGfqCIb9/o8E0TvZDrrO13RFsJ5hM+0wGFlhX+vfKCJeobyKuRBxIRpf/TG+vpo7nWtt4R98AVSEgGyTKCxYZh0jgDqPZV5YH/6yQKZZg/NUPkl0UGO2TsSGjWjIu4UwkSoyzW2jy2tIsXhrYwFSP+ryOIcUihqAMd/rl5sO3mGr1pPbME4/a/Xh3dNAYHkLoffIIUMJgeAbP5flJEcjbQ79VcyXkRvs6wj4haOhOEd0vuTazWTGWQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000105, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 6, 2023 at 4:13=E2=80=AFPM Sean Christopherson wrote: > > On Mon, Nov 06, 2023, Fuad Tabba wrote: > > On Sun, Nov 5, 2023 at 4:34=E2=80=AFPM Paolo Bonzini wrote: > > > +void vm_guest_mem_fallocate(struct kvm_vm *vm, uint64_t base, uint64= _t size, > > > + bool punch_hole) > > > +{ > > > + const int mode =3D FALLOC_FL_KEEP_SIZE | (punch_hole ? FALLOC= _FL_PUNCH_HOLE : 0); > > > + struct userspace_mem_region *region; > > > + uint64_t end =3D base + size; > > > + uint64_t gpa, len; > > > + off_t fd_offset; > > > + int ret; > > > + > > > + for (gpa =3D base; gpa < end; gpa +=3D len) { > > > + uint64_t offset; > > > + > > > + region =3D userspace_mem_region_find(vm, gpa, gpa); > > > + TEST_ASSERT(region && region->region.flags & KVM_MEM_= GUEST_MEMFD, > > > + "Private memory region not found for GPA = 0x%lx", gpa); > > > + > > > + offset =3D (gpa - region->region.guest_phys_addr); > > > > nit: why the parentheses? > > I simply forgot to remove them when I changed the function to support spa= nning > multiple memslots, i.e. when the code went from this > > fd_offset =3D region->region.gmem_offset + > (gpa - region->region.guest_phys_addr); > > to what you see above. I wasn't actually expecting an answer, but I literally _did_ ask for it :) Thanks, /fuad