From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC7FBC4332F for ; Tue, 7 Nov 2023 14:39:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 41A3F8D003B; Tue, 7 Nov 2023 09:39:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A3318D0001; Tue, 7 Nov 2023 09:39:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 21C828D003B; Tue, 7 Nov 2023 09:39:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0DCD68D0001 for ; Tue, 7 Nov 2023 09:39:35 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id DC285A0A67 for ; Tue, 7 Nov 2023 14:39:34 +0000 (UTC) X-FDA: 81431416668.17.1AC9E81 Received: from mail-qv1-f46.google.com (mail-qv1-f46.google.com [209.85.219.46]) by imf09.hostedemail.com (Postfix) with ESMTP id 2FFB4140020 for ; Tue, 7 Nov 2023 14:39:33 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="vVcAJLa/"; spf=pass (imf09.hostedemail.com: domain of tabba@google.com designates 209.85.219.46 as permitted sender) smtp.mailfrom=tabba@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699367973; a=rsa-sha256; cv=none; b=WpnMW2+lfecNYWtaOZEuMHcVKOmOmUCIrOh8Zy2iSKWkxpOs7BzSjz9ry6XypwGmAaGcT4 SL5b1LL4ajOgUrEpZtdBhKt6tsKH62jV51pzPkWvfvUZ1uuGLjo6HEm0lsRD5W04dAront hqey9OD4zQB4B4uhn3b8sn5TRd3Qevo= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="vVcAJLa/"; spf=pass (imf09.hostedemail.com: domain of tabba@google.com designates 209.85.219.46 as permitted sender) smtp.mailfrom=tabba@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699367973; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9yWUxtco4+SHtMfDkrQFL/rv2xiDn8sNB7VvrAl+j00=; b=5q8U/IcYACdm0Ca5Xe4HpvemsTk4yKrpDBu0hcMQ6s+TIsfTEpUNFCYX/Dj8lECWNdaHgt vB+1Okixm4WsRe4SenyDma0lHq4GK6hJmoVIh1oIkKvyAOKfsDfn+CEI+0Vwzy0OmGApaE qkmk/6TFJz6uZLUYbWmd6tXvDxVyyRU= Received: by mail-qv1-f46.google.com with SMTP id 6a1803df08f44-66d0f945893so47139856d6.1 for ; Tue, 07 Nov 2023 06:39:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1699367972; x=1699972772; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=9yWUxtco4+SHtMfDkrQFL/rv2xiDn8sNB7VvrAl+j00=; b=vVcAJLa/Lxn32iUah0zLGH2jS+duHQeFLz/YKuq47KslYd4UR6mx7fkEJkQHX3xE5l 4iNXbtWHAnVoT4fsx98g8HuEVYJ/8jECphjn7HbwPeZ19oPElTKcubP43BPvPuMIF91I cwLwgsTr8g4egQn5+j+IPMNyVXfW0FOlUC9xfo1dfW+1cN4eMVYpCUM18VNKzSYAntgf EoSWUn1kvRI4E8y7MOxPKP4F6xaEjspyvf7L4pNTS6yYjRoauFimsziGO1nesHorWTKF kwHGJwgDoLW9dtBaky8LfMtO/ED+dFSlLruc983oCtLhS+9I+pPK69DCezAZOJDGYMvU gwOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699367972; x=1699972772; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9yWUxtco4+SHtMfDkrQFL/rv2xiDn8sNB7VvrAl+j00=; b=BB62zhVrh8UaJsN2K22XTEXwAn8EjMib3BuRzSUDeeZAcWHFk4twyiAyj7i/BN6d7m bB+A0Q4p3Chu+55JBpb9PfdBdnmbkbLZwnzjL1b68+7gv43UBLFHr3WGwzE9FtZTle6k J4fIIs/1PZ2pICQTsMnqv7C4Laiqa3DXoOIXM56S5ZOzH3JZ9yXUKUUB6FjYvMvLUYBy e4uaP3NC76ZeoLMQ745HC5ZmY4PimQm4xkY+WG1fPL6oeBhlV06hNhGt0Rgp0+zybozj pRt97U6GLogr6z4PmgJWrs71y8LYDGKhRoJ5JhgEt5XrU06P39kBHLiFxn9Mf3MaPk6a mKJg== X-Gm-Message-State: AOJu0Ywp3gUQdVGk2nDNkvZyrqOdH+IEayIzgFSfzhN6aNvypQMgj8jg zj0xQs8T9duTzg6YshsjKIfeoxb6Y9nJ7biUedhZlQ== X-Google-Smtp-Source: AGHT+IENouhYwfq0zksB9smEGLB+VMdhNNrCcscvQWBkeUX0Zkluj03/Xo1edckn4e3jUv+DeKenqbsHwG9y+w7RhbQ= X-Received: by 2002:a05:6214:5297:b0:66f:abb4:49ff with SMTP id kj23-20020a056214529700b0066fabb449ffmr3397127qvb.7.1699367972171; Tue, 07 Nov 2023 06:39:32 -0800 (PST) MIME-Version: 1.0 References: <20231105163040.14904-1-pbonzini@redhat.com> <20231105163040.14904-34-pbonzini@redhat.com> In-Reply-To: <20231105163040.14904-34-pbonzini@redhat.com> From: Fuad Tabba Date: Tue, 7 Nov 2023 14:38:55 +0000 Message-ID: Subject: Re: [PATCH 33/34] KVM: selftests: Test KVM exit behavior for private memory/access To: Paolo Bonzini Cc: Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Sean Christopherson , Alexander Viro , Christian Brauner , "Matthew Wilcox (Oracle)" , Andrew Morton , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiaoyao Li , Xu Yilun , Chao Peng , Jarkko Sakkinen , Anish Moorthy , David Matlack , Yu Zhang , Isaku Yamahata , =?UTF-8?B?TWlja2HDq2wgU2FsYcO8bg==?= , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A. Shutemov" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 2FFB4140020 X-Stat-Signature: 8yjfipgm46gw5bxjuqdd4r6rf3wkgdqr X-Rspam-User: X-HE-Tag: 1699367973-871002 X-HE-Meta: U2FsdGVkX1+VhcrVHgFeqdM+CHXMp5ERScaJOf13eW7wnA6RgjObbFMi/Dmzm1MOrEi1jXCRhyN6jP3H5qs7IhssHmA/dOw+ymMAXiYLOBasG1JHKtYNvdGYsVwTDnk34gyatbCj5/RcPTizc8t0OENJdblA0yw2HUd18A54dCpOMY4oXQc4rsRtBTGT5IQ/4n9DRMt5YXNhG8GkZzxcfTrauYDUSEy3QtDfj3R4n96vuMd06EcrBFuL+8M/+bxfXrmowvFYL3m0MKD1o4kOrdx29Sva9KPDgWA3ls4AM+VdwFKvOvR+UleSSEZEAzzkDT0IhbY0hI4YxeK4Cc9Ejis2YEx5einy5EhqvCyaohv2troi2HA6yVtX6/Krltb+kmQ+Ob+23qoXKSCnuV6z9WvA7QFfGZRGYuNcZsOoKpgzNod2ELP3kZC8RrvDqH1E4SaGUpPhDTuRKMq0fQmbWdrNCJvTZdv9nhoOo22D8O0X6A264aiyjwazMDcdEv9v1tz5yG0OZozOTvwBGEp4SJhbe2jtztYIVrNhi0oA1KPh4uLGoRdMTWur4YVmjos12tTMD5aH7fmoL80SHxQL1lQzftlri/nKjxMmrduw7fAnnTkSwTMn/4lphvx+gziGWc9/QitNh8MSVxdJ4dvT1307bYWxOSzLwmD7FMZcAqU3s3RSR9ZK8UeFax38QGb5o88chHpaOErj/Y4Ys+53UAyLdalCDbAtHJT8PD0RARwpTJyP6yUhjaERE4t+Zj6bUtQ8jH4T68UwB0yB8N75dmfXLoGuHE+JbTuf4HGMFtdyHNIjb2SNLcUOR2uK+qBFbWdoIAcRTnGBJZ24+tuw7/4sNwpAwNQaNkDZQqJXXf6vDOuVrqu+6HEcyF2tk9aSgOgx131m+C2mIjoJ7a6ryqJlx/0fAecWbsOTDb4KnZQmU+Ys4guHhOLI5PkhWNxA2u+EevmioRD+P0PnHfR 3nAdWTJu TlWIud9r0fmo/DxJDxy582OcMMIP0drtOkubTI9a7Ugn+5hOBadCyxwNlh2pA+j600Z6U5KleaxE1b3xOOFLkqVhsEOU0MhhrSSL15hs0cZBxbmxcMfMgb3s2aoRkETXJ4TanSkmbNc4HeBoqZlm3ZXsbYDECIeMdXcc8J5ed7xwZwKKZfn4w3SO6Y/HLq/dP6UJ1VpS5lwZQFcdD5PGkqFpu6o/q8rxj9MdP6GULWn7ejBCuUzjgEVWWJapBIrInvV8ujb9dkDxorkZVzVJ78lNZQaHV3i80m3QR15vG9fKOD7Gkqr+pluU5toFD6O/EAQEAqQKAES3I6hFZuJd0K0llf1E8N0vuiwwo X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Nov 5, 2023 at 4:35=E2=80=AFPM Paolo Bonzini = wrote: > > From: Ackerley Tng > > "Testing private access when memslot gets deleted" tests the behavior > of KVM when a private memslot gets deleted while the VM is using the > private memslot. When KVM looks up the deleted (slot =3D NULL) memslot, > KVM should exit to userspace with KVM_EXIT_MEMORY_FAULT. > > In the second test, upon a private access to non-private memslot, KVM > should also exit to userspace with KVM_EXIT_MEMORY_FAULT. nit: The commit message is referring to private memslots, which might need rewording with the latest changes in v14. > Intentionally don't take a requirement on KVM_CAP_GUEST_MEMFD, > KVM_CAP_MEMORY_FAULT_INFO, KVM_MEMORY_ATTRIBUTE_PRIVATE, etc., as it's a > KVM bug to advertise KVM_X86_SW_PROTECTED_VM without its prerequisites. > > Signed-off-by: Ackerley Tng > [sean: call out the similarities with set_memory_region_test] > Signed-off-by: Sean Christopherson > Message-Id: <20231027182217.3615211-36-seanjc@google.com> > Signed-off-by: Paolo Bonzini > --- > tools/testing/selftests/kvm/Makefile | 1 + > .../kvm/x86_64/private_mem_kvm_exits_test.c | 120 ++++++++++++++++++ > 2 files changed, 121 insertions(+) > create mode 100644 tools/testing/selftests/kvm/x86_64/private_mem_kvm_ex= its_test.c > > diff --git a/tools/testing/selftests/kvm/Makefile b/tools/testing/selftes= ts/kvm/Makefile > index fd3b30a4ca7b..69ce8e06b3a3 100644 > --- a/tools/testing/selftests/kvm/Makefile > +++ b/tools/testing/selftests/kvm/Makefile > @@ -92,6 +92,7 @@ TEST_GEN_PROGS_x86_64 +=3D x86_64/nested_exceptions_tes= t > TEST_GEN_PROGS_x86_64 +=3D x86_64/platform_info_test > TEST_GEN_PROGS_x86_64 +=3D x86_64/pmu_event_filter_test > TEST_GEN_PROGS_x86_64 +=3D x86_64/private_mem_conversions_test > +TEST_GEN_PROGS_x86_64 +=3D x86_64/private_mem_kvm_exits_test > TEST_GEN_PROGS_x86_64 +=3D x86_64/set_boot_cpu_id > TEST_GEN_PROGS_x86_64 +=3D x86_64/set_sregs_test > TEST_GEN_PROGS_x86_64 +=3D x86_64/smaller_maxphyaddr_emulation_test > diff --git a/tools/testing/selftests/kvm/x86_64/private_mem_kvm_exits_tes= t.c b/tools/testing/selftests/kvm/x86_64/private_mem_kvm_exits_test.c > new file mode 100644 > index 000000000000..2f02f6128482 > --- /dev/null > +++ b/tools/testing/selftests/kvm/x86_64/private_mem_kvm_exits_test.c > @@ -0,0 +1,120 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright (C) 2022, Google LLC. nit: 2023 Nits aside: Reviewed-by: Fuad Tabba Tested-by: Fuad Tabba Cheers, /fuad > + */ > +#include > +#include > +#include > + > +#include "kvm_util.h" > +#include "processor.h" > +#include "test_util.h" > + > +/* Arbitrarily selected to avoid overlaps with anything else */ > +#define EXITS_TEST_GVA 0xc0000000 > +#define EXITS_TEST_GPA EXITS_TEST_GVA > +#define EXITS_TEST_NPAGES 1 > +#define EXITS_TEST_SIZE (EXITS_TEST_NPAGES * PAGE_SIZE) > +#define EXITS_TEST_SLOT 10 > + > +static uint64_t guest_repeatedly_read(void) > +{ > + volatile uint64_t value; > + > + while (true) > + value =3D *((uint64_t *) EXITS_TEST_GVA); > + > + return value; > +} > + > +static uint32_t run_vcpu_get_exit_reason(struct kvm_vcpu *vcpu) > +{ > + int r; > + > + r =3D _vcpu_run(vcpu); > + if (r) { > + TEST_ASSERT(errno =3D=3D EFAULT, KVM_IOCTL_ERROR(KVM_RUN,= r)); > + TEST_ASSERT_EQ(vcpu->run->exit_reason, KVM_EXIT_MEMORY_FA= ULT); > + } > + return vcpu->run->exit_reason; > +} > + > +const struct vm_shape protected_vm_shape =3D { > + .mode =3D VM_MODE_DEFAULT, > + .type =3D KVM_X86_SW_PROTECTED_VM, > +}; > + > +static void test_private_access_memslot_deleted(void) > +{ > + struct kvm_vm *vm; > + struct kvm_vcpu *vcpu; > + pthread_t vm_thread; > + void *thread_return; > + uint32_t exit_reason; > + > + vm =3D vm_create_shape_with_one_vcpu(protected_vm_shape, &vcpu, > + guest_repeatedly_read); > + > + vm_userspace_mem_region_add(vm, VM_MEM_SRC_ANONYMOUS, > + EXITS_TEST_GPA, EXITS_TEST_SLOT, > + EXITS_TEST_NPAGES, > + KVM_MEM_GUEST_MEMFD); > + > + virt_map(vm, EXITS_TEST_GVA, EXITS_TEST_GPA, EXITS_TEST_NPAGES); > + > + /* Request to access page privately */ > + vm_mem_set_private(vm, EXITS_TEST_GPA, EXITS_TEST_SIZE); > + > + pthread_create(&vm_thread, NULL, > + (void *(*)(void *))run_vcpu_get_exit_reason, > + (void *)vcpu); > + > + vm_mem_region_delete(vm, EXITS_TEST_SLOT); > + > + pthread_join(vm_thread, &thread_return); > + exit_reason =3D (uint32_t)(uint64_t)thread_return; > + > + TEST_ASSERT_EQ(exit_reason, KVM_EXIT_MEMORY_FAULT); > + TEST_ASSERT_EQ(vcpu->run->memory_fault.flags, KVM_MEMORY_EXIT_FLA= G_PRIVATE); > + TEST_ASSERT_EQ(vcpu->run->memory_fault.gpa, EXITS_TEST_GPA); > + TEST_ASSERT_EQ(vcpu->run->memory_fault.size, EXITS_TEST_SIZE); > + > + kvm_vm_free(vm); > +} > + > +static void test_private_access_memslot_not_private(void) > +{ > + struct kvm_vm *vm; > + struct kvm_vcpu *vcpu; > + uint32_t exit_reason; > + > + vm =3D vm_create_shape_with_one_vcpu(protected_vm_shape, &vcpu, > + guest_repeatedly_read); > + > + /* Add a non-private memslot (flags =3D 0) */ > + vm_userspace_mem_region_add(vm, VM_MEM_SRC_ANONYMOUS, > + EXITS_TEST_GPA, EXITS_TEST_SLOT, > + EXITS_TEST_NPAGES, 0); > + > + virt_map(vm, EXITS_TEST_GVA, EXITS_TEST_GPA, EXITS_TEST_NPAGES); > + > + /* Request to access page privately */ > + vm_mem_set_private(vm, EXITS_TEST_GPA, EXITS_TEST_SIZE); > + > + exit_reason =3D run_vcpu_get_exit_reason(vcpu); > + > + TEST_ASSERT_EQ(exit_reason, KVM_EXIT_MEMORY_FAULT); > + TEST_ASSERT_EQ(vcpu->run->memory_fault.flags, KVM_MEMORY_EXIT_FLA= G_PRIVATE); > + TEST_ASSERT_EQ(vcpu->run->memory_fault.gpa, EXITS_TEST_GPA); > + TEST_ASSERT_EQ(vcpu->run->memory_fault.size, EXITS_TEST_SIZE); > + > + kvm_vm_free(vm); > +} > + > +int main(int argc, char *argv[]) > +{ > + TEST_REQUIRE(kvm_check_cap(KVM_CAP_VM_TYPES) & BIT(KVM_X86_SW_PRO= TECTED_VM)); > + > + test_private_access_memslot_deleted(); > + test_private_access_memslot_not_private(); > +} > -- > 2.39.1 > >