From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57955E784BE for ; Mon, 2 Oct 2023 15:46:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D66E98D0036; Mon, 2 Oct 2023 11:46:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CF0818D000E; Mon, 2 Oct 2023 11:46:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B6ADA8D0036; Mon, 2 Oct 2023 11:46:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A823C8D000E for ; Mon, 2 Oct 2023 11:46:27 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 6DC9BB3BFF for ; Mon, 2 Oct 2023 15:46:27 +0000 (UTC) X-FDA: 81300948414.30.7061C97 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by imf28.hostedemail.com (Postfix) with ESMTP id 96C69C000A for ; Mon, 2 Oct 2023 15:46:25 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=4jEPwsYe; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf28.hostedemail.com: domain of lokeshgidra@google.com designates 209.85.128.54 as permitted sender) smtp.mailfrom=lokeshgidra@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696261585; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3GpMdvzAhSdXiBMXOyN3F1QMGpt/m//1LDMJoTB334A=; b=Dnmjf/DDXgrgaeEw+cDFU6kuEhNqJL3dvh+ZPxtjxY95LJscSmSsk3kFg90DmHLdIfGIqY 1jryS7C8arn5OMKSCPN/IWBVe6TaBZ46kxf6flRyvBqvfKrAqtw+qpqPW8t+BWEzKHZkpl TS+7v8Bq8MgW/flv4Yge7WJLmMIlGwo= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=4jEPwsYe; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf28.hostedemail.com: domain of lokeshgidra@google.com designates 209.85.128.54 as permitted sender) smtp.mailfrom=lokeshgidra@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696261585; a=rsa-sha256; cv=none; b=LsbHqUCZHhY8XvdkUmgQGHeDllVJ9qc2LFuwvMGSbtOI4vPKNCktu2lDCM1OGyswHjdW7K 7ApgoDMV54l36e5kRySnTMdvHOLNwOiJyMLG/seMWFBNSp+lKWdFEjO/p64TCaFJ6zE4CA R1cLD0SrtwJyTaDyP04S8nAT+g6geTM= Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-405505b07dfso19101735e9.0 for ; Mon, 02 Oct 2023 08:46:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1696261584; x=1696866384; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=3GpMdvzAhSdXiBMXOyN3F1QMGpt/m//1LDMJoTB334A=; b=4jEPwsYeUH2ZXL1UUdKZR7noW3dvGC/uywkqixojqyetIonFNhI4CNJlYEovDEaa9/ So3O/cBNMOv8ogS+wWv7kJKzk1R9F+zpyfe2kAlqKOsUo17jvDe7rb+cDn4DVDymthl7 qrCMDTfWwlNGD++5isho1nxOPLQwyPG2rraklM+FHQadrDdj59IqpB2H4acCHyYYhGez /FbHYIjtbXK9dv0CX+IthLIgPv3bW06zr8qPERs4vanw+fXS0a/pV+mSdvRCAfSyojHV 4FG7m5aLlhwQg758KGL8kMe1SsY3ZDvRnXbvTsp1EKNtUHymcgiYeHLzQomQdosuW6TU yTXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696261584; x=1696866384; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3GpMdvzAhSdXiBMXOyN3F1QMGpt/m//1LDMJoTB334A=; b=rEUSLY0UwI1vDDOTq4YMH0+Ktl+qK2sDXfmXRnG0Upl0bhEmWmHqAOFxsRbu9M3xLU 3lAGqQCon09M0bwgKTWFNBfswpzyv5i+0F4zalW6ROWsoGU8Jd+mJw9UP/kEz0lZrQdF 99E+nwdD3Wjd4ccATc1LUYgDSb6kf/SPpyw+4CEjFtFdHWL6ypVC9RslrnYLOJ58bzxY //fwAvSw/hJYO/GjFsWmRfGlcXxXldPQQl0C1Ou8yfiif8tYpvJyub/+LrFzlAAzvE7w 0Bnbu3R4l1ziXrS4gVcTZ5T/dzKStMke7W/8GkwmA3L22je+NbqEvua2SJiU1gwX+//9 l3Ug== X-Gm-Message-State: AOJu0Yw60464evsOQ3ojEjw68N8TRWc56EdOtnYJODS0CLqXkNsvHWlW 84FQusKlowXBgPrOo4YV4htRqwZnudamcpHoEVcmvw== X-Google-Smtp-Source: AGHT+IGEVLTkfWI+L/ulZiTspdc5BVdb2gZ1malMtYF9uJmeShnHEQls1etvNfmxXXXmazmJYi3tfR+ki49hFstKvsI= X-Received: by 2002:a5d:6d47:0:b0:317:6579:2b9f with SMTP id k7-20020a5d6d47000000b0031765792b9fmr2579wri.30.1696261583969; Mon, 02 Oct 2023 08:46:23 -0700 (PDT) MIME-Version: 1.0 References: <20230923013148.1390521-1-surenb@google.com> <20230923013148.1390521-3-surenb@google.com> <03f95e90-82bd-6ee2-7c0d-d4dc5d3e15ee@redhat.com> <98b21e78-a90d-8b54-3659-e9b890be094f@redhat.com> <85e5390c-660c-ef9e-b415-00ee71bc5cbf@redhat.com> In-Reply-To: From: Lokesh Gidra Date: Mon, 2 Oct 2023 16:46:11 +0100 Message-ID: Subject: Re: [PATCH v2 2/3] userfaultfd: UFFDIO_REMAP uABI To: Peter Xu Cc: David Hildenbrand , Jann Horn , Suren Baghdasaryan , akpm@linux-foundation.org, viro@zeniv.linux.org.uk, brauner@kernel.org, shuah@kernel.org, aarcange@redhat.com, hughd@google.com, mhocko@suse.com, axelrasmussen@google.com, rppt@kernel.org, willy@infradead.org, Liam.Howlett@oracle.com, zhangpeng362@huawei.com, bgeffon@google.com, kaleshsingh@google.com, ngeoffray@google.com, jdduke@google.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 96C69C000A X-Stat-Signature: a7pp7r5cek7c8u6fii1msiogu8na97uj X-Rspam-User: X-HE-Tag: 1696261585-339625 X-HE-Meta: U2FsdGVkX19ylczxe0QtU7CIZUJ3MP5JPR98o4LgK9lRDbgvE8urtMM2eL2KPzaS3scLZwpcRqOottNvhzs8gxswybec6g5goZy7g1O7CgoUYLBnTFPezEahJ/QL9j8s6y4RPGdNmmy6cicnf5ZpMOrkQs8rjjyveKtrfSYLmPT4AsFPuCxmu+lXYLnAKp+qwPV0uMCGM2nyTSn+paUQfL+K0xUG4rJY8pv6oIWJq82sU9paCqLyB6UPalWuusYo7yzVNKXaD8VI3hFsDygXmOAuL0lS+H7lMeevHT/VSo7QkQY6pGjHGw23QRyVozKJqDn4LqghaEzmXtX3xmAqRBM5veZFmgdpyBolzYZamShAK7ntkY7pRXTTc8unwz0TqnC5vIgNaA1BQj9pHH6xiG5xM7RUPoGatuK0T/wGfZKSAag9Rm3fW6m8ZB9itsvSWDF9882zNukOVjGZcv+PxymK2EY0/1HAvGbamnUz89XQn0GdtoZV+1PluHtuC+cGeLKxuuYkkomnJacAVatQFt6HJxNanWqJ6O6SpxB85hlQf7LuD0b8OrsJAF9s5qoc99D1yCxbBshmoIBnHDlOKvpcMl2/xloW0SIOweJ8ZF0jiptIvUXtdk9wX24uGdwB0MXY4dM2onFpX4e3Q+ran8AQkhS6wgNN6MFM3sFeAvGVQ9qnDZbAseglLtrT0yrPOUq4KhTfq6WbBm0OBXykjpf6VNLkH008I/GVDXLG8i12dGJDsBEDNHsjnALpsO+Rs9+xGHsqB5Ii5Fd1szDUaGrBKmlTPfMbjX5ENw0yB+cXUTpyiIffGdRNexVDdcVxJvG211AA2cXpDqoam1EkPk7Z3w7H5cUBx4ovXkcy88WL+2MK5+V87zK/Du0XgxGkPG6/LYJTPgvazeEzMiQfVoNwJsM/eiuxv6CvjTiC1f9LG/ZNRB767tK1wKYa2XpoQWCeizn+GOfi9eC4+w+ /ZhRXZu9 G4lzJrHwuXYkSn1qGt1l8U9Sw5oKUMYkFWYwwXNnQSssGoV5xbyu7RJZcqKTl/eSokeyG6/Uhi9NDygNI2ubwp2Yunfvu1cUFKXK3FwDrvDYaxZ/w4xER6pQthbOwk2ak38/aEZRoDlb2A709IT1TUNWgVq94MJn1klLNFrm3CsaHqn6KeK39OKPK8dDzGGzMA33mkMHcSabMsKqeWmpblV4v4lmadeDGEurfOozgMru/RJxzJ+jArKPMV8wdb6HDzymkr9dNFiS/cbd5Nt/obpUuDyBjYhyPAZocAIfX4YkWtqM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.003438, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 2, 2023 at 4:21=E2=80=AFPM Peter Xu wrote: > > On Mon, Oct 02, 2023 at 10:00:03AM +0200, David Hildenbrand wrote: > > In case we cannot simply remap the page, the fallback sequence (from th= e > > cover letter) would be triggered. > > > > 1) UFFDIO_COPY > > 2) MADV_DONTNEED > > > > So we would just handle the operation internally without a fallback. > > Note that I think there will be a slight difference on whole remap > atomicity, on what happens if the page is modified after UFFDIO_COPY but > before DONTNEED. > > UFFDIO_REMAP guarantees full atomicity when moving the page, IOW, threads > can be updating the pages when ioctl(UFFDIO_REMAP), data won't get lost > during movement, and it will generate a missing event after moved, with > latest data showing up on dest. > > I'm not sure that means such a fallback is a problem, Suren may know > better with the use case. Although there is no problem in using fallback with our use case but as a user of userfaultfd, I'd suggest leaving it to the developer. Failing with appropriate errno makes more sense. If handled in the kernel, then the user may assume at the end of the operation that the src vma is completely unmapped. And if not correctness issues, it could lead to memory leaks. > > Thanks, > > -- > Peter Xu >