From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C246CE8FDC1 for ; Tue, 3 Oct 2023 23:39:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 219626B020C; Tue, 3 Oct 2023 19:39:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C91A6B0266; Tue, 3 Oct 2023 19:39:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 091DD6B0269; Tue, 3 Oct 2023 19:39:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id EEA1D6B020C for ; Tue, 3 Oct 2023 19:39:43 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C105F404C8 for ; Tue, 3 Oct 2023 23:39:43 +0000 (UTC) X-FDA: 81305769846.06.FEC2F6D Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by imf27.hostedemail.com (Postfix) with ESMTP id 039A640009 for ; Tue, 3 Oct 2023 23:39:41 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ahwkUs1n; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of lokeshgidra@google.com designates 209.85.128.54 as permitted sender) smtp.mailfrom=lokeshgidra@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696376382; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bmO5pFavK4wOcon/sDd15Ws2jqSVTxN561D6YV6OXgg=; b=gEz8oBcepkLb367yiBLENLoXOHgTrcx5e1d0H6EJ/3FogIFJuhdTXVWZ709IG6qDcs+flB li104iUpXnn55Vii0bWvk/Ca4K2/4n9OzyCPJ/QYHitDEVQochDxAZ4GBLDaMD+FCRyrAO vCyVOz+EYEl7Yu7v87VoteeH4MlUVic= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ahwkUs1n; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of lokeshgidra@google.com designates 209.85.128.54 as permitted sender) smtp.mailfrom=lokeshgidra@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696376382; a=rsa-sha256; cv=none; b=HESepbQsdC6ewINFf3s9lO/63bykAwPZIcp1JowU7drxas1AtvISIbzD9RWj29/7a0nsrH ZhgW3BVkBAplULH9YbslTMte0NfcRLB1Nh5wzQTZo6GOb7Fd1oJlyYO2UpnlTAJebtpZPQ AesYnqzccErduJkIs16+WvF6XS7VpJE= Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-405524e6768so14971945e9.2 for ; Tue, 03 Oct 2023 16:39:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1696376380; x=1696981180; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=bmO5pFavK4wOcon/sDd15Ws2jqSVTxN561D6YV6OXgg=; b=ahwkUs1nixh+LvJzzJUEFeWEjOef7ZSgOVXZWs6BL1gsHOCJ99I5cz1O/Uvif4S3+C 8g4QpHIDApXRHqgiwKOOAdPRPSx0tWtym77isbg2MiqOW0olM2YnOTvbYI1FyWF0D2Vf LZyDYrPKaijXq0P01eDmkoxbgpyePZrxgv8QlIQgA6oTNC7O2gpYnBIFgASpUQYmKNTz QzmQ2qG7NdMlmA0ZDeLIH6QAlHgT9lGdXUUFXFJ3KZg7+pNRCbqOALeAmKIWKhJfzPiN OV4G4wZc8WzCDFGtqblln3y3W0XgAIZWXtqqoykVaUF9rbFyHy+9B+VZAxOLo75UluOp eCeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696376380; x=1696981180; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bmO5pFavK4wOcon/sDd15Ws2jqSVTxN561D6YV6OXgg=; b=P7fE25/ypxkH+DOuiK8hBrGto7o7t8THPwk7to1Q1TgjjfFubT2cS+BjLUYnjlI7IK xRWZlLqoNFQTUmpfZijI521abi5w2i8lDyvVWzeQQHjxf3PetmmxvVxtCC718v49TOgm PF0yEbuZCUwcTDk0eSGHINQzFZ/SNc5kOB4C6FArStFVUKPBw4Add3efjmA55vFr4wCU BHfD5q6n8AOqWT2RsuhZNSOtYD7ymzJDIxEr02LAYENl74i4bxPdieF0X2193/LiaN9B rnrzPbArjSK7I0prd6ZGfrp/AZGq1vDE6J3j6fyCqa2tRvTe7kBo6vs21vTuLvrLsbVR IXgA== X-Gm-Message-State: AOJu0YzDAFRLX7Hu4IwGhSK4an9J2IheWx3Ra492NkL0MfN/5hkV2H1x dvllQrWALQyDLyBv2zlIlhCC6iBFp6U9Bej+FfdYTQ== X-Google-Smtp-Source: AGHT+IHsUX5Map++iKhy04cGuLtW7ImZgA+PIyHNa+JhlI79jYhvJUXLaOyVS+J7sm2Cvgu4hfMreGatARTKDQkrC+w= X-Received: by 2002:adf:f491:0:b0:317:e5ec:8767 with SMTP id l17-20020adff491000000b00317e5ec8767mr638253wro.21.1696376380430; Tue, 03 Oct 2023 16:39:40 -0700 (PDT) MIME-Version: 1.0 References: <9434ef94-15e8-889c-0c31-3e875060a2f7@redhat.com> In-Reply-To: From: Lokesh Gidra Date: Wed, 4 Oct 2023 00:39:28 +0100 Message-ID: Subject: Re: [PATCH v2 2/3] userfaultfd: UFFDIO_REMAP uABI To: Suren Baghdasaryan Cc: Peter Xu , David Hildenbrand , Jann Horn , akpm@linux-foundation.org, viro@zeniv.linux.org.uk, brauner@kernel.org, shuah@kernel.org, aarcange@redhat.com, hughd@google.com, mhocko@suse.com, axelrasmussen@google.com, rppt@kernel.org, willy@infradead.org, Liam.Howlett@oracle.com, zhangpeng362@huawei.com, bgeffon@google.com, kaleshsingh@google.com, ngeoffray@google.com, jdduke@google.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 039A640009 X-Stat-Signature: 1tn1cy5jtbk7j7y1qjiga8jofmnzsgkb X-Rspam-User: X-HE-Tag: 1696376381-820695 X-HE-Meta: U2FsdGVkX1+vh46OzpbWX1kkRSfJgFaBn5ERbVE4LwgUmniDE3L3uB+mfG/dywnl4oloih4cPUHoe8Ni9WkywGSWnCKOqhwkRQlYqV/N6QYtlQhC21uM33Se0OKTfV8cYLBpmCJta6QXUP1eVt4uH91ajHPRgWrG53uZie16Z4HWIGFZA2HE6kDZ3Fvr4im3SMW9F9nosOMc55jmmd4mm+7D3Nd8EUej2ciOcYI0eCelTiTwGH+oP5QTD9s1WRKg8HC4t1+mZRNQ24xsZOFVun/LHRUkkUBKGfc+KpVCBGWZhopXECYc6vrfpim1jAA3kltp+P/SUoD1vTrCvKo/pQZ+kP6TG4InhF1pWiv8zQPlCkQIZYD1OA4qeX4fk8b5dQoZOK6plgeFjt0nsL4WVIUALnEUWViIkMEMRahlKOVNj+MysQI7G3lksZajFbPa3Peeaf6+INdGVp2rwfr54zXoar42RPDtuq7JgDWUEZcGWbhdo8Ndna3v0q2Rso8JgNblaN3gGbUbwDrC8GVA+b/2mu+v/qHhskWYagngTWhC5A7pou4/IDvTBvBqNjnyNMD6x+xLP+uAWb96ZXwe4cFHdgOiTc5PEuoe5z/6DvE9oJI4km6cgSF/P/gTDcl3TuZYjhbWDYNu7476swKZo2gRKa8Tecog6iPr0IQx4bhB2JTR1XMXLdmTj85PzLtvlAV56uJ/AAvLfan2COhKkfJRRy0Kr6PimEDfAwJcX9RdRBd2eVfpJaoD8NQBLxH6Y+H7DGTja9Y0dRkufy8zHihqGmCZKjUxUh6JOVDzBsyqnj4JWzq86Cu3WSZPBPbKcLvv2AS1VusE2sRSH3YvrD+Zoml/zgDlWcvS5B3GuVR5pe+Wh+jvWFsZ3T+Hx3Gj/p2MeshJRMCw8Y8iCYDt6kVLlpaW3feQyyouCSgCLK5WBQ+na4X8DNoXIlVOMPt7fuXkUjmfdiMvXtKbTVB 8HBsIHqG BOWShLkHuC2tR5xzw/AfaYYGmf8f5rYkElKEXXt5RmSBdkfH1ycqZazm6x637BkKPiF3yeN3PcqDD1QM6tep3g1JKGpdOouG8Ode0GeYEQsjlgg7cSSKgeIqyDAt5KbltTOFPKlpV3V+7K5NZKXIEc574ADzCBw3N8JYqL0slLcPrkzVEFG+jm7Qo+QaPoWsZbnb7CD9s+uRvtR6FnylGj6DyGoarECKPBSG4YBVmXMMrzwMOKGzVju26dkxEA83268Iy+ifMarpsToz53RRwQ+0RBI5skEF17yFdNcDEsK+OVWO2o1Yhm4t0J1yKqV2Lrw5ehlf6k6Dkg5Ph0JrRXdPQa2CyrwEM3AP+DjEqtnGhbCbH0KwhYYT50hECh6WdrU33WbWSCD9lgQ/DtLYwzmQFx6yWtIcnaGPcdA0EUd4ZmUw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.045261, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 3, 2023 at 11:26=E2=80=AFPM Suren Baghdasaryan wrote: > > On Tue, Oct 3, 2023 at 2:21=E2=80=AFPM Peter Xu wrote= : > > > > On Tue, Oct 03, 2023 at 11:08:07PM +0200, David Hildenbrand wrote: > > > Sorry I have to ask: has this ever been discussed on the list? I don'= t see > > > any pointers. If not, then probably the number of people that know ab= out the > > > history can be counted with my two hands and that shouldn't be the ba= sis for > > > making decisions. > > > > For example: > > > > https://lore.kernel.org/all/1425575884-2574-21-git-send-email-aarcange@= redhat.com/ > > There was another submission in 2019: > https://lore.kernel.org/all/cover.1547251023.git.blake.caldwell@colorado.= edu/ > > Though both times it did not generate much discussion. I don't have a > strong preference though MOVE sounds more generic to me TBH (it > specifies the operation rather than REMAP which hints on how that > operation is carried out). But again, I'm fine either way. That's a good point. IMHO, if in future we want to have the fallback implemented, then MOVE would be a more appropriate name than REMAP. > As for UFFDIO_MOVE_ZERO_COPY_ONLY vs UFFDIO_MOVE_MODE_ALLOW_COPY, I > find it weird that the default (the most efficient/desired) mode of > operation needs a flag. I would prefer to have no flag initially and > add UFFDIO_MOVE_MODE_ALLOW_COPY or whatever name is more appropriate > when/if we ever need it. Makes sense? Agreed! > > > > > -- > > Peter Xu > > > > -- > > To unsubscribe from this group and stop receiving emails from it, send = an email to kernel-team+unsubscribe@android.com. > >