From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC270E743C3 for ; Mon, 2 Oct 2023 15:55:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 30EDD8D0040; Mon, 2 Oct 2023 11:55:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 297388D000E; Mon, 2 Oct 2023 11:55:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 111078D0040; Mon, 2 Oct 2023 11:55:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 00F848D000E for ; Mon, 2 Oct 2023 11:55:50 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C82F81A036B for ; Mon, 2 Oct 2023 15:55:50 +0000 (UTC) X-FDA: 81300972060.16.BF935CB Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) by imf06.hostedemail.com (Postfix) with ESMTP id 92F8F180002 for ; Mon, 2 Oct 2023 15:55:48 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=dpK20uQZ; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf06.hostedemail.com: domain of lokeshgidra@google.com designates 209.85.221.43 as permitted sender) smtp.mailfrom=lokeshgidra@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696262148; a=rsa-sha256; cv=none; b=C0SRW2+kEHbJXhFKRggIaRCMchY5D7Hy5rDopFe27KkoPZ8ZrZtKY6mXGNTKpZDTd2VuoZ 2ppQ0iVxhIUL0UtpHbu1e8HzQRUg3L5gSN3l1L/XFzO9TahUyn9be0ooa66HdzjgMZL8BB 9bnNyp8ByxOgiUkzGfmcAR2PsPBjliE= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=dpK20uQZ; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf06.hostedemail.com: domain of lokeshgidra@google.com designates 209.85.221.43 as permitted sender) smtp.mailfrom=lokeshgidra@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696262148; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EE6kgS5NryeWM2eNYlqUNOE7bxNuh8Nz6QyL7U8srO0=; b=24CWzKl194eab2GCYDxHGdYdQrZPBo4mgfgxoCu1tM3LbXC55l3DEujVJ1MIAxocG8iQ5+ nsjitrcfzbvG+HE345RQTgaNGd66m14WDyF/bFXue1EIcnnUrS37aMQGeec51f5p3mrpSQ wzQpPWovUTDlt6x4/yOEMxrxHj8vSzY= Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-32336a30d18so8518099f8f.2 for ; Mon, 02 Oct 2023 08:55:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1696262147; x=1696866947; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=EE6kgS5NryeWM2eNYlqUNOE7bxNuh8Nz6QyL7U8srO0=; b=dpK20uQZBW6lmn7RxB1Cf1a/Zp39Ygt5UIPaZNUh3aX24TheYXW7Syb3AAbsr9OsUR ZfjWRFUujVC5cFroH+t837w06asf3vrSd3HP4m+rGyhkQHMdE3qO2cxFzZtvcC7SOLsz H/5RfUCICzqwgDK2olpcsPi+tG5o2UqCJZS/X1bY7Cn48i4cvGhGK46ZNVtI2+Q28XdZ J06SxRTtvunL/r3kOBYCuPIYbwPB5g0KRLB9bmLymPQDsBXLJsbB8XJxiawzcKGnVLH5 stl0W8vFXFGHihXFxZhWp2eW1E5yjgsheBPhOqA3ZEq55o/g75YoAJRqHVblxHtaVC7e e4CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696262147; x=1696866947; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EE6kgS5NryeWM2eNYlqUNOE7bxNuh8Nz6QyL7U8srO0=; b=nAUCiwamSX5WH74H8BLIAIRYvZfNQ+QcD52xjmMlOIf00QJj7oca1k82rMqBN196Y5 lquiF/nItjfrwUTiglxj4Wx9eS7t98cIZpUtYDeN2uBf+AZmWShUYKHp8o7+A1FFAel2 uHlD7D80CLMromqXFfat1FyHNJIic8CE+qhqnA6lf12wftrfLO9Wu83LUvkMJXRu2b4i saI8T3v7NcepTyDjr51YvH3BIRjY0XsrUh7a1aqN8tataRj9rKWBT5Rxsg5+UUJwiXyG HT3J5OG0L5GEIay1ea6bAsb+qVRmdLXEhIM+huCbQW/KMtreVEeUKLIhUVcsNT6aMyWa XGvA== X-Gm-Message-State: AOJu0YzU1T6nZ3NqxUtFIn6HwurF55IDOsuBblGZr7ObE8L0oi0sh0eZ y3SjUQq0ZgNH6olWFyR3iMPfE7y/VGOQdIQ9HAnmzg== X-Google-Smtp-Source: AGHT+IEFiHW93RRhSDCuf+q2eF19Rn8mISAafthoGCjUC4BHJ+ls1MS4+3DZHpu9OZqLfupwwY4gh+J9TIS9DnIhBRI= X-Received: by 2002:a5d:610a:0:b0:314:1f1e:3a85 with SMTP id v10-20020a5d610a000000b003141f1e3a85mr9647998wrt.61.1696262146901; Mon, 02 Oct 2023 08:55:46 -0700 (PDT) MIME-Version: 1.0 References: <20230923013148.1390521-1-surenb@google.com> <20230923013148.1390521-3-surenb@google.com> <03f95e90-82bd-6ee2-7c0d-d4dc5d3e15ee@redhat.com> <98b21e78-a90d-8b54-3659-e9b890be094f@redhat.com> <85e5390c-660c-ef9e-b415-00ee71bc5cbf@redhat.com> In-Reply-To: From: Lokesh Gidra Date: Mon, 2 Oct 2023 16:55:35 +0100 Message-ID: Subject: Re: [PATCH v2 2/3] userfaultfd: UFFDIO_REMAP uABI To: Peter Xu Cc: David Hildenbrand , Jann Horn , Suren Baghdasaryan , akpm@linux-foundation.org, viro@zeniv.linux.org.uk, brauner@kernel.org, shuah@kernel.org, aarcange@redhat.com, hughd@google.com, mhocko@suse.com, axelrasmussen@google.com, rppt@kernel.org, willy@infradead.org, Liam.Howlett@oracle.com, zhangpeng362@huawei.com, bgeffon@google.com, kaleshsingh@google.com, ngeoffray@google.com, jdduke@google.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 92F8F180002 X-Stat-Signature: satjc94819bbg475aes4ggij13kora78 X-HE-Tag: 1696262148-935279 X-HE-Meta: U2FsdGVkX19kieySeyLBElvNkiDKghc/7G4Z0t91xmETpQ4DHwyQvp680eq1lhPy2qEgr6o5mzMOzkxxvOvfd10HzOIBngnyIBHXb5uFmqh6F3lT6z+xR9v7yNQE7Bq04cqvzZ08P0NSd/TvazbWxYZ6g223oKA810Rp9WKkK1eK7qWYo/K8vogbCI4nqZ/3YfCrf7AOeaPm3/ORVnYtRH51W8CkETQIFGk+A7WoDNY8SXbNMGCj8YUyEUsBMK944CotgTfOankwohOnHN7UmBZLm+kfcptNkcN5XvxZYxrM1zBRQiVGCVknGtEgkTRTQT9dcAs0dg/ZJf8Pl7PQ34TYC0+NbkO9uq55yLA30HwW0zcQpQJ8j4vNA8Ny+M44dX4tKJC9AdsdHNGPyJtDlTh74XWPaX+8UeoEqRFosGlhCpGWWD9xSq3lY2IArt48/cgGeJ5NHY3zgyHMP1eePB6gbk9RnnmgBHg3FVQCGzZyagFeb8jn8aX6MDjCrIfAYLhE5ELyLw6sop6sNLPIPYbf4bfbOlBlYd3Sq9JtwROSDfjzGPQoCpi8GR3mmSrGQTLWldMFJQrZPAYYgG36n1SATa+O5grhou2rmmJWKx0DYJmbt6EudcMh8x5XBE6mRTRPFIVStrfq9s2TTLlj8/BISfiLCzFJnTQzLxiR8KQCqAKw5LA9j8J3L1T8iRLmGg9tSf2UgQ71K0Vnq1+m7HgC1nMwNRmPxSS8qvKaevGHssx5I4kEQIyQjU9JzV29bYIqCwWYsaBICgDlC8iE4xqexFF86jIzD+2YEgSykRWagOGIdq3I0cjq/j7mlGiQl7cztgbVR8g4cSZXnBZW5zWeEFndTOoaG66XNK91Zcmvg8hdRTWazvd8sPAEM0wy6plG17w7FDNykBGMPIcHMKncY0K+j1CERVvivG+chQDYHrwfINCNciJnBby7sdR89sG57LFMHw7gTOIMA3C J96xH/uu F2A4NOaIurWazsTrUAycRFCujXKKNZ66ujbfynJXxZ7hnE+NwBoAXJadt1HthyOZdGFAY5kIcjLqKLzWRx2L7FFNqaIRafi+ng8F7Es/Cc0PsGNNUKEvGVIjmOWfHAzDiIy3asUWQ4kZQ2kF76XJZXx7rQH61SW6zlnnyAEMYJmqp0FPp6bdN+WalNLUE9wp3kjnTbaJ0xYV9BRVlGgOrV3NibzxhWfb5m18ui8vqdlnjYTZ1xRQMMjD7ptFbOJsPKksiXLUrfxkq78Pe2zgtPqMun3MLUrIio7K1mPIttgf7JMqcgjmSQZi1UIohL9acYWXg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 2, 2023 at 4:46=E2=80=AFPM Lokesh Gidra wrote: > > On Mon, Oct 2, 2023 at 4:21=E2=80=AFPM Peter Xu wrote= : > > > > On Mon, Oct 02, 2023 at 10:00:03AM +0200, David Hildenbrand wrote: > > > In case we cannot simply remap the page, the fallback sequence (from = the > > > cover letter) would be triggered. > > > > > > 1) UFFDIO_COPY > > > 2) MADV_DONTNEED > > > > > > So we would just handle the operation internally without a fallback. > > > > Note that I think there will be a slight difference on whole remap > > atomicity, on what happens if the page is modified after UFFDIO_COPY bu= t > > before DONTNEED. > > > > UFFDIO_REMAP guarantees full atomicity when moving the page, IOW, threa= ds > > can be updating the pages when ioctl(UFFDIO_REMAP), data won't get lost > > during movement, and it will generate a missing event after moved, with > > latest data showing up on dest. > > > > I'm not sure that means such a fallback is a problem, Suren may know > > better with the use case. > > Although there is no problem in using fallback with our use case but > as a user of userfaultfd, I'd suggest leaving it to the developer. > Failing with appropriate errno makes more sense. If handled in the > kernel, then the user may assume at the end of the operation that the > src vma is completely unmapped. And if not correctness issues, it > could lead to memory leaks. I meant that in addition to the possibility of correctness issues due to lack of atomicity, it could also lead to memory leaks, as the user may assume that src vma is empty post-operation. IMHO, it's better to fail with errno so that the user would fix the code with necessary changes (like using DONTFORK, if forking). > > > > Thanks, > > > > -- > > Peter Xu > >