From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61137C433E6 for ; Tue, 19 Jan 2021 18:28:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CAFB122D2A for ; Tue, 19 Jan 2021 18:28:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CAFB122D2A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=soleen.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 29A836B0036; Tue, 19 Jan 2021 13:28:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 249256B005D; Tue, 19 Jan 2021 13:28:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 13A096B006C; Tue, 19 Jan 2021 13:28:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0189.hostedemail.com [216.40.44.189]) by kanga.kvack.org (Postfix) with ESMTP id F1F6B6B0036 for ; Tue, 19 Jan 2021 13:28:25 -0500 (EST) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id AF793180ACF6C for ; Tue, 19 Jan 2021 18:28:25 +0000 (UTC) X-FDA: 77723359770.14.bath01_1e11fc927554 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin14.hostedemail.com (Postfix) with ESMTP id 912CA18229835 for ; Tue, 19 Jan 2021 18:28:25 +0000 (UTC) X-HE-Tag: bath01_1e11fc927554 X-Filterd-Recvd-Size: 3723 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Tue, 19 Jan 2021 18:28:22 +0000 (UTC) Received: by mail-ed1-f52.google.com with SMTP id bx12so8714159edb.8 for ; Tue, 19 Jan 2021 10:28:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TEivdsLh035xUwd80O8uoWTflxLp0NXnOA1sF8M3+78=; b=MZzAE+lcoJitaKLsjfwICAcGqTemrfvFhimcvi4oG08ftrrRPeijQsl1WSuCgpj5pH KYQSqhemslpy00yUaKBzaldVVL8J5PGb9ucoc8nklBVBOXd/T4RjDFyngbFiJTo99Ho6 5yib6gLuXqtlWtbUkyKMxeKBB9Og3upzBSrJvp+OAmN7cSMR1IvqmISSnMyj8P6ZLD8A GWPSxWq/E6CLhQzK57oQNnKIBhXja+5g3NGQ58PhNaOSXLDFggCh9PWeD3IaOlgFqoio 8jsxGA+NsKalohFP96bDgXGgHmSaXtiVxI6/OvZ5jPJift1+w1ja1OD6l2F40X3QVeZB sJxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TEivdsLh035xUwd80O8uoWTflxLp0NXnOA1sF8M3+78=; b=ZOYP2CMMHhIgCGINLHKV9xxkccmMUOHqgSMogqqQ+8odG+aORY7FZFFfobbBtO9HPx DHbiC1ZEhWpLt1byvem0uv3Tepg958dnZ0RXgu17mhfA0vEmMH+abcDKO1XmG+Q+jBcG yS8vxSuDD8YNWykJ4gaePQKpj+mVdXFLuktaVIhZxX6lXAMuYosq+0a20vLXYpIAGRo9 J+2qgtgAhD3SqrfKyiIs1p3KgYJ1PBtXE7+XIMgAgxEFQFngAyqvRRF2VU2Tyj1psv/c gso/5hzf9Nbhxo3KJgkUFBGP5S8lYAKS2QV+lns3rbGYm3aWop3VQCIRjO4A3mOwBUU9 Oadg== X-Gm-Message-State: AOAM532rClR65mQioCcsgMcVfk+j4of2MZSpE1AR6jeNjePcESkUuZVv UyfojLxAm0B5WTjTanOkoRq4nHdMSfbXnqv5Y2l9KQ== X-Google-Smtp-Source: ABdhPJyIsCE/h8KXnasJlCc79A7cfT2d9l0qv5z4TSIJoVr5CTAM59t6fXq9KkFRvgJmTJyeyJLvPxOfWc7tngLckm4= X-Received: by 2002:a05:6402:5246:: with SMTP id t6mr4448005edd.62.1611080901331; Tue, 19 Jan 2021 10:28:21 -0800 (PST) MIME-Version: 1.0 References: <20210119043920.155044-1-pasha.tatashin@soleen.com> <20210119043920.155044-5-pasha.tatashin@soleen.com> <20210119182200.GZ4605@ziepe.ca> In-Reply-To: <20210119182200.GZ4605@ziepe.ca> From: Pavel Tatashin Date: Tue, 19 Jan 2021 13:27:45 -0500 Message-ID: Subject: Re: [PATCH v5 04/14] mm/gup: check for isolation errors To: Jason Gunthorpe Cc: LKML , linux-mm , Andrew Morton , Vlastimil Babka , Michal Hocko , David Hildenbrand , Oscar Salvador , Dan Williams , Sasha Levin , Tyler Hicks , Joonsoo Kim , mike.kravetz@oracle.com, Steven Rostedt , Ingo Molnar , Peter Zijlstra , Mel Gorman , Matthew Wilcox , David Rientjes , John Hubbard , Linux Doc Mailing List , Ira Weiny , linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > This should have a fixme too, this is a bug. OK > > The patch looks OK, but I keep feeling this logic is all really > overcomplicated... I agree, I have a simplification patch for this logic, check out patch 12/14. > > Reviewed-by: Jason Gunthorpe Thank you for your review. Pasha