From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3EBAC3DA4A for ; Thu, 8 Aug 2024 18:55:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 536996B009C; Thu, 8 Aug 2024 14:55:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E7426B009E; Thu, 8 Aug 2024 14:55:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3880B6B009F; Thu, 8 Aug 2024 14:55:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 186526B009C for ; Thu, 8 Aug 2024 14:55:17 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 884F0814D6 for ; Thu, 8 Aug 2024 18:55:16 +0000 (UTC) X-FDA: 82429981032.11.ADDF005 Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) by imf02.hostedemail.com (Postfix) with ESMTP id A41EE80027 for ; Thu, 8 Aug 2024 18:55:14 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b=fYcon0X0; dmarc=pass (policy=none) header.from=soleen.com; spf=pass (imf02.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.176 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723143305; a=rsa-sha256; cv=none; b=gNgLBTFPsOg5UFkjEnak2YTllR+Ar2SQwRA/YWSPC37tQFd71sfwLW3w6AuHuzoNI49jdJ 5zF4yLg5/TZhQrusyP7C9sfDa9hV4BVfmkARWRk8MGdu2tryyJETCOvR+6zUrz9Mstlyoy zL+kY9DRc0EI0C8FuwrBExr/sZvPG4U= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b=fYcon0X0; dmarc=pass (policy=none) header.from=soleen.com; spf=pass (imf02.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.176 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723143305; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DO/Z3SbablodSUL+R3JeSvJ8+7bDWABWfQskJp837f0=; b=4I4x2PEhmBu6b9fPexq6Dw83pb7VBGgPTBZswgFH6bR5Sv5YJI5pRWdCOmXGEEfB2V4fbE E+oX/ahqREKhXRK8EBJHzZcfDwJaG6wStaew8vfZId9ka4FjBU5nGcqJTdcmUyyjMVQgn4 SA/OWCyFy3TKvFxtL8cJft4sgt2dR4k= Received: by mail-qt1-f176.google.com with SMTP id d75a77b69052e-44f666d9607so6165621cf.1 for ; Thu, 08 Aug 2024 11:55:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen-com.20230601.gappssmtp.com; s=20230601; t=1723143314; x=1723748114; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=DO/Z3SbablodSUL+R3JeSvJ8+7bDWABWfQskJp837f0=; b=fYcon0X0efcLbJLrsVR45mwQKIrhYBYr5oDpxYJgpeqfXjSqBmkzLUpA/zZbGmaRjK QvFKCFMeuMGPvl8SvZuxUGPASWP8jqNqvZkhWuzEGJ9N1wuJRFEauA3sci7iSBjaktx9 5T5DdKDP8fQ73jDvKK9lSfhyMoxuzmveYtCSxwCLiZF0wVav2YEMo0ZMfITBwwEkWH6L Lhz/cbzLaCSMFql05ydHCLRXFQHhUiessD19evLLlYPKl7MeUdu/K2uKxAzceIkg0jTj vSNCLNMSYfq6xp8yarJ2em9+aEerqnmJyKPOtLu3MBkoeIf/HYvcLGlAJLwFkOT5tdD8 0bqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723143314; x=1723748114; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DO/Z3SbablodSUL+R3JeSvJ8+7bDWABWfQskJp837f0=; b=NLpxPeVSo1TezHXxvzVLPpKgsNRwNCsaDURbdmW3hrRTYjF1ALmeglyCs9DG/X2QWE XZGcnR3yfzpxZkY2Qaq3v8dCb2iqf1unukZqnua373zxnarTWyhtYC6ZI3SsEE9BtYm3 6PYyLYGLj57zF5JB8d+nyAlWffsaLha+6+wqd04Ezs6RNXdLWbgZXE0qrp9U2o0ptKp+ HxRMRtSrxwZwuC05wRUHqy0XQjoSXfw5idNR3vthY4c9Ms/Eym9ZQPvfkKD6UkJeN4KX eEFAWdKs2zgROT5/sIDRkDISqdUKg4aUiyzonO/HYRHekjcHKRF1rn8K2PwS0prSP3Mi Y1Xw== X-Forwarded-Encrypted: i=1; AJvYcCXQyFYk5ckThtZE3R6QWxyULGMx2mjVR7H/WEylR5+4+005L0Bt5JuVXJaK7B9U+H4OcfgF1eTeAp15CqVcviCLxvI= X-Gm-Message-State: AOJu0Yzn1BScllFjdSrBD1Mwx9Ao9PeOUdhPjgA7QLn73WTlpPEmSke2 Qx4dfavB4tEjMiyTu49yap+nWXGi48QMVW/3a4MkyACGmV8/MeuJR5aHvr3oQmlGl30z7/8OcAw ZyvDUg9YgKI9wpnDMJJpk08FHBHer63OWroB5Jg== X-Google-Smtp-Source: AGHT+IGCSGjuz41NNdGhYP00jq6qPDxX9zDID06r1oWKzkL+fM3fiKkjBrJ2CXqN+zVBtulvpbY7hra6xTPzoF1wD6c= X-Received: by 2002:a05:622a:4ac9:b0:44f:dd52:8aee with SMTP id d75a77b69052e-451d430ab3fmr39557171cf.46.1723143313673; Thu, 08 Aug 2024 11:55:13 -0700 (PDT) MIME-Version: 1.0 References: <20240808154237.220029-1-pasha.tatashin@soleen.com> <20240808154237.220029-3-pasha.tatashin@soleen.com> <24003526-ba18-42fb-b5c0-7b89872eb61e@redhat.com> In-Reply-To: <24003526-ba18-42fb-b5c0-7b89872eb61e@redhat.com> From: Pasha Tatashin Date: Thu, 8 Aug 2024 14:54:35 -0400 Message-ID: Subject: Re: [PATCH v3 2/4] mm: don't account memmap on failure To: David Hildenbrand Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-cxl@vger.kernel.org, cerasuolodomenico@gmail.com, hannes@cmpxchg.org, j.granados@samsung.com, lizhijian@fujitsu.com, muchun.song@linux.dev, nphamcs@gmail.com, rientjes@google.com, rppt@kernel.org, souravpanda@google.com, vbabka@suse.cz, willy@infradead.org, dan.j.williams@intel.com, yi.zhang@redhat.com, alison.schofield@intel.com, yosryahmed@google.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: A41EE80027 X-Rspamd-Server: rspam01 X-Stat-Signature: 9pcadzzkm3dn6zsd1hrs1sr736xa5arf X-HE-Tag: 1723143314-265440 X-HE-Meta: U2FsdGVkX1+K4j6RbaE0wwzF5a3tAnBDlFiu4Yblfz47/K88PC+4/QmOAz8B1XFYFlqbSI1OVMUVwEBvRhEYJzCasiQGCquRu+3WUgklJnwG8uiirHZWz/jbPZ4DhqL4brS0ebIPWJWdVN/g7Gvy2Igr7mdNPFN0PLbnHXAj2b/HtJwlolxOE1dXZxwAqaOjfc9Oc0r4CuHBH56dbgPCM6PlpKtfEpfgshGWoI4nnKLX8oL4VN9Nip3lzMzni3H1Moc/b6+rOxWXlEnRBH8K6uz5VRmOZRnsRSV7AryMwes6TUdaWO/Jd5eYjUb1HOJidYZsGpuzPNCWmkN2dAm0CDUlO9t4Tey1IUeRCQYNvYN91XwuvrSA+USP4AmyyARMo51b6l/kTEMhJDHouwpaz2juTDGWiLMHbGqH8vTz9owyaovEa7gItkJJjmMhDgi3cyJvGLXEJGRVUjVJcS15bcTdYyM+IsDV3/dYVOVRZDZ6Ni/BkxiFX0diGx6j+so+obzriv8jHy1FYB54osP4lzGkOgRE2bfZKs652okCIHKHS/g4t4dmoXejuv4I3jB88WAVfrokpl92d56PjspEMP9qBcAq7/9bm9efHADr75yVb5CSa+Yky5hpOnyBv3LctedLaSJnFZlLTMXWKgq9zJvaaqc1M4A3imS6h9WAFKGjIh67eZHJt5gDzHYp1FRTDkSam8TBx1gzBqrWU32tG6Jxu1Lpj9HgC/MGVLZzuasIp1s6wfmuhcFUp/tllURnol9jtItqqFNc6NPf4iLKCG0wLik5AYwarj2ngHWzWghZ75xVwiClF6N4Y8dl2UgC62SkYEI5XI8TQ8Tj3AInKNyRVauV1hKNhSJ6wJiLRWJb5AJWCEqN8RaQwpkWclAL/klbHqMtHh5ynkrewVmo9h10ChSrvrkwhUlEU+0ild5dRSOiVgrSm8ucyopHb3ChT2IyDquvcapfGeQCEna JG3m2vRy nCNP6ZNZ+DsD6I3TaMFDkLwSeY/bO7PFkDrLPGAhrthaTe8KbdHZHL7/47F/EQe6C+wPnCbJpdfrWnmkkhImaCCKdlIw8k6PZrYxIx7RRxLJ7UixeSFGmTNmV2WhMFjTzq6cviVEorFU/PYQM4MhIqWDIppOhvaMZqppIXMHH+MAt7QcwO/En4sHfigtx/j7bje2rE05W9ieeZ3gH2KOTYpQvZ4gPmzY1cd9QTKeCaSDmWEJ4PPT7XcTu9n1FGscm2FlCh3HkSAXblASe0Amek4sbMLTO+2h3pobn4WVWUe+fR7EElqc28SJexw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 8, 2024 at 2:12=E2=80=AFPM David Hildenbrand = wrote: > > On 08.08.24 17:42, Pasha Tatashin wrote: > > When in alloc_vmemmap_page_list() memmap is failed to allocate, do > > not account, the memory is going to be release at the function exit. > > I would write it as > > "When we fail to allocate the mmemmap in alloc_vmemmap_page_list(), do > not account any already-allocated pages: we're going to free all them > before we return from the function." > Will change. > Acked-by: David Hildenbrand Thank you, Pasha > > > > > Fixes: 15995a352474 ("mm: report per-page metadata information") > > Signed-off-by: Pasha Tatashin > > --- > > mm/hugetlb_vmemmap.c | 5 +---- > > 1 file changed, 1 insertion(+), 4 deletions(-) > > > > diff --git a/mm/hugetlb_vmemmap.c b/mm/hugetlb_vmemmap.c > > index fa83a7b38199..70027869d844 100644 > > --- a/mm/hugetlb_vmemmap.c > > +++ b/mm/hugetlb_vmemmap.c > > @@ -392,13 +392,10 @@ static int alloc_vmemmap_page_list(unsigned long = start, unsigned long end, > > > > for (i =3D 0; i < nr_pages; i++) { > > page =3D alloc_pages_node(nid, gfp_mask, 0); > > - if (!page) { > > - mod_node_page_state(NODE_DATA(nid), NR_MEMMAP, i)= ; > > + if (!page) > > goto out; > > - } > > list_add(&page->lru, list); > > } > > - > > mod_node_page_state(NODE_DATA(nid), NR_MEMMAP, nr_pages); > > > > return 0; > > -- > Cheers, > > David / dhildenb >