From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26035D591B2 for ; Mon, 18 Nov 2024 20:42:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD6D56B008A; Mon, 18 Nov 2024 15:42:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A87246B0092; Mon, 18 Nov 2024 15:42:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 94E096B0093; Mon, 18 Nov 2024 15:42:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 76A396B008A for ; Mon, 18 Nov 2024 15:42:52 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 32F201C63A8 for ; Mon, 18 Nov 2024 20:42:52 +0000 (UTC) X-FDA: 82800387264.03.7829004 Received: from mail-oo1-f53.google.com (mail-oo1-f53.google.com [209.85.161.53]) by imf24.hostedemail.com (Postfix) with ESMTP id 16907180012 for ; Mon, 18 Nov 2024 20:42:43 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b=SNLTxyHk; spf=pass (imf24.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.161.53 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=pass (policy=none) header.from=soleen.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731962327; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Az3Sp8d9covPjAGoeraghsVludZNEdQZrTadq9s3zg4=; b=ladVVwpFW/0++nJnCzpIJAkVY8oLub2sEVYf994gZzxjAeS1FMNXl8MJ4Ugbc8hoo2NX8t qP8hTdKQBuznybmwfIpSFaUxjkBaUEPPJZ5q8MkRga0eZw/Yqiw+j1MbgP8SxBqQWGWvc4 nuaFemwJOFtTOjG/rnJPpgk3Qzv4XbY= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b=SNLTxyHk; spf=pass (imf24.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.161.53 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=pass (policy=none) header.from=soleen.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731962327; a=rsa-sha256; cv=none; b=XcXg0X62hZVziXw7OdK07J9LvOpJbTPwnMXoQN8/bp9w8zJTqz7nbmTsaiW4WhLZDFkVFX mSr+uO45z7rnZ19+JBQjBzyNUy1eSa6ZpBEN/gRMqGnY/mcYcOGCGEMRgebuv7YUcKnoGt u2b2GFH9fyudhfTIwVPv6Bm+r6n76Vk= Received: by mail-oo1-f53.google.com with SMTP id 006d021491bc7-5ee763f9779so86340eaf.1 for ; Mon, 18 Nov 2024 12:42:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen-com.20230601.gappssmtp.com; s=20230601; t=1731962569; x=1732567369; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Az3Sp8d9covPjAGoeraghsVludZNEdQZrTadq9s3zg4=; b=SNLTxyHkS4tGPOOsXDdkqaC/LlYf/r9MTLmbJhNTRs7Md481C7ZX2Jmeaz+QdEJydj kqXM9X5jZYtGtzi94bGROumIyk960Wm0xnOXRNm4wAii2Tk+PKR8jbFnknY8aC9NGDop YXwwSKOD/OyXfrQnuL9zb7XqI7xm4Pq0Je7tS+Ngkp+oy0FhnSktoAFTlFm9o6WipESo Jnj6ZQVws5LaKokFUS+mQdMqa8kgISt8wtckF+MVQnHLtOgkn5sL6o6wnL/ueXgnjH9y zOxuKNGDUPoN4NIwIrbkWXjQtDaJxs93RWewdQepvHsGSIfYNxvlV99IC5FaZTjq2x8l WnTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731962569; x=1732567369; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Az3Sp8d9covPjAGoeraghsVludZNEdQZrTadq9s3zg4=; b=oVRB3PIGLs6Lyvt1sl3Sd9MGsQo4vQlTCXW76H1PdgPYA5FTP4zQegJg0pCBcIct/t WxBPB/JwjfUTetJJqfJVEIdtcz/CbLMhkJO7pCtRTcvzFnIEwDJFrRtIMEoTGu8vHnBZ dEqYeHcDkVczR3hks8uLGjl8hPBZdPn5U9haVklLvHaIM5Zz2vlN4JsqH9rsQccbWour BSPN5a2qjExM3CSy68V3hkK7SHSChnrJvOSdmpydD5eV/zdBVa66gwNK3GTxB52n/vCt qJCz8Up527bMLjQrrg8Im2suEROWKQZJDB/pbT8kMRuqvNv09SCsnC3zEsoPKKNz4IbD 8I1A== X-Forwarded-Encrypted: i=1; AJvYcCU3QJjV6ThwqVgG1aTGolQGa07C8/P3nyUwXxLtmXoWgW6ONoMjbm01/6ZrSe7TgxU9WlumwO6cnw==@kvack.org X-Gm-Message-State: AOJu0YzabM9ZiYVqJAptsFtz8l7qXUIha8X+k9JVf2YBpjb7UhE6AmZq fhN2n+I5XSB+NCv2BXxLeFd5coDntCRsWAyWORz2JB8fXI6BS6lymNVBhzv/sxUVGHGjUShRBfw UYVkUNFawPyzdng05S9eCSVe4JLtmZ3zXXLUYMw== X-Google-Smtp-Source: AGHT+IHttxr2eFNSFhV8PpJus1DCBKmx1o7nfN6x9M9fk44cvRJr2moQ/A4XKlnUEVw6YKcIvYheu82B5igacrHaq1Y= X-Received: by 2002:a05:6358:170b:b0:1c5:e2ea:8992 with SMTP id e5c5f4694b2df-1c6cd22c1e4mr505681155d.11.1731962569411; Mon, 18 Nov 2024 12:42:49 -0800 (PST) MIME-Version: 1.0 References: <20241116175922.3265872-1-pasha.tatashin@soleen.com> <20241116175922.3265872-3-pasha.tatashin@soleen.com> In-Reply-To: From: Pasha Tatashin Date: Mon, 18 Nov 2024 15:42:12 -0500 Message-ID: Subject: Re: [RFCv1 2/6] pagewalk: Add a page table walker for init_mm page table To: Christoph Hellwig Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, cgroups@vger.kernel.org, linux-kselftest@vger.kernel.org, akpm@linux-foundation.org, corbet@lwn.net, derek.kiernan@amd.com, dragan.cvetic@amd.com, arnd@arndb.de, gregkh@linuxfoundation.org, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, tj@kernel.org, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, vbabka@suse.cz, jannh@google.com, shuah@kernel.org, vegard.nossum@oracle.com, vattunuru@marvell.com, schalla@marvell.com, david@redhat.com, willy@infradead.org, osalvador@suse.de, usama.anjum@collabora.com, andrii@kernel.org, ryan.roberts@arm.com, peterx@redhat.com, oleg@redhat.com, tandersen@netflix.com, rientjes@google.com, gthelen@google.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 16907180012 X-Stat-Signature: hp6jyuk6hmp6j1k4sbn8bo4z8p76jgqu X-Rspam-User: X-HE-Tag: 1731962563-585909 X-HE-Meta: U2FsdGVkX18WuBWtMO0JCFtd4kxv6WWm1BZT6lKgmQCioC7KQCnVMoLFCOvJdoNWkt7Jpw7oyA6nwQlDeAF+RZmZYqvFJ9PpyBgDCossxFqBnxIysYD7T4dX30h3cAmNrkALn8rwYN27wkkwPFovD0ivS9nJK1eXNfXwIZu/GWUw53EP6ELxNEZOApAqZYQwjebkG5SWyPYwLHpidefncUPBEVKhrDByFVNUy/nvR+2cW0DbgD7FK6L7Dt8+M8hhadbw94EdnF7OS5jFsM0wsK/sH/wjmtkIrak4OSRh+HxlsY0Yuiea2T4FNTyZ7TDY+lVZpicneFkI/zkZu+QHoDw2fN84ZD7HhvplM+gvrNfkOXeX6JPoOARAgCM7Xak0lzb3pxhc62JHGGDJykgGvXSeTgWGgqYKTXxPXC5/sTFfZyf7or8BfIjBFd0Y3oGGZQ1mzawrCD5Taf0IM7qIMxWK55snPsvsypx3CiC4kzdjApgyQNkMswlAFy4e2R3d5pN0khu0K2cvvJ6jofgG4OVJcXdFNwUJQ01gGtbXnGsXTedx/NP2u/tT40gj6iLOal/Ol4/i7Un0GdtR8k5gljLFTbE149ygEJH4gJhf7xUcRML2b4QH6CHYBP/4ll9u6QnmWlmOKQK0tNxfQjsZBT7qrkOFtkRvMo9FVK/4YgISeP2mrVjzusMzoE9rXc6/I0JIr0USeIFAKEZdCnwwjm3i+gbOkE5DM2Eg2nPU3spdMFB8yGGEKOipg8MUSePf/U+qEqsEUbFtlymQ9xVZj4w68Uthb4nrlnHTwmgOh8jCcS0rNxLFsKCTho9gCb98RXCGzsAa9SYhFHM7Qe39x2GBDg9diE1AGsUCulbuSVuwOMlFi5TYhH97Q/g2wNSbhKn2wNa1tLxeNJS93Mgo9UPH6qmN9158ADKiMmFP1Df9uh5cuorAiIORBe2xgqVPBFnXU1Aef3ESKc874RG jVl1KElU pKGdyYSLvL6WrXVOSvuBaQCOD8/1AsG1gbRUeB0oaUWR3KS9es2f+7clFkM0JsAQRzLsweJz4mliLi5Di+6X5HvN2ZySPeqc3dmBDjfQanIZgQ9s8FRbBrpd4ySBzXdH+HfGmzZ77oh6QwWltWoEOUWzAgm91zFfoGP6xfqRZppSTb8tgOUNjMMmdIMkWRhGu7NW4WdpP3CIhhbX1V3Z3RPO2m/csCn1Shx/CCxIv3E1tLDn2s7kGVBezZcP4pqi1rFP3ucIcuuHqZpKOX7/R891Ss5aZZPWzTZoradxezlOYJ6D/go4jLt9z56V6fhJ+C7f4yoy6NDIqMC41usqQ2jyHM7BqrW+IU3N1E2Qb8lCrrJg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000016, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 18, 2024 at 1:49=E2=80=AFAM Christoph Hellwig wrote: > > On Sat, Nov 16, 2024 at 05:59:18PM +0000, Pasha Tatashin wrote: > > } while (start =3D next, start < end); > > return err; > > } > > +EXPORT_SYMBOL_GPL(walk_page_range); > > Umm, no. We really should not expose all these page table detail > to modules. > > > +EXPORT_SYMBOL_GPL(walk_page_range_kernel); > > Even more so here. I will remove these exports in the next version, as I am going to convert Page Detective to be part of core mm instead of misc device. Thanks, Pasha