From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B1F5CD1292 for ; Thu, 4 Apr 2024 13:56:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2621C6B0083; Thu, 4 Apr 2024 09:56:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1EBC66B0088; Thu, 4 Apr 2024 09:56:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0B3AE6B008C; Thu, 4 Apr 2024 09:56:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DD7AD6B0083 for ; Thu, 4 Apr 2024 09:56:55 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9A56740464 for ; Thu, 4 Apr 2024 13:56:55 +0000 (UTC) X-FDA: 81972000390.30.5F69B33 Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) by imf15.hostedemail.com (Postfix) with ESMTP id 11429A000A for ; Thu, 4 Apr 2024 13:56:53 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b=hfS+HPjc; dmarc=pass (policy=none) header.from=soleen.com; spf=pass (imf15.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.169 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712239014; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=msc9tQgMq343nFV4/DBdPcJS7hGm3uD+5fv8GwkMOjA=; b=B1tW+KSqXWyhva4gQov3706BPz18XhmyOvjPhtN2PjT7/THI7SbiZx/Pa9BsYIm1lzN4vz JTQafjGoOXb/jA3S1jYi6YSxqBdvMBqskiaxnZH5BH/oPM21NMh1/CcytiQf4HtMx+DbO1 N16kpc4vX+9v//fCwjuY+1gzR16Y7LA= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b=hfS+HPjc; dmarc=pass (policy=none) header.from=soleen.com; spf=pass (imf15.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.169 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712239014; a=rsa-sha256; cv=none; b=7N55g+vnFZALsTZ6ZvkONbdygi6I1ebtIfZwXP6HafDhmliV49Q5qtlgwqG4WbMFS4SRnp I7O6JGsnUx12w3+We02hb57lKe2ddbAQcSVNtQ4BJQG6hXiQmAFOz7lPCPPj6tnix79bFy qp6ij/zdeklXWGIXj8Gzb+gJNoGX61o= Received: by mail-qt1-f169.google.com with SMTP id d75a77b69052e-432f421c56bso4976481cf.2 for ; Thu, 04 Apr 2024 06:56:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen-com.20230601.gappssmtp.com; s=20230601; t=1712239013; x=1712843813; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=msc9tQgMq343nFV4/DBdPcJS7hGm3uD+5fv8GwkMOjA=; b=hfS+HPjcBlXFRt0bSgyWHcdG1SQc9C//uIpjAVC0dGw5EyKelrXwpYFUN9osAn4H9F nLSCj0fcGm13WyfMvwpUGoAwXFQKLeO6LjouWo8ZiuKTmw7TGITkM1dLXCnAVH0fZJRU l47YHv8hjfq97Z7LAlAkd9e7GwRE7xR1KNzOIbsF0jwwUIGZcKQqE3Q5fkaSdQt65NUB kA5wAprzgu+Krnsy6x+FyhyAKw6E5e6P7LqVuQ+wKFoFBXPW1df8VBE9RvEs5A8wFuzP QYTaOzFZ+Y0cM0F1v9JPty7uS2OhOqJZhamK0byJwXlGp0ooeqbdU6i1v18L3peg6Bdj QPvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712239013; x=1712843813; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=msc9tQgMq343nFV4/DBdPcJS7hGm3uD+5fv8GwkMOjA=; b=sTCtCdilOzutq90pM6kNO50gc2HbWVYNjHJ0Ls6zgFWAhXzAdRJBrpUz9O757slrWj igOq9DdkzHBnislYVOeYvhyQrDqxu+wGDNxuJeEaRENIKF6ifvrN9Pyv3jd7XXKFt/pz i/x73YzAGaY9tdsGT7r2BRm1Jlc3O6SH5NC3+TaZOIWFC9H/YxAsE7y02KX1SbTnEsGu H6PZCETGguDACbUyCA2Tb5TgJdhEbu877b1wJZLpCJX4mqt5gH9D6jhN5Bv/Gn9Su1cW kDHFehEo0CBD073EsnKfMkiiH0r3fc/cYE5oekhXmCkBpsvvDLapAN8gCPOZjShPp+nR QkNA== X-Forwarded-Encrypted: i=1; AJvYcCWSlC9HD2v8qhqPIATKac1LyaIpS7Xa2l82F8C0UX0e9U/AwjGBB0tXgZ15+PlN1L61eHwJBU6Wpv+Gu6wHclUusQY= X-Gm-Message-State: AOJu0YwoVrvm4chxbWcrEQWnaZkOdeqkADnPanhiEvLlDZzNQiH8fV3d RpVbFdNm7FXFV4IVvKMoD5g+C2k4Bq3GUGxFA3nyvm3CsIZp3lLVZUzhXtd6azmjqu7VMfOVQlR l9uVrGhhmILdisOAWwIEfAGP1XjdehlC/UFmdKA== X-Google-Smtp-Source: AGHT+IH9S7DU2DIf+z4/lTa3f7DcyJz1Y9kNOGjz2IQr7tohPqSHHhqayAGWHjuk7zhrLKiTZ6wb5Cu4ZzpulPIDrg0= X-Received: by 2002:a05:622a:2:b0:431:378d:afa with SMTP id x2-20020a05622a000200b00431378d0afamr2733138qtw.34.1712239013126; Thu, 04 Apr 2024 06:56:53 -0700 (PDT) MIME-Version: 1.0 References: <20240222173942.1481394-1-pasha.tatashin@soleen.com> <20240222173942.1481394-2-pasha.tatashin@soleen.com> <20240404121625.GB102637@hyd1403.caveonetworks.com> In-Reply-To: <20240404121625.GB102637@hyd1403.caveonetworks.com> From: Pasha Tatashin Date: Thu, 4 Apr 2024 09:56:16 -0400 Message-ID: Subject: Re: [PATCH v5 01/11] iommu/vt-d: add wrapper functions for page allocations To: Linu Cherian Cc: akpm@linux-foundation.org, alim.akhtar@samsung.com, alyssa@rosenzweig.io, asahi@lists.linux.dev, baolu.lu@linux.intel.com, bhelgaas@google.com, cgroups@vger.kernel.org, corbet@lwn.net, david@redhat.com, dwmw2@infradead.org, hannes@cmpxchg.org, heiko@sntech.de, iommu@lists.linux.dev, jernej.skrabec@gmail.com, jonathanh@nvidia.com, joro@8bytes.org, krzysztof.kozlowski@linaro.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, lizefan.x@bytedance.com, marcan@marcan.st, mhiramat@kernel.org, m.szyprowski@samsung.com, paulmck@kernel.org, rdunlap@infradead.org, robin.murphy@arm.com, samuel@sholland.org, suravee.suthikulpanit@amd.com, sven@svenpeter.dev, thierry.reding@gmail.com, tj@kernel.org, tomas.mudrunka@gmail.com, vdumpa@nvidia.com, wens@csie.org, will@kernel.org, yu-cheng.yu@intel.com, rientjes@google.com, bagasdotme@gmail.com, mkoutny@suse.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 11429A000A X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: aj95zw43e6yh5pxc6m7sdzujd11swx6j X-HE-Tag: 1712239013-34053 X-HE-Meta: U2FsdGVkX1/j9rMMqD7gLwoH4eM4HFaY1AWkvwBFL2xqUN4DDCbsWEE14ja6vGF8DSgCAS/GetijEsXg3Y3YxDTb/SIVqB0sTb8siDuzaVa9e0x3Fo6wpwSOY4TQB7iGIUHTeiviMP+7+9RdFhXOnjeBvcQ+YvdBZx48YOBCO6U+Wt/7F0zzQpI2kWqhw6SRmsiEGHdLQ663c6GDBuLsJIIgD7T0ojaKSdoSiSyiBKvuGlCQ5SvFmI3wwrsBRLDOHn8nrj38t4rzmGYSqYiELC1o94s/Mj2erxQ9UE5y1fxxBXHa1JBf2OhGboZxoJsNLgmj3sqjB6w2rV+KThi9h9JUO2ypRIsuYT6PwWRUFhVU3uSOROr6+24D/VL5Qjcj8VeTCJYmIAwdIi22YMpj8qH6q6+X45dYr3tkrizHIOpRRc8gTgO8xLdrh25/UGjIRhJ9XIGhvR1E3pKVwWtxvARFjpSLeANDygaCVYOrSFRM2S10aJe6DwShZGRFrWXwwqrzZFJVsLeTtUYL1/k6aaWrQ4L6UTBRaBhhzxGaiD0AEgprYb02uJJeRVsc8lQeZJHcGK5yO0WXTlF/43qKIRmf5gERR4JDLKV2gUOGMpFBiDRUPcpU0KoWdh9T2qMbS9wekrV0swBOrjw9yXmQfgEOpNAcq7q50TqdjPnj+SjgbUv3arOkglTStz/H3ZsZubjfbWfjH049cqQqaAxz0L47InO8FkoEqa1V8g7FLa1Ca8uCWHcUc84ORKQjdTV9UZyriwQv5RzAQXB3iJYZigl7c/Ins4sZ5S1vG4wZedGks2uRFVPTIspR2VhL/Ppj24P3d0lUDUS37un8LZysMoo3glcAomwDKPp3tsFNxYeAS1YhHojJ647FbF1H5C8CNRZCG6w4mdLT1lIhaBgPiQAZ9v/RvZyQRSJO/+2E+/F2URtn0hVtc3/mV7Ad8e4hw3gn3exuKKSxpV1J3ne 3KEDbMh/ Yk/Sya5YboqXXnBcZTesPnsVDYmpcZKNaWuKcAUolWxm26Z/3qU71cgN4dni7LL6M3S3iG8d3ygUpv0VHXs79NKPXbmC8xx9CJFrIn+jLivtiAy7AgK2cvvA4vStXmr7V94kA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > Few minor nits. Hi Linu, Thank you for taking a look at this patch, my replies below. > > +/* > > + * All page allocations that should be reported to as "iommu-pagetables" to > > + * userspace must use on of the functions below. This includes allocations of > > + * page-tables and other per-iommu_domain configuration structures. > > /s/use on/use one/? I will correct in the next version (if there is going to be one). > > + * > > + * This is necessary for the proper accounting as IOMMU state can be rather > > + * large, i.e. multiple gigabytes in size. > > + */ > > + > > +/** > > + * __iommu_alloc_pages - allocate a zeroed page of a given order. > > + * @gfp: buddy allocator flags > > Shall we keep the comments generic here(avoid reference to allocator > algo) ? There are no references to allocator algorithm. I specify the zero page because this function adds __GFP_ZERO. The order and gfp arguments are provided by the caller, therefore, should be mentioned. > > + * @order: page order > > + * > > + * returns the head struct page of the allocated page. > > + */ > > +static inline struct page *__iommu_alloc_pages(gfp_t gfp, int order) > > +{ > > + struct page *page; > > + > > + page = alloc_pages(gfp | __GFP_ZERO, order); > > + if (unlikely(!page)) > > + return NULL; > > + > > + return page; > > +} > > + > > +/** > > + * __iommu_free_pages - free page of a given order > > + * @page: head struct page of the page > > + * @order: page order > > + */ > > +static inline void __iommu_free_pages(struct page *page, int order) > > +{ > > + if (!page) > > + return; > > + > > + __free_pages(page, order); > > +} > > + > > +/** > > + * iommu_alloc_pages_node - allocate a zeroed page of a given order from > > + * specific NUMA node. > > + * @nid: memory NUMA node id > > + * @gfp: buddy allocator flags > > Same here for this one and other references below. ditto. Thank you, Pasha