From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E89BDC4167D for ; Thu, 2 Nov 2023 14:24:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 739BB80029; Thu, 2 Nov 2023 10:24:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6E9E78D000F; Thu, 2 Nov 2023 10:24:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B25180029; Thu, 2 Nov 2023 10:24:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 493358D000F for ; Thu, 2 Nov 2023 10:24:44 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 20487120161 for ; Thu, 2 Nov 2023 14:24:44 +0000 (UTC) X-FDA: 81413235288.04.E2EBEA2 Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) by imf23.hostedemail.com (Postfix) with ESMTP id 4AB3E14001A for ; Thu, 2 Nov 2023 14:24:42 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=soleen.com header.s=google header.b=jTWU+aFF; spf=pass (imf23.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.178 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698935082; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=varkfJCjnH+u3E50Sky0yjh/elja1DPy2fnutdy0fKI=; b=7L5jiYV7KJY0IKtwo4QZQvrkj6YVP4+cdHLWBudgVYcDMlz2pNRBxZCPJQ+AB8WvkU1TvY Rwo+3MJ/xCd/kszHgTBN1le21Xe6TNotqz3qq7BFbRVcTu7iNBUhvxH9dMWGecjS6Npw4M pvakkFkeyPjxY9CuWnH96B+Aada1OmQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698935082; a=rsa-sha256; cv=none; b=Cr2RPDiFRvDe5dnnxlA37DxyFy0bDTGGwT+nWEK24VgDazimoDODywUvw7s/rpVHEHBrhg s2xdxwvUkLkhk2VTnIk+e37uyVOaNTeWhdRoWR2kre+47baVgghnmmULYNjz83yotS3W3w ZxHuYeqO+kp0zSt2kPeyvDRXXqIElMM= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=soleen.com header.s=google header.b=jTWU+aFF; spf=pass (imf23.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.178 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=none Received: by mail-qt1-f178.google.com with SMTP id d75a77b69052e-41cbd1d7e04so5277681cf.1 for ; Thu, 02 Nov 2023 07:24:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; t=1698935081; x=1699539881; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=varkfJCjnH+u3E50Sky0yjh/elja1DPy2fnutdy0fKI=; b=jTWU+aFFMTQ42YyoG9w89eFbrBrWrc9hDYELAIwUlXmDm11scOO6Gp/8eIdCCW1x/A rtjkdnMA/Tm7/RvNkp+IxfhO2QpwGmXsnDrEVfz0UUTIANHZ7eELJcwFyOaNIn6M81L9 fG3GSDz9z+5HzmkJmLMbui8RbPPna4mdNYlyLY+m7ZC65GFA7mCF6kaIXfzXR4DbjGVM PtUZgZU0GQjuJP77cdgUC+nj859uK4LrMGC2DMfylwbWIw7jJCsKem2+XBY6Npj/S6ot GIGxx0OLWjFqcnJ5lkHHCqUMn7llTy/1eK+wywcn9u2eQ3/4688XAPIceab2ewLkzqhm c5ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698935081; x=1699539881; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=varkfJCjnH+u3E50Sky0yjh/elja1DPy2fnutdy0fKI=; b=hhIQKeSpDnAt7dVQWeakmoeqL30Ijg/PBKouKn7dTQadqfVmhqmGRjn7hlxkAsJrGd KViBRKcfRicz25q1TYoYy17ebZW9feur2Un6G3pw+3IPKpvuD439S0XUTipBXLtas7SU A77HiwgxqC/C1OMItK12f73RQ77tRTh/vbToHgx8pjeuWyAIvv9gLYgWhohNZuGivHAl 6btUfUBAhAM8SJlabA8Q9CWsjCVCjPq9Tqt112hQ5rnuOIiLI/bFR8n+K/8cz6ueaC4h GxIPiT3BuldwCdEwb8UJeD+vw1E2DsXzRLKv66uVRBsP/BY8sDZGvV+pL90K3LIYAgKW lzEA== X-Gm-Message-State: AOJu0YyUaMYj4NzM5MWP4Jnx9DFJE63TdAoyHS0p0zHks8I3x0akNVJh dnHS1lP3PeWEWaAVoOlaiwctUz11tWonXMJair4KtA== X-Google-Smtp-Source: AGHT+IH0Y68XhZR7psJfRikRrstCfvOIMTxVmiuULLZaDr4XBQoFiKDeDkzTE0NG9ZK0jSv8qPfgX077gTc8xgXgCAA= X-Received: by 2002:a05:622a:44b:b0:412:3092:feab with SMTP id o11-20020a05622a044b00b004123092feabmr21550874qtx.50.1698935081374; Thu, 02 Nov 2023 07:24:41 -0700 (PDT) MIME-Version: 1.0 References: <20231101230816.1459373-1-souravpanda@google.com> <20231101230816.1459373-2-souravpanda@google.com> <2023110205-enquirer-sponge-4f35@gregkh> In-Reply-To: <2023110205-enquirer-sponge-4f35@gregkh> From: Pasha Tatashin Date: Thu, 2 Nov 2023 10:24:04 -0400 Message-ID: Subject: Re: [PATCH v5 1/1] mm: report per-page metadata information To: Greg KH Cc: Sourav Panda , corbet@lwn.net, rafael@kernel.org, akpm@linux-foundation.org, mike.kravetz@oracle.com, muchun.song@linux.dev, rppt@kernel.org, david@redhat.com, rdunlap@infradead.org, chenlinxuan@uniontech.com, yang.yang29@zte.com.cn, tomas.mudrunka@gmail.com, bhelgaas@google.com, ivan@cloudflare.com, yosryahmed@google.com, hannes@cmpxchg.org, shakeelb@google.com, kirill.shutemov@linux.intel.com, wangkefeng.wang@huawei.com, adobriyan@gmail.com, vbabka@suse.cz, Liam.Howlett@oracle.com, surenb@google.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, willy@infradead.org, weixugc@google.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4AB3E14001A X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: q5x6kugoogmcsz7378pp16eytcwdkox8 X-HE-Tag: 1698935082-876081 X-HE-Meta: U2FsdGVkX1/QeMUC1hpfgkF44F/DPE2rV87wuAwifkw2Hi2+thh9Fv2CDEF5KfRdeJqLMmKozshaM5MsQHIybkoqfj40Jio6lJM3XyH5N4dyRGLBSOhtK9mS/cyo2IIWs6hCk60lNW1JxGfqhuIfMUSLXUPHvORQATm77hKHW1lRpVpAsoh9tGW8XXeC6QNw+dFy8w0LwlIsrOc80GGkgBJN7N5ZMT6erjy6cbnJ2NtDkljwCnGBfgmBv8eZeSQ63cEkkKuhGJx21wcAinLDOE53WKB/+Zj1FcCVIh4aD8pXOZap2SmbRFY3Yti4qlJUGUtxGxWs/SN6fq8jjaAP2wqdW2Dwt/HR6497XWFATK/Mlih1xub0O5qSvAwl3+WnKN0Dk8Zy9XqzrrqSvYr69SDWHsUdOE3ZxhqsQJJw4NGqOn9c7AlN1lrH3tGlCspmMjzsL8IPnRXcQindqjBILTDoBCjbV/sncyzMzECqQGe7iQKij+oDYXn7DZ67VHTWsMeBaA1/+du8TEbMu5+U/bLtOISSc+3NV5xaK+JSg7Qg9wU/mnsGgzkEFPLQDgY94M0YrX72vVTSWIf43ftY1J4rbvCDW8tLPVqbYkj0bMnJDbiMqTk9CMQ6Fi7NrdM6L/vlDswTgMg6NbVJ2ex4rzTMi+YuhZyntJ7Xnct+g0jQuMFJDS1KoRCJGWYD5wG5ou+nKnYMNojoBP6Y8YLM+OHBpiI0tPkbbZ/EqHLxTF3KcElFI2YKVUJFPPL8t9CQpB9Oetx/vsUSkQZGeBsSk+osPxQvHTSmzuIZiCi518M+9mqqkVzhwEXxbcB9N0VhMGUiZiiV+5eASCWEmdR+5YOxW6fC3U40xy+UvxP98V+LWB8U5oTCovwnQbmKBEQtl5eEU9n9fY3b8bjyrbwmdTqai0VeCCgOesU1snrHouDdATy4ees9wpfk79pHB74HPdltp4Rz9ptrAwbh3Fi Qicy+KyW 2E1WkwJorqFgN3hcAj9dtzq3BsQ/eCW96ISBYV/zo21GqYjhna5JPRYa4fFLtVOGUnxsNHvrEQC+cUu2uyo9pW97V3+s72OEDArkSjKHM6Dcgvnu+SOjAkhRfoZHVN1DZL5LVpLrEt837neo5rDez5DkzA2rgHUBAtPOwZ5W8wtCGKhbmB0lfdOBrKDpFNpNmp5ehzi78qh4zwrZDkfnZ/vgGdBoaLWr3I8uRmNeFJvVvIpq0657Ey2LYUgactkXsNEOwA965hQlrB383F8z1Amns3RXRU/lAQcUCcrON/uFQVBUZ3ExWN7dFkMrZ5fvY7upQK2Hb2hph9yU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000127, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 2, 2023 at 1:42=E2=80=AFAM Greg KH = wrote: > > On Wed, Nov 01, 2023 at 04:08:16PM -0700, Sourav Panda wrote: > > Adds a new per-node PageMetadata field to > > /sys/devices/system/node/nodeN/meminfo > > No, this file is already an abuse of sysfs and we need to get rid of it > (it has multiple values in one file.) Please do not add to the > nightmare by adding new values. Hi Greg, Today, nodeN/meminfo is a counterpart of /proc/meminfo, they contain almost identical fields, but show node-wide and system-wide views. Since per-page metadata is added into /proc/meminfo, it is logical to add into nodeN/meminfo, some nodes can have more or less struct page data based on size of the node, and also the way memory is configured, such as use of vmemamp optimization etc, therefore this information is useful to users. I am not aware of any example of where a system-wide field from /proc/meminfo is represented as a separate sysfs file under node0/. If nodeN/meminfo is ever broken down into separate files it will affect all the fields in it the same way with or without per-page metadata > Also, even if you did want to do this, you didn't document it properly > in Documentation/ABI/ :( The documentation for the fields in nodeN/meminfo is only specified in Documentation/filesystems/proc.rst, there is no separate sysfs Documentation for the fields in this file, we could certainly add that. Thank you, Pasha