From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97B85C433F5 for ; Thu, 21 Apr 2022 15:48:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1DE0D6B0072; Thu, 21 Apr 2022 11:48:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 18F066B0073; Thu, 21 Apr 2022 11:48:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 030186B0074; Thu, 21 Apr 2022 11:48:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id E97716B0072 for ; Thu, 21 Apr 2022 11:48:38 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id BF3A62232C for ; Thu, 21 Apr 2022 15:48:38 +0000 (UTC) X-FDA: 79381318716.04.168C0B8 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) by imf25.hostedemail.com (Postfix) with ESMTP id 0182DA0025 for ; Thu, 21 Apr 2022 15:48:34 +0000 (UTC) Received: by mail-ej1-f51.google.com with SMTP id l7so10956662ejn.2 for ; Thu, 21 Apr 2022 08:48:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=99zPGQDcBvB2eneXnR+UDPkr2FlkHpg0OSrd18ZV4Fg=; b=VLywufJWMlVFxqcfNnZ5LLc0KyAM4UcVKWw+3U/dmyzmkYUl66eNLXln+J8wdYeFib TFyQctG/3jB/BbqgBgIkmvyVe+j+kUwysGydwnvXU5g4OFlIiLrRR8CbwW/1kcOqrDS+ k0cjhjdEuKA9oz6o6ZI4+lhEkSrErxxRSEcNrzW34RIWL52UoIMChNYDRaHpCNE9iMIV 60vSWFF+QCw7DM/nHF6PHQih9JoZHz7nKTTuQuC2JzA1lYWsULBpVaziblXAfpywWIj6 7dnAXZKJS1yem3+vHGn6UQEIyt4JSgqGoBuYdFziAgX7DDF3NJAd76xP+qrOxF4jsiZD kJgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=99zPGQDcBvB2eneXnR+UDPkr2FlkHpg0OSrd18ZV4Fg=; b=GDLEQfqMu9Efh8OSnfSd8mSROnFET20LkSRo78j8Hot8LeTxhX0lV4qBrUeliDJh/6 4ydWWfd9r+zcTJZgNqduUoeJbT3umIeS0+DldKT4xaOtDZAs5x+c3TNmbHE0tPSDPeqd Kp1UcrThdW7fGrcQqqvUmOWniPhvrhxkygCPJb4cHzx4QAtfjIic1DgZ53itpYis6Uu4 TdDJLObcyySo6xJX4kEAKnVgHohJCqkk6EoiXyIRU2/TXJFIdJ8kR5Nkvg/yk7UdpP7U kaHLigUWQFT6A8Q2f2Qar+f5hD8SLz7MClZlC2ignjLr83lmwsuG1TSiMnUJeVyD70hM EnYw== X-Gm-Message-State: AOAM530kzt6Y+T6ublOlAFSku0UvP0vj1X1juX6j1Sc5F7ZowgBrkER1 WEyx1S9JFx1JpwFGbBg1mP0bwnXk5+W5996H21JZ/Q== X-Google-Smtp-Source: ABdhPJwZmx55dd2ozNjrym2eOBStotYqhCTvy4duFqRmIX0adxyFMMBT3BVbRgBAgiRzqcsobnw2+YrQW3eqbI1gKqU= X-Received: by 2002:a17:906:1841:b0:6e8:872d:8999 with SMTP id w1-20020a170906184100b006e8872d8999mr162746eje.492.1650556113446; Thu, 21 Apr 2022 08:48:33 -0700 (PDT) MIME-Version: 1.0 References: <20220421070631.1273879-1-anshuman.khandual@arm.com> In-Reply-To: <20220421070631.1273879-1-anshuman.khandual@arm.com> From: Pasha Tatashin Date: Thu, 21 Apr 2022 11:47:57 -0400 Message-ID: Subject: Re: [PATCH V2] mm/page_table_check: Drop all redundant EXPORT_SYMBOL() To: Anshuman Khandual Cc: linux-mm , Andrew Morton , LKML Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 0182DA0025 X-Stat-Signature: 16o5zx3iy66jyh668tt3fzb6wrtxhqp6 Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=soleen.com header.s=google header.b=VLywufJW; dmarc=none; spf=pass (imf25.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.218.51 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com X-HE-Tag: 1650556114-581467 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 21, 2022 at 3:05 AM Anshuman Khandual wrote: > > Function definitions need not be exported via EXPORT_SYMBOL() mechanism. In > this case these functions just get called only inside their wrappers. Even > __page_table_check_zero() gets called without such an export. Just drop all > these redundant EXPORT_SYMBOL(). > > Cc: Pasha Tatashin > Cc: Andrew Morton > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Anshuman Khandual Acked-by: Pasha Tatashin Thank you, Pasha > --- > This applies on v5.18-rc3 > > Changes in V2: > > - Restored EXPORT_SYMBOL for __page_table_check_pte_set() per Pasha > > mm/page_table_check.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/mm/page_table_check.c b/mm/page_table_check.c > index 2458281bff89..627c5025d786 100644 > --- a/mm/page_table_check.c > +++ b/mm/page_table_check.c > @@ -167,7 +167,6 @@ void __page_table_check_pte_clear(struct mm_struct *mm, unsigned long addr, > PAGE_SIZE >> PAGE_SHIFT); > } > } > -EXPORT_SYMBOL(__page_table_check_pte_clear); > > void __page_table_check_pmd_clear(struct mm_struct *mm, unsigned long addr, > pmd_t pmd) > @@ -180,7 +179,6 @@ void __page_table_check_pmd_clear(struct mm_struct *mm, unsigned long addr, > PMD_PAGE_SIZE >> PAGE_SHIFT); > } > } > -EXPORT_SYMBOL(__page_table_check_pmd_clear); > > void __page_table_check_pud_clear(struct mm_struct *mm, unsigned long addr, > pud_t pud) > @@ -193,7 +191,6 @@ void __page_table_check_pud_clear(struct mm_struct *mm, unsigned long addr, > PUD_PAGE_SIZE >> PAGE_SHIFT); > } > } > -EXPORT_SYMBOL(__page_table_check_pud_clear); > > void __page_table_check_pte_set(struct mm_struct *mm, unsigned long addr, > pte_t *ptep, pte_t pte) > @@ -223,7 +220,6 @@ void __page_table_check_pmd_set(struct mm_struct *mm, unsigned long addr, > pmd_write(pmd)); > } > } > -EXPORT_SYMBOL(__page_table_check_pmd_set); > > void __page_table_check_pud_set(struct mm_struct *mm, unsigned long addr, > pud_t *pudp, pud_t pud) > @@ -238,7 +234,6 @@ void __page_table_check_pud_set(struct mm_struct *mm, unsigned long addr, > pud_write(pud)); > } > } > -EXPORT_SYMBOL(__page_table_check_pud_set); > > void __page_table_check_pte_clear_range(struct mm_struct *mm, > unsigned long addr, > -- > 2.20.1 >