From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58782C4167B for ; Tue, 28 Nov 2023 23:33:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C72668D000E; Tue, 28 Nov 2023 18:33:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BFBB08D0001; Tue, 28 Nov 2023 18:33:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A74CA8D000E; Tue, 28 Nov 2023 18:33:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 901498D0001 for ; Tue, 28 Nov 2023 18:33:00 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id D3CDE120416 for ; Tue, 28 Nov 2023 23:32:59 +0000 (UTC) X-FDA: 81508965678.20.09E842D Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) by imf05.hostedemail.com (Postfix) with ESMTP id 0E1AE100012 for ; Tue, 28 Nov 2023 23:32:57 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=soleen.com header.s=google header.b=AI2Si39l; dmarc=none; spf=pass (imf05.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.169 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701214378; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T5E8YxJ+6DFizX8w/tjdr1Q20AjeSOztly1v+T84HO0=; b=aUZ3tpqs1BZsZDQg0IGdaekx4dRoykg454cqZ453w+ov5zCHDy+G2y/sAvDQsrnzipfntd bS9hX+jPQrTA2D23Ko1JrqYWAX5Ds7qZCLQLlc4awzC8huKVQyAphxQVTYQIY5ynkJKkKb F6laK/G8hCYjFJob2ouBLHd1lvYTbvQ= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=soleen.com header.s=google header.b=AI2Si39l; dmarc=none; spf=pass (imf05.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.169 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701214378; a=rsa-sha256; cv=none; b=4gEImRwUw3u1/Jzd7xjb5XfW7yu7x8XcTpPqvn3w/zOjRKe5OzX83+UDoNqXD3x/wiPKb9 MI3Uj1YeMRO5dgPzJWxbE5gd4636Y1XStsYxVj6Bwc5lYFMgrlmUQi5s42WeHpf8wbPfFp Da4+2pTuhES8sihW+fNU+TB3GiTPwr8= Received: by mail-qt1-f169.google.com with SMTP id d75a77b69052e-4239f5c1ec2so23482121cf.0 for ; Tue, 28 Nov 2023 15:32:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; t=1701214377; x=1701819177; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=T5E8YxJ+6DFizX8w/tjdr1Q20AjeSOztly1v+T84HO0=; b=AI2Si39lwZeaA6VFx/k42AfP2F9eOcAWfMRmGQke7yTD+1PlmqtcpVMZPA/VWaUa0B ewVnJ1Bhhfyg5IP69h2ACp36BUoVsWAO/1QUoam/rM0jg2g2oPs08OlO5Lb/hIaIaXVs BT9hiZO+dim6Fx8QeCkb/aWHAEYiPXD8cUQ98IiGPkz4ORjux/N+F/GbwFMqp9xGjRuf UUPUb9P+/0/NoWJhMqemE0C+s7/9r4Y4+ZfxT8deNflaKv8tfbUQXGkJqpsabJHZW9XL nICYb8veEZlGut8oWFULZywEU7tTo4W6sErrJqn4E+mKTb2JqSVFTQ+aPR4gVHbDp4fM Kn6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701214377; x=1701819177; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=T5E8YxJ+6DFizX8w/tjdr1Q20AjeSOztly1v+T84HO0=; b=AGut3n047gyBlosgrx0+FMTB0Zwnncki6CiEWj9WdQMXO07Qd/F5BdruE90EFrJcjl aQI809Y+/s4stvfIciseXYJCEDAb4Vy4Kjsg9qJHld3hM4mLEfv8FymAHPtjxJXix/aA 23v/JzgWZmvN2MGuzi+uQXDHK4ctsfo3a6X0e1NBiXeaZQ15x1INjYwvvd88w3epi60z aeTLAsDP+EehE0CuNBZoWZsYHovWAwZ7IgC69j4AhBuW1J2RlnYrIyfrbvD7LD2IAieg phws5QAQkAEYgZ9XjEZslwbSV9ALdGOnkgk3z6e4uW2sZ5zCBfR/ps/YTCFczbaxjVFE BG5g== X-Gm-Message-State: AOJu0Yw6VESYxRlxO3f+EE9qvsAkLM9fLH8G/qsAGa9+sYrh6ZGSHMKF 42G5cSPVT9W2e9QizMiAxZeB5Tr1A/3t4tdC+QBVQg== X-Google-Smtp-Source: AGHT+IEOuxWHhR77aLWnHKpzlrX1TcnL7YFPpFLtYSrpaVGNIqLOq9dSsp5P0HO6NZm9ZocGV6nook5EATgkphMBWlk= X-Received: by 2002:ac8:5c06:0:b0:419:a2c6:820e with SMTP id i6-20020ac85c06000000b00419a2c6820emr19578443qti.12.1701214377257; Tue, 28 Nov 2023 15:32:57 -0800 (PST) MIME-Version: 1.0 References: <20231128204938.1453583-1-pasha.tatashin@soleen.com> <20231128204938.1453583-6-pasha.tatashin@soleen.com> <8e1961c9-0359-4450-82d8-2b2fcb2c5557@arm.com> <6f9ff0aa-7713-4de1-869e-4725828942e4@arm.com> In-Reply-To: <6f9ff0aa-7713-4de1-869e-4725828942e4@arm.com> From: Pasha Tatashin Date: Tue, 28 Nov 2023 18:32:20 -0500 Message-ID: Subject: Re: [PATCH 05/16] iommu/io-pgtable-arm-v7s: use page allocation function provided by iommu-pages.h To: Robin Murphy Cc: akpm@linux-foundation.org, alex.williamson@redhat.com, alim.akhtar@samsung.com, alyssa@rosenzweig.io, asahi@lists.linux.dev, baolu.lu@linux.intel.com, bhelgaas@google.com, cgroups@vger.kernel.org, corbet@lwn.net, david@redhat.com, dwmw2@infradead.org, hannes@cmpxchg.org, heiko@sntech.de, iommu@lists.linux.dev, jasowang@redhat.com, jernej.skrabec@gmail.com, jgg@ziepe.ca, jonathanh@nvidia.com, joro@8bytes.org, kevin.tian@intel.com, krzysztof.kozlowski@linaro.org, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, lizefan.x@bytedance.com, marcan@marcan.st, mhiramat@kernel.org, mst@redhat.com, m.szyprowski@samsung.com, netdev@vger.kernel.org, paulmck@kernel.org, rdunlap@infradead.org, samuel@sholland.org, suravee.suthikulpanit@amd.com, sven@svenpeter.dev, thierry.reding@gmail.com, tj@kernel.org, tomas.mudrunka@gmail.com, vdumpa@nvidia.com, virtualization@lists.linux.dev, wens@csie.org, will@kernel.org, yu-cheng.yu@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 0E1AE100012 X-Stat-Signature: 98dezickhcf1n69ccg65a1dqegudfdtu X-HE-Tag: 1701214377-84865 X-HE-Meta: U2FsdGVkX19F5xsdV4PgUNwE38EdFruylA8K7D3FN46JMbGNZe+Uott+ch7nYShKH/fdYRNIIoKGMNua0PXCgstRv62PX709yhKQesZKJG4OiAU0+LsOgH+9EGg9mcdJYjMsofyyEmfglTFJwi+RyJMD3VOri1p+Sz5Q0p/ExwnSE7gKqgzuB2bfrS9mU54lrn3YVlmReuni9fBxc9MmCDVeOIPNBcUihxgfoU2Xlc/1E+mC8peex5kpyi2AysZt2WA1frmP+iNm4iZrQtgmwpRhEHUHl5Vz+jEkDpbMdojnLBjCb+K74KRUTQ8i9QkSuKb57+1wEGBGksfwkwjEvPL8Py//30rkieop5b7fB4W2WnEC+2v4TLR/bW/GzWFR6x/Vuv2ak8edSJM3nONoXrYTgllBHic4v9faj5aM/6dfz9WY/A18Ob4f18eusZqcAlMH5GS7Z5p8e4BiLOd8C/DWFCgAfgidRXXVKJNqmy8lJ2EgiK5dwFRBGiLZTbtWQoFAxJ+JQp6FCMCHVtwq3lf2hhW4FpWeoKW/Q7teBbAlDUmag+2zs+c3prGG/RWSDcGuRm+bzSXdjQH2ry4R8WI/222qLCyFcRsYY8+FfalHAN8mHuZfFVgdOlSJsVF+9d5e6uaQGFJpW1E7ua/ggpPGf6mbfQSf9X98+wBqkVIMrk7oxTkpBxNK7brdd6HmMu0D0mEJ4VoZpDmn2yIfsUFwSoXa0iLnpPZKEXoi1ATwdgKr7hYGjOqXMJNuUzzurNfuqILLK3+CY/VH62G05j9U6DLSFq2LyvjlL4gpApB0LaWyP1BNBuxBkxIFUJIU16THU+Rj9eAlz/mzexIFX1opQvAzXkdbcZ1uYJgKU2NGKODvf7J+EyadeYgOLmBAfcSZNeEAP6QBd0OT0QG1DHRvPB2QSjxKIRnJezg6O3HUStPOLPl/+gDW/xFicQNaJOeFJS22UPGe2nC/B43 RzqBFPZu O9zKxHOQFu9DLyxY9e8+yrg9xkAtLnKMkVpMINx9Ft29LU36XuKPSoRVU+mTcywVydq8z+yCYURICYO8CnhxcJnL+pN6rXs/8ODTUNTQwXeJwxy7lKSDytOf7dD1jGGQGSRPblgbNVPxPNeQ6lbvI4iihvme+aJUt8yyPChQOjIedofvS9ijGjzWr1RJdqp3jw9to0fqdre7OBcAtUlxhCenlURc+5vk+4ZXJ85mqVE+p/F42gidkUFLUu9L/qypIJW1ruqUiWE8qM0MIOT2/y9qx6l6YmyWsr2xxsAz+m1d+KZItpNULH2ho3Vs9YWb28gChmrFBm5leeRn2CP30TwEQQf8U5gtv0uZJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Nov 28, 2023 at 6:08=E2=80=AFPM Robin Murphy = wrote: > > On 2023-11-28 10:55 pm, Pasha Tatashin wrote: > >>> kmem_cache_free(data->l2_tables, table); > > > > We only account page allocations, not subpages, however, this is > > something I was surprised about this particular architecture of why do > > we allocate l2 using kmem ? Are the second level tables on arm v7s > > really sub-page in size? > > Yes, L2 tables are 1KB, so the kmem_cache could still quite easily end > up consuming significantly more memory than the L1 table, which is > usually 16KB (but could potentially be smaller depending on the config, > or up to 64KB with the Mediatek hacks). I am OK removing support for this architecture, or keeping only info for L1, I do not think there is a reason to worry about sub-page accounting only for v7s. Pasha > > Thanks, > Robin.