From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6838C54E76 for ; Tue, 17 Jan 2023 20:05:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 598D86B0080; Tue, 17 Jan 2023 15:05:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 521A26B0081; Tue, 17 Jan 2023 15:05:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3CBE86B0082; Tue, 17 Jan 2023 15:05:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 276EF6B0080 for ; Tue, 17 Jan 2023 15:05:24 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 026091A020E for ; Tue, 17 Jan 2023 20:05:23 +0000 (UTC) X-FDA: 80365370568.02.93A6124 Received: from mail-qk1-f182.google.com (mail-qk1-f182.google.com [209.85.222.182]) by imf08.hostedemail.com (Postfix) with ESMTP id 71926160019 for ; Tue, 17 Jan 2023 20:05:22 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=soleen.com header.s=google header.b=d9ogxEmu; dmarc=none; spf=pass (imf08.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.222.182 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673985922; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8vzw4YVtMRSUz3v9Tgk4v9t6M5/XnmiHZaqhNCNW9Gk=; b=AwcGOHsH/bttlzCUi3avtPTpls/7R30HF7rIEiakqvqLrE6zoUcxO8Th1Yul/tmeI1KDsT 3JWHSmL1zxAVW6EitniFhRxfpg4bLjfTdf9JaDcb9KY29LCL16VXSjtDpnE6OfhiUKjO9J NH+nEvw0rX6EKViZu8/Rz6HcBoL9uv8= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=soleen.com header.s=google header.b=d9ogxEmu; dmarc=none; spf=pass (imf08.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.222.182 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673985922; a=rsa-sha256; cv=none; b=Try0h+GYV7agzUN8cgsQofWQQEsfhydKE0ldvUd2Pn2lvzSY0Al2kaLSpnAv29sn9Dt2Hw An07CLa0AeGiyVaXLynvX/xxYFdubwVCCSbAdsKOLjypZdoEQJOtyeIA49QlyNCtVfB3Kh IE2w1DzzHPgUMvNrKIngkSKO8vZtdJc= Received: by mail-qk1-f182.google.com with SMTP id pe2so16750651qkn.1 for ; Tue, 17 Jan 2023 12:05:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=8vzw4YVtMRSUz3v9Tgk4v9t6M5/XnmiHZaqhNCNW9Gk=; b=d9ogxEmuDNgwfLV09PPVDLrVRjJa9Lb6a565zZUrtoVkjyDiQ0zhZSKMf4baREB5qA wMEdn9L26GJrXhkbM0HiD7JT5+nHnMMqXJZ4vn3ljBUvTaeOdhVZ3gCrug1i0Gr2i+YD G4fQu4J0eVGtc7xQ7+UZzbdgYx+BVW2jSlk/ih51YAHbk4pqKDqG76W39KUWluOfPpbg nqzK/VOUitN5V6uUWtym2Dh6QuhshM7uC/ZGL2fp0Z+4ESCQ/wKfDmGIPTFcFrMcbU1i QmjBOnV0xKyc9tKAGkMUlBWMq92Xi19yTgzqBF5GzN+m9h5blJFWfN3JIfzuj1hQHxWn i3Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8vzw4YVtMRSUz3v9Tgk4v9t6M5/XnmiHZaqhNCNW9Gk=; b=xipz1Ol1BVJdXHuA2kF8/l9W0TqgVZT74JP3KtBkuU/jXpcjdWsuyu9p+3lPSzM1Ym r9/gyIa1PBks9DALhQaMNWdngw6OYPdY+uOM1cx+DEYFcwfKcjzoLXMQ0YgasBSXGZ6t Hx8HnTx/gBK/JDFj9X6X72dT3Evl+xPI2RClX6ENzsgVky6FjOQRCr5Ulz2z+E1alvb0 LzuzpLU4TrM7ojKjWVGl3TTUZxgKCqVf//7oQH7k17x4ThiyD0EZ5UKcdOtbW7SJiBvI YSMqP/AMQ4wgbmQEVmo3xGPQVKPOfzMG/rXpyB7ia+mQ2djnX8i4iGsl9XR3SDqVL0Uh iOhQ== X-Gm-Message-State: AFqh2kqzWQSKW2qp14e1iwlkwpGNUPMzFZFEh6RBQfQlXOic7iA23BBN 7NbeDGr+aF5/p91YGS/x4z909xAl0s8R0cB9gb/OLg== X-Google-Smtp-Source: AMrXdXsMcHwF7iN4F4ae8o58I+poPjzv+kb7t//4HBRvoDAok9O5ME86npmBDPuCUSudlwS6JE/ZFpcCCQoqrtoN/yw= X-Received: by 2002:a37:aa07:0:b0:6ff:c9c:dde4 with SMTP id t7-20020a37aa07000000b006ff0c9cdde4mr221524qke.18.1673985921537; Tue, 17 Jan 2023 12:05:21 -0800 (PST) MIME-Version: 1.0 References: <20230113154253.92480-1-pasha.tatashin@soleen.com> In-Reply-To: From: Pasha Tatashin Date: Tue, 17 Jan 2023 15:04:46 -0500 Message-ID: Subject: Re: [PATCH v3] mm/page_ext: Do not allocate space for page_ext->flags if not needed To: Mike Rapoport Cc: akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz, david@redhat.com, quic_charante@quicinc.com, lizhe.67@bytedance.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 71926160019 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: axxth9ohqib31m4yr6kjqxx8o5dt6gxr X-HE-Tag: 1673985922-879701 X-HE-Meta: U2FsdGVkX1+DIXrdr4uF9RIqMDVmzpvL8ckjIWmacNxz/aUQWyZqO+dLEDLv5DU5z5WZdcYVGRD/UCR5N5mj6xFVPQbyhWYhnecNIHUkV/0kRf3eWM0T3vi+Bb/KEeP4xIaNBiafTQj8f0djNwSDUTMvfpjmxfh99qNZ2xxZQLAWtnib6/1azFxiafbjNvMCl0b/CHxaW/+bFc20sEyYb9L/SVyDogL+RaSep3uh/xig5sI9fmpReyEA04gJxwo1LZRVzspBzXqN1qQvnuJRJr4xpOdGS8Zmhc5O788aC54pRg9BX0QuAmle41OFbC6wqGKAmFU++C7O7HqSEKjJSW4Q1omlv9eTuECmcuDe9+90PMjR+Uh2fAvAD44kTxNqtV1Y8SPEMUd52BnWphlDY5XVud0YfYBj00H+jMrMVuKkxAehe8NvmMLhpUWSWCiNjD7WlRODQHw/Oabwn5YB+ietkKx4/go6Ui1X5L7W0qKJAl/Bv8VY81cRuDjYlqGubJqWnJeTLKI22LQwK/go3zDJzqgOVF2eB7s26UQIKgCU35z0yrI03nxCW9N/lV6bL1/bVv6ttsxazNWwRhsEOLhnDHBDB8A075Lp5fGCN02A0dG9Uc1XdRGYbmhkX/azWuPA2ikFo4C2GBxrI+Fw4AlEMh1kgc9R8fkjGjZdSbko7sdzdBK5NBzmmzir0DLUDXffwm7+/TFR0J65nNFCCbIhP8WtCFVcRZ3/Tzn9C0NpB2JN0Ia87ORfgH4lGYBKwmz/LEkkUEuvUDgEYdddQY5WtL4aiLCGptDVW2Z1PDAntl7BcMlkpWaFoLa/+ptxpeaOBvXtaWocbFzOnzZEM4VOnH7f+hlbQ4FeUl8rIfSnGTPoxyUJmPEirE1yo0HmnbsYzdX1Nu8O+F1Zk8sEB7pMtcpb/bYC7tEYy0Kq8gZaE/mHQnVMM07xy4Nf/VjHhJPjx1q2j0RfC+3bYMe 4qBIQptg 7bhFS54WXN5VWF4CYkPdn4MkZ17RHqHJkhcRS X-Bogosity: Ham, tests=bogofilter, spamicity=0.053645, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hey Mike, > > Also, add a comment before page_ext_operations that describes the > > field, and remove check if need() is set, as that is now a required > > Nit: fields OK > > struct pglist_data; > > + > > +/* > > Please make it kerneldoc. OK > > void (*init)(void); > > + bool using_shared_ext_flags; > > I'd s/using_shared_ext_flags/need_shared_flags. Sure > > + * Note: that if none of the users of page_ext is setting > > I'd drop that ^that OK Thanks for the review, I will send a new version soon. Pasha