linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Pasha Tatashin <pasha.tatashin@soleen.com>
To: Mike Rapoport <rppt@kernel.org>
Cc: akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz,
	 david@redhat.com, quic_charante@quicinc.com,
	lizhe.67@bytedance.com,  linux-kernel@vger.kernel.org,
	linux-mm@kvack.org
Subject: Re: [PATCH v3] mm/page_ext: Do not allocate space for page_ext->flags if not needed
Date: Tue, 17 Jan 2023 15:04:46 -0500	[thread overview]
Message-ID: <CA+CK2bDKLfgBdO-b6jZ+_LJf2j8poUsZUfx67LDMMm7670miQQ@mail.gmail.com> (raw)
In-Reply-To: <Y8USQBPlMNTTIyIO@kernel.org>

Hey Mike,

> > Also, add a comment before page_ext_operations that describes the
> > field, and remove check if need() is set, as that is now a required
>
> Nit: fields

OK

> >  struct pglist_data;
> > +
> > +/*
>
> Please make it kerneldoc.

OK

> >       void (*init)(void);
> > +     bool using_shared_ext_flags;
>
> I'd s/using_shared_ext_flags/need_shared_flags.

Sure

> > + * Note: that if none of the users of page_ext is setting
>
> I'd drop that ^that

OK

Thanks for the review, I will send a new version soon.

Pasha


  reply	other threads:[~2023-01-17 20:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-13 15:42 Pasha Tatashin
2023-01-16  9:00 ` Mike Rapoport
2023-01-17 20:04   ` Pasha Tatashin [this message]
2023-01-16 10:51 ` Vlastimil Babka
2023-01-16 10:53   ` David Hildenbrand
2023-01-17 20:05     ` Pasha Tatashin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+CK2bDKLfgBdO-b6jZ+_LJf2j8poUsZUfx67LDMMm7670miQQ@mail.gmail.com \
    --to=pasha.tatashin@soleen.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lizhe.67@bytedance.com \
    --cc=mhocko@suse.com \
    --cc=quic_charante@quicinc.com \
    --cc=rppt@kernel.org \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox