From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34B47C433FE for ; Sat, 5 Nov 2022 02:59:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 796126B0071; Fri, 4 Nov 2022 22:59:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7464F6B0073; Fri, 4 Nov 2022 22:59:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 60DED6B0074; Fri, 4 Nov 2022 22:59:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 529B76B0071 for ; Fri, 4 Nov 2022 22:59:00 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2396180403 for ; Sat, 5 Nov 2022 02:59:00 +0000 (UTC) X-FDA: 80097881640.24.314C3CD Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) by imf22.hostedemail.com (Postfix) with ESMTP id B0828C0002 for ; Sat, 5 Nov 2022 02:58:59 +0000 (UTC) Received: by mail-ed1-f45.google.com with SMTP id l11so10111146edb.4 for ; Fri, 04 Nov 2022 19:58:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=uDDAW4bfixZV9jxCbkjO/hz8g7Y57vtJ/LbWD2zWZg0=; b=aBYv502mu5ffMnm/ju1VA5lVoHbMZd1zLNmKFIYeyVqluZxcQKGuLTGYcvb4TNYZ+c S5WL8awJiq5PFIfb7bg3Jhx9mEa4UU5S8CasjXmZASxieB3+IiJPizYBrOkrsVOEuc7t eIlcm6UnRaDRjIXpgrqfn1ICHw9+OYnY4LqBdtTG1TafgUOsdWYeRULs1LHtVuuN6ltO vKSgcGXivF32sOK6XR2dndvN1WtQMxg7+V+5PBvWM4uPpYj8XIdZ07a3mRBl8EYPYRG6 fOaNoI8OsZ367sJefgVdXHz+Va62zPqMz4pa0BRVDEle2kjiJfZJ2Ny4XMlRh5GrBCyf pIYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uDDAW4bfixZV9jxCbkjO/hz8g7Y57vtJ/LbWD2zWZg0=; b=GojLojfLMIXejdtpIQiFtfSQlP/gIwJrsUW76u68nio1ENtZ6sDBd/wWgxVuT3XB80 3m2O2OvizXkqyQUX00ycSAch5wRv0eLyLRbNc4fyjn9TeB00k90p4PwQp9kTKS/dRa/+ lzqaXLp3Hu/1UWDuBDMqcZ9wlXtcjThJPhFTE9UoWdpeLtNedUht6jmV/s5GfkXfpLS/ jELMfDEYb+b3ZiF0MV+N4JdqQxz1z/t8JLoD7ZGtZ2/fJjFbNLxJKTUiVc0ord1+sYlp wzVxPU56DPuL1j2Y6ykYTvW1pCpX9X32bW4OWQK0OjSOskA3p1YzgbQ36W8vOSsok4kv oIyA== X-Gm-Message-State: ACrzQf1NEmehTlqn7VguOULXmfjB8U/aph7g6oZngEA0OQF8LXmLgxWk riu4FF/kcEcgeAgX1RGDgGk3Zl0Rqoj4CWqwpabujA== X-Google-Smtp-Source: AMsMyM4/G+GGwu/XWb7PryL7j0Ob5S/pX6DTxOjBIX9oRf9pcoBvcDWaB2iq48g4djXsLr6PkXjNCVNKoQCGxSwdmuo= X-Received: by 2002:a05:6402:2025:b0:464:67fd:e5d3 with SMTP id ay5-20020a056402202500b0046467fde5d3mr6533366edb.59.1667617138320; Fri, 04 Nov 2022 19:58:58 -0700 (PDT) MIME-Version: 1.0 References: <03f9401a6c8b87a1c786a2138d16b048f8d0eb53.1667336095.git.christophe.jaillet@wanadoo.fr> In-Reply-To: <03f9401a6c8b87a1c786a2138d16b048f8d0eb53.1667336095.git.christophe.jaillet@wanadoo.fr> From: Pasha Tatashin Date: Fri, 4 Nov 2022 22:58:20 -0400 Message-ID: Subject: Re: [PATCH 21/30] mm: Use kstrtobool() instead of strtobool() To: Christophe JAILLET Cc: Andrew Morton , Kees Cook , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667617139; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uDDAW4bfixZV9jxCbkjO/hz8g7Y57vtJ/LbWD2zWZg0=; b=tFAY+c2d/ROGjqZCHv609g6MKZy/Z543TyiSIotYSI0s9T3fysCSSBC9khXe9bYKSbC1a8 xmgQnXpeigs4SP5wTVEjmaIx/xl8aVfTufKzdgf0Z1c/ZVtP3lyTmNnAmw8F0Q+c5eYGZ1 HN1bdBl5DDqyEbrGLh2n0GzpnZVhPvE= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=soleen.com header.s=google header.b=aBYv502m; spf=pass (imf22.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.208.45 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667617139; a=rsa-sha256; cv=none; b=7liUB7v74c4IXzKXUMiCsyv51pkMv+KaT2HxfHOPtfeUD+AIt91vg/iZWHFUrmBKR3F9D2 VUxjJcstpXsrT0uUEUJJk/9NJvJuHElVAVMXl1BxW5IWlZ3e0G666aoQ3TNoi8hAZykW6W 1rlSvw+aR+TbhCSh09XjGsePti1/q6A= Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=soleen.com header.s=google header.b=aBYv502m; spf=pass (imf22.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.208.45 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: B0828C0002 X-Stat-Signature: zkrqi6b5rd46yk8zkhu1tdenc3wpuw4o X-HE-Tag: 1667617139-85791 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 1, 2022 at 5:15 PM Christophe JAILLET wrote: > > strtobool() is the same as kstrtobool(). > However, the latter is more used within the kernel. > > In order to remove strtobool() and slightly simplify kstrtox.h, switch to > the other function name. > > While at it, include the corresponding header file () > > Signed-off-by: Christophe JAILLET > --- > This patch is part of a serie that axes all usages of strtobool(). > Each patch can be applied independently from the other ones. > > The last patch of the serie removes the definition of strtobool(). > > You may not be in copy of the cover letter. So, if needed, it is available > at [1]. > > [1]: https://lore.kernel.org/all/cover.1667336095.git.christophe.jaillet@wanadoo.fr/ > --- > mm/page_table_check.c | 3 ++- > mm/usercopy.c | 3 ++- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/mm/page_table_check.c b/mm/page_table_check.c > index 433dbce13fe1..93e633c1d587 100644 > --- a/mm/page_table_check.c > +++ b/mm/page_table_check.c > @@ -4,6 +4,7 @@ > * Copyright (c) 2021, Google LLC. > * Pasha Tatashin > */ > +#include > #include > #include > > @@ -23,7 +24,7 @@ EXPORT_SYMBOL(page_table_check_disabled); > > static int __init early_page_table_check_param(char *buf) > { > - return strtobool(buf, &__page_table_check_enabled); > + return kstrtobool(buf, &__page_table_check_enabled); > } Acked-by: Pasha Tatashin > > early_param("page_table_check", early_page_table_check_param); > diff --git a/mm/usercopy.c b/mm/usercopy.c > index c1ee15a98633..4c3164beacec 100644 > --- a/mm/usercopy.c > +++ b/mm/usercopy.c > @@ -12,6 +12,7 @@ > > #include > #include > +#include > #include > #include > #include > @@ -258,7 +259,7 @@ static bool enable_checks __initdata = true; > > static int __init parse_hardened_usercopy(char *str) > { > - if (strtobool(str, &enable_checks)) > + if (kstrtobool(str, &enable_checks)) > pr_warn("Invalid option string for hardened_usercopy: '%s'\n", > str); > return 1; > -- > 2.34.1 >