From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED035C5B543 for ; Sun, 8 Jun 2025 00:07:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7FED56B008A; Sat, 7 Jun 2025 20:07:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7D6EF6B008C; Sat, 7 Jun 2025 20:07:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6EF096B0092; Sat, 7 Jun 2025 20:07:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4C2F26B008A for ; Sat, 7 Jun 2025 20:07:41 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 89F868029F for ; Sun, 8 Jun 2025 00:07:40 +0000 (UTC) X-FDA: 83530294680.01.C48D3A3 Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) by imf25.hostedemail.com (Postfix) with ESMTP id B26DFA0002 for ; Sun, 8 Jun 2025 00:07:38 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b="xR/U68l0"; dmarc=pass (policy=none) header.from=soleen.com; spf=pass (imf25.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.180 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749341258; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0UHtAUcnJfFf44KjoiEAzK/GgbeDg6XEKPgsifKNFJI=; b=ZGctb05vZJE+3dSK6FoIFfT+3z+/GhNrjCuTlXjF1GSR67TvRq/VZb0UunYtsNeYgqht5D KmkC0yI9QoGGu30f9nboqodim2kxk3xBACU5L7CfqdLY3Zcv/gjehPBklNAz1zN43NGWD8 sOiCkbc/0t7an931wbf0zyTMtrRijGE= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b="xR/U68l0"; dmarc=pass (policy=none) header.from=soleen.com; spf=pass (imf25.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.180 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749341258; a=rsa-sha256; cv=none; b=T9xOCF1fpCmiT5bGyZ7DP8MpGFfh8GfHUuOsloDZZzFtJyJKYz+icvmYG7U/wLQuAfiD08 NQTLgVIL+/aSsRq0fzlJ2X4PPbz0LNnGtUJsMYyTYmObebsMgyLaapvSKQqDGHVbkshqB4 v0z2NOFHCnYWHd1lL6AU94jbjYJoELY= Received: by mail-qt1-f180.google.com with SMTP id d75a77b69052e-4a5903bceffso40419681cf.3 for ; Sat, 07 Jun 2025 17:07:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen-com.20230601.gappssmtp.com; s=20230601; t=1749341258; x=1749946058; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=0UHtAUcnJfFf44KjoiEAzK/GgbeDg6XEKPgsifKNFJI=; b=xR/U68l0dMfB5Y7tJdqdu6F+p1gZ1tR5D6b8U7YO0q7TF76VOz8ftDVfDsLZTwWCxR eTyTkFc2EyJ0vC2L2zEH8Fw4lbDzxz83a1ST95qzumKCSVMPGu/VgvHwkjxz4xEwTMcZ vQWpkNMpIHm00JHsUxtYajrWH4L2aW83MeilLvVN3DASidF2JXAZ3Dh+Msg++a+bwftc rZADwwyYdfUmmOwUY0rto7r+UOPinU/fXV4jb4KddLrREcmM7S6YlaPtxOsP+h6/HiLe V0T2OuvziLAmuWhrn2LmnGn0O1cI+MJEo6z1JxkPT8a8KWfN9f0ajfuZK3yNfILOnIf1 G+uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749341258; x=1749946058; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0UHtAUcnJfFf44KjoiEAzK/GgbeDg6XEKPgsifKNFJI=; b=ZxcbnjIng1RW33dfjRBbfJVNWX+rPkZMkNsqIo8dKh//4lNHtRO/U+PfpY5oXF2Z5p /Jr65Nadlpwvd/y4QG48sVplHbZVgFgQB26f4Hm47Ny/CnpRR17OWZgzNwkbXsOdwoBx WkPBSAI4VkPLw6IldY6Q2mtzKOGdHUoamWZ2QfvHqgoo4pHo0MC97dBEIqmXlItV6yZ1 oVgAXZhAsgw3cajslw57KwqWu2cmEd96nxLCrkTP5aQDNmLow++oYJmr84feqiYXm952 5s57BA80SNvhZjbnXXcVLQLSsVBkT7PVJs7pY/kHLRRwg2ghAXSYJJTLihwCJc8D7A9f ECHA== X-Forwarded-Encrypted: i=1; AJvYcCUZ/2czkllBCspuDiikiBppu/3QBGSAxa+1nmuD5qc2LS+j8ePXjdxmttt0BTFjsU3KHGPYvOZC6w==@kvack.org X-Gm-Message-State: AOJu0YzqNRlGV0Dv5nrHV6c3DoPwGdT0bfUhS+OANltl2pAHWyK1Lk9k PIpgllG0GzAjjwCZLUt4AkXBt2A7LO8ed1fOE5lSmaMigOm6RHqcsOAlDF4xL47+YaxgCYJE9bZ kOqvhKHCsrw90QBcKdKQOP5gnUX1jEVBdvleR8E+/mg== X-Gm-Gg: ASbGncvs94Sp+CTaz+7P3ilKXtTPnijFBq87bLyBujkf1O+evZO9m6AhJ7d7fUn7mxf LMMLVMdHInx44P5/GArMcv/PG9jBQOs8Qusn96+1eU80IlCevp+D2auoR81lLNp4swl4j0FtWCE QDwclIPJleEEc0Mdzt5bIbjAfDo0Xa5udO4zwJ70tb X-Google-Smtp-Source: AGHT+IGZXoZIxS9/yln1HGP/gC39IRXpdwmbCIccfIgA/QRPKVyeFdcL/3Evwv4wy0rGEIkAT0IK7awaOmhPrDGklrU= X-Received: by 2002:a05:622a:2287:b0:4a4:4da5:8b55 with SMTP id d75a77b69052e-4a5b9d39e8cmr156784701cf.28.1749341257836; Sat, 07 Jun 2025 17:07:37 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Pasha Tatashin Date: Sat, 7 Jun 2025 20:07:00 -0400 X-Gm-Features: AX0GCFt1ImFK2hsbn3A789K1X_AfOKzUxJEaw3s1RQYNVvl-mWg1uEajt-sMD-4 Message-ID: Subject: Re: [RFC v2 08/16] luo: luo_files: add infrastructure for FDs To: Anish Moorthy Cc: Jonathan.Cameron@huawei.com, akpm@linux-foundation.org, aleksander.lobakin@intel.com, aliceryhl@google.com, andriy.shevchenko@linux.intel.com, anna.schumaker@oracle.com, axboe@kernel.dk, bartosz.golaszewski@linaro.org, bhelgaas@google.com, bp@alien8.de, changyuanl@google.com, chenridong@huawei.com, corbet@lwn.net, cw00.choi@samsung.com, dakr@kernel.org, dan.j.williams@intel.com, dave.hansen@linux.intel.com, david@redhat.com, djeffery@redhat.com, dmatlack@google.com, graf@amazon.com, gregkh@linuxfoundation.org, hannes@cmpxchg.org, hpa@zytor.com, ilpo.jarvinen@linux.intel.com, ira.weiny@intel.com, jannh@google.com, jasonmiu@google.com, joel.granados@kernel.org, kanie@linux.alibaba.com, leon@kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux@weissschuh.net, lukas@wunner.de, mark.rutland@arm.com, masahiroy@kernel.org, mingo@redhat.com, mmaurer@google.com, myungjoo.ham@samsung.com, ojeda@kernel.org, pratyush@kernel.org, ptyadav@amazon.de, quic_zijuhu@quicinc.com, rafael@kernel.org, rdunlap@infradead.org, rientjes@google.com, roman.gushchin@linux.dev, rostedt@goodmis.org, rppt@kernel.org, song@kernel.org, stuart.w.hayes@gmail.com, tglx@linutronix.de, tj@kernel.org, vincent.guittot@linaro.org, wagi@kernel.org, x86@kernel.org, yesanishhere@gmail.com, yoann.congal@smile.fr, zhangguopeng@kylinos.cn Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: B26DFA0002 X-Stat-Signature: stq4mbiyyxi4iq1pbdjw31oy38zfmnxi X-Rspam-User: X-HE-Tag: 1749341258-369167 X-HE-Meta: U2FsdGVkX1+eaasPX/nwhHvOCtOY48nL3PTCvqUmIAmKVL2CkzPAm+45iM/4jsygTD8Bcs0zsiqvo30HDg72S1Be6KmITfJD833UahOylXZ7JWq4iW/i0915uYI8cvjTPAsqktWovuEQsouURQ+QyTxL75iRb5JfeAL0FJPXMUohlcfLOGJYJhUsyMuOlnb0okZBpbAJhKIFiFQ4uk0mi1zWeM6Ct1Ok6APhyIAwed0AAmZOxB+cUa5KVnlCqQ9U73alUDYDEVh/zD1uVxDxYO45nSSMY3kgkRV00woSg92u6QQjHCgquzjR+mHnlSkiIaeutVKXABvbBaRjcL6aEs+/45bIuUOukTUenxYOpv3+o4RcShjZr/U3HuwrAMpJaxOrXHhBHUPX2UNC2LMMCtgcBNDyfv+RunKBn4vrMGBI9BNlC+6jBo5ze5REO4YezqjF+UE0+Jyy8qd4VTY7hUSp947FbWe5kKXSdPqVMW8cNekgwdvsMgWEJCI6dQD1cQyYYU2NuvxELY+yMPeMSw8LsZoJkJ12iKS1Upx2kWkapHM09myy8sm939/49rHyJlWLVjfPMyV7ey/thkeq0emSaxmutk7aPmr2QHpQMGUgqsS+sSwHtKQkRXXpTzozYFrEMdEVx1IBySOEdzCXjRDjA3ZbyqhfJIfK6LSVXKGs5qiBGu/MVvoMucOzV8eGXh8xQItCPz4SyuBv317RKkaD3ajjBiYWahQobTJYlhGkCLO/a+nK3YYBjZyLmqCulWM4uFJYndgGP0psqqQMM7A/y+1OGUYBEXu+2uPB86SEXKdTy9dw99eDlwl/LHVze/1oIZss4+zRv1kaMbG/dxOwdxCG/b+VEhiEi/5p6NH4wy01Nnuvh3d9lEJOtwJnHT2SCjv2KjnIhRsLSfo2k5j8rROiLrNbaMMAeKGNEvz3GKX9xGahZcmI4+Ibz9lqFjJ8G7bCclOOWNGVDXg JaYY8J8M JvV9DsjgAsEhcYA6eeTzs3W6ZPsifffwqMB8r7RtscKJCNAsUgP0fwLfKYj05QE45ceRAljUwbLuC+9yX1tyINwWVKCNN82msfCYx7cWN0ZAQSbmMqoufk/lMabc7Y9+Hb8mYS7Vm7VDnhJhFlfKm6+tCRGLgmO+XJX+E79F+FkPMz6naRQ1zWLFynKGg6gGjCiguBc1FQ0oSL4OhJAMZurJ5zDCdjTwRwjSBJeHFeupoKfibsQ1ZWd0OtTW6t6gIYYX1uHd+naInlL5RQBcWNGcSEzrp5FX1N5HH8OWd41W0X9mSMVOiHs3UE3W+AttM3qQ4luJ0G5l3pNlBTqi1p9gpoWPYmIFRUaHm8Nl1QNkguj5KImZgR3AGpX8WzFg4zqglXWGyK1HUXQIho9WoF2dg3iLKXA/AUxgt X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 6, 2025 at 6:28=E2=80=AFPM Anish Moorthy wrote: > > > + token =3D luo_next_file_token; > > + luo_next_file_token++; > > This seems like it should be an atomic fetch_add: I'm only seeing read lo= cks up till this point > > (Sorry if this is too nitpicky. Also for any formatting issues, I'm on mo= bile atm) Thank you, this was also found by other reviewers. I have updated this to use atomic. Pasha