From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FC8BC25B76 for ; Thu, 6 Jun 2024 00:04:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B5EEA6B0092; Wed, 5 Jun 2024 20:03:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B0F4A6B00A5; Wed, 5 Jun 2024 20:03:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 988C66B00A6; Wed, 5 Jun 2024 20:03:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7774B6B0092 for ; Wed, 5 Jun 2024 20:03:59 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 35A7A160B81 for ; Thu, 6 Jun 2024 00:03:59 +0000 (UTC) X-FDA: 82198515798.08.B1F2A21 Received: from mail-qt1-f182.google.com (mail-qt1-f182.google.com [209.85.160.182]) by imf16.hostedemail.com (Postfix) with ESMTP id 7A991180004 for ; Thu, 6 Jun 2024 00:03:57 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b=hpViZ5JL; spf=pass (imf16.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.182 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=pass (policy=none) header.from=soleen.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717632237; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Amsdr4HLBYsBEEfof3gSxLShXDHW8pNbXUNczYcLiRU=; b=WY7H5pF7yc+nbeFyQrAUvZBKeQVwtYC1bKGsHDn++3K9YufUbk5iYXsGvIV+M99FuTla3k sb7bB8k3KHgPg5VlgNBWqEb+remWbiv2lkGbBSQr+gIfqoRRG3KbfGS1sd0D5VZrq5ehk0 zMdP7UH7G2u7y7+0JjacJq4qM8ssJrY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717632237; a=rsa-sha256; cv=none; b=vSvxmKo15BXkx45ZPGs50u8AtzAY4PMAYQZqd18BoLAleh1vxeAzYWqyZsP62Fl9+2pi1U 6buEKWU5NkuqZDa8UB75nXe7VbjoacCLTdMCfLrXMuPMGwA6TMBllkCg9IAAYbJehBseuU AxKO6K1w3s3mP0Gbw7jJ/BBUHsmLHTc= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b=hpViZ5JL; spf=pass (imf16.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.182 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=pass (policy=none) header.from=soleen.com Received: by mail-qt1-f182.google.com with SMTP id d75a77b69052e-4402e119571so2566951cf.1 for ; Wed, 05 Jun 2024 17:03:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen-com.20230601.gappssmtp.com; s=20230601; t=1717632236; x=1718237036; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Amsdr4HLBYsBEEfof3gSxLShXDHW8pNbXUNczYcLiRU=; b=hpViZ5JLhcUDX2bJmQFVw2mIXrkDgI09yZnHXUQCmIgCyKyLqDHesvnHKkw4FGpd7m eV5qyZTVq1TdmTZ6YbL6xUIxac3v+ZjE/xe9cwz55w8zMhuXfh9wJNPZWZYoJKj0gU4N IPMcXVipsVOBwjBQcsQjMCr/dt36VDkPYGLrQJx6/XAO+bfYX27BZQKdKnTJMVXDovVD epdpCX55BInlQ2aCnI9VLYBzzHFikLv9nKtjCRY/0INE1QoFFX6uQMDk9vFbfCm/CjwY 6LoS9JpK4icFfboADPQhTXjNw7dSqT3jR5cdSXKobIBJugq9PXvgDbbFcim75VqdvfgP fuTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717632236; x=1718237036; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Amsdr4HLBYsBEEfof3gSxLShXDHW8pNbXUNczYcLiRU=; b=KUIRD1cgiQr9eVipcy+pqaUD5RnUiN4vJ+NGpQeRfzQRGDBd16kCAnmOzE4mD2f/dP 0r0dW5z+zpbWQocvusMcHP29SOhACFV0OjSFh8Wf0OiOETHjTTNcFtLGCJUIU9icW+LS QF0LWWVy4uFVLlIiuP1TschMGRj0TLNFCEccVF4fbT8t598kbFs3pQDJczpr0Nq5uIqH AnColHZYuOQS4KXhHzv4KZsvMMnUufLWBOp3JZr8FkJAeyDGVrbuyqPDQOWtPBXlwFL9 OFDs/Y2kWbkT8dgxXUKM3+U13pm+nEp7DPjsROzIsoC871AxUw47yS9Qiupcui7F7+Sc TuSg== X-Forwarded-Encrypted: i=1; AJvYcCWjaExPY4VLpGYo6Y7HpwDMkiPJrsj3VTgxPxHYxOVjTS/vkVpBuIa6h0uP/9NCzfKsOMQ4uZOSYhCTyMdBgJIaxWo= X-Gm-Message-State: AOJu0YzMFkESGl3VaHGy+vsNrg/tvmzsxAEE0glSgJfUfhhm/5R+Krz1 qndSdb2C3D5SW46CVw8YdXjKpuz+tkVL7U6N/6k1GPAeLwGgDdyrix4A+SH8zBwddAywPkr/CZK PqYG82+eTk+wkTOKf1OZARDssbJyBRRMVt1n3+Q== X-Google-Smtp-Source: AGHT+IE2DRuFlltNwyIS/VDUUwHtknHgVQUgsXKv0p5hEFT2yy+hK1MWJPZ7tc+UeYTVvVhfRpP8lZ99+uKTnilin4s= X-Received: by 2002:a05:622a:1388:b0:440:2a5b:ed6 with SMTP id d75a77b69052e-440361fbc96mr22097821cf.5.1717632236484; Wed, 05 Jun 2024 17:03:56 -0700 (PDT) MIME-Version: 1.0 References: <20240530170259.852088-1-pasha.tatashin@soleen.com> <20240531173823.4ec7b4693a4e433b1da91e75@linux-foundation.org> In-Reply-To: <20240531173823.4ec7b4693a4e433b1da91e75@linux-foundation.org> From: Pasha Tatashin Date: Wed, 5 Jun 2024 20:03:19 -0400 Message-ID: Subject: Re: [PATCH v3] vmstat: Kernel stack usage histogram To: Andrew Morton Cc: Shakeel Butt , jpoimboe@kernel.org, kent.overstreet@linux.dev, peterz@infradead.org, nphamcs@gmail.com, cerasuolodomenico@gmail.com, surenb@google.com, lizhijian@fujitsu.com, willy@infradead.org, vbabka@suse.cz, ziy@nvidia.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 7A991180004 X-Rspam-User: X-Stat-Signature: 6mukobnsf6oy1odt7dr4zfg8hkfi81sb X-HE-Tag: 1717632237-265086 X-HE-Meta: U2FsdGVkX1+tUBX24JqP2Tl8T/Hd/tTjxRllMW0zWBz0Im29AC9bAvhgN3R3Ij9mDpfFY2rdd1NoeV+cSj5OYMq01PccUlTg3WhI8QNmYfqWb2gK7eW7QILPImn7+zDcVqm929hjlUJfW6AHWZrO6ZQkwcUGmkAKlfX5HVvjX6QtG6JMPZWSVce3Cl3ZdoRUMuum1/NTghxlpC+biy8zKc9gZuUHWYH6ZES53jHa6FEAcolCwENWphrzFYLi304HvppKy5obnVHAnF+HJpP7FlwNcyPHXMyEWfboTMcc4rNt50JXCL34FMhX0P6NDhSbTTIt51U27E7t1jNkhwRo5ayiTIXT5bwqszkfXLu/czX2Fg8bLSgiyRrYJtNIBslYrHDqlmFzYU5xCjJPKo4IUQtkqCyRkmAf10FudZSUy5Hz37/DbuDdd8CBsDZrxPIJfZX+MdyL6O/ttZrmwydLe14jYTX6t88ehkG9BvUlOzC9myZ5xeypzaI82YzdRNZ74Fw8LsvjIX5F8bQ7qlPMVozVhYWh6o6C3RBJhx6/Xot4DezayhwO5YdLsasYc+N6l9CygQAe63LrcyVaGnJCgfgxN6eWClgQpK+2G6aMm7ynxtYGXzEkdsBzvzqq6rThpDAs8ia5MK0+N7TOt6blxq1wUUANA8y4KLXW8k9O5SL3GMdCoq2RBOFYksay0g28gPuR/1Ea+tayn9SqRndA+f+UrGO3o20gJmRs/JQedMQL88XPaAuFfHqTv2NdfgZMvH9dGByfHDtdduTCw3KM3dWOEDhzQ7k43o7JRKdX9LNoxrYqIH4WghgG2znTc/E7UXr+mjEW9agKPjaI7iKBrWanUtBdaQj5guwWJe5a5kVEOQra9Cz+3h6fH6tqOTVmveuqZiEl9d+I3GclSu9njdmjCBvw5TXFYW/3oBd7Us5jHNSBn1Gwh0255vbp0IGZJhWsmaH1qcCf72c9tCh XBf0bvOT isG9tUfkaXw2JLawooU7L0ZcQrQzdZ/Dn6qR4Co77KeEe8QzMCzfhYfBrvM3cvUpbtxegmiwtGgNaEb2liW0ZjFJdil0vnbgf/+igiq5idaPyoHGXf+gDXisM/c1srtrtawLrmN75VFYo8OvRCZp/hJdYsBzcNzVLkPaXKrMwFD6DlSiz7W5tGQGgrTkguuB792DucEfDvISpGd0TjjxP+L8tX0ITXp0m+YUfEuyeqBso6hhLa2sS7Es4eONBox5htYL5vTV1uxQIfzpt5QVIuJSHhiDKDUvv4VoUQ6qVH0HQsmMt1MD6ScZEc9j5xaF3yYHcRGiFVvDUbzQCEach99IQ0bO3ByiM+XYP/UWf5IkeSRKlwSzqY2bUpnWfU311aWONMBw4PjTo7QpkGKTMWbfb9w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000064, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 31, 2024 at 8:38=E2=80=AFPM Andrew Morton wrote: > > On Thu, 30 May 2024 20:14:17 -0400 Pasha Tatashin wrote: > > > > Couple of questions: > > > > > > 1. In future with your on-demand kstack allocation feature, will thes= e > > > metrics still be useful? (I think so but I want to know your take) > > I do think the changelog for this patch should reference the dynamic > stack feature. It strengthens the justification for adding this patch. I will add a reference. > > > It depends on how on-demand allocation is implemented. On hardware > > that supports faults on kernel stacks, we will have other metrics that > > show the total number of pages allocated for stacks. On hardware where > > faults are not supported, we will most likely have some optimization > > where only some threads are extended, and for those, these metrics > > will still be very useful. > > Also useful changelog info for this patch. > > Pasha, could you please prepare some additional text which I can paste > in? Thanks. Yes, this makes sense, I will send a new version with the updated commit log soon. Thank you, Pasha