From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 537F2C433EF for ; Wed, 17 Nov 2021 16:44:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BF48961BFB for ; Wed, 17 Nov 2021 16:44:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BF48961BFB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=soleen.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 04C3E6B0071; Wed, 17 Nov 2021 11:44:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F14D06B0073; Wed, 17 Nov 2021 11:44:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DB66E6B0074; Wed, 17 Nov 2021 11:44:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0225.hostedemail.com [216.40.44.225]) by kanga.kvack.org (Postfix) with ESMTP id CCAC26B0071 for ; Wed, 17 Nov 2021 11:44:43 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 8F0918249980 for ; Wed, 17 Nov 2021 16:44:33 +0000 (UTC) X-FDA: 78818995584.27.3128167 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) by imf12.hostedemail.com (Postfix) with ESMTP id 3790D10000A3 for ; Wed, 17 Nov 2021 16:44:33 +0000 (UTC) Received: by mail-ed1-f47.google.com with SMTP id b15so13908708edd.7 for ; Wed, 17 Nov 2021 08:44:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mk3EQIQlc769iqF40WF3/rES8RREP3zrgFFWj+6hSiI=; b=RgTmEIalg6v0Bmq8xYKdGWPG70YJJ60v3Z2MwhHUBE08nlXk3BwGXx5vU1nh3Ua7WF J9/1jdQLH5iFcxUurmvSRvKSRTNgAwFTg+9XXxG6SNUMZddXBA7Ld/CPAe/UW+b036oF EiaMYBpO8+d5QNuFs5N80udBePkVNGMM90kVJs4ZMWMTkBgDQvNZYCMdpaEKI4bkGwW8 SnslfEl71dYywRKd1gmj0JCtXkWRPmhNEGb/QzsPVWBQbLOR2FAVScOXLuLFZSqEg2QT xBE/3DJesZREbjfjPZmq8ew46H8XCj9uGulm7YJKuY8Xft1ZYPIFePqERG41ewYkfJAi FRvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mk3EQIQlc769iqF40WF3/rES8RREP3zrgFFWj+6hSiI=; b=nc54mXL+EYXiDval21cvicUE3ditKH0RiP4wC+UDT9BqtXJTOeq+6Om74xyqB2xDmn Adc8WC+U7zW5NM+IOnQ8Vsj87GXXq/1SIfK9suioDdkPV0gIUYtZEfElMP1qt2ukcyiO cPjO/BGw/uEPnRCMqThO1tyEa4IOLWoe1V07Wtltk3fswY8mH7VU0uRBn/YFdu6FaRos 49Jqsg33h51r0cHUQPcppdH7vDsA9MabhXIl37O7P51bhpfMg6Oangmno5Sht+l2Awaw 0GPOjq1TjLkdJNA5lgpE/J281rPu/dh/2LP3fpY6uz7KlKxK/rfuHSoyLsEsB/s6WGjB b6mQ== X-Gm-Message-State: AOAM533ARo5mz6luSeGXfwEzIbtPgGbhMCidyOn6uz8TOuQI4CrncbG0 1T48IpzdszrMzPBnurx212WWafU2Lbcao/DR3f5FJw== X-Google-Smtp-Source: ABdhPJx0MbyNR612auC3mvloK/yYL0PaX5BeexgnzrhLnlbOYQHqtK/fT8+qzfBrH/s4b0DEQ/KqFm24q5GriqDCi9I= X-Received: by 2002:a05:6402:1911:: with SMTP id e17mr9414edz.43.1637167471649; Wed, 17 Nov 2021 08:44:31 -0800 (PST) MIME-Version: 1.0 References: <20211116220038.116484-1-pasha.tatashin@soleen.com> <20211116220038.116484-2-pasha.tatashin@soleen.com> In-Reply-To: From: Pasha Tatashin Date: Wed, 17 Nov 2021 11:43:55 -0500 Message-ID: Subject: Re: [RFC 1/3] mm: ptep_clear() page table helper To: Anshuman Khandual Cc: LKML , linux-mm , Linux Doc Mailing List , Andrew Morton , David Rientjes , Paul Turner , weixugc@google.com, Greg Thelen , Ingo Molnar , Jonathan Corbet , Will Deacon , Mike Rapoport , Kees Cook , Thomas Gleixner , Peter Zijlstra , masahiroy@kernel.org, Sami Tolvanen , Dave Hansen , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , frederic@kernel.org, "H. Peter Anvin" , "Aneesh Kumar K.V" Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 3790D10000A3 X-Stat-Signature: ng14t4bnimztijx8ma98y3tthgz5ju3h Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=soleen.com header.s=google header.b=RgTmEIal; dmarc=none; spf=pass (imf12.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.208.47 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com X-HE-Tag: 1637167473-145221 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 17, 2021 at 3:52 AM Anshuman Khandual wrote: > > > > On 11/17/21 3:30 AM, Pasha Tatashin wrote: > > diff --git a/Documentation/vm/arch_pgtable_helpers.rst b/Documentation/vm/arch_pgtable_helpers.rst > > index 552567d863b8..fbe06ec75370 100644 > > --- a/Documentation/vm/arch_pgtable_helpers.rst > > +++ b/Documentation/vm/arch_pgtable_helpers.rst > > @@ -66,9 +66,11 @@ PTE Page Table Helpers > > +---------------------------+--------------------------------------------------+ > > | pte_mknotpresent | Invalidates a mapped PTE | > > +---------------------------+--------------------------------------------------+ > > -| ptep_get_and_clear | Clears a PTE | > > +| ptep_clear | Clears a PTE | > > +---------------------------+--------------------------------------------------+ > > -| ptep_get_and_clear_full | Clears a PTE | > > +| ptep_get_and_clear | Clears and returns PTE | > > ++---------------------------+--------------------------------------------------+ > > +| ptep_get_and_clear_full | Clears and returns PTE (batched PTE unmap) | > > +---------------------------+--------------------------------------------------+ > > | ptep_test_and_clear_young | Clears young from a PTE | > > +---------------------------+--------------------------------------------------+ > > Just curious. This does not have a corresponding change in mm/debug_vm_pgtable.c ? You are right, I need to replace it in mm/debug_vm_pgtable.c as well. I will do it in the next version. Thanks, Pasha