From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF744C433EF for ; Thu, 30 Sep 2021 04:08:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 627FF617E4 for ; Thu, 30 Sep 2021 04:08:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 627FF617E4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=soleen.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id DEEB4940083; Thu, 30 Sep 2021 00:08:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D9E2694003A; Thu, 30 Sep 2021 00:08:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C8CF5940083; Thu, 30 Sep 2021 00:08:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0209.hostedemail.com [216.40.44.209]) by kanga.kvack.org (Postfix) with ESMTP id BAF7594003A for ; Thu, 30 Sep 2021 00:08:56 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 5FA5A3209E for ; Thu, 30 Sep 2021 04:08:56 +0000 (UTC) X-FDA: 78642909072.01.6D628AF Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) by imf11.hostedemail.com (Postfix) with ESMTP id 1D4DAF000227 for ; Thu, 30 Sep 2021 04:08:55 +0000 (UTC) Received: by mail-lf1-f50.google.com with SMTP id i25so19614522lfg.6 for ; Wed, 29 Sep 2021 21:08:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=t3FALQ9F/29nwpH8yMUnQ6iSaUPA8tnjZM1xJdoGkuk=; b=gK60KkPoCIhYjuIuwMim1u3NwuU9HylcGXNclr7e0uqmbx+CoAzIWT0pe1fLPVl0L3 w5u9kwiH+H0vxWtAD+y15k4oAAWs1MrP04iGYomqEUqp6veYnSMmKS28XG4FGb7Dma+Y 66q/zAAp90Erg5XJHSwCUOOCnywwpudyr4S5bSoxF+msczjUqEZMuFE7fjiq/HVqvTYR 9eE/gC5d3bQedL9VhZYb7hmsDTOxfi1cAygzz9bOJm0VmqS6vJ9mUkO2npkLdDloFTO2 589WHGrGqJg7Vxr96r3XdjQKYkS1ABMxBEdKh7C8C+nhzNVnR4aO11DpWf3uD4lbKo/x OYJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=t3FALQ9F/29nwpH8yMUnQ6iSaUPA8tnjZM1xJdoGkuk=; b=gYuSx31IFJieqK9AeT7tqflUpR8/2sE+GUe7pdE4Xvo3KSGOIPZjgm4MiZxUWy83/+ XX5859m10MfyvxRa39d846WKiC1B+kecwVYeX47WwfE7XfZod6H0moqFhVbHN6bnOuwb V0XPAVNIpAqzfpaRBc5isJQwM3KC11PmNs4y4cPsWLuF8jA8ubO1vRPuzqtcLps91E3k NjUjQTLj65weLxSsAuKgm7pLh5TWFjodMI0ciXxfPLv4ijke/4TIc/JKesXVLWSldjk4 XlEzKt+ccxqtG37b+mhCAQ5nKWiGz/4h5lx4CEoNTbo5pl+cdg5E3hlahD0j9yria/k+ XtkQ== X-Gm-Message-State: AOAM531q69G4pHmLOGwiAHYBw74KaTrPg7nzSUL2dX5k73oX7hqZsi5k f4CGx7TnapFgT11jACfexsF4Zz2jPPemosDIWs+4/Q== X-Google-Smtp-Source: ABdhPJyav0ctqOfrQN5qVG918Z+tPvChnwnLpYKr3rd9LFJlbCyzYrotLyv/ym5LkvisvocbMG+fF0MLyYyJoozE6zQ= X-Received: by 2002:a2e:7504:: with SMTP id q4mr3777457ljc.422.1632974934566; Wed, 29 Sep 2021 21:08:54 -0700 (PDT) MIME-Version: 1.0 References: <20210916231325.125533-1-pasha.tatashin@soleen.com> <20210916231325.125533-11-pasha.tatashin@soleen.com> <20210929124513.GD21631@willie-the-truck> In-Reply-To: <20210929124513.GD21631@willie-the-truck> From: Pasha Tatashin Date: Thu, 30 Sep 2021 00:08:17 -0400 Message-ID: Subject: Re: [PATCH v17 10/15] arm64: kexec: use ld script for relocation function To: Will Deacon Cc: James Morris , Sasha Levin , "Eric W. Biederman" , kexec mailing list , LKML , Jonathan Corbet , Catalin Marinas , Linux ARM , Marc Zyngier , James Morse , Vladimir Murzin , Matthias Brugger , linux-mm , Mark Rutland , steve.capper@arm.com, rfontana@redhat.com, Thomas Gleixner , Selin Dag , Tyler Hicks , Pingfan Liu , Andrew Morton , madvenka@linux.microsoft.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 1D4DAF000227 X-Stat-Signature: ga1bhjdppz4qsuk4hzndf31bc1amno34 Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=soleen.com header.s=google header.b=gK60KkPo; dmarc=none; spf=pass (imf11.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.167.50 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com X-HE-Tag: 1632974935-162911 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Sorry, missed two comments: > > /* Flush the reloc_code in preparation for its execution. */ > > dcache_clean_inval_poc((unsigned long)reloc_code, > > - (unsigned long)reloc_code + > > - arm64_relocate_new_kernel_size); > > + (unsigned long)reloc_code + reloc_size); > > Extra whitespace. Yeap, extra whitespace after '+', will fix it :) > > > icache_inval_pou((uintptr_t)reloc_code, > > - (uintptr_t)reloc_code + > > - arm64_relocate_new_kernel_size); > > + (uintptr_t)reloc_code + reloc_size); > > kexec_list_flush(kimage); > > kexec_image_info(kimage); > > > > diff --git a/arch/arm64/kernel/relocate_kernel.S b/arch/arm64/kernel/relocate_kernel.S > > index b4fb97312a80..9d2400855ee4 100644 > > --- a/arch/arm64/kernel/relocate_kernel.S > > +++ b/arch/arm64/kernel/relocate_kernel.S > > @@ -15,6 +15,7 @@ > > #include > > #include > > > > +.pushsection ".kexec_relocate.text", "ax" > > Just use .section if you're putting the entire file in there? Good point, I will change it to .section.