From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 558BAC77B75 for ; Mon, 8 May 2023 23:22:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B5F4D280003; Mon, 8 May 2023 19:22:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B0F85280001; Mon, 8 May 2023 19:22:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9D690280003; Mon, 8 May 2023 19:22:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8E999280001 for ; Mon, 8 May 2023 19:22:36 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5DA6116016F for ; Mon, 8 May 2023 23:22:36 +0000 (UTC) X-FDA: 80768664312.22.5C9421E Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) by imf09.hostedemail.com (Postfix) with ESMTP id 77905140007 for ; Mon, 8 May 2023 23:22:34 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=soleen.com header.s=google header.b=TNMGn3m6; spf=pass (imf09.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.222.174 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683588154; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=J20KJD8UUGIZf35RzyX4QJCStx2hC/zK71qAj+ED4BU=; b=ZT5Cvn5Mwl0zJL+G4rUIzKbWyRU1wQ6HF/hjhd+MVEYUtepACUPcAfD+KorPAfKtskHFNv MuoL51V+mwqppVBQ4DRf3nKIc87Kc021YJ17C6RpkOoGWJT26XZSTW8C7w+Q0PcAhN+rt9 2j1FUpQnuHmH4WFdTl8TQBn3rT6AJeE= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=soleen.com header.s=google header.b=TNMGn3m6; spf=pass (imf09.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.222.174 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683588154; a=rsa-sha256; cv=none; b=4Szu295lEuwCSncWegrB4hC9HjL87J7uZsBKM7AVRQt2391vYu33gS4qfWvrj1g3GrICEL 3Gz/JiVHTbCUxq+cZlXg78pNE5GDP007OJ0wsrUezWfX0sg5sKzXtPd4pl2LmZ/cRdWK+0 yiGeCuKko/+INEdinySTXnX5XyhYta0= Received: by mail-qk1-f174.google.com with SMTP id af79cd13be357-74e4f839ae4so262340185a.0 for ; Mon, 08 May 2023 16:22:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; t=1683588153; x=1686180153; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=J20KJD8UUGIZf35RzyX4QJCStx2hC/zK71qAj+ED4BU=; b=TNMGn3m6WEBl4N8JuGwvWyR7WctTWHrVftC5hiZc+tYMbbctCLn9sos4hh8iEGyDm5 5110E/Ts3cuwWgtVQzy6GgZQvFIuUQmm5K7wnEGtbGLk6sT8A1VO8cg1Im+govrADMOV Cy3Q+TEYXLHygksHb/uhHTtC/wyU5d4TaivEarWakk+ul7Rnm1CztBxTQhPcqPm7c15k NmY7elOhiRuBr5r94CHdVN1p+F/ne2xVcpGTtVJdluQqWcjPcftUAajG1zyCm6iqVxV7 nI+lYGjD842cyiWHZcP+QWXu19HTR2CEZIUESzAJTGZKgwxs62NdbD+juBhTQ29gzj3t uKNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683588153; x=1686180153; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=J20KJD8UUGIZf35RzyX4QJCStx2hC/zK71qAj+ED4BU=; b=XdIuwuKoy5lP+IF6GCrbnntlG2JaovXu7WmqsVZjkdwgL/Gwx1rfKjBusZDV9RwThM Y/7dFn08yKBygVUMYK4H4sEfraybK2clqeyR9f0CL4K6OJuP+S22RUW4sCGYZUG1beOe 5iPMvd/jWx/clffk/+CXyYmit7F2HAGcrWI49jFFi4cJbejQFzsmJuNE+F5Nb4o/iXJE AEEn7zOiM+g4mqac6ENwCF5X3p/2MGIpKevxGbkxGIbFwrBba3HMPUSAVvsJufcSgAmU Kp3EdsxW+JppLQdQrUdCQ7wS9NjB8CJbZ02Bo3/vVKm78YcOASLoGocVdH0j6svZfg8q Mx7w== X-Gm-Message-State: AC+VfDxB8v7/3TmFs7ZdBouqhdbGxZrwWq3PgFO7JNJAqm9ZaJsVwTPr t5ZdWFGyiARiC/LVDh7Jx/eCbGOyWBbrlUep6uu7ew== X-Google-Smtp-Source: ACHHUZ4DeQtgBYpWTCa9YUWXWDlEycg+YX2NYUxENmkf0GpGHlt+us2Dpq7iHJUuTDYh8Df6ApBq8rf1ewCUs5TI9Fo= X-Received: by 2002:a05:6214:2427:b0:61a:c2bf:9f0b with SMTP id gy7-20020a056214242700b0061ac2bf9f0bmr20819167qvb.6.1683588153435; Mon, 08 May 2023 16:22:33 -0700 (PDT) MIME-Version: 1.0 References: <000000000000258e5e05fae79fc1@google.com> <20230507135844.1231056-1-lrh2000@pku.edu.cn> In-Reply-To: From: Pasha Tatashin Date: Mon, 8 May 2023 16:21:57 -0700 Message-ID: Subject: Re: usbdev_mmap causes type confusion in page_table_check To: David Hildenbrand Cc: Matthew Wilcox , Ruihan Li , syzbot+fcf1a817ceb50935ce99@syzkaller.appspotmail.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, syzkaller-bugs@googlegroups.com Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: 5hgcxzhnnch35ob1th99k8cmy6e3b3om X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 77905140007 X-Rspam-User: X-HE-Tag: 1683588154-888934 X-HE-Meta: U2FsdGVkX1+T5rfAbsWs6EjNHq2slPZRMKmsXdoIfAc2giUW7F8RFGjHBVRQEjjEgXGGtb0IzQRmf6LKKaNGljG+O8v9rbrUopeZbsyUQTPTOAXUUoiRV0lvDDctOTrV6eQjUkwCIoTwUPjmM3FE2Gw8HgJ//hles7MxdRYtuA3djhyhe4B8DL+jYUJ7WZLLh19z8bldF9qzpheLQTpFaVfU3NIXomkOObhEMwYZT3ytHPO7WPlGdrmft+bsyzRfyWeB5bjJsmec/GGYFIeNOjnxLLMu5qZPuoNyb1XXFpq2HISI11rdgXxscPKetMV/zHZrI0K7JElUdvR4/JZltzJ5c54j5z8YJw2evr7lry8iDW0oqYRXglvLcg+zz1QpL7ZqdDKn2ltuYFXaa1HHZ16avMkKqbJuI0lBKaemPUqi8GyntIIoYu+vFXIk7DZn2I7qO1SJ2UJE45+d123NcW+fX0CgDlbIVbaw3UQBKLL9AuXVHf/j+j9LhLauSaDSIHK2CtQ98XowEQxyGoK5XRUoZ/zOtq0uJXeT3yF/cWHK47yU9m4fFaXIrbtlhkIf6+Ti8Y9QVkI2wN560jRZK77jRSDNiUlqJJfaw8dSuFOTgDvHT8unDZcIE+AuWHOVRRkzG/74AzyeRyPXf3cTAR9egIrqM9hQ4yNrgaYYZR91xQKoZmNK/gUWRGRvv3eB51eO0Ui1D6b6e6B7Pe/FE2caEVWygdKWJln+AvUYbCas2ljrkDACOJv+cu3jt0nKfxYoJOxSEDgYBfJbh/W9+gLdyhV4Yj8JcBggcIgIxV4c7v0d1qbLiMeqUjrt5ePaGd+hZPntaKDP5QgOKcDuzrB9GENJiG+qvobTEIMLjmM340SEZsrntoeS3GaW5/IYQTLyoizeutaabj++X7C3IS1scgyi9HkOa1oAeUrZrbO4eUn8AkaqFcy2eLN5dPUq9n4iQDpkyiv8YAxGu7V wDMQJrqM jY/efK8S3dETRrHbChlCWX3cffrG42ce2bJ2K5aGLOf/QtKH/5uuhAbSIBwlm5xEBIWAYHNc5AE7wK8Ab9x3RazKGBsF3yt4NBgy8cpSiURkqYHVDGUkGeJBiQjHIIAT58R6XzYwMHYHWJ0US7JqaS4k/Yii2HrAZtazA6Gsv4IVTNR1I0AvA7opVFLW8P5lFgcAaJbjS0aCEzqwJUF0W5+rVD1NraHa7eDE5iRTjIBML00ysvOTMU7GIhZ6OqZI5LwpcCp/sSyy+qXA8+sLrXrDLGf6AEiOnNzt/p9vZUTDP3aTTlq49OL8r+8i3u9ss6f0E/IrSzgyT5seJFNMfSq890isjbHW8IyUDagBzGnxDGRVRotBw00A4ew== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > For normal Kernel-MM operations, vm_normal_page() should be used to > get "struct page" based on vma+addr+pte combination, but > page_table_check does not use vma for its operation in order to > strengthen the verification of no invalid page sharing. But, even > vm_normal_page() can cause access to the "struct page" for VM_PFNMAP > if pfn_valid(pfn) is true. So, vm_normal_page() can return a struct > page for a user mapped slab page. Only for !ARCH_HAS_PTE_SPECIAL case, otherwise NULL is returned. Pasha